mlx4 - query regarding PF VF functionality division

2014-06-23 Thread Bob Biloxi
Hi All, I was going through the Mellanox driver (mlx4) and then I had difficulty understanding which portion of code corresponds to the one executed by the PF(Physical Function Driver) and which portion of code by (Virtual Function Driver) in the SRIOV mode. My confusion is because, I was of the

Re: mlx4 - query regarding PF VF functionality division

2014-06-23 Thread Or Gerlitz
On Mon, Jun 23, 2014 at 12:33 PM, Bob Biloxi iambobbil...@gmail.com wrote: [...] Is there any way we can clearly separate the files that are used by PF vs the files that are used by VF in the (drivers/net/ethernet/mlx4 sub-directory)? [...] Not really, but let's take EIM approach, what's your

Sparkasse Online-Banking ©

2014-06-23 Thread Rodrigo
Sehr geehrter Kunde, Bitte beachten Sie, dass Ihre E-Banking-Zugang ablдuft bald. dies Weiter zum Service kцnnen zu verwenden, auf den Button unten klicken Sie bitte Ihr Zugang manuell mit unseren Sicherheitsupdate auf Link- Update: Sparkasse Online-Banking Update: folgen Sie dem Link unten

[PATCH 0/2] Fixes skb leak and connection clean up on ARP error

2014-06-23 Thread Hariprasad Shenai
Hi, This patch series fixes skb leak and connection clean up on ARP error for iw_cxgb4 driver. This patch series is created on top of linux-next tree. We would like to request this patch series to get merged via Roland's infiniband tree master branch. We have included all the maintainers of

[PATCH 1/2] iw_cxgb4: Fix skb_leak in reject_cr

2014-06-23 Thread Hariprasad Shenai
Based on origninal work by Steve Wise sw...@opengridcomputing.com Signed-off-by: Steve Wise sw...@opengridcomputing.com Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/infiniband/hw/cxgb4/cm.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git

[PATCH 2/2] iw_cxgb4: clean up connection on arp error

2014-06-23 Thread Hariprasad Shenai
Based on origninal work by Steve Wise sw...@opengridcomputing.com Signed-off-by: Steve Wise sw...@opengridcomputing.com Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/infiniband/hw/cxgb4/cm.c | 11 ++- 1 files changed, 10 insertions(+), 1 deletions(-) diff --git

[PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread Joe Perches
Adding the helper reduces object code size as well as overall source size line count. It's also consistent with all the various zalloc mechanisms in the kernel. Done with a simple cocci script and some typing. Joe Perches (22): pci-dma-compat: Add pci_zalloc_consistent helper atm: Use

Re: [PATCH 05/22] infiniband: Use pci_zalloc_consistent

2014-06-23 Thread Steve Wise
For the amso1100 change... Acked-by: Steve Wise sw...@opengridcomputing.com -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 05/22] infiniband: Use pci_zalloc_consistent

2014-06-23 Thread Joe Perches
Remove the now unnecessary memset too. Signed-off-by: Joe Perches j...@perches.com --- drivers/infiniband/hw/amso1100/c2.c | 6 ++ drivers/infiniband/hw/nes/nes_hw.c| 12 ++-- drivers/infiniband/hw/nes/nes_verbs.c | 5 ++--- 3 files changed, 10 insertions(+), 13 deletions(-)

PCI/AER: AER in SRIOV environment

2014-06-23 Thread Yishai Hadas
Hi Vijay, Trying to add AER support for Mellanox NIC in SRIOV environment, while evaluating/testing encountered a problem which led me to your patch accepted as part of kernel 3.8, commit ID 918b4053184c0ca22236e70e299c5343eea35304. Have some concerns/questions on: When working in SRIOV

Re: how to re-use a QP for a new connection

2014-06-23 Thread Chuck Lever
Hi Sean- On Jun 20, 2014, at 5:17 PM, Hefty, Sean sean.he...@intel.com wrote: During a remote transport disconnect, the QP leaves RTS. xprtrdma deals with this in a separate transport connect worker process, where it creates a new id and qp, and replaces the existing id and qp.

RE: how to re-use a QP for a new connection

2014-06-23 Thread Devesh Sharma
Hi Chuck, -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Chuck Lever Sent: Monday, June 23, 2014 8:51 PM To: Hefty, Sean Cc: linux-rdma Subject: Re: how to re-use a QP for a new connection Hi Sean- On Jun 20,

RE: [PATCH for-next 0/2] Bug fixes for nfs-rdma support

2014-06-23 Thread Devesh Sharma
Roland, Please pull this series to 3.16 to make sure ocrdma works fine with upstreame NFS-RDMA. -Regards Devesh -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of dev...@vger.kernel.org Sent: Monday, June 09, 2014 10:53

RE: [PATCH v1 for-next 00/16] Bug fixes for ocrdma driver

2014-06-23 Thread Devesh Sharma
Roland, Please consider this series to be merged to the next pull request to Linus. This contains some critical bug fixes for ocrdma, and we don't want to miss this pull cycle. -Best Regards Devesh -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-

Re: why flipping responder_resources/initiator_depth?

2014-06-23 Thread Jason Gunthorpe
On Mon, Jun 23, 2014 at 08:55:07AM +0300, Or Gerlitz wrote: 1. the client to put into the responder_resources they provide to rdma_connect the the maximum number of outstanding RDMA read that they will be able accept from the server side 2. the server to apply a minimum function between the

Re: how to re-use a QP for a new connection

2014-06-23 Thread Chuck Lever
On Jun 23, 2014, at 12:22 PM, Hefty, Sean sean.he...@intel.com wrote: Steve Wise is helping me with a particular issue where QP re-use might be helpful. When an RPC/RDMA transport connection is dropped (for example, the NFS server crashes), xprtrdma destroys the transport's QP and creates

RE: how to re-use a QP for a new connection

2014-06-23 Thread Hefty, Sean
For the record, with both mlx4 and cxgb4, we see FRMRs left valid after a FAST_REG_MR is flushed during a connection loss. More study needed, obviously. Is the bug that this type of WR completes in error, but actually exposed the memory region? -- To unsubscribe from this list: send the line

RE: why flipping responder_resources/initiator_depth?

2014-06-23 Thread Hefty, Sean
The swapping and general missing handling of RR negotiating in the whole kernel CM API (not just RDMA CM, but IB CM too) is a longstanding bug, and I have written user space code that fixes it up in the past :( Jason, the swapping takes place in the IB CM indeed, I just used the

Re: why flipping responder_resources/initiator_depth?

2014-06-23 Thread Jason Gunthorpe
On Mon, Jun 23, 2014 at 06:00:57PM +, Hefty, Sean wrote: The swapping and general missing handling of RR negotiating in the whole kernel CM API (not just RDMA CM, but IB CM too) is a longstanding bug, and I have written user space code that fixes it up in the past :( Jason,

Re: PCI/AER: AER in SRIOV environment

2014-06-23 Thread Bjorn Helgaas
[+cc linux-pci, Don] On Mon, Jun 23, 2014 at 8:29 AM, Yishai Hadas yish...@dev.mellanox.co.il wrote: Hi Vijay, Trying to add AER support for Mellanox NIC in SRIOV environment, while evaluating/testing encountered a problem which led me to your patch accepted as part of kernel 3.8, commit ID

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread Joe Perches
On Mon, 2014-06-23 at 10:25 -0700, Luis R. Rodriguez wrote: On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote: Adding the helper reduces object code size as well as overall source size line count. It's also consistent with all the various zalloc mechanisms in the kernel.

ibacm release 1.0.9

2014-06-23 Thread Hefty, Sean
A new release of ibacm - 1.0.9 - is available from: https://www.openfabrics.org/downloads/rdmacm/ibacm-1.0.9.tar.gz 1.0.9 adds handling for dynamic IP address changes, plus a few bug fixes. To avoid incorporating the recent provider support changes, the 1.0.9 release was creating in a branch.

Re: PCI/AER: AER in SRIOV environment

2014-06-23 Thread Don Dutile
On 06/23/2014 03:09 PM, Bjorn Helgaas wrote: [+cc linux-pci, Don] Adding Alex Williamson in case he can add more to this conversation... On Mon, Jun 23, 2014 at 8:29 AM, Yishai Hadas yish...@dev.mellanox.co.il wrote: Hi Vijay, Trying to add AER support for Mellanox NIC in SRIOV environment,

Re: [PATCH v2 2/3] libiscsi, iser: Adjust data_length to include protection information

2014-06-23 Thread Christoph Hellwig
This patch causes a regression when using the iscsi initiator over TCP for me. When mounting a newly created ext4 filesystem I get the following BUG: [ 31.611803] BUG: unable to handle kernel NULL pointer dereference at 000c [ 31.613563] IP: [8197b38d]

Re: how to re-use a QP for a new connection

2014-06-23 Thread Steve Wise
On 6/23/2014 12:31 PM, Chuck Lever wrote: On Jun 23, 2014, at 1:25 PM, Hefty, Sean sean.he...@intel.com wrote: For the record, with both mlx4 and cxgb4, we see FRMRs left valid after a FAST_REG_MR is flushed during a connection loss. More study needed, obviously. Is the bug that this type of

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-23 Thread Mike Christie
On 06/11/2014 04:09 AM, Sagi Grimberg wrote: In case protection information exists on the wire scsi transports should include it in the transfer byte count (even if protection information does not exist in the host memory space). This helper will compute the total transfer length from the

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread David Miller
From: Joe Perches j...@perches.com Date: Mon, 23 Jun 2014 06:41:28 -0700 Adding the helper reduces object code size as well as overall source size line count. It's also consistent with all the various zalloc mechanisms in the kernel. Done with a simple cocci script and some typing. For

[PATCH v1 01/13] xprtrdma: Fix panic in rpcrdma_register_frmr_external()

2014-06-23 Thread Chuck Lever
seg1-mr_nsegs is not yet initialized when it is used to unmap segments during an error exit. Use the same unmapping logic for all error exits. if (frmr_wr.wr.fast_reg.length len) { used to be a BUG_ON check. The broken code should never be executed under normal operation. Fixes:

[PATCH v1 02/13] xprtrdma: Protect -qp during FRMR deregistration

2014-06-23 Thread Chuck Lever
Ensure the QP remains valid while posting LOCAL_INV during a transport reconnect. Otherwise, ia-ri_id-qp is NULL, which triggers a panic. BugLink: https://bugzilla.linux-nfs.org/show_bug.cgi?id=259 Fixes: ec62f40d3505a643497d105c297093bb90afd44e Signed-off-by: Chuck Lever chuck.le...@oracle.com

[PATCH v1 00/13] NFS/RDMA patches for 3.17

2014-06-23 Thread Chuck Lever
The main purpose of this series is to address more connection drop recovery issues by fixing FRMR re-use to make it less likely the client will drop the connection due to a memory operation error. Some other clean-ups and fixes are present as well. See topic branch nfs-rdma-for-3.17 in

[PATCH v1 06/13] xprtrdma: Unclutter struct rpcrdma_mr_seg

2014-06-23 Thread Chuck Lever
Clean ups: - make it obvious that the rl_mw field is a pointer -- allocated separately, not as part of struct rpcrdma_mr_seg - promote struct {} frmr; to a named type - promote the state enum to a named type - name the MW state field the same way other fields in rpcrdma_mw are named

[PATCH v1 08/13] xprtrdma: Back off rkey when FAST_REG_MR fails

2014-06-23 Thread Chuck Lever
If posting a FAST_REG_MR Work Reqeust fails, or the FAST_REG WR flushes, revert the rkey update to avoid subsequent IB_WC_MW_BIND_ERR completions. Suggested-by: Steve Wise sw...@opengridcomputing.com Signed-off-by: Chuck Lever chuck.le...@oracle.com --- net/sunrpc/xprtrdma/verbs.c | 39

[PATCH v1 05/13] xprtrdma: Don't drain CQs on transport disconnect

2014-06-23 Thread Chuck Lever
CQs are not destroyed until unmount. By draining CQs on transport disconnect, successful completions that can change the r.frmr.state field can be missed. Signed-off-by: Chuck Lever chuck.le...@oracle.com --- net/sunrpc/xprtrdma/verbs.c |5 - 1 file changed, 5 deletions(-) diff --git

[PATCH v1 04/13] xprtrdma: Update rkeys after transport reconnect

2014-06-23 Thread Chuck Lever
Various reports of: rpcrdma_qp_async_error_upcall: QP error 3 on device mlx4_0 ep 8800bfd3e848 Ensure that rkeys in already-marshalled RPC/RDMA headers are refreshed after the QP has been replaced by a reconnect. BugLink: https://bugzilla.linux-nfs.org/show_bug.cgi?id=249

[PATCH v1 07/13] xprtrdma: Encode Work Request opcode in wc-wr_id

2014-06-23 Thread Chuck Lever
The wc-opcode field is unreliable when a completion fails. Up until now, the completion handler has ignored unsuccessful completions, so that didn't matter to xprtrdma. In a subsequent patch, however, the send CQ handler will need to know which Work Request opcode is completing, even if for error

[PATCH v1 03/13] xprtrdma: Limit data payload size for ALLPHYSICAL

2014-06-23 Thread Chuck Lever
When the client uses physical memory registration, each page in the payload gets its own array entry in the RPC/RDMA header's chunk list. Therefore, don't advertise a maximum payload size that would require more array entries than can fit in the RPC buffer where RPC/RDMA headers are built.

[PATCH v1 09/13] xprtrdma: Refactor rpcrdma_buffer_put()

2014-06-23 Thread Chuck Lever
Split out the code that manages the rb_mws list. A little extra error checking is introduced in the code path that grabs MWs for the next RPC request. If rb_mws were ever to become empty, the list_entry() would cause a NULL pointer dereference. Instead, now rpcrdma_buffer_get() returns NULL,

[PATCH v1 13/13] xprtrdma: Handle additional connection events

2014-06-23 Thread Chuck Lever
Commit 38ca83a5 added RDMA_CM_EVENT_TIMEWAIT_EXIT. But that status is relevant only for consumers that re-use their QPs on new connections. xprtrdma creates a fresh QP on reconnection, so that event should be explicitly ignored. Squelch the alarming unexpected CM event message. Signed-off-by:

[PATCH v1 10/13] xprtrdma: Release FRMR segment buffers during LOCAL_INV completion

2014-06-23 Thread Chuck Lever
FRMR uses a LOCAL_INV Work Request, which is asynchronous, to deregister segment buffers. Other registration strategies use synchronous deregistration mechanisms (like ib_unmap_fmr()). For a synchronous deregistration mechanism, it makes sense for xprt_rdma_free() to put segment buffers back

[PATCH v1 11/13] xprtrdma: Clean up rpcrdma_ep_disconnect()

2014-06-23 Thread Chuck Lever
The return code is used only for dprintk's that are already redundant. Signed-off-by: Chuck Lever chuck.le...@oracle.com --- net/sunrpc/xprtrdma/transport.c |2 +- net/sunrpc/xprtrdma/verbs.c | 13 +++-- net/sunrpc/xprtrdma/xprt_rdma.h |2 +- 3 files changed, 5

[PATCH v1 12/13] xprtrdma: Remove RPCRDMA_PERSISTENT_REGISTRATION macro

2014-06-23 Thread Chuck Lever
Clean up. RPCRDMA_PERSISTENT_REGISTRATION was a compile-time switch between RPCRDMA_REGISTER mode and RPCRDMA_ALLPHYSICAL mode. Since RPCRDMA_REGISTER has been removed, there's no need for the extra conditional compilation. Signed-off-by: Chuck Lever chuck.le...@oracle.com ---

Re: PCI/AER: AER in SRIOV environment

2014-06-23 Thread Yishai Hadas
On 6/23/2014 11:12 PM, Don Dutile wrote: On 06/23/2014 03:09 PM, Bjorn Helgaas wrote: [+cc linux-pci, Don] Adding Alex Williamson in case he can add more to this conversation... On Mon, Jun 23, 2014 at 8:29 AM, Yishai Hadas yish...@dev.mellanox.co.il wrote: Hi Vijay, Trying to add AER

Re: PCI/AER: AER in SRIOV environment

2014-06-23 Thread Alex Williamson
On Mon, 2014-06-23 at 16:12 -0400, Don Dutile wrote: On 06/23/2014 03:09 PM, Bjorn Helgaas wrote: [+cc linux-pci, Don] Adding Alex Williamson in case he can add more to this conversation... On Mon, Jun 23, 2014 at 8:29 AM, Yishai Hadas yish...@dev.mellanox.co.il wrote: Hi Vijay,

Re: PCI/AER: AER in SRIOV environment

2014-06-23 Thread Alex Williamson
On Tue, 2014-06-24 at 01:44 +0300, Yishai Hadas wrote: On 6/23/2014 11:12 PM, Don Dutile wrote: On 06/23/2014 03:09 PM, Bjorn Helgaas wrote: [+cc linux-pci, Don] Adding Alex Williamson in case he can add more to this conversation... On Mon, Jun 23, 2014 at 8:29 AM, Yishai Hadas

Re: [PATCH 00/22] Add and use pci_zalloc_consistent

2014-06-23 Thread Julian Calaby
Hi Joe, On Tue, Jun 24, 2014 at 5:13 AM, Joe Perches j...@perches.com wrote: On Mon, 2014-06-23 at 10:25 -0700, Luis R. Rodriguez wrote: On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote: Adding the helper reduces object code size as well as overall source size line count.

Re: [PATCH v2 1/3] scsi_cmnd: Introduce scsi_transfer_length helper

2014-06-23 Thread Martin K. Petersen
Mike == Mike Christie micha...@cs.wisc.edu writes: + unsigned int xfer_len = blk_rq_bytes(scmd-request); Mike Can you do bidi and dif/dix? Nope. -- Martin K. Petersen Oracle Linux Engineering -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a