Hi All,
I was going through the Mellanox driver (mlx4) and then I had
difficulty understanding which portion of code corresponds to the one
executed by the PF(Physical Function Driver) and which portion of code
by (Virtual Function Driver) in the SRIOV mode.
My confusion is because, I was of the
On Mon, Jun 23, 2014 at 12:33 PM, Bob Biloxi iambobbil...@gmail.com wrote:
[...]
Is there any way we can clearly separate the files that are used by PF
vs the files that are used by VF in the (drivers/net/ethernet/mlx4
sub-directory)?
[...]
Not really, but let's take EIM approach, what's your
Sehr geehrter Kunde,
Bitte beachten Sie, dass Ihre E-Banking-Zugang ablдuft bald. dies
Weiter zum Service kцnnen zu verwenden, auf den Button unten klicken Sie
bitte
Ihr Zugang manuell mit unseren Sicherheitsupdate auf Link-
Update: Sparkasse Online-Banking Update: folgen Sie dem Link unten
Hi,
This patch series fixes skb leak and connection clean up on ARP error for
iw_cxgb4 driver.
This patch series is created on top of linux-next tree. We would like to
request this patch series to get merged via Roland's infiniband tree master
branch.
We have included all the maintainers of
Based on origninal work by Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Hariprasad Shenai haripra...@chelsio.com
---
drivers/infiniband/hw/cxgb4/cm.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git
Based on origninal work by Steve Wise sw...@opengridcomputing.com
Signed-off-by: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Hariprasad Shenai haripra...@chelsio.com
---
drivers/infiniband/hw/cxgb4/cm.c | 11 ++-
1 files changed, 10 insertions(+), 1 deletions(-)
diff --git
Adding the helper reduces object code size as well as overall
source size line count.
It's also consistent with all the various zalloc mechanisms
in the kernel.
Done with a simple cocci script and some typing.
Joe Perches (22):
pci-dma-compat: Add pci_zalloc_consistent helper
atm: Use
For the amso1100 change...
Acked-by: Steve Wise sw...@opengridcomputing.com
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Remove the now unnecessary memset too.
Signed-off-by: Joe Perches j...@perches.com
---
drivers/infiniband/hw/amso1100/c2.c | 6 ++
drivers/infiniband/hw/nes/nes_hw.c| 12 ++--
drivers/infiniband/hw/nes/nes_verbs.c | 5 ++---
3 files changed, 10 insertions(+), 13 deletions(-)
Hi Vijay,
Trying to add AER support for Mellanox NIC in SRIOV environment, while
evaluating/testing encountered a problem which led me to your
patch accepted as part of kernel 3.8, commit ID
918b4053184c0ca22236e70e299c5343eea35304.
Have some concerns/questions on:
When working in SRIOV
Hi Sean-
On Jun 20, 2014, at 5:17 PM, Hefty, Sean sean.he...@intel.com wrote:
During a remote transport disconnect, the QP leaves RTS.
xprtrdma deals with this in a separate transport connect worker process,
where it creates a new id and qp, and replaces the existing id and qp.
Hi Chuck,
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of Chuck Lever
Sent: Monday, June 23, 2014 8:51 PM
To: Hefty, Sean
Cc: linux-rdma
Subject: Re: how to re-use a QP for a new connection
Hi Sean-
On Jun 20,
Roland,
Please pull this series to 3.16 to make sure ocrdma works fine with upstreame
NFS-RDMA.
-Regards
Devesh
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
ow...@vger.kernel.org] On Behalf Of dev...@vger.kernel.org
Sent: Monday, June 09, 2014 10:53
Roland,
Please consider this series to be merged to the next pull request to Linus.
This contains some critical bug fixes for ocrdma, and we don't want to miss
this pull cycle.
-Best Regards
Devesh
-Original Message-
From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-
On Mon, Jun 23, 2014 at 08:55:07AM +0300, Or Gerlitz wrote:
1. the client to put into the responder_resources they provide to
rdma_connect the the maximum number of outstanding RDMA read that they
will be able accept from the server side
2. the server to apply a minimum function between the
On Jun 23, 2014, at 12:22 PM, Hefty, Sean sean.he...@intel.com wrote:
Steve Wise is helping me with a particular issue where QP re-use might
be helpful.
When an RPC/RDMA transport connection is dropped (for example, the NFS
server crashes), xprtrdma destroys the transport's QP and creates
For the record, with both mlx4 and cxgb4, we see FRMRs left valid
after a FAST_REG_MR is flushed during a connection loss. More study
needed, obviously.
Is the bug that this type of WR completes in error, but actually exposed the
memory region?
--
To unsubscribe from this list: send the line
The swapping and general missing handling of RR negotiating in the
whole kernel CM API (not just RDMA CM, but IB CM too) is a
longstanding bug, and I have written user space code that fixes it up
in the past :(
Jason, the swapping takes place in the IB CM indeed, I just used the
On Mon, Jun 23, 2014 at 06:00:57PM +, Hefty, Sean wrote:
The swapping and general missing handling of RR negotiating in the
whole kernel CM API (not just RDMA CM, but IB CM too) is a
longstanding bug, and I have written user space code that fixes it up
in the past :(
Jason,
[+cc linux-pci, Don]
On Mon, Jun 23, 2014 at 8:29 AM, Yishai Hadas
yish...@dev.mellanox.co.il wrote:
Hi Vijay,
Trying to add AER support for Mellanox NIC in SRIOV environment, while
evaluating/testing encountered a problem which led me to your
patch accepted as part of kernel 3.8, commit ID
On Mon, 2014-06-23 at 10:25 -0700, Luis R. Rodriguez wrote:
On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote:
Adding the helper reduces object code size as well as overall
source size line count.
It's also consistent with all the various zalloc mechanisms
in the kernel.
A new release of ibacm - 1.0.9 - is available from:
https://www.openfabrics.org/downloads/rdmacm/ibacm-1.0.9.tar.gz
1.0.9 adds handling for dynamic IP address changes, plus a few bug fixes.
To avoid incorporating the recent provider support changes, the 1.0.9 release
was creating in a branch.
On 06/23/2014 03:09 PM, Bjorn Helgaas wrote:
[+cc linux-pci, Don]
Adding Alex Williamson in case he can add more to this conversation...
On Mon, Jun 23, 2014 at 8:29 AM, Yishai Hadas
yish...@dev.mellanox.co.il wrote:
Hi Vijay,
Trying to add AER support for Mellanox NIC in SRIOV environment,
This patch causes a regression when using the iscsi initiator over
TCP for me. When mounting a newly created ext4 filesystem I get the
following BUG:
[ 31.611803] BUG: unable to handle kernel NULL pointer dereference at
000c
[ 31.613563] IP: [8197b38d]
On 6/23/2014 12:31 PM, Chuck Lever wrote:
On Jun 23, 2014, at 1:25 PM, Hefty, Sean sean.he...@intel.com wrote:
For the record, with both mlx4 and cxgb4, we see FRMRs left valid
after a FAST_REG_MR is flushed during a connection loss. More study
needed, obviously.
Is the bug that this type of
On 06/11/2014 04:09 AM, Sagi Grimberg wrote:
In case protection information exists on the wire
scsi transports should include it in the transfer
byte count (even if protection information does not
exist in the host memory space). This helper will
compute the total transfer length from the
From: Joe Perches j...@perches.com
Date: Mon, 23 Jun 2014 06:41:28 -0700
Adding the helper reduces object code size as well as overall
source size line count.
It's also consistent with all the various zalloc mechanisms
in the kernel.
Done with a simple cocci script and some typing.
For
seg1-mr_nsegs is not yet initialized when it is used to unmap
segments during an error exit. Use the same unmapping logic for
all error exits.
if (frmr_wr.wr.fast_reg.length len) { used to be a BUG_ON check.
The broken code should never be executed under normal operation.
Fixes:
Ensure the QP remains valid while posting LOCAL_INV during a
transport reconnect. Otherwise, ia-ri_id-qp is NULL, which
triggers a panic.
BugLink: https://bugzilla.linux-nfs.org/show_bug.cgi?id=259
Fixes: ec62f40d3505a643497d105c297093bb90afd44e
Signed-off-by: Chuck Lever chuck.le...@oracle.com
The main purpose of this series is to address more connection drop
recovery issues by fixing FRMR re-use to make it less likely the
client will drop the connection due to a memory operation error.
Some other clean-ups and fixes are present as well.
See topic branch nfs-rdma-for-3.17 in
Clean ups:
- make it obvious that the rl_mw field is a pointer -- allocated
separately, not as part of struct rpcrdma_mr_seg
- promote struct {} frmr; to a named type
- promote the state enum to a named type
- name the MW state field the same way other fields in
rpcrdma_mw are named
If posting a FAST_REG_MR Work Reqeust fails, or the FAST_REG WR
flushes, revert the rkey update to avoid subsequent
IB_WC_MW_BIND_ERR completions.
Suggested-by: Steve Wise sw...@opengridcomputing.com
Signed-off-by: Chuck Lever chuck.le...@oracle.com
---
net/sunrpc/xprtrdma/verbs.c | 39
CQs are not destroyed until unmount. By draining CQs on transport
disconnect, successful completions that can change the r.frmr.state
field can be missed.
Signed-off-by: Chuck Lever chuck.le...@oracle.com
---
net/sunrpc/xprtrdma/verbs.c |5 -
1 file changed, 5 deletions(-)
diff --git
Various reports of:
rpcrdma_qp_async_error_upcall: QP error 3 on device mlx4_0
ep 8800bfd3e848
Ensure that rkeys in already-marshalled RPC/RDMA headers are
refreshed after the QP has been replaced by a reconnect.
BugLink: https://bugzilla.linux-nfs.org/show_bug.cgi?id=249
The wc-opcode field is unreliable when a completion fails.
Up until now, the completion handler has ignored unsuccessful
completions, so that didn't matter to xprtrdma.
In a subsequent patch, however, the send CQ handler will need
to know which Work Request opcode is completing, even if for
error
When the client uses physical memory registration, each page in the
payload gets its own array entry in the RPC/RDMA header's chunk list.
Therefore, don't advertise a maximum payload size that would require
more array entries than can fit in the RPC buffer where RPC/RDMA
headers are built.
Split out the code that manages the rb_mws list.
A little extra error checking is introduced in the code path that
grabs MWs for the next RPC request. If rb_mws were ever to become
empty, the list_entry() would cause a NULL pointer dereference.
Instead, now rpcrdma_buffer_get() returns NULL,
Commit 38ca83a5 added RDMA_CM_EVENT_TIMEWAIT_EXIT. But that status
is relevant only for consumers that re-use their QPs on new
connections. xprtrdma creates a fresh QP on reconnection, so that
event should be explicitly ignored.
Squelch the alarming unexpected CM event message.
Signed-off-by:
FRMR uses a LOCAL_INV Work Request, which is asynchronous, to
deregister segment buffers. Other registration strategies use
synchronous deregistration mechanisms (like ib_unmap_fmr()).
For a synchronous deregistration mechanism, it makes sense for
xprt_rdma_free() to put segment buffers back
The return code is used only for dprintk's that are already
redundant.
Signed-off-by: Chuck Lever chuck.le...@oracle.com
---
net/sunrpc/xprtrdma/transport.c |2 +-
net/sunrpc/xprtrdma/verbs.c | 13 +++--
net/sunrpc/xprtrdma/xprt_rdma.h |2 +-
3 files changed, 5
Clean up.
RPCRDMA_PERSISTENT_REGISTRATION was a compile-time switch between
RPCRDMA_REGISTER mode and RPCRDMA_ALLPHYSICAL mode. Since
RPCRDMA_REGISTER has been removed, there's no need for the extra
conditional compilation.
Signed-off-by: Chuck Lever chuck.le...@oracle.com
---
On 6/23/2014 11:12 PM, Don Dutile wrote:
On 06/23/2014 03:09 PM, Bjorn Helgaas wrote:
[+cc linux-pci, Don]
Adding Alex Williamson in case he can add more to this conversation...
On Mon, Jun 23, 2014 at 8:29 AM, Yishai Hadas
yish...@dev.mellanox.co.il wrote:
Hi Vijay,
Trying to add AER
On Mon, 2014-06-23 at 16:12 -0400, Don Dutile wrote:
On 06/23/2014 03:09 PM, Bjorn Helgaas wrote:
[+cc linux-pci, Don]
Adding Alex Williamson in case he can add more to this conversation...
On Mon, Jun 23, 2014 at 8:29 AM, Yishai Hadas
yish...@dev.mellanox.co.il wrote:
Hi Vijay,
On Tue, 2014-06-24 at 01:44 +0300, Yishai Hadas wrote:
On 6/23/2014 11:12 PM, Don Dutile wrote:
On 06/23/2014 03:09 PM, Bjorn Helgaas wrote:
[+cc linux-pci, Don]
Adding Alex Williamson in case he can add more to this conversation...
On Mon, Jun 23, 2014 at 8:29 AM, Yishai Hadas
Hi Joe,
On Tue, Jun 24, 2014 at 5:13 AM, Joe Perches j...@perches.com wrote:
On Mon, 2014-06-23 at 10:25 -0700, Luis R. Rodriguez wrote:
On Mon, Jun 23, 2014 at 06:41:28AM -0700, Joe Perches wrote:
Adding the helper reduces object code size as well as overall
source size line count.
Mike == Mike Christie micha...@cs.wisc.edu writes:
+ unsigned int xfer_len = blk_rq_bytes(scmd-request);
Mike Can you do bidi and dif/dix?
Nope.
--
Martin K. Petersen Oracle Linux Engineering
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a
46 matches
Mail list logo