Re: [PATCH net-next 3/4] libcxgbi: Add ipv6 api to driver

2014-07-17 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Tue, 15 Jul 2014 19:55:52 -0700 +#define pr_info_ipaddr(fmt_trail,\ + addr1, addr2, args_trail...)\ Barf... use %pIS instead, which takes a pointer to a sockaddr of family

[PATCH net-next v2 1/4] cxgb4/iw_cxgb4: Move common defines to cxgb4

2014-07-17 Thread Anish Bhatt
This define is used by cxgb4i and iw_cxgb4, moving to avoid code duplication Signed-off-by: Anish Bhatt an...@chelsio.com Acked-by: Steve Wise sw...@opengridcomputing.com --- drivers/infiniband/hw/cxgb4/t4fw_ri_api.h | 1 - drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 1 + 2 files changed, 1

[PATCH net-next v2 0/4] cxgb4i: Add ipv6 support

2014-07-17 Thread Anish Bhatt
Hi, The following patchset add ipv6 support for the cxgb4i(iscsi) driver. Patch 1 moves a define from the iw_cxgb4 to cxgb4 to prevent code duplication, as it is used by cxgb4i and iw_cxgb4 both. Patch 2 exports symbols needed by cxgb4i for ipv6 support from cxgb4. Patch 3 4 deal with actual

[PATCH net-next v2 2/4] cxgb4: Export symbols required by cxgb4i for ipv6 support and required defines

2014-07-17 Thread Anish Bhatt
Signed-off-by: Anish Bhatt an...@chelsio.com --- drivers/net/ethernet/chelsio/cxgb4/cxgb4_main.c | 10 ++ drivers/net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 4 drivers/net/ethernet/chelsio/cxgb4/t4_msg.h | 2 ++ 3 files changed, 12 insertions(+), 4 deletions(-) diff --git

[PATCH net-next v2 3/4] libcxgbi: Add ipv6 api to driver

2014-07-17 Thread Anish Bhatt
Signed-off-by: Anish Bhatt an...@chelsio.com Signed-off-by: Karen Xie k...@chelsio.com Signed-off-by: Manoj Malviya manojmalv...@chelsio.com --- drivers/scsi/cxgbi/libcxgbi.c | 237 ++ drivers/scsi/cxgbi/libcxgbi.h | 21 +++- 2 files changed, 237

[PATCH net-next v2 4/4] cxgb4i: Add ipv6 code to driver, call into libcxgbi ipv6 api

2014-07-17 Thread Anish Bhatt
Signed-off-by: Anish Bhatt an...@chelsio.com Signed-off-by: Karen Xie k...@chelsio.com Signed-off-by: Manoj Malviya manojmalv...@chelsio.com --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 353 + 1 file changed, 314 insertions(+), 39 deletions(-) diff --git

[patch] RDMA/amso1100: integer overflow in c2_alloc_cq_buf()

2014-07-17 Thread Dan Carpenter
This is a static checker fix. The static checker says that q_size comes from the user and can be any 32 bit value. The call tree is: -- ib_uverbs_create_cq() -- c2_create_cq() -- c2_init_cq() Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git

[PATCH] uapi/rdma_user_cm.h: include socket.h

2014-07-17 Thread Doug Ledford
Commit ee7aed4528f (RDMA/ucma: Support querying for AF_IB addresses) added struct sockaddr_storage to rdma_user_cm.h without also adding an include for linux/socket.h to make sure it is defined. As systemtap needs the header files to build standalone and not rely on the code files to pre-include

RE: [PATCH v3 00/21] NFS/RDMA client patches for 3.17

2014-07-17 Thread Devesh Sharma
Hi Chuck, Tested the cable pull also. V3 is passing the cable pull test also. I have tried following tests: Run iozone on nfs-rdma mount. Bring down the link from switch (to simulate cable pull). Wait for 10 secs. Bring back the link. This test passes, iozone resumes traffic. Run iozone on

Re: [PATCH v3 00/21] NFS/RDMA client patches for 3.17

2014-07-17 Thread Chuck Lever
On Jul 17, 2014, at 10:12 AM, Devesh Sharma devesh.sha...@emulex.com wrote: Hi Chuck, Tested the cable pull also. V3 is passing the cable pull test also. I have tried following tests: Run iozone on nfs-rdma mount. Bring down the link from switch (to simulate cable pull). Wait for 10

[for-next 0/2] NFS/RDMA client fixes for 3.17

2014-07-17 Thread Devesh Sharma
This patch series is test with 3.16-rc5 on top of chuck's series [PATCH v3 00/21] NFS/RDMA client patches for 3.17 This series fixes hot removal of rdma provider driver and pd_deallocation sequence. Devesh Sharma (2): xprtrdma: take reference of rdma provider module xprtrdma: fix

[for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Devesh Sharma
If verndor driver is attempted for removal while xprtrdma still has an active mount, the removal of driver may never complete and can cause unseen races or in worst case system crash. To solve this, xprtrdma module should get reference of struct ib_device structure for every mount. Reference is

[for-next 2/2] xprtrdma: fix deallocation sequence of pd

2014-07-17 Thread Devesh Sharma
xprtrdma tries to destroy pd after destruction of cm_id. However, pd should be deallocated before destruction of cm_id. Signed-off-by: Devesh Sharma devesh.sha...@emulex.com --- net/sunrpc/xprtrdma/verbs.c | 22 +- 1 files changed, 13 insertions(+), 9 deletions(-) diff

[ANNOUNCE] opensm 3.3.18 release

2014-07-17 Thread Hal Rosenstock
There is a new 3.3.18 release of OpenSM. Tarball is available in: http://www.openfabrics.org/downloads/management/ (listed in http://www.openfabrics.org/downloads/management/latest.txt) md5sum: 642c2a2fda102a7d11add773a89265af opensm-3.3.18.tar.gz All component versions are from recent master

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Steve Wise
On 7/17/2014 9:01 AM, Devesh Sharma wrote: If verndor driver is attempted for removal while xprtrdma still has an active mount, the removal of driver may never complete and can cause unseen races or in worst case system crash. To solve this, xprtrdma module should get reference of struct

Re: [for-next 2/2] xprtrdma: fix deallocation sequence of pd

2014-07-17 Thread Steve Wise
On 7/17/2014 9:01 AM, Devesh Sharma wrote: xprtrdma tries to destroy pd after destruction of cm_id. However, pd should be deallocated before destruction of cm_id. Why? I think you really mean that the pd dealloc needs to be done before the module deref that you added in the first patch. But

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Chuck Lever
On Jul 17, 2014, at 11:01 AM, Steve Wise sw...@opengridcomputing.com wrote: On 7/17/2014 9:01 AM, Devesh Sharma wrote: If verndor driver is attempted for removal while xprtrdma still has an active mount, the removal of driver may never complete and can cause unseen races or in worst case

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Devesh Sharma
From: Steve Wise [sw...@opengridcomputing.com] Sent: Thursday, July 17, 2014 8:31 PM To: Devesh Sharma; Roland Dreier; Hefty, Sean Cc: linux-rdma@vger.kernel.org; chuck.le...@oracle.com Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma provider

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Devesh Sharma
Replying again, due to mail formatting issue: -Original Message- From: Chuck Lever [mailto:chuck.le...@oracle.com] Sent: Thursday, July 17, 2014 8:36 PM To: Steve Wise Cc: Devesh Sharma; Roland Dreier; Hefty, Sean; linux-rdma@vger.kernel.org Subject: Re: [for-next 1/2] xprtrdma:

RE: [for-next 2/2] xprtrdma: fix deallocation sequence of pd

2014-07-17 Thread Devesh Sharma
-Original Message- From: Steve Wise [mailto:sw...@opengridcomputing.com] Sent: Thursday, July 17, 2014 8:36 PM To: Devesh Sharma; linux-rdma@vger.kernel.org Cc: chuck.le...@oracle.com Subject: Re: [for-next 2/2] xprtrdma: fix deallocation sequence of pd On 7/17/2014 9:01 AM,

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Hefty, Sean
On 7/17/2014 9:01 AM, Devesh Sharma wrote: If verndor driver is attempted for removal while xprtrdma still has an active mount, the removal of driver may never complete and can cause unseen races or in worst case system crash. To solve this, xprtrdma module should get reference of

[PATCH] iw_cxgb4: fix for 64-bit integer division

2014-07-17 Thread Hariprasad Shenai
Fixed error introduced in commit id 7730b4c ( cxgb4/iw_cxgb4: work request logging feature) while compiling on 32 bit architecture reported by kbuild. Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/infiniband/hw/cxgb4/device.c |3 ++- 1 files changed, 2 insertions(+), 1

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Steve Wise
-Original Message- From: Shirley Ma [mailto:shirley...@oracle.com] Sent: Thursday, July 17, 2014 1:58 PM To: Hefty, Sean; Steve Wise; Devesh Sharma; Roland Dreier Cc: linux-rdma@vger.kernel.org; chuck.le...@oracle.com Subject: Re: [for-next 1/2] xprtrdma: take reference of rdma

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Steve Wise
-Original Message- From: Hefty, Sean [mailto:sean.he...@intel.com] Sent: Thursday, July 17, 2014 2:50 PM To: Steve Wise; 'Shirley Ma'; 'Devesh Sharma'; 'Roland Dreier' Cc: linux-rdma@vger.kernel.org; chuck.le...@oracle.com Subject: RE: [for-next 1/2] xprtrdma: take reference of

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Steve Wise
-Original Message- From: Steve Wise [mailto:sw...@opengridcomputing.com] Sent: Thursday, July 17, 2014 2:56 PM To: 'Hefty, Sean'; 'Shirley Ma'; 'Devesh Sharma'; 'Roland Dreier' Cc: 'linux-rdma@vger.kernel.org'; 'chuck.le...@oracle.com' Subject: RE: [for-next 1/2] xprtrdma: take

RE: [PATCH 1/1] ibacm: Incorrect return value check in path resolution

2014-07-17 Thread Hefty, Sean
thanks - merged -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Shirley Ma
On 07/17/2014 12:55 PM, Steve Wise wrote: -Original Message- From: Hefty, Sean [mailto:sean.he...@intel.com] Sent: Thursday, July 17, 2014 2:50 PM To: Steve Wise; 'Shirley Ma'; 'Devesh Sharma'; 'Roland Dreier' Cc: linux-rdma@vger.kernel.org; chuck.le...@oracle.com Subject: RE:

Re: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Chuck Lever
On Jul 17, 2014, at 4:08 PM, Steve Wise sw...@opengridcomputing.com wrote: -Original Message- From: Steve Wise [mailto:sw...@opengridcomputing.com] Sent: Thursday, July 17, 2014 2:56 PM To: 'Hefty, Sean'; 'Shirley Ma'; 'Devesh Sharma'; 'Roland Dreier' Cc:

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Steve Wise
-Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Chuck Lever Sent: Thursday, July 17, 2014 3:42 PM To: Steve Wise Cc: Hefty, Sean; Shirley Ma; Devesh Sharma; Roland Dreier; linux-rdma@vger.kernel.org Subject: Re:

Re: [PATCH net-next v2 0/4] cxgb4i: Add ipv6 support

2014-07-17 Thread David Miller
From: Anish Bhatt an...@chelsio.com Date: Thu, 17 Jul 2014 00:18:14 -0700 The following patchset add ipv6 support for the cxgb4i(iscsi) driver. Patch 1 moves a define from the iw_cxgb4 to cxgb4 to prevent code duplication, as it is used by cxgb4i and iw_cxgb4 both. Patch 2 exports

Re: [PATCH] iw_cxgb4: fix for 64-bit integer division

2014-07-17 Thread David Miller
From: Sergei Shtylyov sergei.shtyl...@cogentembedded.com Date: Thu, 17 Jul 2014 22:44:42 +0400 Hello. On 07/17/2014 09:01 PM, Hariprasad Shenai wrote: Fixed error introduced in commit id 7730b4c ( cxgb4/iw_cxgb4: work request logging feature) while compiling on 32 bit architecture

RE: [for-next 1/2] xprtrdma: take reference of rdma provider module

2014-07-17 Thread Devesh Sharma
-Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Steve Wise Sent: Friday, July 18, 2014 2:29 AM To: 'Chuck Lever' Cc: 'Hefty, Sean'; 'Shirley Ma'; Devesh Sharma; 'Roland Dreier'; linux- r...@vger.kernel.org Subject: