On Mon, 12 Jan 2015, Dan Carpenter wrote:
We should return -ENOMEM on allocation failure instead of success.
Probably not a big deal, but the commit message is not clear at all. From
the fix, it doesn't look like the code was returning -ENOMEM on success.
julia
Fixes: e126ba97dba9 ('mlx5:
The current code returns success when kmalloc() fails. It should return
an error code, -ENOMEM.
Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-IB adapters')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
---
v2: re-write changelog
diff --git
We should return -ENOMEM on allocation failure instead of success.
Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-IB adapters')
Signed-off-by: Dan Carpenter dan.carpen...@oracle.com
diff --git a/drivers/infiniband/hw/mlx5/main.c
b/drivers/infiniband/hw/mlx5/main.c
index
Acked-by: Eli Cohen e...@mellanox.com
Thanks!
On Mon, Jan 12, 2015 at 11:14:29AM +0300, Dan Carpenter wrote:
We should return -ENOMEM on allocation failure instead of success.
Fixes: e126ba97dba9 ('mlx5: Add driver for Mellanox Connect-IB adapters')
Signed-off-by: Dan Carpenter
-Original Message-
From: Chuck Lever [mailto:chuck.le...@oracle.com]
Sent: Sunday, January 11, 2015 6:41 PM
To: Sagi Grimberg; Steve Wise
Cc: linux-rdma@vger.kernel.org; Linux NFS Mailing List
Subject: Re: [PATCH v1 06/10] svcrdma: Plant reader function in struct
svcxprt_rdma
Add support for ConnectX-3 and ConnectX-4.
Signed-off-by: Hal Rosenstock h...@mellanox.com
---
diff --git a/src/ibdiag_common.c b/src/ibdiag_common.c
index 8c749c7..384d342 100644
--- a/src/ibdiag_common.c
+++ b/src/ibdiag_common.c
@@ -499,9 +499,9 @@ conv_cnt_human_readable(uint64_t val64,
Signed-off-by: Hal Rosenstock h...@mellanox.com
---
diff --git a/src/fields.c b/src/fields.c
index 33a6364..9965811 100644
--- a/src/fields.c
+++ b/src/fields.c
@@ -835,7 +835,7 @@ static const ib_field_t ib_mad_f[] = {
{BITSOFFS(16, 16), ThresholdEventCounter, mad_dump_uint},
Add support for ConnectX-4.
Signed-off-by: Hal Rosenstock h...@mellanox.com
---
opensm/osm_subnet.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/opensm/osm_subnet.c b/opensm/osm_subnet.c
index ba760ff..3463eca 100644
--- a/opensm/osm_subnet.c
+++
From: Anish Bhatt an...@chelsio.com
Date: Thu, 8 Jan 2015 21:38:14 -0800
This patch series cleans up all register defines/MACROS defined in t4_msg.h
and
affected files as part of the continuing cleanup effort
The patches series is created against 'net-next' tree and includes patches
to
On 1/12/2015 9:08 PM, Hal Rosenstock wrote:
Add support for ConnectX-3 and ConnectX-4
So... ConnectX-3 isn't supported today?! on what infrastructure/tools
exactly?
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
Acked-by: Steve Wise sw...@opengridcomputing.com
--
To unsubscribe from this list: send the line unsubscribe linux-rdma in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: Ira Weiny ira.we...@intel.com
Save dereference and clarifies that rcv_has_same_class can process both IB and
OPA MADs.
Signed-off-by: Ira Weiny ira.we...@intel.com
---
drivers/infiniband/core/mad.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git
From: Ira Weiny ira.we...@intel.com
Use the new mad_size specified by devices for the allocations and DMA maps.
kmalloc is more flexible to support devices with different sized MADs and
research and testing showed that the current use of kmem_cache does not provide
performance benefits over
From: Ira Weiny ira.we...@intel.com
OPA_MIN_CLASS_VERSION -- OPA Class versions are 0x80
OPA_SMP_CLASS_VERSION -- Defined at 0x80
OPA_MGMT_BASE_VERSION -- Defined at 0x80
Increase max management version to accommodate OPA
Signed-off-by: Ira Weiny ira.we...@intel.com
---
From: Ira Weiny ira.we...@intel.com
This helper function will be used for processing both IB and OPA SMP recvs.
Signed-off-by: Ira Weiny ira.we...@intel.com
---
drivers/infiniband/core/smi.c | 80 -
1 files changed, 47 insertions(+), 33 deletions(-)
From: Ira Weiny ira.we...@intel.com
Define jumbo_mad and jumbo_rmpp_mad
Create an RMPP Base header to share between ib_rmpp_mad and jumbo_rmpp_mad
Update code to use the new structures.
Signed-off-by: Ira Weiny ira.we...@intel.com
---
Changes from RFC:
add JUMBO_MGMT_MAD_SIZE
From: Ira Weiny ira.we...@intel.com
This helper function will be used for processing both IB and OPA SMPs.
Signed-off-by: Ira Weiny ira.we...@intel.com
---
drivers/infiniband/core/mad.c | 85 +++-
1 files changed, 49 insertions(+), 36 deletions(-)
diff
From: Ira Weiny ira.we...@intel.com
validate_mad only needs access to the MAD header
Signed-off-by: Ira Weiny ira.we...@intel.com
---
drivers/infiniband/core/mad.c | 12 ++--
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/infiniband/core/mad.c
From: Ira Weiny ira.we...@intel.com
Add a device capability flag to flag OPA MAD support on devices.
Signed-off-by: Ira Weiny ira.we...@intel.com
---
Changes from RFC:
Changed flag to indicate OPA MAD base version support
Added device_cap_flags2 as device_cap_flags bits are
From: Ira Weiny ira.we...@intel.com
This helper function will be used for processing both IB and OPA SMP sends.
Signed-off-by: Ira Weiny ira.we...@intel.com
---
drivers/infiniband/core/smi.c | 81 -
1 files changed, 47 insertions(+), 34 deletions(-)
From: Ira Weiny ira.we...@intel.com
This helper function will be used for processing both IB and OPA SMPs.
Signed-off-by: Ira Weiny ira.we...@intel.com
---
drivers/infiniband/core/smi.c | 26 +-
1 files changed, 17 insertions(+), 9 deletions(-)
diff --git
From: Ira Weiny ira.we...@intel.com
OPA SMP packets must carry a valid pkey
process wc.pkey_index returned by agents for response.
Handle variable length OPA MADs based on the Base Version
Support is provided by:
* Adjusting the 'fake' WC for locally routed SMP's to represent
From: Ira Weiny ira.we...@intel.com
In preparation to support the new OPA MAD Base version, add a base version
parameter ib_create_send_mad and set it to IB_MGMT_BASE_VERSION for current
users.
Definition of the new base version and it's processing will occur in later
patches.
Signed-off-by:
From: Ira Weiny ira.we...@intel.com
In support of variable length MADs add in and out MAD size parameters to the
process_mad call.
The out MAD size parameter is passed by reference such that it can be updated
by the agent to indicate the proper response length to be sent by the MAD
stack.
The
From: Ira Weiny ira.we...@intel.com
Define the new OPA SMP format, create support functions for this format using
the previously defined helper functions as appropriate.
Signed-off-by: Ira Weiny ira.we...@intel.com
---
drivers/infiniband/core/mad_priv.h |2 +
From: Ira Weiny ira.we...@intel.com
If the MAD is an OPA base version; verify the device supports Jumbo MAD sizes
Set MAD size and sg lengths as appropriate
Split RMPP MADs as appropriate
Signed-off-by: Ira Weiny ira.we...@intel.com
---
Changes from RFC:
remove use of
From: Ira Weiny ira.we...@intel.com
If the registration specifies an OPA MAD class version and the device does not
support OPA MADs, fail the MAD registration.
Signed-off-by: Ira Weiny ira.we...@intel.com
---
Changes from RFC:
remove use of supports_jumbo_mads
convert to use
Since the persistent server threads aren't joined, they must be created in
the DETACHED state or resources will not be cleaned up when they exit.
This results in pthread_create() failures after thousands of rping
instances are run against a persistent server.
Also check the return from all calls
From: Ira Weiny ira.we...@intel.com
ib_response_mad only needs access to the MAD header
Signed-off-by: Ira Weiny ira.we...@intel.com
---
drivers/infiniband/core/mad.c | 20 ++--
drivers/infiniband/core/user_mad.c |6 +++---
include/rdma/ib_mad.h |2 +-
From: Ira Weiny ira.we...@intel.com
The following patch series modifies the kernel MAD processing (ib_mad/ib_umad)
and related interfaces to send and receive Intel Omni-Path Architecture MADs on
devices which support them.
In addition to supporting some IBTA management classes, OPA devices use
From: Ira Weiny ira.we...@intel.com
Signed-off-by: Ira Weiny ira.we...@intel.com
---
drivers/infiniband/core/device.c |2 ++
include/rdma/ib_verbs.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/drivers/infiniband/core/device.c
31 matches
Mail list logo
