On 03/31/2015 12:35 AM, Jason Gunthorpe wrote:
On Mon, Mar 30, 2015 at 05:10:12PM +0200, Michael Wang wrote:
I found that actually we don't have to touch this one which
only used by HW driver currently.
I'm having a hard time understanding this, the code in question was in
On 03/31/2015 01:47 AM, ira.weiny wrote:
On Mon, Mar 30, 2015 at 06:20:48PM +0200, Michael Wang wrote:
[snip]
Cc: Jason Gunthorpe jguntho...@obsidianresearch.com
Cc: Doug Ledford dledf...@redhat.com
Cc: Ira Weiny ira.we...@intel.com
Cc: Sean Hefty sean.he...@intel.com
Signed-off-by: Michael
On Tue, Mar 31, 2015 at 6:47 AM, Roland Dreier rol...@kernel.org wrote:
Roland, I have to genuinely agree with Or, that your handling of
patch integration is sub-par and really painful for anyone actually
trying to get real work done here.
If you simply don't have the time to devote to
On 3/31/2015 3:39 AM, Michael Wang wrote:
On 03/31/2015 12:35 AM, Jason Gunthorpe wrote:
On Mon, Mar 30, 2015 at 05:10:12PM +0200, Michael Wang wrote:
I found that actually we don't have to touch this one which
only used by HW driver currently.
I'm having a hard time understanding this, the
Hi, Tom
Thanks for the comments :-)
On 03/31/2015 01:19 PM, Tom Talpey wrote:
[snip]
Actually I'm thinking about Doug's idea to use rdma_transport_is_XX()
instead of the current basic helper, thus may be use
rdma_transport_is_iwarp()
in here could be better, since it's actually a feature
On 03/27/2015, 01:42 PM, Yann Droneaud wrote:
Hi,
Please add commit 377b513485fd (IB/core: Avoid leakage from kernel to
user space) to -stable. It can be applied to v2.6.32 and later.
Now pushed to 3.12. Thanks.
--
js
suse labs
--
To unsubscribe from this list: send the line unsubscribe
On 3/31/2015 6:47 AM, Roland Dreier wrote:
Roland, I have to genuinely agree with Or, that your handling of
patch integration is sub-par and really painful for anyone actually
trying to get real work done here.
If you simply don't have the time to devote to constantly reviewing
patches as they
On 3/30/2015 8:16 PM, Jason Gunthorpe wrote:
But, it doesn't really make sense to use eth_random_addr (which
doesn't have a special OUI) and not randomize every bit.
get_random_bytes(guid, sizeof(guid));
guid = ~(1ULL 56);
guid |= 1ULL 57;
OK, we can do that, sure.
Well this needs to be addressed yes but in order to have that done someone
needs to step forward do the proper work, maintain git trees, do the
review and show up for the conferences. Neither Roland nor Or was there at
the Infiniband conferences in Monterey this year(!) and this is the prime
venue
On 3/31/2015 8:49 AM, Christoph Lameter wrote:
Well this needs to be addressed yes but in order to have that done someone
needs to step forward do the proper work, maintain git trees, do the
review and show up for the conferences. Neither Roland nor Or was there at
the Infiniband conferences
On Tue, Mar 31, 2015 at 08:51:13PM -0400, ira.weiny wrote:
Going forward we want to NAK stuff like this:
if (rdma_ib_mgmt() || rdma_opa_mgmt())
if (has_sa() || has_opa_foobar())
I'm confused.
Is the idea that you would NAK has_sa but be in favor of has_ib_sa?
It is the || I
On Tue, Mar 31, 2015 at 05:12:02PM -0600, Jason Gunthorpe wrote:
On Mon, Mar 30, 2015 at 01:02:03PM -0400, Doug Ledford wrote:
If we use something like this, then the above is all you need. Then
every place in the code that checks for something like has_sa or cap_sa
can be replaced with
On 03/31/2015 03:42 PM, Tom Talpey wrote:
On 3/31/2015 7:41 AM, Michael Wang wrote:
[snip]
Yes, in fact the iWARP protocol does not preclude multiple read SGEs,
even though most iWARP implementations have chosen to support just one.
Even for multi-SGE-capable adapters, there is a limit of
On 3/31/2015 7:41 AM, Michael Wang wrote:
Hi, Tom
Thanks for the comments :-)
On 03/31/2015 01:19 PM, Tom Talpey wrote:
[oops - repeating my reply with full cc's]
[snip]
Actually I'm thinking about Doug's idea to use rdma_transport_is_XX()
instead of the current basic helper, thus may
On 03/30/2015 02:33 PM, Chuck Lever wrote:
This is a series of client-side patches for NFS/RDMA. In preparation
for increasing the transport credit limit and maximum rsize/wsize,
I've re-factored the memory registration logic into separate files,
invoked via a method API.
The series is
From: Or Gerlitz gerlitz...@gmail.com
Date: Tue, 31 Mar 2015 14:22:50 +0300
On Tue, Mar 31, 2015 at 6:47 AM, Roland Dreier rol...@kernel.org wrote:
Roland, I have to genuinely agree with Or, that your handling of
patch integration is sub-par and really painful for anyone actually
trying to
On Tue, 31 Mar 2015, Hal Rosenstock wrote:
Sean and Hal showed up for the conference. Sean is active mostly in
focusing on userspace stuff. Both could become more involved in the kernel
ib tree and the review process? Hal is employed by Mellanox but is not
participating in these patch
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/ulp/iser/iscsi_iser.h
b/drivers/infiniband/ulp/iser/iscsi_iser.h
index 5fd0963..a39645a 100644
---
No need to keep lkey, va, len variables, we can keep
them as struct ib_sge. This will help when we change the
memory registration logic.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Adir Lev ad...@mellanox.com
---
No need to pass that, we can take it from the task.
In a later stage, this function will be invoked
according to a device capability.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Adir Lev ad...@mellanox.com
---
On Sun, Mar 15, 2015 at 11:52:44AM -0700, Doug Ledford wrote:
On Mar 13, 2015, at 1:41 AM, Or Gerlitz gerlitz...@gmail.com wrote:
On Sun, Feb 22, 2015 at 2:26 AM, Doug Ledford dledf...@redhat.com wrote:
This is the re-ordered, squashed version of my 22 patch set that I
posted on Feb
Fast registration and local invalidate work requests can
also fail. We should call error completion handler for them.
Reported-by: Roi Dayan r...@mellanox.com
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_verbs.c | 11 ++-
1 files changed, 6
In some rare cases, IO operations may be not aligned to page
boundaries. This prevents iser from performing fast memory
registration. In order to overcome that iser uses a bounce
buffer to carry the transaction. We basically allocate a buffer
in the size of the transaction and perform a copy.
The
No need for these two separate. Keep it in a single routine
like in the fastreg case. This will also make iser_reg_page_vec
closer to iser_fast_reg_mr arguments. This is a preparation
step for registration flow refactor.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg
No need to keep two iser_data_buf structures just in case we use
mem copy. We can avoid that just by adding a pointer to the original
sg. So keep only two iser_data_buf per command (data and protection)
and pass the relevant data_buf to bounce buffer routine.
This patch does not change any
Instead of passing ib_sge as output variable, we pass the mem_reg
pointer to have the routines fill the rkey as well. This reduces
code duplication and extra assignments. This is a preparation step
to unify some registration logics together.
This patch does not change any functionality.
Hi Roland,
This set contains bug fixes as well as code refactoring patches
- Patches 1-3: Bug fixes (stable material)
- Patches 4-6: Bounce buffer related code cleanups
- Patches 7-12,16: Refactoring
- Patches 13-15: Minor optimizations
- Patch 17:Version bump
- Patch 18:
Make iser_[create|destroy]_fastreg_desc shorter, more
readable and easily extendable.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Adir Lev ad...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_verbs.c | 118
Buffer length was assigned twice, and no reason to set va to
io_addr and then add the offset, just set va to io_addr + offset.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Adir Lev ad...@mellanox.com
---
Instead of open-coding connection fastreg pool get/put,
we introduce iser_reg_desc[get|put] helpers.
We aren't setting these static as this will be a per-device
routine later on. Also, cleanup iser_unreg_rdma_mem_fastreg
a bit.
This patch does not change any functionality.
Signed-off-by: Sagi
Memory regions are resources that are saved
in the device caches. Increase the probability for
a cache hit by adding the MRU descriptor to pool
head.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iser_memory.c |2 +-
1 files changed, 1 insertions(+), 1
This struct members other than struct iser_mem_reg are unused,
so remove it altogether.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Adir Lev ad...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.h | 21 +-
This length miss-calculation may cause a silent data corruption
in the DIX case and cause the device to reference unmapped area.
Fixes: d77e65350f2d ('libiscsi, iser: Adjust data_length to include protection
information')
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
In singleton scatterlists, DMA memory registration code
is taken both for Fastreg and FMR code paths. Move it to
a function.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
Signed-off-by: Adir Lev ad...@mellanox.com
---
In case the user unloaded ib_iser while ep_connect is in
progress, we need to destroy the endpoint although ep_disconnect
wasn't invoked (we detect this by the iser conn state != DOWN).
However, if we got an REJECTED/UNREACHABLE CM event we move the
connection state to DOWN which will prevent us
As memory registration/de-registration methods, lets
move them to their natural location. While we're at it,
make iser_reg_page_vec routine static.
This patch does not change any functionality.
Signed-off-by: Sagi Grimberg sa...@mellanox.com
---
drivers/infiniband/ulp/iser/iscsi_iser.h |4
From: Christoph Lameter c...@linux.com
Date: Tue, 31 Mar 2015 07:49:38 -0500 (CDT)
Well this needs to be addressed yes but in order to have that done someone
needs to step forward do the proper work, maintain git trees, do the
review and show up for the conferences. Neither Roland nor Or was
On Tue, 31 Mar 2015, David Miller wrote:
Well this needs to be addressed yes but in order to have that done someone
needs to step forward do the proper work, maintain git trees, do the
review and show up for the conferences. Neither Roland nor Or was there at
the Infiniband conferences in
On Tue, Mar 31, 2015 at 12:13:58PM +0300, Sagi Grimberg wrote:
We had a talk about a similar topic at LSFMM15. Linux-scsi subsystem
is a large scale subsystem and also has the single maintainer with
limited time for upstream maintenance bottleneck.
Christoph created the scsi-queue tree to
It doesn't take a lot of time to do this work, especially if you use
the correct tools. I can review and apply 100 patches a day, even
when I'm on vacation. I'm an extreme example, but what you're doing
right now Roland is not acceptable and is not in agreement with your
claims about how
On Tue, Mar 31, 2015 at 8:27 PM, Hefty, Sean sean.he...@intel.com wrote:
I honestly think part of the issue here is general approach being taken by
the rdma stack, which is to expose every hardware specific component that a
vendor might define through the interfaces up to the consumers.
On Tue, Mar 31, 2015 at 8:04 PM, ira.weiny ira.we...@intel.com wrote:
On Sun, Mar 15, 2015 at 11:52:44AM -0700, Doug Ledford wrote:
On Mar 13, 2015, at 1:41 AM, Or Gerlitz gerlitz...@gmail.com wrote:
On Sun, Feb 22, 2015 at 2:26 AM, Doug Ledford dledf...@redhat.com wrote:
This is the
On 03/30/2015 07:02 PM, Doug Ledford wrote:
On Mon, 2015-03-30 at 18:42 +0200, Michael Wang wrote:
[snip]
rdma_transport_is_ib and rdma_port_ll_is_ib is actually just rough helper
to save some code, we can get rid of them when we no longer need them, but
currently device driver still using
I must disagree. You made this claim back when we submitted the IB
core patch which adds support for signature, protection etc offloads
(commit 1b01d33560e7 IB/core: Introduce signature verbs API and the
detailed replied you got were explaining that
And I'll continue to make this claim
On Mon, Mar 30, 2015 at 01:02:03PM -0400, Doug Ledford wrote:
If we use something like this, then the above is all you need. Then
every place in the code that checks for something like has_sa or cap_sa
can be replaced with rdma_ib_mgmt.
I don't want to see this slide back into some ill
On Mon, Mar 30, 2015 at 12:13:00PM -0400, Doug Ledford wrote:
On Fri, 2015-03-27 at 16:47 +0100, Michael Wang wrote:
Introduce helper has_iwarp() to help us check if an IB device
support IWARP protocol.
This is a needless redirection. Just stick with the original
46 matches
Mail list logo
