RE: [PATCH v5 14/27] IB/Verbs: Reform cma_acquire_dev()

2015-04-21 Thread Devesh Sharma
Looks good, I would like to test with ocrdma before confirming. -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Michael Wang Sent: Monday, April 20, 2015 2:08 PM To: Roland Dreier; Sean Hefty;

Re: [PATCH v2 00/11] Add network namespace support in the RDMA-CM

2015-04-21 Thread Haggai Eran
On 20/04/2015 17:53, Steve Wise wrote: Hey Haggai, Did you check for changes needed in drivers/infiniband/core/iwcm.c? We focused on namespace support for InfiniBand alone in this series. We didn't handle iWARP, nor did we implement support for RoCE or other transports. I notice that it

Re: [PATCHv2 for-4.1 0/4] Misc. fixes and cleanup for iw_cxgb4

2015-04-21 Thread Doug Ledford
On Wed, 2015-04-22 at 01:44 +0530, Hariprasad Shenai wrote: Hi, This patch series changes a macro definition to be consistent with other register macro defines. Fixes for 32b platform, use BAR2 register for kernel mode CQ's and enforces qp/cq id requirements. The patches series is created

Re: [PATCH v2 02/11] IB/addr: Pass network namespace as a parameter

2015-04-21 Thread Haggai Eran
On 21/04/2015 01:05, Doug Ledford wrote: On Mon, 2015-04-20 at 12:03 +0300, Haggai Eran wrote: From: Guy Shapiro gu...@mellanox.com Add network namespace support to the ib_addr module. For that, all the address resolution and matching should be done using the appropriate namespace instead

[PATCH net] net/mlx4_core: Fix reading HCA max message size in mlx4_QUERY_DEV_CAP

2015-04-21 Thread Or Gerlitz
From: Eran Ben Elisha era...@mellanox.com Currently we parse max_msg_sz from the wrong offset in QUERY_DEV_CAP, fix to use the right offset. Fixes: 0b131561a7d6 ('net/mlx4_en: Add Flow control statistics [..]') Signed-off-by: Eran Ben Elisha era...@mellanox.com Signed-off-by: Or Gerlitz

Re: [PATCH v5 04/27] IB/Verbs: Reform IB-core cm

2015-04-21 Thread Michael Wang
On 04/20/2015 07:04 PM, Hal Rosenstock wrote: On 4/20/2015 4:33 AM, Michael Wang wrote: Use raw management helpers to reform IB-core cm. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

Re: [PATCH v5 19/27] IB/Verbs: Use management helper cap_iw_cm()

2015-04-21 Thread Michael Wang
On 04/20/2015 05:51 PM, Tom Tucker wrote: [snip] int ib_query_gid(struct ib_device *device, u8 port_num, int index, union ib_gid *gid); iWARP devices _must_ support the IWCM so cap_iw_cm() is not really useful. Sean suggested to add this helper paired with cap_ib_cm(),

Re: [PATCH v5 13/27] IB/Verbs: Reserve legacy transport type in 'dev_addr'

2015-04-21 Thread Michael Wang
On 04/21/2015 07:58 AM, Devesh Sharma wrote: [snip] diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index ebac646..6195bf6 100644 --- a/drivers/infiniband/core/cma.c +++ b/drivers/infiniband/core/cma.c @@ -244,14 +244,35 @@ static inline void cma_set_ip_ver(struct

Re: [PATCH v5 14/27] IB/Verbs: Reform cma_acquire_dev()

2015-04-21 Thread Michael Wang
On 04/21/2015 08:15 AM, Devesh Sharma wrote: Looks good, I would like to test with ocrdma before confirming. That's great :-) Any testing would be really helpful, please let us know if there is some thing broken. Regards, Michael Wang -Original Message- From:

Re: [PATCH v2 01/11] RDMA/CMA: Mark IPv4 addresses correctly when the listener is IPv6

2015-04-21 Thread Haggai Eran
On 20/04/2015 23:01, Jason Gunthorpe wrote: On Mon, Apr 20, 2015 at 09:38:02PM +0300, Or Gerlitz wrote: On Mon, Apr 20, 2015 at 7:41 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: On Mon, Apr 20, 2015 at 12:03:32PM +0300, Haggai Eran wrote: From: Yotam Kenneth yota...@mellanox.com

Re: [PATCH v5 19/27] IB/Verbs: Use management helper cap_iw_cm()

2015-04-21 Thread Tom Tucker
On 4/21/15 2:39 AM, Michael Wang wrote: On 04/20/2015 05:51 PM, Tom Tucker wrote: [snip] int ib_query_gid(struct ib_device *device, u8 port_num, int index, union ib_gid *gid); iWARP devices _must_ support the IWCM so cap_iw_cm() is not really useful. Sean suggested to

[PATCHv2 for-4.1 0/4] Misc. fixes and cleanup for iw_cxgb4

2015-04-21 Thread Hariprasad Shenai
Hi, This patch series changes a macro definition to be consistent with other register macro defines. Fixes for 32b platform, use BAR2 register for kernel mode CQ's and enforces qp/cq id requirements. The patches series is created against github for-4.1 branch. And includes patches on iw_cxgb4

[PATCHv2 for-4.1 3/4] iw_cxgb4: use BAR2 GTS register for T5 kernel mode CQs

2015-04-21 Thread Hariprasad Shenai
For T5, we must not use the kdb/kgts registers, in order avoid db drops under extreme loads. Signed-off-by: Steve Wise sw...@opengridcomputing.com Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/infiniband/hw/cxgb4/cq.c | 15 +++ drivers/infiniband/hw/cxgb4/t4.h |

[PATCHv2 for-4.1 1/4] iw_cxgb4: Cleanup register defines/MACROS

2015-04-21 Thread Hariprasad Shenai
Cleanup macros and register defines for consistency Signed-off-by: Hariprasad Shenai haripra...@chelsio.com --- drivers/infiniband/hw/cxgb4/cm.c | 4 ++-- drivers/infiniband/hw/cxgb4/t4fw_ri_api.h | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git

[PATCHv2 for-4.1 4/4] iw_cxgb4: enforce qp/cq id requirements

2015-04-21 Thread Hariprasad Shenai
Currently the iw_cxgb4 implementation requires the qp and cq qid densities to match as well as the qp and cq id ranges. So fail a device open if the device configuration doesn't meet the requirements. The reason for these restictions has to do with the fact that IQ qid X has a UGTS register in

[PATCHv2 for-4.1 2/4] iw_cxgb4: 32b platform fixes

2015-04-21 Thread Hariprasad Shenai
- get_dma_mr() was using ~0UL which is should be ~0ULL. This causes the DMA MR to get setup incorrectly in hardware. - wr_log_show() needed a 64b divide function div64_u64() instead of doing division directly. - fixed warnings about recasting a pointer to a u64 Signed-off-by: Steve Wise

[PATCH infiniband-diags] vendstat: mad_rpc_close_port not called in corner cases

2015-04-21 Thread Hal Rosenstock
From: Vladimir Koushnir vladim...@mellanox.com Date: Thu, 16 Apr 2015 18:27:39 +0300 Call mad_rpc_close_port in all corner cases. This is needed so fds are not leaked with ibsim. Signed-off-by: Vladimir Koushnir vladim...@mellanox.com Signed-off-by: Hal Rosenstock h...@mellanox.com ---

Re: [PATCH v2 00/11] Add network namespace support in the RDMA-CM

2015-04-21 Thread Haggai Eran
On 21/04/2015 17:11, Steve Wise wrote: On 4/21/2015 1:36 AM, Haggai Eran wrote: On 20/04/2015 17:53, Steve Wise wrote: Hey Haggai, Did you check for changes needed in drivers/infiniband/core/iwcm.c? We focused on namespace support for InfiniBand alone in this series. We didn't handle iWARP,

Re: [PATCH v2 07/11] IB/cm: Add network namespace support

2015-04-21 Thread Haggai Eran
On 20/04/2015 20:06, Jason Gunthorpe wrote: On Mon, Apr 20, 2015 at 12:03:38PM +0300, Haggai Eran wrote: From: Guy Shapiro gu...@mellanox.com Add namespace support to the IB-CM layer. - Each CM-ID now has a network namespace it is associated with, assigned at creation. This namespace is

[PATCH 2/2 infiniband-diags] ibqueryerrors: Resource leak in path_record_query

2015-04-21 Thread Hal Rosenstock
From: Vladimir Koushnir vladim...@mellanox.com Date: Thu Apr 16 16:39:43 2015 +0300 sa_free_handle function is not called at the end of path_record_query function. The patch fixes file descriptor leak when path_record_query function is called. Signed-off-by: Vladimir Koushnir

[PATCH infiniband-diags] dump_fts: Open global file descriptor after calling ibnd_discover_fabric

2015-04-21 Thread Hal Rosenstock
From: Vladimir Koushnir vladim...@mellanox.com Date: Thu, 16 Apr 2015 16:56:40 +0300 Global file descriptor for SMPs should be opened only after running ibnd_discover_fabric() to avoid parallel usage of two SMP file descriptors Signed-off-by: Vladimir Koushnir vladim...@mellanox.com

Re: [PATCH v2 07/11] IB/cm: Add network namespace support

2015-04-21 Thread Jason Gunthorpe
On Tue, Apr 21, 2015 at 03:07:47PM +0300, Haggai Eran wrote: Namespace is needed for RoCE address resolution, in cases where the driver doesn't report the MAC as part of the ib_wc. This patch explicitly says it doesn't deal with RoCE, so why are we adding namespaces to support RoCE paths in

Re: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-21 Thread Michael Wang
On 04/21/2015 01:03 PM, Devesh Sharma wrote: Hi Michael, It will be great help if you could base you patches on existing Roland's tree and share to branch details to pull. Just like Chuck lever does for his nfs-rdma patches? I've setup a repository in:

[PATCH for-4.1 2/3] RDMA/nes: Report the actual address of the remote connecting peer

2015-04-21 Thread Tatyana Nikolova
Get the actual (non-mapped) ip/tcp address of the connecting peer from the port mapper and report the address info to the user space application at the time of connection establishment Signed-off-by: Tatyana Nikolova tatyana.e.nikol...@intel.com --- drivers/infiniband/hw/nes/nes.c|1 +

[PATCH for-4.1 3/3] RDMA/cxgb4: Report the actual address of the remote connecting peer

2015-04-21 Thread Tatyana Nikolova
From: Steve Wise sw...@opengridcomputing.com Get the actual (non-mapped) ip/tcp address of the connecting peer from the port mapper Also setup the passive side endpoint to correctly display the actual and mapped addresses for the new connection. Signed-off-by: Steve Wise

[PATCH for-4.1 1/3] RDMA/core: Enable the iWarp Port Mapper to provide the actual address of the connecting peer to its clients

2015-04-21 Thread Tatyana Nikolova
Add functionality to enable the port mapper on the passive side to provide to its clients the actual (non-mapped) ip/tcp address information of the connecting peer 1) Adding remote_info_cb() to process the address info of the connecting peer The address info is provided by the user space

[PATCH v3 3/3] IB/ipath: add counting for MTRR

2015-04-21 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com There is no good reason not to, we eventually delete it as well. Cc: Toshi Kani toshi.k...@hp.com Cc: Roland Dreier rol...@kernel.org Cc: Sean Hefty sean.he...@intel.com Cc: Hal Rosenstock hal.rosenst...@gmail.com Cc: Suresh Siddha sbsid...@gmail.com Cc:

[PATCH v3 1/3] IB/qib: add acounting for MTRR

2015-04-21 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com There is no good reason not to, we eventually delete it as well. Cc: Toshi Kani toshi.k...@hp.com Cc: Suresh Siddha sbsid...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Thomas Gleixner t...@linutronix.de Cc: Juergen Gross jgr...@suse.com Cc: Daniel Vetter

[PATCH v4 0/2] qib: few changes to bury MTRR use

2015-04-21 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com MTRR use is being deprecated and should only be used with the helper arch_phys_wc_add() when PAT is not available and enabled. This v4 follows addresse the removal of the PAT module parameter for the driver which was always preferring PAT anyway. Luis R.

[PATCH for-4.1 0/3] Enable the iWarp Port Mapper to provide the actual address of the connecting peer to its clients

2015-04-21 Thread Tatyana Nikolova
This patch series was first submitted for inclusion upstream on 10/13/14, but it seems to have slipped through the cracks. When iWARP port mapping is being done, the passive side of a connection only knows the mapped address/port of the peer. This patch series enables the passive side port mapper

[PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com This driver already makes use of ioremap_wc() on PIO buffers, so convert it to use arch_phys_wc_add(). Cc: Toshi Kani toshi.k...@hp.com Cc: Rickard Strandqvist rickard_strandqv...@spectrumdigital.se Cc: Mike Marciniszyn mike.marcinis...@intel.com Cc:

[PATCH v3 0/3] infiniband: few MTRR fixes and conversions

2015-04-21 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com Infiniband has a few MTRR uses which from the looks of it was first written on the ipath driver, later copied and pasted on the qib driver. The behaviour of not counting is matched on both drivers but with no good reason, since we want to generalize use of

RE: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Marciniszyn, Mike
This driver already makes use of ioremap_wc() on PIO buffers, so convert it to use arch_phys_wc_add(). This is probably OK, but I think you should also remove the qib_wc_pat module parameter. Jason Revise based on Jason's request and I will do some testing. Mike -- To unsubscribe from

Re: [PATCH net] net/mlx4_core: Fix reading HCA max message size in mlx4_QUERY_DEV_CAP

2015-04-21 Thread David Miller
From: Or Gerlitz ogerl...@mellanox.com Date: Tue, 21 Apr 2015 15:46:34 +0300 From: Eran Ben Elisha era...@mellanox.com Currently we parse max_msg_sz from the wrong offset in QUERY_DEV_CAP, fix to use the right offset. Fixes: 0b131561a7d6 ('net/mlx4_en: Add Flow control statistics [..]')

Re: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Jason Gunthorpe
On Tue, Apr 21, 2015 at 01:37:55PM -0700, Luis R. Rodriguez wrote: From: Luis R. Rodriguez mcg...@suse.com This driver already makes use of ioremap_wc() on PIO buffers, so convert it to use arch_phys_wc_add(). This is probably OK, but I think you should also remove the qib_wc_pat module

Re: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 2:12 PM, Andy Lutomirski l...@amacapital.net wrote: On Tue, Apr 21, 2015 at 2:09 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: On Tue, Apr 21, 2015 at 1:59 PM, Marciniszyn, Mike mike.marcinis...@intel.com wrote: This driver already makes use of ioremap_wc() on

Re: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 1:59 PM, Marciniszyn, Mike mike.marcinis...@intel.com wrote: This driver already makes use of ioremap_wc() on PIO buffers, so convert it to use arch_phys_wc_add(). This is probably OK, but I think you should also remove the qib_wc_pat module parameter. Jason

Re: [PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Jason Gunthorpe
On Tue, Apr 21, 2015 at 02:50:35PM -0700, Luis R. Rodriguez wrote: - if (qib_wc_pat) { - resource_size_t vl15off; - /* - * We do not set WC on the VL15 buffers to avoid - * a rare problem with unaligned writes from - *

[PATCH v4 2/2] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com This driver already makes use of ioremap_wc() on PIO buffers, so convert it to use arch_phys_wc_add(). The qib driver uses a mmap() special case for when PAT is not used, this behaviour used to be determined with a module parameter but since we have been

[PATCH v4 1/2] IB/qib: add acounting for MTRR

2015-04-21 Thread Luis R. Rodriguez
From: Luis R. Rodriguez mcg...@suse.com There is no good reason not to, we eventually delete it as well. Cc: Toshi Kani toshi.k...@hp.com Cc: Suresh Siddha sbsid...@gmail.com Cc: Ingo Molnar mi...@elte.hu Cc: Thomas Gleixner t...@linutronix.de Cc: Juergen Gross jgr...@suse.com Cc: Daniel Vetter

Re: [PATCH v3 2/3] IB/qib: use arch_phys_wc_add()

2015-04-21 Thread Andy Lutomirski
On Tue, Apr 21, 2015 at 2:09 PM, Luis R. Rodriguez mcg...@do-not-panic.com wrote: On Tue, Apr 21, 2015 at 1:59 PM, Marciniszyn, Mike mike.marcinis...@intel.com wrote: This driver already makes use of ioremap_wc() on PIO buffers, so convert it to use arch_phys_wc_add(). This is probably OK,

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Luis R. Rodriguez
On Wed, Apr 15, 2015 at 01:42:47PM -0700, Andy Lutomirski wrote: On Mon, Apr 13, 2015 at 10:49 AM, Luis R. Rodriguez mcg...@suse.com wrote: c) ivtv: the driver does not have the PCI space mapped out separately, and in fact it actually does not do the math for the framebuffer, instead it

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Jason Gunthorpe
On Wed, Apr 22, 2015 at 12:46:01AM +0200, Luis R. Rodriguez wrote: are talking about annotating the qib driver as known to be broken without PAT and since the ipath driver needs considerable work to be ported to use PAT (the This only seems to be true for one of the chips that driver

Re: [PATCH v5 02/27] IB/Verbs: Implement raw management helpers

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:32:32AM +0200, Michael Wang wrote: Add raw helpers: rdma_tech_ib rdma_tech_iboe rdma_tech_iwarp rdma_ib_or_iboe (transition, clean up later) To help us detect which technology the port supported. Cc: Hal Rosenstock

Re: [PATCH v5 07/27] IB/Verbs: Reform IB-ulp ipoib

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:35:15AM +0200, Michael Wang wrote: Use raw management helpers to reform IB-ulp ipoib. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc:

Re: [PATCH v5 04/27] IB/Verbs: Reform IB-core cm

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:33:45AM +0200, Michael Wang wrote: Use raw management helpers to reform IB-core cm. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc: Doug

Re: [PATCH v5 06/27] IB/Verbs: Reform IB-core multicast

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:34:48AM +0200, Michael Wang wrote: Use raw management helpers to reform IB-core multicast. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com

Re: [PATCH v5 08/27] IB/Verbs: Reform IB-ulp xprtrdma

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:35:47AM +0200, Michael Wang wrote: Use raw management helpers to reform IB-ulp xprtrdma. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com Cc:

Re: [PATCH v5 05/27] IB/Verbs: Reform IB-core sa_query

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:34:23AM +0200, Michael Wang wrote: Use raw management helpers to reform IB-core sa_query. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe jguntho...@obsidianresearch.com

Re: [PATCH v5 27/27] IB/Verbs: Cleanup rdma_node_get_transport()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:43:51AM +0200, Michael Wang wrote: We have get rid of all the scene using legacy rdma_node_get_transport(), now clean it up. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

Re: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-21 Thread ira.weiny
On Tue, Apr 21, 2015 at 11:36:40PM +, Liran Liss wrote: Hi Michael, The spirit of this patch-set is great, but I think that we need to clarify some concepts. Since this will affect the whole patch-set, I am laying out my concerns here instead. A suggestion for the resulting

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Jason Gunthorpe
On Wed, Apr 22, 2015 at 01:39:07AM +0200, Luis R. Rodriguez wrote: Mike, do you think the time is right to just remove the iPath driver? With PAT now being default the driver effectively won't work with write-combining on modern kernels. Even if systems are old they likely had PAT support,

Re: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-21 Thread Jason Gunthorpe
On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote: Introduce helper cap_ipoib() to help us check if the port of an IB device support IP over Infiniband. I thought we were dropping this in favor of listing the actual features the ULP required unconditionally? One of my messages had

Re: ioremap_uc() followed by set_memory_wc() - burrying MTRR

2015-04-21 Thread Luis R. Rodriguez
On Tue, Apr 21, 2015 at 04:57:32PM -0600, Jason Gunthorpe wrote: On Wed, Apr 22, 2015 at 12:46:01AM +0200, Luis R. Rodriguez wrote: are talking about annotating the qib driver as known to be broken without PAT and since the ipath driver needs considerable work to be ported to use PAT

Re: [PATCH v5 11/27] IB/Verbs: Reform route related part in IB-core cma

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:37:13AM +0200, Michael Wang wrote: Use raw management helpers to reform route related part in IB-core cma. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

Re: [PATCH v5 15/27] IB/Verbs: Reform rest part in IB-core cma

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:38:49AM +0200, Michael Wang wrote: Use raw management helpers to reform rest part in IB-core cma. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

Re: [PATCH v5 18/27] IB/Verbs: Use management helper cap_ib_cm()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:40:04AM +0200, Michael Wang wrote: Introduce helper cap_ib_cm() to help us check if the port of an IB device support Infiniband Communication Manager. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey

Re: [PATCH v5 03/27] IB/Verbs: Reform IB-core mad/agent/user_mad

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:33:11AM +0200, Michael Wang wrote: Use raw management helpers to reform IB-core mad/agent/user_mad. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

Re: [PATCH v5 13/27] IB/Verbs: Reserve legacy transport type in 'dev_addr'

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:38:00AM +0200, Michael Wang wrote: Reserve the legacy transport type for the 'transport' member of 'struct rdma_dev_addr' until we make sure this is no longer needed. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom

Re: [PATCH v5 14/27] IB/Verbs: Reform cma_acquire_dev()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:38:23AM +0200, Michael Wang wrote: Reform cma_acquire_dev() with management helpers, introduce cma_validate_port() to make the code more clean. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com

Re: [PATCH v5 12/27] IB/Verbs: Reform mcast related part in IB-core cma

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:37:35AM +0200, Michael Wang wrote: Use raw management helpers to reform mcast related part in IB-core cma. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc: Jason Gunthorpe

Re: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:28:57AM +0200, Michael Wang wrote: Since v4: * Thanks for the comments from Hal, Sean, Tom, Or Gerlitz, Jason, Roland, Ira and Steve :-) Please remind me if anything missed :-P * Fix logical issue inside 3#, 14# * Refine 3#, 4#, 5# with label 'free' *

Re: [PATCH v5 26/27] IB/Verbs: Clean up rdma_ib_or_iboe()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:43:26AM +0200, Michael Wang wrote: We have finished introducing the cap_XX(), and raw helper rdma_ib_or_iboe() is no longer necessary, thus clean it up. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey

Re: [PATCH v5 25/27] IB/Verbs: Use management helper cap_eth_ah()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:43:03AM +0200, Michael Wang wrote: Introduce helper cap_eth_ah() to help us check if the port of an IB device support Ethernet Address Handler. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com

Re: [PATCH v5 24/27] IB/Verbs: Use management helper cap_af_ib()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:42:33AM +0200, Michael Wang wrote: Introduce helper cap_af_ib() to help us check if the port of an IB device support Native Infiniband Address. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com

Re: [PATCH v5 22/27] IB/Verbs: Use management helper cap_ipoib()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:41:38AM +0200, Michael Wang wrote: Introduce helper cap_ipoib() to help us check if the port of an IB device support IP over Infiniband. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com Cc:

Re: [PATCH v5 21/27] IB/Verbs: Use management helper cap_ib_mcast()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:41:14AM +0200, Michael Wang wrote: Introduce helper cap_ib_mcast() to help us check if the port of an IB device support Infiniband Multicast. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com

Re: [PATCH v5 20/27] IB/Verbs: Use management helper cap_ib_sa()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:40:50AM +0200, Michael Wang wrote: Introduce helper cap_ib_sa() to help us check if the port of an IB device support Infiniband Subnet Administration. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey

RE: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-21 Thread Liran Liss
Hi Michael, The spirit of this patch-set is great, but I think that we need to clarify some concepts. Since this will affect the whole patch-set, I am laying out my concerns here instead. A suggestion for the resulting management helpers is given below. I believe the result would be much more

Re: [PATCH v5 23/27] IB/Verbs: Use management helper cap_read_multi_sge()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:42:07AM +0200, Michael Wang wrote: Introduce helper cap_read_multi_sge() to help us check if the port of an IB device support RDMA Read Multiple Scatter-Gather Entries. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom

Re: [PATCH v5 19/27] IB/Verbs: Use management helper cap_iw_cm()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:40:27AM +0200, Michael Wang wrote: Introduce helper cap_iw_cm() to help us check if the port of an IB device support IWARP Communication Manager. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey t...@talpey.com

Re: [PATCH v5 16/27] IB/Verbs: Use management helper cap_ib_mad()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:39:12AM +0200, Michael Wang wrote: Introduce helper cap_ib_mad() to help us check if the port of an IB device support Infiniband Management Datagrams. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey

Re: [PATCH v5 17/27] IB/Verbs: Use management helper cap_ib_smi()

2015-04-21 Thread ira.weiny
On Mon, Apr 20, 2015 at 10:39:37AM +0200, Michael Wang wrote: Introduce helper cap_ib_smi() to help us check if the port of an IB device support Infiniband Subnet Management Interface. Cc: Hal Rosenstock h...@dev.mellanox.co.il Cc: Steve Wise sw...@opengridcomputing.com Cc: Tom Talpey

Re: [PATCH v2 02/11] IB/addr: Pass network namespace as a parameter

2015-04-21 Thread Haggai Eran
On 20/04/2015 20:09, Jason Gunthorpe wrote: On Mon, Apr 20, 2015 at 12:03:33PM +0300, Haggai Eran wrote: +/** rdma_addr_find_smac_by_sgid() - Find the src MAC and VLAN ID for a src GID + * @sgid: Source GID to find the MAC and VLAN for. + * @smac: A buffer to contain the resulting MAC

RE: [PATCH v5 00/27] IB/Verbs: IB Management Helpers

2015-04-21 Thread Devesh Sharma
Hi Michael, It will be great help if you could base you patches on existing Roland's tree and share to branch details to pull. Just like Chuck lever does for his nfs-rdma patches? -Regards Devesh -Original Message- From: Michael Wang [mailto:yun.w...@profitbricks.com] Sent: