Re: [ANNOUNCE] SRP: ProfitBricks publishes its SRP Initiator patches

2013-05-15 Thread Bart Van Assche
On 05/15/13 07:12, Vasiliy Tolstov wrote: Thanks. What about close session from target side? For example i need to close the srp session and block all access from specific initiator? The traditional approach to block access from a specific initiator is to modify the LUN masking configuration

Re: [ANNOUNCE] SRP: ProfitBricks publishes its SRP Initiator patches

2013-05-14 Thread Bart Van Assche
On 05/14/13 12:00, Vasiliy Tolstov wrote: if i need faster reconnects and ability to close session from initiator side under qlogic hardware, does it possible? Or this patches only covers mallanox cards? The ability to close a session from the initiator side went upstream in kernel 3.8

Re: [ANNOUNCE] SRP: ProfitBricks publishes its SRP Initiator patches

2013-05-06 Thread Bart Van Assche
On 05/06/13 10:44, Sebastian Riemer wrote: Sorry Bart, but a reconnect with just the commit message IB/srp: Add kernel-level transport layer recovery and no further description isn't very trustworthy for me. I also wonder why you need so much locking. Hello Sebastian, There is a very good

Re: [ANNOUNCE] SRP: ProfitBricks publishes its SRP Initiator patches

2013-05-03 Thread Bart Van Assche
On 04/30/13 09:34, Vasiliy Tolstov wrote: What is main difference between bvanassche repo and sriemer ? Good question. As soon as I have the time I will try to find a single approach that works for everyone and post a new patch series for review on the linux-rdma mailing list such that these

Re: linux 3.8.6 and srp backports

2013-04-08 Thread Bart Van Assche
On 04/08/13 10:00, Vasiliy Tolstov wrote: Hello. Some times ago, when i'm use kernel 3.6 i'm use https://github.com/bvanassche/ib_srp-backport/ for srp drivers on my linux server. Now i'm using 3.8.6, does i need something from https://github.com/bvanassche/ib_srp-backport/ or all patches

Re: [PATCH 4/5] tipc: add InfiniBand media type

2013-04-07 Thread Bart Van Assche
On 04/03/13 14:43, Patrick McHardy wrote: diff --git a/net/tipc/bearer.h b/net/tipc/bearer.h +#ifdef CONFIG_TIPC_MEDIA_IB +int tipc_ib_media_start(void); +void tipc_ib_media_stop(void); +#else +int tipc_ib_media_start(void) { return 0; } +void tipc_ib_media_stop(void) { return; } +#endif Is

Re: [PATCH 0/3] Least attached vector support

2013-04-02 Thread Bart Van Assche
Yevgeny Petrilin yevgenyp@... writes: Hello Roland, Those patches where submitted a while ago, I cleaned them up a little and generated against your latest git. They allow to hw driver to choose to which EQ a CQ would be attached, considering the load on its eqs. (replying to an e-mail from

Re: [PATCH] ipoib: fix hard_header return value

2013-03-26 Thread Bart Van Assche
On 03/26/13 17:24, Doug Ledford wrote: If you have a patched up dhcp server (and dhclient), they will use AF_PACKET/SOCK_DGRAM pair to send dhcp packets over IPoIB. This has worked since forever if you use OFED kernels or one of the distribution kernels. However, when testing an upstream

Re: [RFC ib_srp-backport] ib_srp: bind fast IO failing to QP timeout

2013-03-19 Thread Bart Van Assche
On 03/19/13 11:16, Sebastian Riemer wrote: Hi Bart, now I've got my priority on SRP again. I've also noticed that your ib_srp-backport doesn't fail the IO fast enough. The fast_io_fail_tmo only comes into play after the QP is already in timeout and the terminate_rport_io function is missing.

Re: v3.7: Unloading ib_ipoib triggers circular locking dependency complaint

2013-03-12 Thread Bart Van Assche
On 11/26/12 09:00, Or Gerlitz wrote: On Fri, Nov 23, 2012 at 2:10 PM, Bart Van Assche bvanass...@acm.org wrote: Apparently unloading the ib_ipoib kernel module triggers a circular locking dependency complaint. Has anyone already been looking into this ? Yes, I see that this happens here e.g

Re: srptools (Virtual ibnetdiscover command fails)

2013-02-25 Thread Bart Van Assche
On 02/06/13 11:40, Sebastian Riemer wrote: On 06.02.2013 11:20, Or Gerlitz wrote: On 06/02/2013 12:04, Mathis GAVILLON wrote: Just a last question : is that possible VFs lid to be different from PF one ? NO, we've implemented a shared port model, so all functions on the same IB port use the

Re: [PATCH] IB/srp: Fail I/O requests if the transport is offline

2013-02-24 Thread Bart Van Assche
On 02/18/13 09:11, Sagi Grimberg wrote: On 2/18/2013 6:06 AM, David Dillow wrote: On Fri, 2013-02-15 at 10:39 +0100, Bart Van Assche wrote: diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 8a7eb9f..b34752d 100644 --- a/drivers/infiniband/ulp/srp

Re: [PATCH] IB/srp: Fail I/O requests if the transport is offline

2013-02-21 Thread Bart Van Assche
On 02/18/13 05:06, David Dillow wrote: On Fri, 2013-02-15 at 10:39 +0100, Bart Van Assche wrote: diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 8a7eb9f..b34752d 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b/drivers/infiniband/ulp/srp

[PATCH v4 0/4] IB/srp fixes

2013-02-21 Thread Bart Van Assche
This patch series avoids that SCSI error handling triggers an endless loop and also restores reporting of QP errors in the kernel log. Changes between v4 and v3: - Added a patch that ensures that the SCSI host gets removed in time when a user space process keeps queueing I/O during removal,

[PATCH v4 1/4] IB/srp: Track connection state properly

2013-02-21 Thread Bart Van Assche
Remove an assignment that incorrectly overwrites the connection state update by srp_connect_target(). Signed-off-by: Bart Van Assche bvanass...@acm.org Acked-by: David Dillow d...@thedillows.org Cc: Roland Dreier rol...@purestorage.com Cc: sta...@vger.kernel.org # 3.8 --- drivers/infiniband/ulp

[PATCH v4 2/4] IB/srp: Avoid sending a task management function needlessly

2013-02-21 Thread Bart Van Assche
Do not send a task management function if sending will fail anyway because either there is no RDMA/RC connection or the QP is in the error state. Signed-off-by: Bart Van Assche bvanass...@acm.org Acked-by: David Dillow d...@thedillows.org Cc: Roland Dreier rol...@purestorage.com Cc: sta

[PATCH v4 3/4] IB/srp: Avoid endless SCSI error handling loop

2013-02-21 Thread Bart Van Assche
. Modify the SCSI error handling functions in ib_srp as follows: - Abort SCSI commands properly even if the QP is in the error state. - Make srp_reset_host() reset SCSI requests even after host removal has already started or if reconnecting fails. Signed-off-by: Bart Van Assche bvanass...@acm.org

[PATCH v4 4/4] IB/srp: Fail I/O requests if the transport is offline

2013-02-21 Thread Bart Van Assche
of failing requests if (!target-connected || target-qp_in_error) such that the SCSI error handler has a chance to retry commands after a transport layer failure occurred. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: David Dillow d...@thedillows.org Cc: Or Gerlitz ogerl...@mellanox.com Cc

[PATCH] IB/srp: Fail I/O requests if the transport is offline

2013-02-15 Thread Bart Van Assche
of failing requests if (!target-connected || target-qp_in_error) such that the SCSI error handler has a chance to retry commands after a transport layer failure occurred. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: David Dillow d...@thedillows.org Cc: Or Gerlitz ogerl...@mellanox.com Cc

Re: [PATCH] IB/lmx4: silence GCC warning

2013-02-13 Thread Bart Van Assche
On 10/29/12 10:50, Paul Bolle wrote: On Wed, 2012-10-10 at 09:23 +0200, Jack Morgenstein wrote: You could use: u16 uninitialized_var(vlan); instead. I guess we'd better just wait and see whether uninitialized_var() survives before discussing your suggestion (see the thread starting at

Re: [PATCH for 3.8 v3, resend 0/3] IB/SRP patches for kernel 3.8

2013-02-07 Thread Bart Van Assche
On 02/07/13 10:41, Or Gerlitz wrote: (BTW - if the fourth patch that Vu used save restore host_scribble during error handling is also needed, maybe you add it to this series, so they are reviewed/accepted together). Hello Or, The three patches I posted guarantee timely host removal even

Re: [PATCH for 3.8 v3, resend 0/3] IB/SRP patches for kernel 3.8

2013-02-05 Thread Bart Van Assche
On 02/04/13 22:11, Or Gerlitz wrote: On Fri, Feb 1, 2013 at 5:18 PM, Bart Van Assche bvanass...@acm.org wrote: This patch series avoids that SCSI error handling triggers an endless loop and also restores reporting of QP errors in the kernel log. Bart, You wrote resend in the subject line

Re: [PATCH for 3.8 v3, resend 0/3] IB/SRP patches for kernel 3.8

2013-02-05 Thread Bart Van Assche
On 02/05/13 21:54, Or Gerlitz wrote: On Tue, Feb 5, 2013 at 6:25 PM, Bart Van Assche bvanass...@acm.org wrote: On 02/04/13 22:11, Or Gerlitz wrote: Bart, I'd like to sharpen the point: could you please clarify if the series posted to linux-rdma stands for itself in the sense that SRP HA scheme

Re: [PATCH for 3.8 v3, resend 0/3] IB/SRP patches for kernel 3.8

2013-02-05 Thread Bart Van Assche
On 02/06/13 08:44, Or Gerlitz wrote: On 06/02/2013 09:22, Bart Van Assche wrote: A huge number of patches have been taken upstream between 3.8-rc1 and 3.8-rc6. I have retested these three patches with 3.8-rc6 and would appreciate if you would also repeat your tests. not really

Re: [PATCH] opensm/configure.in: Remove Default-Start from opensmd init script

2013-02-04 Thread Bart Van Assche
On 02/04/13 16:36, Alex Netes wrote: On 09:20 Thu 31 Jan , Doug Ledford wrote: On 01/31/13 02:21, Alex Netes wrote: On 14:24 Wed 30 Jan , Doug Ledford wrote: On 1/30/2013 2:12 PM, Bart Van Assche wrote: On 01/30/13 18:48, Doug Ledford wrote: On 1/30/2013 11:00 AM, Bart Van Assche

[LSF/MM TOPIC] Reducing the SRP initiator failover time

2013-02-01 Thread Bart Van Assche
It is known that it takes about two to three minutes before the upstream SRP initiator fails over from a failed path to a working path. This is not only considered longer than acceptable but is also longer than other Linux SCSI initiators (e.g. iSCSI and FC). Progress so far with improving the

[PATCH for 3.8 v3, resend 0/3] IB/SRP patches for kernel 3.8

2013-02-01 Thread Bart Van Assche
This patch series avoids that SCSI error handling triggers an endless loop and also restores reporting of QP errors in the kernel log. Changes between v3 and v2: - As proposed by Dave, added a patch that prevents sending of a task management function over a closed connection. Changes between

[PATCH for 3.8 v3, resend 1/3] IB/srp: Track connection state properly

2013-02-01 Thread Bart Van Assche
Remove an assignment that incorrectly overwrites the connection state update by srp_connect_target(). Signed-off-by: Bart Van Assche bvanass...@acm.org Acked-by: David Dillow d...@thedillows.org Cc: Roland Dreier rol...@purestorage.com --- drivers/infiniband/ulp/srp/ib_srp.c |1 - 1 file

[PATCH for 3.8 v3, resend 2/3] IB/srp: Avoid sending a task management function needlessly

2013-02-01 Thread Bart Van Assche
Do not send a task management function if sending will fail anyway because either there is no RDMA/RC connection or the QP is in the error state. Signed-off-by: Bart Van Assche bvanass...@acm.org Acked-by: David Dillow d...@thedillows.org Cc: Roland Dreier rol...@purestorage.com --- drivers

[PATCH for 3.8 v3, resend 3/3] IB/srp: Avoid endless SCSI error handling loop

2013-02-01 Thread Bart Van Assche
. Modify the SCSI error handling functions in ib_srp as follows: - Abort SCSI commands properly even if the QP is in the error state. - Make srp_reset_host() reset SCSI requests even after host removal has already started or if reconnecting fails. Signed-off-by: Bart Van Assche bvanass...@acm.org

Re: [PATCH] opensm/configure.in: Remove Default-Start from opensmd init script

2013-01-30 Thread Bart Van Assche
On 01/29/13 18:18, Alex Netes wrote: During opensm RPM packaging, `chkconfig --add opensmd` is called. `chkconfig --add` creates the appropriate entry as specified by the default values in the init script. Having opensmd run by default on boot isn't desired. Signed-off-by: Alex Netes

Re: [PATCH] opensm/configure.in: Remove Default-Start from opensmd init script

2013-01-30 Thread Bart Van Assche
On 01/30/13 18:48, Doug Ledford wrote: On 1/30/2013 11:00 AM, Bart Van Assche wrote: Which convention is followed for other packages ? This is what I found in the Fedora 18 iscsi-initiator-utils package (http://be.mirror.eurid.eu/fedora/linux/releases/18/Fedora/source/SRPMS/i/iscsi-initiator

Re: [PATCH] IB/srp: disconnect to SRP target before removing SCSI host

2013-01-11 Thread Bart Van Assche
On 01/11/13 15:07, Dongsu Park wrote: However, that action will hang forever until the target machine comes up again. Precisely it's blocked on scsi_execute() directly after sending SYNCHRONIZE_CACHE command to the first target of the host. As IB stack is not able to give any response, further

Re: [PATCH 1/2] IB/rds: Correct ib_api use with gs_dma_address/sg_dma_len

2012-12-25 Thread Bart Van Assche
On 12/21/12 19:01, Mike Marciniszyn wrote: 0b088e00 (RDS: Use page_remainder_alloc() for recv bufs) added uses of sg_dma_len() and sg_dma_address(). This makes RDS DOA with the qib driver. IB ulps should use ib_sg_dma_len() and ib_sg_dma_address respectively since some HCAs overload

Re: [PATCH v3 1/3] IB/srp: Track connection state properly

2012-12-20 Thread Bart Van Assche
On 12/19/12 19:04, David Dillow wrote: On Wed, 2012-12-19 at 15:21 +0100, Bart Van Assche wrote: The connection state must be initialized before srp_connect_target() is invoked. Drop the assignment in srp_add_target() since it occurs after srp_connect_target() and since scsi_host_alloc() zero

Re: [PATCH v3 0/3] IB/SRP patches for kernel 3.8

2012-12-20 Thread Bart Van Assche
On 12/20/12 13:38, Or Gerlitz wrote: I think few days ago you had a patch on your tree named Save and restore host_scribble during error handling, is it possible we need this here for happy removal of the scsi host? No. Host removal works fine even without that patch. That's because

Re: [PATCH v3 1/3] IB/srp: Track connection state properly

2012-12-20 Thread Bart Van Assche
On 12/20/12 16:10, David Dillow wrote: On Thu, 2012-12-20 at 09:13 +0100, Bart Van Assche wrote: On 12/19/12 19:04, David Dillow wrote: On Wed, 2012-12-19 at 15:21 +0100, Bart Van Assche wrote: The connection state must be initialized before srp_connect_target() is invoked. Drop

[PATCH v4 1/3] IB/srp: Track connection state properly

2012-12-20 Thread Bart Van Assche
Remove an assignment that incorrectly overwrites the connection state update by srp_connect_target(). Signed-off-by: Bart Van Assche bvanass...@acm.org Acked-by: David Dillow d...@thedillows.org Cc: Roland Dreier rol...@purestorage.com --- drivers/infiniband/ulp/srp/ib_srp.c |1 - 1 file

Re: [PATCH v2 2/2] IB/srp: Avoid endless SCSI error handling loop

2012-12-19 Thread Bart Van Assche
On 12/19/12 05:09, David Dillow wrote: Did you update the patch? I think I'm on-board with the idea. Sorry for the delay. I will post the updated patch series. Bart. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org

[PATCH v3 0/3] IB/SRP patches for kernel 3.8

2012-12-19 Thread Bart Van Assche
This patch series avoids that SCSI error handling triggers an endless loop and also restores reporting of QP errors in the kernel log. Changes between v3 and v2: - As proposed by Dave, added a patch that prevents sending of a task management function over a closed connection. Changes between

[PATCH v3 1/3] IB/srp: Track connection state properly

2012-12-19 Thread Bart Van Assche
The connection state must be initialized before srp_connect_target() is invoked. Drop the assignment in srp_add_target() since it occurs after srp_connect_target() and since scsi_host_alloc() zero-initializes the Scsi_Host structure anyway. Signed-off-by: Bart Van Assche bvanass...@acm.org Acked

[PATCH v3 2/3] IB/srp: Avoid sending a task management function needlessly

2012-12-19 Thread Bart Van Assche
Do not send a task management function if sending will fail anyway because either there is no RDMA/RC connection or the QP is in the error state. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: David Dillow d...@thedillows.org Cc: Roland Dreier rol...@purestorage.com --- drivers/infiniband

[PATCH v3 3/3] IB/srp: Avoid endless SCSI error handling loop

2012-12-19 Thread Bart Van Assche
. Modify the SCSI error handling functions in ib_srp as follows: - Abort SCSI commands properly even if the QP is in the error state. - Make srp_reset_host() reset SCSI requests even after host removal has already started or if reconnecting fails. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc

[PATCH v2] IB/SRP patches for kernel 3.8

2012-12-14 Thread Bart Van Assche
Hello Dave, It would be appreciated if you could have a look at the following two patches: * Track connection state properly. Apparently an assignment statement had not been dropped while it should have been dropped. * Avoid endless SCSI error handling loop after cable pull. Thanks, Bart.

[PATCH v2 1/2] IB/srp: Track connection state properly

2012-12-14 Thread Bart Van Assche
The connection state must be initialized before srp_connect_target() is invoked. Drop the assignment in srp_add_target() since scsi_host_alloc() zero-initializes the Scsi_Host structure anyway. This patch makes ib_srp again report the first QP error. Signed-off-by: Bart Van Assche bvanass

[PATCH v2 2/2] IB/srp: Avoid endless SCSI error handling loop

2012-12-14 Thread Bart Van Assche
if the QP is in the error state. - Make srp_reset_host() reset SCSI requests even if host removal has already started or if reconnecting fails. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: David Dillow d...@thedillows.org Cc: Roland Dreier rol...@purestorage.com Reported

Re: [PATCH v2 2/2] IB/srp: Avoid endless SCSI error handling loop

2012-12-14 Thread Bart Van Assche
On 12/14/12 16:55, David Dillow wrote: On Fri, 2012-12-14 at 16:38 +0100, Bart Van Assche wrote: If a SCSI command times out it is passed to the SCSI error handler. The SCSI error handler will try to abort the command that timed out. If aborting failed a device reset will be attempted

Re: [PATCH v2 2/2] IB/srp: Avoid endless SCSI error handling loop

2012-12-14 Thread Bart Van Assche
On 12/14/12 17:19, David Dillow wrote: On Fri, 2012-12-14 at 17:12 +0100, Bart Van Assche wrote: On 12/14/12 16:55, David Dillow wrote: This is much more than your original patch that Alex claimed fixed his issues; are you not merging two separate issues? Also, there's no reason to invoke

Re: [PATCH] [RFC] osm_log printing incorrectly assumes that pthread_t is not opaque type

2012-12-09 Thread Bart Van Assche
On 12/09/12 10:26, Garrett Cooper wrote: +#if defined(__FreeBSD__) +%s %02d %02d:%02d:%02d %06d [%p] 0x%02x - %s, +#else %s %02d %02d:%02d:%02d %06d [%04X] 0x%02x - %s, +#endif Please cast the pthread_t value to an unsigned long long or another integral type. Such

Re: [PATCH 3/3] Avoid linker error with clang 3.0

2012-12-09 Thread Bart Van Assche
On 12/09/12 12:07, Garrett Cooper wrote: It seems that there's a bug when linking inlined functions with clang; this issue will need to be upstreamed and reverified with clang 3.2. Signed-off-by: Garrett Cooper yaneg...@gmail.com --- osmtest/osmtest.c | 2 +- 1 file changed, 1

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-08 Thread Bart Van Assche
On 12/07/12 22:47, Vu Pham wrote: I applied your latest patch [PATCH for-next] IB/srp: Make SCSI error handling finish and test Let me capture what I'm seeing: Host has two paths (scsi_host 7 8) to target thru two physical ports 1 2 [root@rsws42 ~]# multipath -l size=50G features='0'

Re: srp-ha backport

2012-12-06 Thread Bart Van Assche
On 12/06/12 10:52, Vasiliy Tolstov wrote: Now i'm switch from sles kernel to 3.6.7 All works fine , but now you patches from github provide some errors: /sbin/service openibd restart Unloading ib_srp [FAILED] Removing 'ib_srp': Device or resource busy xen11:~

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-06 Thread Bart Van Assche
On 12/05/12 22:32, Or Gerlitz wrote: On Wed, Dec 5, 2012 at 8:50 PM, Bart Van Assche bvanass...@acm.org wrote: [...] The only way to make I/O work reliably if a failure can occur at the transport layer is to use multipathd on top of ib_srp. If a connection fails for some reason, then the SRP

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-06 Thread Bart Van Assche
On 12/06/12 15:27, Or Gerlitz wrote: The core problem here seems to be that scsi_remove_host simply never ends. Hello Or, The later patches in the srp-ha patch series avoided such behavior by checking whether the connection between SRP initiator and target is unique, and by removing

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Bart Van Assche
On 12/05/12 19:23, Or Gerlitz wrote: On Fri, Nov 30, 2012 at 4:21 AM, David Dillow dillo...@ornl.gov wrote: [...] Modulo a few style issues (braces around one line if branches, etc.) and having three state variables vs one, I can live with everything up to aabfa852acd27962 at

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-12-05 Thread Bart Van Assche
On 12/05/12 19:50, Bart Van Assche wrote: On 12/05/12 19:23, Or Gerlitz wrote: On Fri, Nov 30, 2012 at 4:21 AM, David Dillow dillo...@ornl.gov wrote: [...] Modulo a few style issues (braces around one line if branches, etc.) and having three state variables vs one, I can live with everything

Re: [PATCH 00/11] First pass at merging Bart's HA work

2012-11-27 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: Here is a first, UNTESTED, pass at preparing a merge of Bart's SRP HA work to upstream. It is not complete, as I have not yet added the transport layer error handling and related patches. It is also currently missing the patch to maintain a single

Re: [PATCH 03/11] IB/srp: don't send anything on a bad QP

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: Once we know we have an issue with the QP, there is no point trying to send anything else down the pipe. This also allows us to consolidate code in the SCSI EH path. [ ... ] @@ -1683,7 +1681,7 @@ static int srp_send_tsk_mgmt(struct srp_target_port

Re: [PATCH 04/11] IB/srp: keep processing commands during host removal

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: From: Bart Van Assche bvanass...@acm.org Some SCSI upper layer drivers, e.g. sd, issue SCSI commands from inside scsi_remove_host() (see also the sd_shutdown() call in sd_remove()). Make sure that these commands have a chance to reach the SCSI device

Re: [PATCH 02/11] IB/srp: simplify state tracking

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: The state of the target has several conditions that overlap, making it easier to model as a bit-field of exceptional conditions rather than an enum of all possible states. Bart Van Assche did the hard work of identifying the states that can be removed

Re: [PATCH 05/11] IB/srp: destroy and recreate QP and CQs on each connection

2012-11-26 Thread Bart Van Assche
On 11/26/12 05:44, David Dillow wrote: From: Ishai Rabinovitz is...@mellanox.co.il HW QP FATAL errors persist over a reset operation, but we can recover from that by recreating the QP and associated CQs for each connection. Creating a new QP/CQ also completely forecloses any possibility of

Re: srp-ha backport

2012-11-23 Thread Bart Van Assche
On 11/23/12 07:53, Vasiliy Tolstov wrote: Is that possible to backport needed patch to sles11 sp2 (i can't switch kernel now becouse i'm using xen on initiator node and need recompile many different packages for new kernel) In every Linux distribution I know the SCSI core is not a kernel

v3.7: Unloading ib_ipoib triggers circular locking dependency complaint

2012-11-23 Thread Bart Van Assche
Hello, Apparently unloading the ib_ipoib kernel module triggers a circular locking dependency complaint. Has anyone already been looking into this ? Thanks, Bart. == [ INFO: possible circular locking dependency detected ] 3.7.0-rc6-debug+

Re: srp-ha backport

2012-11-23 Thread Bart Van Assche
On 11/23/12 09:07, Vasiliy Tolstov wrote: Is that possible to determine what patches are needed to backport to fix my problem? If you have a look at the output of the command below that will help a lot: git log drivers/scsi/{hosts,scsi,scsi_lib,scsi_sysfs}.c Bart. -- To unsubscribe from

Re: [PATCH 00/20, v4] Make ib_srp better suited for H.A. purposes

2012-11-23 Thread Bart Van Assche
On 09/27/12 02:31, David Dillow wrote: On Tue, 2012-09-25 at 17:05 +0200, Bart Van Assche wrote: On 08/09/12 17:41, Bart Van Assche wrote: [ ... ] Hello Dave, More than six weeks have elapsed since I posted version four of this patch series. It would be appreciated if you could tell me when

Re: srp-ha backport

2012-11-22 Thread Bart Van Assche
. 21.11.2012 22:35 пользователь Bart Van Assche bvanass...@acm.org mailto:bvanass...@acm.org написал: On 11/21/12 18:41, Vasiliy Tolstov wrote: Another test has very bad results: initiator multipath -ll running than storage go to down never returns (deadlock), but other

Re: srp-ha backport

2012-11-21 Thread Bart Van Assche
On 11/21/12 18:41, Vasiliy Tolstov wrote: Another test has very bad results: initiator multipath -ll running than storage go to down never returns (deadlock), but other multipath -ll returns immediate with output (i'm reboot sas01) It could be helpful to have a look at the call stacks

Re: srp-ha backport

2012-11-20 Thread Bart Van Assche
On 11/20/12 05:04, Vasiliy Tolstov wrote: Thanks for this backport! I have some problem under sles 11 sp2 (kernel 3.0.42- 0.7-xen) then i shutdown srp target (reboot one sas server) multipath -ll does not respond. If i provide in multipath and srp identical dev_loss_tmo and fast_io_fail_tmo

Re: [PATCH 00/19, v5] Make ib_srp better suited for H.A. purposes

2012-11-13 Thread Bart Van Assche
On 11/12/12 23:51, Or Gerlitz wrote: Bart Van Assche bvanass...@acm.org wrote: This patch series makes the ib_srp driver better suited for use in a H.A. setup because: - multipathd is notified faster about transport layer failures. - Transport layer failures reliably result in SCSI host

Re: [PATCH 00/19, v5] Make ib_srp better suited for H.A. purposes

2012-11-13 Thread Bart Van Assche
On 11/12/12 23:36, Or Gerlitz wrote: Bart Van Assche bvanass...@acm.org wrote: This patch series makes the ib_srp driver better suited for use in a H.A. setup because: - multipathd is notified faster about transport layer failures. - Transport layer failures reliably result in SCSI host

Re: [PATCH 18/19] ib_srp: Remove SCSI devices upon port down event

2012-11-13 Thread Bart Van Assche
On 11/12/12 23:40, Or Gerlitz wrote: Bart Van Assche bvanass...@acm.org wrote: This patch is a modified version of a patch from Karandeep Chahal that was posted on May 29, 2012 on the linux-rdma mailing list (http://www.mail-archive.com/linux-rdma@vger.kernel.org/msg11796.html) If you want

Re: [PATCH 18/19] ib_srp: Remove SCSI devices upon port down event

2012-11-13 Thread Bart Van Assche
On 11/13/12 21:54, Or Gerlitz wrote: Bart Van Assche bvanass...@acm.org wrote: [ ... ] this gets way too much complicated, and just for patch which you said is not an essential part of this patch series ... can we just drop it altogether from the series? OK. Bart. -- To unsubscribe from

Re: [PATCH 00/19, v5] Make ib_srp better suited for H.A. purposes

2012-11-13 Thread Bart Van Assche
On 11/13/12 22:04, Or Gerlitz wrote: Bart Van Assche bvanass...@acm.org wrote: On 11/12/12 23:36, Or Gerlitz wrote: This patch series reduces path failover time significantly. Instead of having to wait until the SCSI error handler has finished recovery, When a SCSI device is selected

Re: [PATCH 18/19] ib_srp: Remove SCSI devices upon port down event

2012-11-13 Thread Bart Van Assche
On 11/13/12 22:23, Or Gerlitz wrote: On Tue, Nov 13, 2012 at 11:20 PM, Bart Van Assche bvanass...@acm.org wrote: On 11/13/12 21:54, Or Gerlitz wrote: Bart Van Assche bvanass...@acm.org wrote: [ ... ] this gets way too much complicated, and just for patch which you said is not an essential

Re: [PATCH 00/19, v5] Make ib_srp better suited for H.A. purposes

2012-11-13 Thread Bart Van Assche
On 11/13/12 22:41, Or Gerlitz wrote: On Tue, Nov 13, 2012 at 11:30 PM, Bart Van Assche bvanass...@acm.org wrote: These attributes have been added to the SRP transport layer. Since the ib_srp driver registers itself with the SRP transport layer the SRP transport layer creates these two

[PATCH 00/19, v5] Make ib_srp better suited for H.A. purposes

2012-10-26 Thread Bart Van Assche
This patch series makes the ib_srp driver better suited for use in a H.A. setup because: - multipathd is notified faster about transport layer failures. - Transport layer failures reliably result in SCSI host removal. - Switchover can be triggered explicitly by deleting an initiator device. -

[PATCH 01/19] ib_srp: Enlarge block layer timeout

2012-10-26 Thread Bart Van Assche
Enlarge the block layer timeout for disks such that it is above the InfiniBand transport layer timeout. Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/infiniband/ulp/srp/ib_srp.c | 45

[PATCH 02/19] ib_srp: Eliminate state SRP_TARGET_CONNECTING

2012-10-26 Thread Bart Van Assche
Block the SCSI host while reconnecting instead of representing the reconnection activity as a distinct SRP target state. This allows to eliminate the target state SRP_TARGET_CONNECTING. Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche

[PATCH 03/19] ib_srp: Introduce srp_handle_qp_err()

2012-10-26 Thread Bart Van Assche
Introduce the function srp_handle_qp_err(), change the type of qp_in_error from int into bool and move the initialization of that variable from srp_reconnect_target() to srp_connect_target(). Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van

[PATCH 04/19] ib_srp: Suppress superfluous error messages

2012-10-26 Thread Bart Van Assche
...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/infiniband/ulp/srp/ib_srp.c | 43 +++ drivers/infiniband/ulp/srp/ib_srp.h |1 + 2 files changed, 35 insertions(+), 9 deletions(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c

[PATCH 05/19] ib_srp: Avoid that SCSI error handling causes trouble

2012-10-26 Thread Bart Van Assche
that it did not expect. This can result in a kernel oops. Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/infiniband/ulp/srp/ib_srp.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH 06/19] ib_srp: Introduce the helper function srp_remove_target()

2012-10-26 Thread Bart Van Assche
Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/infiniband/ulp/srp/ib_srp.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b

[PATCH 07/19] ib_srp: Eliminate state SRP_TARGET_DEAD

2012-10-26 Thread Bart Van Assche
: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/infiniband/ulp/srp/ib_srp.c | 86 +-- drivers/infiniband/ulp/srp/ib_srp.h |5 +- 2 files changed, 33 insertions(+), 58 deletions

[PATCH 08/19] ib_srp: Keep processing commands during host removal

2012-10-26 Thread Bart Van Assche
-by: Bart Van Assche bvanass...@acm.org --- drivers/infiniband/ulp/srp/ib_srp.c |6 -- 1 file changed, 6 deletions(-) diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c index 23612c1..8ae2070 100644 --- a/drivers/infiniband/ulp/srp/ib_srp.c +++ b

[PATCH 09/19] ib_srp: Make srp_disconnect_target() wait for IB completions

2012-10-26 Thread Bart Van Assche
Modify srp_disconnect_target() such that it waits until it is sure that no new IB completions will be received anymore. Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/infiniband/ulp/srp/ib_srp.c | 104

[PATCH 10/19] ib_srp: Document sysfs attributes

2012-10-26 Thread Bart Van Assche
Document the sysfs attributes of the SRP initiator (ib_srp) according to the rules specified in Documentation/ABI/README. Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- Documentation/ABI/stable/sysfs-driver-ib_srp

[PATCH 11/19] srp_transport: Fix attribute registration

2012-10-26 Thread Bart Van Assche
array will see all values written into that array. Cc: FUJITA Tomonori fujita.tomon...@lab.ntt.co.jp Cc: Robert Jennings r...@linux.vnet.ibm.com Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/scsi

[PATCH 12/19] srp_transport: Simplify attribute initialization code

2012-10-26 Thread Bart Van Assche
adding new attributes. Cc: FUJITA Tomonori fujita.tomon...@lab.ntt.co.jp Cc: Robert Jennings r...@linux.vnet.ibm.com Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/scsi/scsi_transport_srp.c | 26

[PATCH 13/19] srp_transport: Document sysfs attributes

2012-10-26 Thread Bart Van Assche
Cc: FUJITA Tomonori fujita.tomon...@lab.ntt.co.jp Cc: Robert Jennings r...@linux.vnet.ibm.com Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- Documentation/ABI/stable/sysfs-transport-srp | 12 1 file

[PATCH 15/19] ib_srp: Maintain a single connection per I_T nexus

2012-10-26 Thread Bart Van Assche
, remove the target port. Add a target to the target list before connecting instead of after such that this algorithm has a chance to work. Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/infiniband/ulp/srp

[PATCH 14/19] ib_srp: Allow SRP disconnect through sysfs

2012-10-26 Thread Bart Van Assche
...@purestorage.com Cc: FUJITA Tomonori fujita.tomon...@lab.ntt.co.jp Cc: Robert Jennings r...@linux.vnet.ibm.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- Documentation/ABI/stable/sysfs-transport-srp |7 +++ drivers/infiniband/ulp/srp/ib_srp.c | 10 ++ drivers/scsi

[PATCH 16/19] srp_transport: Add transport layer error handling

2012-10-26 Thread Bart Van Assche
Van Assche bvanass...@acm.org --- Documentation/ABI/stable/sysfs-transport-srp | 17 +++ drivers/scsi/scsi_transport_srp.c| 192 +- include/scsi/scsi_transport_srp.h| 10 +- 3 files changed, 216 insertions(+), 3 deletions(-) diff --git

[PATCH 17/19] ib_srp: Add dev_loss_tmo support

2012-10-26 Thread Bart Van Assche
Remove an SRP host if dev_loss_tmo expired. Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/infiniband/ulp/srp/ib_srp.c | 30 +- drivers/infiniband/ulp/srp/ib_srp.h |2

[PATCH 19/19] scsi_transport_srp: Fail I/O faster

2012-10-26 Thread Bart Van Assche
Start the transport layer failure timer if a SCSI timeout occurs. Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier rol...@purestorage.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- drivers/scsi/scsi_transport_srp.c | 95 ++--- include/scsi

[PATCH 3/4 v2 for opensm] /etc/init.d/opensmd: Improve systemd integration

2012-10-25 Thread Bart Van Assche
: Doug Ledford dledf...@redhat.com Signed-off-by: Bart Van Assche bvanass...@acm.org --- v2: replaced [ -e $pidfile ] test in start() by [ -e $pidfile ] [ $(readlink /proc/$($pidfile)/exe) = @sbindir@/opensm ] configure.in |6 ++ scripts/opensm.init.in| 31

Re: [PATCH 2/4 for opensm] Make it possible to enable opensm with chkconfig

2012-10-24 Thread Bart Van Assche
On 10/24/12 15:19, Alex Netes wrote: Hi Bart, On 16:43 Fri 21 Sep , Bart Van Assche wrote: chkconfig $service on enables a service in the runlevels mentioned next to Default-Start and only in those runlevels. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Doug Ledford dledf

Re: [PATCH 3/4 for opensm] /etc/init.d/opensmd: Improve systemd integration

2012-10-24 Thread Bart Van Assche
On 10/24/12 15:27, Alex Netes wrote: On 16:44 Fri 21 Sep , Bart Van Assche wrote: +default_rdma_service=openibd +AC_ARG_WITH([rdma_service], +AC_HELP_STRING([--with-rdma-service=name], + [name of the RDMA service: rdma when using /etc/init.d/rdma to start RDMA

Re: [PATCH 3/4 for opensm] /etc/init.d/opensmd: Improve systemd integration

2012-10-24 Thread Bart Van Assche
On 10/24/12 16:33, Doug Ledford wrote: On 10/24/2012 9:27 AM, Alex Netes wrote: On 16:44 Fri 21 Sep , Bart Van Assche wrote: start () { +if [ -e $pidfile ]; then On opensm segfault (happens one in a while :), pidfile won't be removed, so you won't be able to start the opensm again

Re: [PATCH] prevent CVE-2012-2372 rds-ping causes kernel panic

2012-10-22 Thread Bart Van Assche
On 10/22/12 20:12, Jay Fenlason wrote: If you use rds-ping of the local IP address of some Infiniband HCAs (QLogic, possibly others) the machine will panic with a BUG_ON due to an overly restrictive check. Loosen the restriction a bit This should have gotten sent a while ago (it was first

Re: [PATCH 00/20, v4] Make ib_srp better suited for H.A. purposes

2012-09-25 Thread Bart Van Assche
On 08/09/12 17:41, Bart Van Assche wrote: [ ... ] Hello Dave, More than six weeks have elapsed since I posted version four of this patch series. It would be appreciated if you could tell me when review comments for this patch series will be posted. I'd also like to remind you that some

<    2   3   4   5   6   7   8   9   10   11   >