Re: [PATCH v2] staging/rdma/hfi1: check for ARMED->ACTIVE transition in receive interrupt

On Mon, Jan 04, 2016 at 11:21:19AM -0500, Jubin John wrote: > From: Jim Snow > > } else { > + /* Auto activate link on non-SC15 packet receive */ > + if (unlikely(rcd->ppd->host_link_state == > +

Re: [PATCH TRIVIAL] IB/core: ib_mad.h ib_mad_snoop_handler documentation fix

On Mon, Jan 04, 2016 at 11:04:53AM -0500, Hal Rosenstock wrote: > ib_mad_snoop_handler ues send_buf rather than send_wr ues --> uses -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 3/6] IB/uapi: expose uverbs WC opcodes

On Wed, Dec 30, 2015 at 10:44:29AM +0100, Christoph Hellwig wrote: > On Tue, Dec 29, 2015 at 01:02:54PM +0200, Sagi Grimberg wrote: > >> As you did it in the first patch, just don't assign after IB_WC_LOCAL_INV. > >> Compiler will handle IB_UVERS_WC_SEND_END + X calculations by itself. > > > > I

Re: [PATCH v1 ib-next 0/3] IB core uverbs support for leagacy commands

On Tue, Nov 10, 2015 at 08:00:07PM +0200, Eli Cohen wrote: > Hi Doug, > > this patcheset is addresses comments from the community. Specifically if the > verbs is not supported by a hardware driver, we return -EOPNOTSUPP. > > Eli > > Eli Cohen (3): > IB/core: Avoid duplicate code > IB/core:

Re: git://git.kernel.org/pub/scm/linux/kernel/git/dledford/rdma.git/k.o/for-4.5 crash during boot

On Wed, Dec 30, 2015 at 02:22:23PM +0200, Or Gerlitz wrote: > On 12/30/2015 2:04 PM, Bart Van Assche wrote: > >Hello Christoph, > > > >Can you check whether the branch in the subject of this e-mail works fine > >on your setup (commit 59caaed7a7) ? On my test setup (Dell R430 with two > >ConnectX-3

Re: [PATCH] IB/core: Remove a set-but-not-used variable from ib_sg_to_pages()

On Tue, Dec 29, 2015 at 10:45:03AM +0100, Bart Van Assche wrote: > Detected this by building the IB core with W=1. See also patch > "IB core: Fix ib_sg_to_pages()" (commit 8f5ba10ed40a). Reviewed-by: Leon Romanovsky <leon.romanov...@mellanox.com> > > Signed-off-by:

[PATCH V2] IB/mlx5: Unify CQ create flags check

From: Leon Romanovsky <leo...@mellanox.com> The create_cq() can receive creation flags which were used differently by two commits which added create_cq extended command and cross-channel. The merged code caused to not accept any flags at all. This patch unifies the check into one fu

Re: [PATCH V2] IB/mlx5: Unify CQ create flags check

On Tue, Dec 29, 2015 at 04:03:41PM +0200, Leon Romanovsky wrote: > On Tue, Dec 29, 2015 at 03:51:47PM +0200, Sagi Grimberg wrote: > > >From: Leon Romanovsky <leo...@mellanox.com> > > > > > >The create_cq() can receive creation flags which were used > >

[PATCH] IB/mlx5: Unify CQ create flags check

From: Leon Romanovsky <leo...@mellanox.com> The create_cq() can receive creation flags which were used differently by two following commits [1] and [2]. This patch unifies the check into one function and one return error code. [1] commit 972ecb821379 ("IB/mlx5: Add create_cq exten

[PATCH V2] IB/mlx5: Unify CQ create flags check

From: Leon Romanovsky <leo...@mellanox.com> The create_cq() can receive creation flags which were used differently by two following commits [1] and [2]. The current code caused to not accept any flags at all. This patch unifies the check into one function and one return error code.

[PATCH V3] IB/mlx5: Unify CQ create flags check

From: Leon Romanovsky <leo...@mellanox.com> The create_cq() can receive creation flags which were used differently by two commits which added create_cq extended command and cross-channel. The merged code caused to not accept any flags at all. This patch unifies the check into one fu

Re: [PATCH V2] IB/mlx5: Unify CQ create flags check

On Tue, Dec 29, 2015 at 03:51:47PM +0200, Sagi Grimberg wrote: > >From: Leon Romanovsky <leo...@mellanox.com> > > > >The create_cq() can receive creation flags which were used > >differently by two following commits [1] and [2]. The current > >code caused to

Re: [PATCH v2 01/36] IB/rdmavt: Create module framework and handle driver registration

On Mon, Dec 28, 2015 at 12:59:45PM -0800, Dennis Dalessandro wrote: > This patch introduces the basics for a new module called rdma_vt. This new > driver is a software implementation of the InfiniBand verbs and aims to > replace the multiple implementations that exist and duplicate each others' >

Re: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations

On Sun, Dec 27, 2015 at 01:36:30PM +0100, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sun, 27 Dec 2015 13:12:10 +0100 > Subject: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function > implementations Just a note for the future submissions (no need

Re: [PATCH 0/2] InfiniBand-iSER: Refactoring for two function implementations

return directly instead of using the jump label "err" > in two functions (which are working without clean-up there). > > Markus Elfring (2): > One jump label less in iser_reg_sig_mr() > One jump label less in isert_reg_sig_mr() Looks good, Reviewed-by: Leon Romanovsky <leo

Re: [PATCH 1/6] IB/uapi: expose uverbs WR opcodes

On Thu, Dec 24, 2015 at 03:39:22PM +0100, Christoph Hellwig wrote: > #define MLX5_IB_SEND_UMR_UPDATE_MTT (IB_SEND_RESERVED_START << 2) > #define MLX5_IB_QPT_REG_UMR IB_QPT_RESERVED1 > -#define MLX5_IB_WR_UMR IB_WR_RESERVED1 > +#define MLX5_IB_WR_UMR (IB_WR_END +

Re: [PATCH 3/6] IB/uapi: expose uverbs WC opcodes

On Thu, Dec 24, 2015 at 03:39:24PM +0100, Christoph Hellwig wrote: > This exposes the WC opcodes supported by uverbs as part of the uapi > headers. It follows the same scheme as the WR opcodes. > > Signed-off-by: Christoph Hellwig > --- > include/rdma/ib_verbs.h | 29

Re: [PATCH 4/6] IB/uapi: expose uverbs WC flags

On Thu, Dec 24, 2015 at 03:39:25PM +0100, Christoph Hellwig wrote: > This exposes the WC flags supported by uverbs as part of the uapi > headers. It follows the same scheme as the WR opcodes. > > Signed-off-by: Christoph Hellwig > --- > include/rdma/ib_verbs.h | 14

Re: [PATCH 5/6] IB/uapi: expose uverbs WC status codes

On Thu, Dec 24, 2015 at 03:39:26PM +0100, Christoph Hellwig wrote: > This exposes the WC status codes supported by uverbs as part of the uapi > headers. It follows the same scheme as the WR opcodes. > > Signed-off-by: Christoph Hellwig > --- > include/rdma/ib_verbs.h | 44 >

Re: [PATCH rdma-next V2 01/32] IB/core: Macro for RoCEv2 UDP port

On Thu, Dec 24, 2015 at 11:17:47AM +0200, Kamal Heib wrote: > From: Amir Vadai > > Adding a macro for RoCEv2 UDP destination port. You are adding define and not macro. > > Signed-off-by: Amir Vadai > Signed-off-by: Kamal Heib > ---

[PATCH V2 0/2] Add cross-channel support

From: Leon Romanovsky <leo...@mellanox.com> The following set of patches implements cross-channel (CC) support in the RDMA core and in the mlx5 infiniband driver. The cross-channel feature allows to execute WQEs that involve cross-channel synchronization of IO operations’ on differe

[PATCH V2 2/2] IB/mlx5: Add driver cross-channel support

From: Leon Romanovsky <leo...@mellanox.com> Add support of cross-channel functionality to mlx5 driver. This includes ability to ignore overrun for CQ which intended for cross-channel, export device capability and configure the QP to be sync master/slave queues. The cross-channel enab

[PATCH V2 1/2] IB/core: Add cross-channel support

From: Leon Romanovsky <leo...@mellanox.com> The cross-channel feature allows to execute WQEs that involve synchronization of IO operations’ on different QPs. This capability enables to program complex flows with a single function call, hereby significantly reducing overhead associated w

Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

On Wed, Dec 23, 2015 at 12:00:41PM +0200, Or Gerlitz wrote: > On 12/21/2015 9:53 AM, Leon Romanovsky wrote: > >On Mon, Dec 21, 2015 at 9:40 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: > >>On Mon, Dec 21, 2015 at 9:27 AM, Leon Romanovsky <l...@leon.nu> wrote: > &

Re: [PATCH for-next V3 01/11] IB/core: Add gid_type to gid attribute

On Wed, Dec 23, 2015 at 02:56:47PM +0200, Matan Barak wrote: > In order to support multiple GID types, we need to store the gid_type > with each GID. This is also aligned with the RoCE v2 annex "RoCEv2 PORT > GID table entries shall have a "GID type" attribute that denotes the L3 > Address type".

Re: [PATCH 1/2] Isolate common list remove code

On Mon, Dec 21, 2015 at 08:42:53AM -0600, Christoph Lameter wrote: > Code cleanup to remove multicast specific code from ipoib_main.c > > The removal of a list of multicast groups occurs in three places. > Create a new function ipoib_mcast_remove_list(). Use this new > function in ipoib_main.c

Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

On Mon, Dec 21, 2015 at 8:22 AM, ira.weiny <ira.we...@intel.com> wrote: > On Sun, Dec 20, 2015 at 12:16:09PM +0200, Leon Romanovsky wrote: >> From: Leon Romanovsky <leo...@mellanox.com> >> >> Modify enum ib_device_cap_flags such that other patches which a

[PATCH V1] libmlx5: Add gitignore file to the project

From: Leon Romanovsky <leo...@mellanox.com> Add gitignore file to the libmlx5 project. Changes from v0: * Add temporary files created by etags/ctags/gtags/cscope. * Add Reviewed-by signature Reviewed-by: Sagi Grimberg <sa...@mellanox.com> Signed-off-by: Leon Romanovsky <leo.

[PATCH libibverbs 2/3] libibverbs: Add cross-channel QP initialization flags

From: Leon Romanovsky <leo...@mellanox.com> The cross-channel feature allows to execute WQEs that involve synchronization of I/O operations' on different QPs. These QPs should be configured to work as a "sync master queue" or “sync slave queues”. The QP property flags to in

[PATCH libibverbs 3/3] libibverbs: Export cross-channel capability flag

From: Leon Romanovsky <leo...@mellanox.com> The device implements capability to execute complex I/O operations across multiple I/O channels - synchronize execution of I/O operations on one I/O channel with execution of I/O operations on another channel(s). Cross-channel operations s

[PATCH libmlx5 0/2] Add cross-channel support

From: Leon Romanovsky <leo...@mellanox.com> This patchset adds libmlx5 part of cross-channel support. These patches were added on top of "Completion timestamping" [2]. [1] http://thread.gmane.org/gmane.linux.drivers.rdma/31715 [2] http://www.spinics.net/lists/linux-rdma/msg

[PATCH libmlx5 2/2] libmlx5: Add CQ ignore overrun creation flag

From: Leon Romanovsky <leo...@mellanox.com> In order to use CQ for cross-channel operations, the user needs to configure CQ to ignore overrun creation flag. This patch adds support of it to libmlx5 library. Signed-off-by: Leon Romanovsky <leo...@mellanox.com> --- src/mlx

[PATCH libibverbs 0/3] Add cross-channel support

From: Leon Romanovsky <leo...@mellanox.com> This patchset adds supplementary part of cross-channel support [1] to libibverbs. These patches were added on top of "Completion timestamping" [2] and "Expose QP block self multicast loopback creation flag" [3] series. [

[PATCH libmlx5 1/2] libmlx5: Add cross-channel primitives

From: Leon Romanovsky <leo...@mellanox.com> The cross-channel feature relies on special primitives to send and receive work requests. * WAIT on CQ WR - This WR holds execution of subsequent requests on that queue until producer index of a CQ is met. • SEND_EN WR - This WR specifies

[PATCH V1 2/3] IB/core: Add cross-channel support

From: Leon Romanovsky <leo...@mellanox.com> The cross-channel feature allows to execute WQEs that involve synchronization of I/O operations’ on different QPs. This capability enables to program complex flows with a single function call, hereby significantly reducing overhead associated wi

[PATCH V1 0/3] Add cross-channel support

From: Leon Romanovsky <leo...@mellanox.com> This patchset adds cross-channel support. The cross-channel feature allows to execute WQEs that involve synchronization of I/O operations’ on different QPs. This capability enables to program complex flows with a single function call,

[PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

From: Leon Romanovsky <leo...@mellanox.com> Modify enum ib_device_cap_flags such that other patches which add new enum values pass strict checkpatch.pl checks. Reviewed-by: Sagi Grimberg <sa...@mellanox.com> Signed-off-by: Leon Romanovsky <leo...@mellanox.com> --- include/rd

[PATCH V1 3/3] IB/mlx5: Add driver cross-channel support

From: Leon Romanovsky <leo...@mellanox.com> Add support of cross-channel functionality to mlx5 driver. This includes ability to ignore overrun for CQ which intended for cross-channel, export device capability and configure the QP to be sync master/slave queues. The cross-channel enab

[PATCH libibverbs 1/3] libibverbs: Add CQ ignore overrun creation flag

From: Leon Romanovsky <leo...@mellanox.com> A CQ overrun is checked while posting a completion, and if encountered, the QP is transferred to the appropriate error state. CQ update (and error discovery) are not synchronized with WQE execution. Thus, a positive acknowledgement can b

Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

On Mon, Dec 21, 2015 at 8:52 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Mon, Dec 21, 2015 at 8:37 AM, Leon Romanovsky <l...@leon.nu> wrote: >> On Mon, Dec 21, 2015 at 8:22 AM, ira.weiny <ira.we...@intel.com> wrote: >>> On Sun, Dec 20, 2015 at 12:

Re: [PATCH V1 1/3] IB/core: Align coding style of ib_device_cap_flags structure

On Mon, Dec 21, 2015 at 9:40 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: > On Mon, Dec 21, 2015 at 9:27 AM, Leon Romanovsky <l...@leon.nu> wrote: >> On Mon, Dec 21, 2015 at 8:52 AM, Or Gerlitz <gerlitz...@gmail.com> wrote: >>> On Mon, Dec 21, 2015 at 8:37 AM,

[PATCH] libmlx5: Add gitignore file to the project

From: Leon Romanovsky <leo...@mellanox.com> Add gitignore file to the libmlx5 project. Signed-off-by: Leon Romanovsky <leo...@mellanox.com> --- .gitignore | 20 1 file changed, 20 insertions(+) create mode 100644 .gitignore diff --git a/.gitignore b/.gitign

Re: [PATCH 3/3] bject: IB Core: Display extended counter set if available

There are number of minor issues: Subject: Re: [PATCH 3/3] bject: IB Core: Display extended counter set if ^^^ On Thu, Dec 17, 2015 at 01:52:58PM -0600, Christoph Lameter wrote: > - in_mad->data[41] = port_num;/* PortSelect field */ > + if (port_num) > +

[PATCH 2/2] IB/mlx4: Convert kmalloc to be kmalloc_array to fix checkpatch warnings

From: Leon Romanovsky <leo...@mellanox.com> Convert kmalloc to be kmalloc_array to fix warnings below: WARNING: Prefer kmalloc_array over kmalloc with multiply + qp->sq.wrid = kmalloc(qp->sq.wqe_cnt * sizeof(u64), WARNING: Prefer kmalloc_array over kmalloc w

[PATCH 1/2] IB/mlx4: Suppress memory allocations warnings in kmalloc->__vmalloc flows

From: Leon Romanovsky <leo...@mellanox.com> Failure in kmalloc memory allocations will throw a warning about it. Such warnings are not needed anymore, since in commit 0ef2f05c7e02 ("IB/mlx4: Use vmalloc for WR buffers when needed"), fallback mechanism from kmalloc() to __vma

[PATCH 2/3] IB/core: Add cross-channel support

From: Leon Romanovsky <leo...@mellanox.com> The cross-channel feature allows to execute WQEs that involve synchronization of I/O operations’ on different QPs. This capability enables to program complex flows with a single function call, hereby significantly reducing overhead associated wi

[PATCH 0/3] Add cross-channel support

From: Leon Romanovsky <leo...@mellanox.com> This patchset adds cross-channel support. The cross-channel feature allows to execute WQEs that involve synchronization of I/O operations’ on different QPs. This capability enables to program complex flows with a single function call,

[PATCH 3/3] IB/mlx5: Add driver cross-channel support

From: Leon Romanovsky <leo...@mellanox.com> Add support of cross-channel functionality to mlx5 driver. This includes ability to ignore overrun for CQ which intended for cross-channel, export device capability and configure the QP to be sync master/slave queues. The cross-channel enab

[PATCH 1/3] IB/core: Align coding style of ib_device_cap_flags structure

From: Leon Romanovsky <leo...@mellanox.com> Modify enum ib_device_cap_flags such that other patches which add new enum values pass strict checkpatch.pl checks. Reviewed-by: Sagi Grimberg <sa...@mellanox.com> Signed-off-by: Leon Romanovsky <leo...@mellanox.com> --- include/rd

Re: [PATCH] IB/usnic: Handle 0 counts in resource allocation

> Thanks for looking at the code. I am still not understanding your point. >> Old code: >> usnic_vnic_res_free_cnt(vnic, type) == 0 and cnt == 1 will return EINVAL > Yes: > if (0 < 1 || 1 < 1 || !owner) > return -EINVAL; >> New code >> snic_vnic_res_free_cnt(vnic, type) ==

Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

On Thu, Dec 10, 2015 at 11:40:48AM -0500, Dennis Dalessandro wrote: > On Tue, Dec 08, 2015 at 08:28:17AM +0200, Leon Romanovsky wrote: > >On Mon, Dec 07, 2015 at 03:43:10PM -0500, Dennis Dalessandro wrote: > >>+ > >>+/* > >>+ * Things that are driver specifi

Re: [PATCH 02/37] IB/rdmavt: Consolidate dma ops in rdmavt.

On Thu, Dec 10, 2015 at 11:17:09AM -0500, Dennis Dalessandro wrote: > On Tue, Dec 08, 2015 at 08:08:21AM +0200, Leon Romanovsky wrote: > >On Mon, Dec 07, 2015 at 03:43:06PM -0500, Dennis Dalessandro wrote: > >>+ > >>+#define BAD_DMA_ADDRESS ((u64)0) > >What is th

Re: Ping: [PATCH 1/1] Fix deadlock when running run_iter_bw_infinitely

leted[0] = get_cycles(); > - print_report_bw(duration_param,NULL); > - duration_param->iters = 0; > - alarm(duration_param->duration); > - duration_param->tposted[0] = get_cycles(); > + trig_print_report_bw = 1; > } Thanks, it looks good, Reviewed-by: L

Re: Ping: [PATCH 1/1] Fix deadlock when running run_iter_bw_infinitely

On Wed, Dec 09, 2015 at 09:33:11AM +0100, Hans Westgaard Ry wrote: > Any comments on this patch ? > > > > On 11/18/2015 01:27 PM, Hans Westgaard Ry wrote: > >The test uses a signal-handler to periodically print a line of report. > >+if (trig_print_report_bw) { > >+

Re: [PATCH] IB/usnic: Handle 0 counts in resource allocation

On Wed, Dec 09, 2015 at 10:42:19AM -0800, Nelson Escobar wrote: > - if (usnic_vnic_res_free_cnt(vnic, type) < cnt || cnt < 1 || !owner) > + if (usnic_vnic_res_free_cnt(vnic, type) < cnt || cnt < 0 || !owner) Before this change you returned EINVAL if no free_cnt were available, now you will

Re: [PATCH 07/37] IB/rdmavt: Add query and modify port stubs

On Mon, Dec 07, 2015 at 03:43:28PM -0500, Dennis Dalessandro wrote: > +/** > + * rvt_query_port: Passes the query port call to the driver > + * ibdev: Verbs IB dev > + * port: port number > + * props: structure to hold returned properties > + * > + * Returns 0 on success > + */ ... > +/** > + *

Re: [PATCH 02/37] IB/rdmavt: Consolidate dma ops in rdmavt.

On Mon, Dec 07, 2015 at 03:43:06PM -0500, Dennis Dalessandro wrote: > + > +#define BAD_DMA_ADDRESS ((u64)0) What is the advantage in using directly u64 values instead of pointers? You will get NULL and functions which return pointers without need of casting. ... > +static u64

Re: [PATCH 01/37] IB/rdmavt: Create module framework and handle driver registration

On Mon, Dec 07, 2015 at 03:43:02PM -0500, Dennis Dalessandro wrote: > +#include > +#include > +#include "vt.h" > + > +#define RDMAVT_DRIVER_VERSION "0.1" Do we really need driver version? > + > +MODULE_LICENSE("Dual BSD/GPL"); > +MODULE_DESCRIPTION("RDMA Verbs Transport Library"); >

Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

On Mon, Dec 07, 2015 at 03:43:10PM -0500, Dennis Dalessandro wrote: > + > +/* > + * Things that are driver specific, module parameters in hfi1 and qib > + */ > +struct rvt_driver_params { > + int max_pds; Can it be negative value? > +}; -- To unsubscribe from this list: send the line

Re: [PATCH 03/37] IB/rdmavt: Add protection domain to rdmavt.

On Tue, Dec 08, 2015 at 08:28:17AM +0200, Leon Romanovsky wrote: > On Mon, Dec 07, 2015 at 03:43:10PM -0500, Dennis Dalessandro wrote: > > + > > +/* > > + * Things that are driver specific, module parameters in hfi1 and qib > > + */ > > +struct rvt_driver_pa

Re: [PATCH 06/37] IB/rdmavt: Add query and modify device stubs

On Mon, Dec 07, 2015 at 02:39:04PM -0700, Jason Gunthorpe wrote: > On Mon, Dec 07, 2015 at 09:26:11PM +, Hefty, Sean wrote: > > > +static int rvt_query_device(struct ib_device *ibdev, > > > + struct ib_device_attr *props, > > > + struct ib_udata *uhw) >

Re: [PATCH] IB/mlx4: use list_for_each_entry_safe in search_relocate_mgid0_group

group, mgid0_list); > + list_for_each_entry_safe(group, n, >mcg_mgid0_list, mgid0_list) { > mutex_lock(>lock); > if (group->last_req_tid == tid) { > if (memcmp(new_mgid, , sizeof mgid0)) { Thanks, Reviewed-by: Leon Romanovsky <leo

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

On Wed, Nov 11, 2015 at 08:39:08AM -0500, Dennis Dalessandro wrote: > On Wed, Nov 11, 2015 at 08:25:35AM +0200, Leon Romanovsky wrote: > >On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote: > >>From: Dennis Dalessandro <dennis.dalessan...@int

Re: [PATCH] staging/rdma/hfi1: Reduce number of parameters passed to send handlers

On Wed, Nov 11, 2015 at 12:34:37AM -0500, ira.we...@intel.com wrote: > From: Dennis Dalessandro > > +int snoop_send_dma_handler(struct hfi1_qp *qp, struct hfi1_pkt_state *ps, > +u64 pbc) > { > - pr_alert("Snooping/Capture of Send DMA

Re: [PATCH for-next 3/4] IB/mlx5: Add support querying timestamp related fields in query_device

On Mon, Nov 09, 2015 at 06:30:56PM +0200, Matan Barak wrote: > + > + if (uhw->outlen) { > + err = ib_copy_to_udata(uhw, , resp.response_length); > + if (err) > + return err; > + } > + > return 0; What do you think about to rewrite this part

Re: [PATCH for-next 2/4] IB/core: Add ib_is_udata_cleared

On Mon, Nov 09, 2015 at 06:30:55PM +0200, Matan Barak wrote: > > +static inline bool ib_is_udata_cleared(struct ib_udata *udata, > +char cleared_char, > +size_t offset, > +size_t len) > +{

Re: [PATCH 1/1] staging: rdma: hfi1 : Prefer using the BIT macro

On Thu, Nov 05, 2015 at 05:28:03PM +0530, Sunny Kumar wrote: > This patch replaces bit shifting on 1 with the BIT(x) macro > > Signed-off-by: Sunny Kumar > --- > drivers/staging/rdma/hfi1/user_sdma.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > /*

Re: [PATCH] IB/mlx5: Postpone remove_keys under knowledge of coming preemption

On Wed, Oct 21, 2015 at 9:21 AM, Leon Romanovsky <l...@leon.nu> wrote: > From: Leon Romanovsky <leo...@mellanox.com> > > The remove_keys() logic is performed as garbage collection task. Such > task is intended to be run when no other active processes are running. > >

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Tue, Oct 27, 2015 at 11:19 AM, Dan Carpenter <dan.carpen...@oracle.com> wrote: > On Sun, Oct 25, 2015 at 01:21:11PM +0200, Leon Romanovsky wrote: >> On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani >> <falakre...@gmail.com> wrote: >> Please

Re: [PATCH libibverbs] Expose QP block self multicast loopback creation flag

On Tue, Oct 27, 2015 at 02:53:01PM +0200, Eran Ben Elisha wrote: ... > +enum ibv_qp_create_flags { > + IBV_QP_CREATE_BLOCK_SELF_MCAST_LB = 1 << 1, > }; > I'm sure that I'm missing something important, but why did it start from shift 1 and not shift 0? > -- > To unsubscribe from

Re: [PATCH 2195/2195] Staging: rdma: amso1100: Fix multiple assignments on single line.

On Sun, Oct 25, 2015 at 12:50 PM, Weston Silbaugh wrote: > Multiple assignments should be avoided. > > For example: > > cm_event.ird = cm_event.ord = 128; > > Should be: > > cm_event.ird = 128; > cm_event.ord = 128; > > Signed-off-by: Weston Silbaugh

Re: [PATCH 1/4 v2] staging: ipath: ipath_driver: Use setup_timer

On Sun, Oct 25, 2015 at 12:17 PM, Muhammad Falak R Wani wrote: Please follow standard naming convention for the patches. It should be [PATCH v2 1/4] and not [PATCH 1/4 v2]. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to

[PATCH] IB/mlx5: Postpone remove_keys under knowledge of coming preemption

From: Leon Romanovsky <leo...@mellanox.com> The remove_keys() logic is performed as garbage collection task. Such task is intended to be run when no other active processes are running. The need_resched() will return TRUE if there are user tasks to be activated in near future. In such ca

Re: [PATCH] fix return value error

On Wed, Oct 14, 2015 at 5:17 PM, Marciniszyn, Mike wrote: >> > Subject: [PATCH] fix return value error >> > >> >> I checked returns in configfs (-ENOMEM), proc (-ENOENT), proc-sys (- >> ENOMEM), ramfs (-ENOSPC), vfs (-ENOMEM). >> >> Not entirely consistent but this

Re: [PATCH] IB/mlx4: Use vmalloc for WR buffers when needed

On Fri, Sep 25, 2015 at 08:51:22AM +0800, Wengang Wang wrote: > Hi Or, > > 在 2015年09月24日 19:57, Or Gerlitz 写道: > >On Thu, Sep 24, 2015 at 1:49 PM, Wengang Wang > >wrote: > >>@@ -786,8 +787,14 @@ static int create_qp_common(struct mlx4_ib_dev *dev, > >>struct ib_pd

Re: [PATCH] IB/mlx4: Use vmalloc for WR buffers when needed

On Thu, Oct 8, 2015 at 9:14 AM, Or Gerlitz <ogerl...@mellanox.com> wrote: > On 10/8/2015 9:06 AM, Leon Romanovsky wrote: >> >> Additionally, I want to spot Or's attention on the following discussion >> in MM-subsystem about kmalloc/vmalloc and general function to fall

Re: [PATCH] IPoIB: serialize changing on tx_outstanding

>>> + spin_lock_irqsave(>lock, flags); >>> + --priv->tx_outstanding; >>> + if (netif_queue_stopped(dev)) >>> + netif_wake_queue(dev); >>> + spin_unlock_irqrestore(>lock, flags); >> >> Why are you locking the netif_*

Re: [PATCH] IPoIB: serialize changing on tx_outstanding

On Mon, Sep 28, 2015 at 01:42:10PM +0800, Wengang Wang wrote: > The changing on tx_outstanding should be protected by spinlock or to be > atomic operations. > > Such log is found in dmesg: > > Sep 16 14:20:53 naep11x06 kernel: ib0: queue stopped 1, tx_head 1034733, > tx_tail 1034733,

Re: [PATCH v2 16/16] NFS: Enable client side NFSv4.1 backchannel to use other transports

On Tue, Oct 6, 2015 at 6:00 PM, Chuck Lever wrote: > Pass the correct backchannel transport class to svc_create_xprt() > when setting up an NFSv4.1 backchannel transport. > > Signed-off-by: Chuck Lever > --- > fs/nfs/callback.c |