[PATCH] IB/mlx5: Remove dead code from alloc_cached_mr()

2015-07-27 Thread Roland Dreier
From: Roland Dreier rol...@purestorage.com The only place that assigns mr inside the loop already does a break. So if (mr) will never be true here since the function initializes mr to NULL at the top. We can just drop the extra if and break here. Signed-off-by: Roland Dreier rol

Re: IBV_SEND_INLINE Behavior Differing from Spec

2015-07-05 Thread Roland Dreier
On Fri, Jul 3, 2015 at 2:50 PM, Christopher Mitchell christop...@cemetech.net wrote: The manpage for ibv_post_send indicates that if you specify the IBV_SEND_INLINE flag, that you can immediately re-use the buffer after ibv_post_send() returns. However, I have found that if I modify the buffer

Re: rdma kernel tree

2015-06-03 Thread Roland Dreier
Also, how does this relate to Roland's infiniband tree (git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git#for-next) that is already in linux-next? You can drop my tree, I'm no longer updating it. - R. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in

[PATCH 1/3] RDMA/ocrdma: Fix memory leak in _ocrdma_alloc_pd()

2015-05-30 Thread Roland Dreier
From: Roland Dreier rol...@purestorage.com If ocrdma_get_pd_num() fails, then we need to free the pd struct we allocated. This was detected by Coverity (CID 1271245). Signed-off-by: Roland Dreier rol...@purestorage.com --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 7 ++- 1 file changed

[PATCH 2/3] IB/mlx4: Fix error paths in mlx4_ib_create_flow()

2015-05-30 Thread Roland Dreier
From: Roland Dreier rol...@purestorage.com The unwinding clean up code are err_create_flow starts at the current index i. That means we shouldn't increment i until we're really sure we won't have to destroy the current flow; otherwise we might increment the index, fail inside an is_bonded block

[PATCH 3/3] iser-target: Fix error path in isert_create_pi_ctx()

2015-05-30 Thread Roland Dreier
From: Roland Dreier rol...@purestorage.com We don't assign pi_ctx to desc-pi_ctx until we're certain to succeed in the function. That means the cleanup path should use the local pi_ctx variable, not desc-pi_ctx. This was detected by Coverity (CID 1260062). Signed-off-by: Roland Dreier rol

Re: Stepping down as maintainer (was Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management)

2015-04-22 Thread Roland Dreier
On Wed, Apr 22, 2015 at 7:43 AM, Doug Ledford dledf...@redhat.com wrote: New items since the last push: Jason's fix to the CMA for IPv4/IPv6 canonization Hariprasad's series to iw_cxgb4 Tatyana's and Steve's series for iWARP portmapper address resolution I just sent the previous batch, since

[GIT PULL] please pull infiniband.git

2015-04-22 Thread Roland Dreier
Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus InfiniBand/RDMA updates for 4.1: - IPoIB fixes from Doug Ledford and Erez Shitrit - iSER updates from Sagi

Re: Stepping down as maintainer (was Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management)

2015-04-17 Thread Roland Dreier
On Apr 11, 2015 12:28 PM, Or Gerlitz gerlitz...@gmail.com wrote: If taking off the maintainer hat would get you some free/spare cycles, maybe you could resume posting in the digitalvampire blog and/or participate in the upstreamming of soft-RoCE driver? some folks here are working on this, so

Re: Stepping down as maintainer (was Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management)

2015-04-17 Thread Roland Dreier
On Fri, Apr 17, 2015 at 4:15 AM, Or Gerlitz gerlitz...@gmail.com wrote: Seems like Roland isn't around to carry the rdma pull request for 4.1 ... Why do you ignore my emails (I see no reply to http://www.spinics.net/lists/linux-rdma/msg24194.html) and jump to this conclusion? I will send a pull

Re: [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib

2015-04-16 Thread Roland Dreier
On Thu, Apr 16, 2015 at 9:44 AM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: We can give client-add() callback a return value and make ib_register_device() return -ENOMEM when it failed, just wondering why we don't do this at first, any special reason? No idea, but having

Re: Stepping down as maintainer (was Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management)

2015-04-15 Thread Roland Dreier
On Wed, Apr 15, 2015 at 5:39 AM, Doug Ledford dledf...@redhat.com wrote: Regardless of what we end up doing long term, Roland is out at the moment, so 4.1 is happening more or less without him :-/ Sorry. I am back at work now. I went ahead and put together a 4.1 branch and pulled the

Re: RDMA patches for 4.1 (was: Stepping down as maintainer (was Re: [PATCH for-next 0/9] mlx4 changes [...]))

2015-04-15 Thread Roland Dreier
On Wed, Apr 15, 2015 at 6:54 AM, Or Gerlitz ogerl...@mellanox.com wrote: There were two trivial conflicts between the mlx4 changes to another mlx4 series which is present in net-next, I resolved them and you can pull the fixed series from my git tree,SB. Not sure how you expect this to work.

Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management

2015-04-05 Thread Roland Dreier
On Sat, Apr 4, 2015 at 10:15 PM, Or Gerlitz gerlitz...@gmail.com wrote: Indeed. No maintainer voice makes it kind of impossible for discussions to converge. What happens over the last years is that when there's no easy consensus on matter Y, everyone stops breathing and wait to see what

Re: iser patches for kernel 4.1 [v2]

2015-04-02 Thread Roland Dreier
Thanks, applied 1-18. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[GIT PULL] please pull infiniband.git

2015-04-02 Thread Roland Dreier
Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus One 4.0 RDMA change: - Fix for exploitable integer overflow in uverbs interface.

Re: CVE-2014-8159 kernel: infiniband: uverbs: unprotected physical memory access

2015-04-02 Thread Roland Dreier
On Thu, Apr 2, 2015 at 12:52 AM, Shachar Raindel rain...@mellanox.com wrote: This is a common practice in the security industry, called responsible disclosure. Following the kernel security bugs policy [1], we reported it to the kernel security contacts few days before making the issue

Re: [PATCH v2] IB/srp: Add 64-bit LUN support

2015-04-02 Thread Roland Dreier
Thanks, applied at last. I'm assuming the vscsi changes are OK since they look mechanical and we haven't heard anything from IBM people. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: CVE-2014-8159 kernel: infiniband: uverbs: unprotected physical memory access

2015-04-01 Thread Roland Dreier
On Wed, Mar 18, 2015 at 10:39 AM, Shachar Raindel rain...@mellanox.com wrote: Date: Sun, 04 Jan 2015 18:30:32 +0200 Subject: [PATCH] IB/core: Prevent integer overflow in ib_umem_get address arithmetic Just so we're clear, this bug has been known since January 4, and it's getting sent upstream

Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management

2015-03-30 Thread Roland Dreier
Roland, I have to genuinely agree with Or, that your handling of patch integration is sub-par and really painful for anyone actually trying to get real work done here. If you simply don't have the time to devote to constantly reviewing patches as they come in, and doing so in a timely

Re: [patch] IB/qib: fix a do nothing for loop

2015-02-20 Thread Roland Dreier
On Fri, Feb 20, 2015 at 2:56 AM, Dan Carpenter dan.carpen...@oracle.com wrote: We accidentally deleted a semi-colon here and changed this do-nothing loop into a do-something loop. Thanks! I folded this into the original cleanup patch. -- To unsubscribe from this list: send the line

[GIT PULL] please pull infiniband.git

2015-02-20 Thread Roland Dreier
better code for ocrdma_srq_toggle_bit RDMA/ocrdma: Use unsigned for bit index Rickard Strandqvist (1): IB/ipath: Remove unused function in ipath_wc_ppc64 Roi Dayan (1): IB/iser: Use correct dma direction when unmapping SGs Roland Dreier (1): Merge branches 'core', 'cxgb4

Re: linux-next: build failure after merge of the infiniband tree

2015-02-17 Thread Roland Dreier
On Tue, Feb 17, 2015 at 6:32 PM, Stephen Rothwell s...@canb.auug.org.au wrote: After merging the livepatching tree, today's linux-next build (powerpc allyesconfig) failed like this: In file included from drivers/infiniband/hw/qib/qib_cq.c:41:0: drivers/infiniband/hw/qib/qib.h: In function

Re: [PATCH 1/3] IB/core: Add support for extended query device caps

2015-02-17 Thread Roland Dreier
The verb also checks the user-space provided response buffer size and only fills in capabilities that will fit in the buffer. In attempt to follow the spirit of presentation [2] by Tzahi Oved that was presented during OpenFabrics Alliance International Developer Workshop 2013, the comp_mask

Re: [PATCH RE-RESEND V2 for-next 5/5] IB/core: Fix deadlock on uverbs modify_qp error flow

2015-02-17 Thread Roland Dreier
On Tue, Feb 17, 2015 at 9:03 PM, Or Gerlitz ogerl...@mellanox.com wrote: Roland, can you please pick this one too, it's a bug fix and no comments were raised against it. I just failed to remove the Gerrit Issue: XXX line, so if you can do that, will be great OK. -- To unsubscribe from this

Re: [PATCH FIXES for-3.19 0/2] iser initiator fixes for kernel 3.19

2015-02-17 Thread Roland Dreier
On Tue, Feb 17, 2015 at 11:21 AM, Or Gerlitz gerlitz...@gmail.com wrote: On Sun, Jan 18, 2015 at 9:51 AM, Sagi Grimberg sa...@mellanox.com wrote: This set consist of two fixes error flows (cleanup resources). Hi Roland, I see now that you started to pull the updates for 3.20, please remember

Re: [PATCH 1/1] IB/mthca: remove deprecated use of pci api

2015-02-17 Thread Roland Dreier
On Wed, Feb 4, 2015 at 6:09 AM, Quentin Lambert lambert.quen...@gmail.com wrote: - dev-eq_table.icm_dma = pci_map_page(dev-pdev, dev-eq_table.icm_page, 0, - PAGE_SIZE, PCI_DMA_BIDIRECTIONAL); - if (pci_dma_mapping_error(dev-pdev,

[GIT PULL] please pull infiniband.git

2015-02-06 Thread Roland Dreier
Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus One more last-second RDMA change for 3.19: - Yann realized that the previous revert of new userspace ABI did

[GIT PULL] please pull infiniband.git

2015-02-03 Thread Roland Dreier
in a rush and make a mistake, we'll take a bit more time and get it right in 3.20. Haggai Eran (1): IB/core: Temporarily disable ex_query_device uverb Roland Dreier (9): Revert IPoIB: No longer use flush as a parameter

Re: [PATCH V3 FIX for-3.19] IB/ipoib: Fix sendonly traffic and multicast traffic

2015-01-29 Thread Roland Dreier
On Thu, Jan 29, 2015 at 7:34 AM, Doug Ledford dledf...@redhat.com wrote: So lets close the 3.19 saga, again, either revert your eight patches I would support that option. I think at this point we have to do the revert, and get it right for 3.20. There's just too much noise floating around

Re: [PATCH v1 1/5] IB/uverbs: ex_query_device: answer must not depend on request's comp_mask

2015-01-29 Thread Roland Dreier
On Thu, Jan 29, 2015 at 1:59 PM, Yann Droneaud ydrone...@opteya.com wrote: Roland: I agree with Yann, these patches need to go in, or the ODP patches reverted. Reverting all On Demand Paging patches seems overkill: if something as to be reverted it should be commit 5a77abf9a97a (IB/core: Add

Re: [PATCH FIX For-3.19 v5 00/10] Fix ipoib regressions

2015-01-23 Thread Roland Dreier
Doug, Roland - eight rc1 patches followed ten rc6 fixes - sounds a bit too much to me. We can do as we wish upstream, but these are going live in our product ASAP. The original 8 rc1 patches took so long to get upstream that they had already been live in 6.5-z and 6.6 and were slated for

Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-21 Thread Roland Dreier
On Tue, Jan 20, 2015 at 8:16 AM, Erez Shitrit ere...@dev.mellanox.co.il wrote: After trying your V4 patch series, I can tell that first, the endless scheduling of the mcast task is indeed over, but still, the multicast functionality in ipoib is unstable. Is this worse than 3.18? (Have you

Re: [PATCH FIX For-3.19 v4 0/7] IB/ipoib: follow fixes for multicast handling

2015-01-21 Thread Roland Dreier
On Wed, Jan 21, 2015 at 12:34 PM, Or Gerlitz gerlitz...@gmail.com wrote: Because Doug's changes fixed some bad, easy-to-reproduce issues. On the other hand we don't want to introduce new regressions to fix the old issues. See above, we did introduced regressions. Yes, I know, that's my

[GIT PULL] please pull infiniband.git

2014-12-18 Thread Roland Dreier
): IB/addr: Improve address resolution callback scheduling Pramod Kumar (2): RDMA/cxgb4: Increase epd buff size for debug interface RDMA/cxgb4: Configure 0B MRs to match HW implementation Roland Dreier (2): mlx5_core: Re-add MLX5_DEV_CAP_FLAG_ON_DMND_PG flag Merge

Re: [PATCH v3 06/17] IB/core: Add support for extended query device caps

2014-12-16 Thread Roland Dreier
On Tue, Dec 16, 2014 at 4:33 AM, Yann Droneaud ydrone...@opteya.com wrote: With the suggested change here, buffer overflow won't happen, but the error is silently ignored, allowing uverb to return a partial result, which is likely not expected by userspace as it's a bit difficult to handle it

Re: linux-next: build failure after merge of the infiniband tree

2014-12-15 Thread Roland Dreier
On Mon, Dec 15, 2014 at 5:56 PM, Roland Dreier rol...@kernel.org wrote: I'll add a partial revert of that patch to my tree to get back the now-used enum values. I rebased my tree on top of the merge-window merge of davem's tree, and added the missing flag on top of the remove this flag commit

Re: [PATCH for-next 00/16] iser initiator updates for 3.19

2014-12-09 Thread Roland Dreier
Thanks, applied for 3.19. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 06/17] IB/core: Add support for extended query device caps

2014-12-09 Thread Roland Dreier
I was getting ready to apply the ODP series, but then I noticed: On Tue, Nov 11, 2014 at 8:36 AM, Haggai Eran hagg...@mellanox.com wrote: diff --git a/drivers/infiniband/core/uverbs_main.c b/drivers/infiniband/core/uverbs_main.c index 71ab83fde472..974025028790 100644 ---

Re: [RFC PATCH 03/16] ib/mad: Add check for jumbo MADs support on a device

2014-12-07 Thread Roland Dreier
On Sun, Dec 7, 2014 at 4:23 PM, Weiny, Ira ira.we...@intel.com wrote: I don't think this is a bad idea, however, the complication is determining the kmem_cache object size in that case. How about we limit this value to 2K until such time as there is a need for larger support? Can we just

Re: [PATCH ] mlx4_core: Verify that port types are the same only if DPDP supported

2014-12-07 Thread Roland Dreier
On Sat, Dec 6, 2014 at 10:46 AM, Yuval Shaia yuval.sh...@oracle.com wrote: - for (i = 0; i dev-caps.num_ports - 1; i++) { - if (port_type[i] != port_type[i + 1]) { - if (!(dev-caps.flags MLX4_DEV_CAP_FLAG_DPDP)) { + if (!(dev-caps.flags

Re: [PATCH V2 for-next 0/9] Peer-Direct support

2014-10-23 Thread Roland Dreier
On Thu, Oct 23, 2014 at 5:02 AM, Yishai Hadas yish...@mellanox.com wrote: The API defined for Peer-Direct is described in this cover letter. The required implementation for a hardware device to expose memory buffers over Peer-Direct is also detailed in this letter. I don't see how I can

Re: [Users] Linux kernel: Crash of IB peer in RC mode is not detected

2014-10-23 Thread Roland Dreier
On Thu, Oct 23, 2014 at 6:50 AM, Jack Wang xjtu...@gmail.com wrote: I expected that RDMA-Write operations will fail if the other crashes. Also I hoped that an event is generated when a host is crashed. The subnet manager should notice it and notify every other device in the network. Are we

Re: ib_post_send execution time

2014-10-23 Thread Roland Dreier
On Thu, Oct 23, 2014 at 10:21 AM, Evgenii Smirnov evgenii.smir...@profitbricks.com wrote: I am trying to achieve high packet per second throughput with 2-byte messages over Infiniband from kernel using IB_SEND verb. The most I can get so far is 3.5 Mpps. However, ib_send_bw utility from

[GIT PULL] please pull infiniband.git

2014-10-16 Thread Roland Dreier
/iser: Remove unused variables and dead code Roland Dreier (1): Merge branches 'core', 'cxgb4', 'iser', 'mlx5' and 'ocrdma' into for-next Sagi Grimberg (23): IB/iser: Rename ib_conn - iser_conn IB/iser: Re-introduce ib_conn IB/iser: Extend iser_free_ib_conn_res() IB

Re: [PATCH v1 for-next 06/16] IB/core: Implement support for MMU notifiers regarding on demand paging regions

2014-10-14 Thread Roland Dreier
+ notifiers_seq = atomic_read(item-odp_data-notifiers_seq) + 1; + atomic_set(item-odp_data-notifiers_seq, +notifiers_seq); Is this code really as silly as it looks, or is there some deep reason for avoiding atomic_inc() that I'm missing? Do you need atomic_inc(), since

Re: [PATCH 8/8] IB/srp: Add multichannel support

2014-10-10 Thread Roland Dreier
On Mon, Oct 6, 2014 at 4:16 AM, Bart Van Assche bvanass...@acm.org wrote: On 10/02/14 19:30, Christoph Hellwig wrote: Also if we want to merge scsi LLDDs that can take advantage of multiqueue support it would probably be best if I take this via the SCSI tree. Sending these patches to you is

[GIT PULL] please pull infiniband.git

2014-09-23 Thread Roland Dreier
: Avoid executing gid task when device is being removed Or Gerlitz (1): IB/iser: Bump version to 1.4.1 Roi Dayan (1): IB/iser: Fix RX/TX CQ resource leak on error flow Roland Dreier (1): Merge branches 'core', 'ipoib', 'iser', 'mlx4', 'ocrdma' and 'qib' into for-next Sagi

Re: [PATCH 0/7] Signature feature update

2014-08-22 Thread Roland Dreier
On Fri, Aug 22, 2014 at 11:22 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: Roland, are you planning to pick these up for v3.18..? Sure. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

[GIT PULL] please pull infiniband.git

2014-08-14 Thread Roland Dreier
handling IB/iser: Clarify a duplicate counters check Roland Dreier (1): Merge branches 'core', 'cxgb4', 'ipoib', 'iser', 'iwcm', 'mad', 'misc', 'mlx4', 'mlx5', 'ocrdma' and 'srp' into for-next Sagi Grimberg (2): IB/iser: Fix responder resources advertisement IB/iser

Re: [PATCH 6/8] ib/srpt: Enhance printk output

2014-08-12 Thread Roland Dreier
On Tue, Aug 12, 2014 at 4:20 PM, Doug Ledford dledf...@redhat.com wrote: The ib_srpt module has a metric ton of printks for debugging and warnings and such. And it never prefaces a single one of them with information to allow an admin to know what errant module is spewing garbage all through

Re: [PATCH 2/8] IB/srp: Use P_Key cache for P_Key lookups

2014-08-12 Thread Roland Dreier
On Tue, Aug 12, 2014 at 4:20 PM, Doug Ledford dledf...@redhat.com wrote: - ret = ib_find_pkey(target-srp_host-srp_dev-dev, - target-srp_host-port, - be16_to_cpu(target-path.pkey), - attr-pkey_index); + ret

Re: [PATCH] ib_mad: fix microblaze build issue (PFX macro mistake)

2014-08-11 Thread Roland Dreier
diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c index 3c6b228..cc00e4e 100644 --- a/drivers/infiniband/core/mad.c +++ b/drivers/infiniband/core/mad.c @@ -34,7 +34,7 @@ * */ -#define pr_fmt(fmt) PFX fmt +#define pr_fmt(fmt) ib_mad: fmt #include

[GIT PULL] please pull infiniband.git

2014-07-18 Thread Roland Dreier
fixes Hariprasad S (2): RDMA/cxgb4: Fix skb_leak in reject_cr() RDMA/cxgb4: Clean up connection on ARP error Or Gerlitz (1): IB/mlx5: Enable block multicast loopback for kernel consumers Roland Dreier (1

[GIT PULL] please pull infiniband.git

2014-06-10 Thread Roland Dreier
to use GFP_NOIO allocations Roi Dayan (1): IB/iser: Add missing newlines to logging messages Roland Dreier (6): IB/mlx5: Fix warning about cast of wr_id back to pointer on 32 bits mlx4_core: Move handling of MLX4_QP_ST_MLX to proper switch statement IB/mad: Fix sparse

Re: [PATCH for-next] mlx4_core: Add support for secure-host and SMP firewall

2014-06-10 Thread Roland Dreier
On Sun, Jun 8, 2014 at 12:48 PM, Or Gerlitz or.gerl...@gmail.com wrote: So, is this OK for 3.16? note this touches mlx4 only. if you have any questions on the patch, please let us know and Jack will address. This came in after the merge window already opened, but I will try to get it into my

Re: [PATCH for-next] mlx4_core: Add support for secure-host and SMP firewall

2014-06-10 Thread Roland Dreier
By this you mean the reminder...? I sent the patch June 1st wheres the window opened on the 8th, but thanks anyway. The merge window opened June 1: https://lwn.net/Articles/600984/ - R. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

Re: [RESEND PATCH] IB/umad: Fix a use-after-free

2014-06-06 Thread Roland Dreier
On Fri, Jun 6, 2014 at 9:25 AM, Yann Droneaud ydrone...@opteya.com wrote: It seems this one was not rolled in your latest katamari[1]. Thanks, picked it up this time around. - R. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

Re: [PATCH for-next 00/15] Bug fixes for ocrdma driver

2014-06-04 Thread Roland Dreier
On Wed, Jun 4, 2014 at 9:37 AM, Steve Wise sw...@opengridcomputing.com wrote: Seems like the subject lines in each patch are getting truncated? Yes, truncated in patchwork too -- for example: https://patchwork.kernel.org/patch/4292461/ Please fix and resend. -- To unsubscribe from this list:

Re: [PATCH 0/2] Include protection information in iscsi header

2014-06-03 Thread Roland Dreier
On Sun, Jun 1, 2014 at 9:19 AM, Sagi Grimberg sa...@mellanox.com wrote: Although these patches involve 3 subsystems with different maintainers (scsi, iser, target) I would prefer seeing these patches included together. Why? Because they break wire compatibility? I hate to say it but even if

Re: [infiniband:for-next 41/47] drivers/net/ethernet/mellanox/mlx4/resource_tracker.c:2875:3: warning: case value '7' not in enumerated type 'enum qp_transition'

2014-05-30 Thread Roland Dreier
\n, Looks like this is actually a bug... assuming you guys agree the patch is correct, I'll add the following: commit 165cb465f73c (HEAD, mlx4) Author: Roland Dreier rol...@purestorage.com Date: Fri May 30 15:38:58 2014 mlx4_core: Move handling of MLX4_QP_ST_MLX to proper switch statement

Re: [PATCH v4 0/9] SRP initiator patches for kernel 3.16

2014-05-20 Thread Roland Dreier
On Tue, May 20, 2014 at 7:06 AM, Or Gerlitz ogerl...@mellanox.com wrote: V3 is already applied It's OK, I can replace the series. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH v3 0/9] SRP initiator patches for kernel 3.16

2014-05-19 Thread Roland Dreier
The series looks good to me. Reviewed-by: Sagi Grimberg sa...@mellanox.com thanks, queued all 9 patches up. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [PATCH 0/3] mlx5 signature handover fixes for kernel 3.16

2014-05-19 Thread Roland Dreier
On Sun, May 18, 2014 at 8:32 AM, Sagi Grimberg sa...@mellanox.com wrote: This patchset addresses 3 issues signature handover mlx5 implementation. Thanks, applied all 3. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org

Re: [PATCH v1 for-next 0/3] IB: Use GFP_NOIO calls in IPoIB connected mode TX path

2014-05-19 Thread Roland Dreier
On Sat, May 17, 2014 at 1:52 PM, Or Gerlitz or.gerl...@gmail.com wrote: Roland, we're soon on -rc6 and there's no reason for this to miss 3.16, could you please comment whether you want it to go through your tree or net-next? I will pick it up. -- To unsubscribe from this list: send the line

Re: [PATCH libibverbs V1] Align Flow Steering API to the extension verbs scheme

2014-05-19 Thread Roland Dreier
On Thu, May 15, 2014 at 6:16 AM, Or Gerlitz ogerl...@mellanox.com wrote: Hi Roland -- this addresses all the comments by Jason who gave a ack/reviewed-by note for both the libibverbs and libmlx4 fixes. So you can move ahead and conduct point releases for both libs. OK... so I should do one

Re: [PATCH 0/3] RDMA/core: iWARP Port Mapper Overview

2014-05-19 Thread Roland Dreier
On Wed, Mar 26, 2014 at 3:07 PM, Tatyana Nikolova tatyana.e.nikol...@intel.com wrote: 1) The IWPM functionality, common for both iWarp drivers (nes and cxgb4) is refactored from the drivers source files and is moved to new shared files in infiniband/core which are compiled as part of the

Re: [PATCH libibverbs V3 3/3] Add ibv_query_port_ex support

2014-05-12 Thread Roland Dreier
BTW, before I forget, the patch that introduces the API must also include a man page for it. Jason, care to send a patch for the README or whatever with the rules? :) -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org

Re: [PATCH libibverbs V3 3/3] Add ibv_query_port_ex support

2014-05-09 Thread Roland Dreier
On Thu, May 8, 2014 at 12:09 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: struct verbs_context { /* grows up - new fields go here */ + int (*drv_query_port_ex)(struct ibv_context *context, uint8_t port_num, + struct ibv_port_attr_ex

Re: [PATCH libibverbs V3 2/3] Use neighbour lookup for RoCE UD QPs Eth L2 resolution

2014-05-09 Thread Roland Dreier
On Thu, May 8, 2014 at 1:15 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: From now on I think every proposed API/ABI change should be in an isolated patch from anything else, it should be accompanied by other patches showing the implementation, and the ABI patch specifically

Re: [PATCH libibverbs V3 3/3] Add ibv_query_port_ex support

2014-05-09 Thread Roland Dreier
On Fri, May 9, 2014 at 11:10 AM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: To be honest, I never bothered looking at any patches beyond the core extension patches. There was no indication from you that they would ever be merged, so it didn't feel like good use of my time. Haven't

[ANNOUNCE] libmlx4 1.0.6 is released

2014-05-07 Thread Roland Dreier
Roland Dreier (5): resize_cq: Fix possible endless loop scanning CQ Remove compatibility with libibverbs 1.1.7 Use dh-autoreconf to fix build on ppc64el Enable subdir-objects for automake Roll libmlx4 1.0.6 release Sean Hefty (1): Add support for XRC QPs Yishai

Re: [ANNOUNCE] libibverbs 1.1.8 is released

2014-05-07 Thread Roland Dreier
On Wed, May 7, 2014 at 1:48 AM, Or Gerlitz ogerl...@mellanox.com wrote: Roland, due to a mistake I made in the rebased flow-steering patch I handed you -- I was nominated as the author instead of Matan, our flow-steering maintainer.. can you please git reword this commit in your libibverbs

[ANNOUNCE] libibverbs 1.1.8 is released

2014-05-05 Thread Roland Dreier
extensions Or Gerlitz (1): Add receive flow steering support Roland Dreier (2): Update maintainer now that I'm a DD Roll libibverbs 1.1.8 release Sean Hefty (5): Introduce XRC domains (XRCDs) Add support for XRC SRQs Add support for XRC QPs Add ibv_open_qp

[GIT PULL] please pull infiniband.git

2014-05-01 Thread Roland Dreier
Hi Linus, Please pull from git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git tags/rdma-for-linus InfiniBand/RDMA updates for 3.15-rc4: - cxgb4 hardware driver fixes

Re: [PATCH RESEND 3.15-rc3 1/3] iw_cxgb4: Fix endpoint mutex deadlocks

2014-04-28 Thread Roland Dreier
On Mon, Apr 28, 2014 at 5:53 AM, Steve Wise sw...@opengridcomputing.com wrote: Hey Roland, do these 3 bug fixes look good for 3.15? Yes, look fine, applying now. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More

Re: [PATCH for-next] IB/mlx5: Add block multicast loopback support

2014-04-21 Thread Roland Dreier
commit f360d88a2efd upstream. On Mon, Apr 21, 2014 at 10:56 AM, Christoph Lameter c...@linux.com wrote: On Wed, 2 Apr 2014, Or Gerlitz wrote: From: Eli Cohen e...@dev.mellanox.co.il Add support for the block multicast loopback QP creation flag along the proper firmware API for that.

Re: [PATCH for-next] IB/mlx5: Add block multicast loopback support

2014-04-21 Thread Roland Dreier
Is something more than commit 521e575b9a73 (from 2008) required? On Mon, Apr 21, 2014 at 11:59 AM, Christoph Lameter c...@linux.com wrote: On Mon, 21 Apr 2014, Roland Dreier wrote: commit f360d88a2efd upstream. Great. Is there a corresponding patch for mlx4? Dont see that in the kernel

[GIT PULL] please pull infiniband.git

2014-04-03 Thread Roland Dreier
/iser: Update Mellanox copyright note IB/iser: Bump driver version to 1.3 Prarit Bhargava (1): RDMA/ocrdma: Fix compiler warning Randy Dunlap (1): IB/iser: Fix sector_t format warning Roi Dayan (1): IB/iser: Drain the tx cq once before looping on the rx cq Roland Dreier (2

Re: [PATCH for v3.14 0/5] Coccicheck / coccinelle catched errors on ib/hw

2014-04-01 Thread Roland Dreier
On Tue, Mar 25, 2014 at 6:15 AM, Yann Droneaud ydrone...@opteya.com wrote: Here removing sta...@vger.kernel.org doesn't sound right. Sorry, I've added that back. Could you help me to understand the reason why your selectively remove some 'Cc:' on some patches while leaving them on other

Re: [Patch 0/3] Hangs with IPoIB when doing PCI error injection

2014-03-28 Thread Roland Dreier
On Fri, Mar 28, 2014 at 1:47 PM, David Miller da...@davemloft.net wrote: I'm assuming Roland will take this in via his tree. Yes, hoping for some feedback from Mellanox people. - R. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to

Re: [PATCH 0/8] Misc. fixes for iw_cxgb4

2014-03-20 Thread Roland Dreier
Thanks, applied all except iw_cxgb4: use the BAR2/WC path for kernel QPs and T5 devices which doesn't apply to my tree (seems to depend on patches only in net-next). -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org

Re: linux rdma 3.14 merge plans

2014-03-07 Thread Roland Dreier
patches on top of previous series of patches. -Regards Devesh -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma-ow...@vger.kernel.org] On Behalf Of Nicholas A. Bellinger Sent: Thursday, March 06, 2014 12:34 AM To: Roland Dreier Cc: Or Gerlitz; Hefty Sean

Re: [PATCH v5 00/10] Introduce Signature feature

2014-03-07 Thread Roland Dreier
So I went ahead and applied this for 3.15, although I suspect the verbs API is probably the wrong one. I understand that the mlx5 microarchitecture requires some of this signature binding stuff to go through a work queue, but conceptually I don't think the IB_WR_REG_SIG_MR work request makes

Re: linux rdma 3.14 merge plans

2014-03-05 Thread Roland Dreier
On Wed, Mar 5, 2014 at 1:54 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: That all said, do you have an objection wrt taking this bits through target-pending..? Given the dependencies involved, that would seem the most logical path to take. Perhaps not surprisingly, I would prefer to

[GIT PULL] please pull infiniband.git

2014-02-14 Thread Roland Dreier
bonding IB: Report using RoCE IP based gids in port caps Roi Dayan (1): IB/iser: Avoid dereferencing iscsi_iser conn object when not bound to iser connection Roland Dreier (2): mlx5: Add include of linux/slab.h because of kzalloc()/kfree() use Merge branches 'cma', 'cxgb4

Re: [PATCH master] RDMA/ocrdma: Fix load time panic during GID table init

2014-02-13 Thread Roland Dreier
On Mon, Feb 3, 2014 at 10:40 PM, Devesh Sharma devesh.sha...@emulex.com wrote: driver should use rdma_vlan_dev_real_dev() instead of using vlan_dev_real_dev() while building GID table for a vlan interface. Signed-off-by: Devesh Sharma devesh.sha...@emulex.com ---

Re: [PATCH v2] IB/CMA: Fix initialization of hop_limit instead of hardcode to 1.

2014-02-13 Thread Roland Dreier
On Wed, Feb 12, 2014 at 9:44 PM, Somnath Kotur somnath.ko...@emulex.com wrote: Hi Roland, Yes you are correct, currently it is not routable , and this would probably be the first gentle step in enabling it to be so. Also, I did see that in ib_init_ah_from_wc() currently , it is

Re: [PATCH] IB/mlx5: Remove dependency on X86

2014-02-13 Thread Roland Dreier
There's another Kconfig you need to fix as well. Full patch below. With this it compiles and loads on powerpc. Got it, I'll use this patch. Thanks! Roland -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More

Re: linux rdma 3.14 merge plans

2014-02-06 Thread Roland Dreier
On Thu, Feb 6, 2014 at 4:02 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: Can you give us an estimate of when you'll have some time to give feedback on the outstanding patches..? I hope to get to it in the next few weeks. - R. -- To unsubscribe from this list: send the line

Re: [PATCH for-3.14] IB/mlx4: Report using RoCE IP based gids in port caps

2014-02-06 Thread Roland Dreier
On Sun, Feb 2, 2014 at 7:51 AM, Or Gerlitz ogerl...@mellanox.com wrote: For user-space RoCE UD QPs we need to know the GID format that the kernel uses, e.g when working over older kernels. For that end, add new port capability IB_PORT_IP_BASED_GIDS and report it when a port query is issued.

[GIT PULL] please pull infiniband.git

2014-01-24 Thread Roland Dreier
based gids Or Gerlitz (2): IB/core: Resolve Ethernet L2 addresses when modifying QP IB/core: Fix unused variable warning Paul Bolle (1): RDMA/cxgb4: Fix gcc warning on 32-bit arch Roland Dreier (6): IB/usnic: Fix typo Ignorning - Ignoring RDMA/ocrdma: Move

Re: SRP initiator driver maintainership (was: Stepping down)

2014-01-21 Thread Roland Dreier
On Mon, Jan 20, 2014 at 9:37 AM, Bart Van Assche bvanass...@acm.org wrote: Thanks for all the time you have spent reviewing and testing SRP initiator patches. Such maintainer work is unglamorous but important - it is due to the combined effort of all kernel maintainers that the Linux kernel

Re: linux rdma 3.14 merge plans

2014-01-18 Thread Roland Dreier
On Thu, Jan 16, 2014 at 1:14 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: I've reviewed the API from the perspective of what's required for implementing protection support in iser, and currently don't have any recommendations or objections beyond what has been proposed by Sagi Co in

Re: [PATCH for-next 0/6] Add flow steering support for IPoIB

2014-01-14 Thread Roland Dreier
Applied this IB UD flow steering stuff, sorry for the delay. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: linux rdma 3.14 merge plans

2014-01-07 Thread Roland Dreier
On Tue, Jan 7, 2014 at 1:02 PM, Or Gerlitz or.gerl...@gmail.com wrote: Currently there is single patch for 3.14 on your for-next branch, the usnic driver. With 3.13 being on rc7 and likely to be released next week, are you planning any other merges for 3.14? we have patches waiting for weeks

[GIT PULL] please pull infiniband.git

2013-12-23 Thread Roland Dreier
. Rashika (1): RDMA/cxgb4: Make _c4iw_write_mem_dma() static Roland Dreier (2): IB/uverbs: New macro to set pointers to NULL if length is 0 in INIT_UDATA() Merge branches 'cxgb4', 'flowsteer' and 'misc' into for-linus Steve Wise (1): RDMA/iwcm: Don't

Re: [PATCH V9 libmlx4 1/2] Infra-structure changes to support verbs extensions

2013-12-23 Thread Roland Dreier
On Thu, Aug 1, 2013 at 8:05 AM, Yishai Hadas yish...@mellanox.com wrote: #ifdef HAVE_IBV_REGISTER_DRIVER static __attribute__((constructor)) void mlx4_register_driver(void) { - ibv_register_driver(mlx4, mlx4_driver_init); + verbs_register_driver(mlx4, mlx4_driver_init); }

Re: [PATCH for-next] IB/usnic: Fix userspace/kernel ABI alignement discrepancy

2013-12-20 Thread Roland Dreier
On Fri, Dec 20, 2013 at 1:39 PM, Upinder Malhi (umalhi) uma...@cisco.com wrote: @@ -67,7 +67,7 @@ struct usnic_ib_create_qp_resp { u32 rq_idx[USNIC_QP_GRP_MAX_RQS]; u32 cq_idx[USNIC_QP_GRP_MAX_CQS]; u32

Re: [PATCHv4 for-3.13 00/10] create_flow/destroy_flow fixes for v3.13

2013-12-19 Thread Roland Dreier
prefer something like the patch below. I integrated that into the series and pushed out the result (since everyone seems OK with rebasing for-next). Please let me know what you think. From: Roland Dreier rol...@purestorage.com Date: Thu, 19 Dec 2013 08:37:03 -0800 Subject: [PATCH] IB/uverbs: Set

  1   2   3   4   5   6   7   8   9   10   >