mlx4 devices (ConnectX-2, ConnectX-3) can not issue
max_sge in a single RDMA_READ request (resulting in
a completion error). Thus, expose lower max_sge_rd
to avoid this issue.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
---
drivers/infiniband/hw/mlx4/main.c |3 ++-
1 files chan
Hello Sagi,
Is this the same issue as what has been discussed in
http://www.spinics.net/lists/linux-rdma/msg21799.html ?
Looks like it.
I think this patch addresses this issue, but lets CC Eli
to comment if I'm missing something.
Thanks for digging this up...
Sagi.
--
To unsubscribe from
On 27/10/2015 16:39, Or Gerlitz wrote:
On 10/27/2015 11:40 AM, Sagi Grimberg wrote:
mlx4 devices (ConnectX-2, ConnectX-3) can not issue
max_sge in a single RDMA_READ request (resulting in
a completion error). Thus, expose lower max_sge_rd
to avoid this issue.
Sagi,
Hey Or,
Still
But AFAIR, the magic number was 28... how this goes hand in hand with
your findings?
mlx4 max_sge is 32, and isert does max_sge - 2 = 30.
So it always used 30... and I run it reliably with this for a while now.
This thing exists before I was involved so I might not be familiar with
all the
and added
a root cause analysis to patch change log.
- Fixed isert qp creation to be max_sge but construct rdma
work request with the minimum of max_sge and max_sge_rd
as non-rdma sends (login rsp) take 2 sges (and some devices
have max_sge_rd = 1.
Sagi Grimberg (2):
mlx4: Expose correct
The driver now exposes sufficient limits so we can
avoid having mlx4 specific work-around.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
---
drivers/infiniband/ulp/isert/ib_isert.c | 13 +++--
1 files changed, 3 insertions(+), 10 deletions(-)
diff --git a/drivers/infiniba
= 30.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
---
drivers/infiniband/hw/mlx4/main.c |2 +-
include/linux/mlx4/device.h | 11 +++
2 files changed, 12 insertions(+), 1 deletions(-)
diff --git a/drivers/infiniband/hw/mlx4/main.c
b/drivers/infiniband/hw/mlx4/
Detected this by compiling with W=1.
Signed-off-by: Bart Van Assche <bart.vanass...@sandisk.com>
Cc: Sagi Grimberg <sa...@mellanox.com>
FWIW,
Reviewed-by: Sagi Grimberg <sa...@mellanox.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma&qu
Did we converge on this?
Just a heads up to Doug, this conflicts with
[PATCH v4 11/16] xprtrdma: Pre-allocate Work Requests for backchannel
but it's trivial to sort out...
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to
On 10/21/2015 1:04 PM, Or Gerlitz wrote:
On 10/21/2015 12:53 PM, Sagi Grimberg wrote:
On 10/15/2015 2:44 PM, Eran Ben Elisha wrote:
+struct ib_uverbs_ex_create_qp {
+__u64 user_handle;
+__u32 pd_handle;
+__u32 send_cq_handle;
+__u32 recv_cq_handle;
+__u32 srq_handle
On 10/15/2015 2:44 PM, Eran Ben Elisha wrote:
ib_uverbs_ex_create_qp follows the extension verbs
mechanism. New features (for example, QP creation flags
field which is added in a downstream patch) could used
via user-space libraries without breaking the ABI.
This is an important addition, I'll
Doug, are you planning on taking this for 4.4?
I think this set has converged towards inclusion.
Reminder, this series goes on top of Christoph's
wr_cleanup patches and iser bounce buffering cleanup.
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of
So this patch seems to work well for me. I've ran some kernel
applications (ipoib, iser, srp, nfs) and a user-space application
(ibsrpdm) over mlx4/mlx5 and didn't spot any issues.
I think this is very useful to have and I'd love having it in 4.4,
does anyone have any other comments on this
But this makes struct ib_device much much bigger, and this structure
is used in **fast** path,
e.g the ULP traverses through a pointer from struct ib_device to
post_send/recv, poll_cq and friends.
Umm, all the caps are appended to the end of the ib_device structure so
I don't see how it will
On 10/20/2015 5:08 PM, Or Gerlitz wrote:
On Tue, Oct 20, 2015 at 4:08 PM, Sagi Grimberg <sa...@dev.mellanox.co.il> wrote:
I think this is very useful to have and I'd love having it in 4.4,
does anyone have any other comments on this patch?
Were we ever presented with performance
I think this is very useful to have and I'd love having it in 4.4,
does anyone have any other comments on this patch?
Were we ever presented with performance gains achieved using the patch?
Hi Or,
Can you explain what you mean by performance gains? My understanding is
that this patch is
No callers and no providers left, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/core/verbs.c | 25 ---
include/rdma/ib_verbs.h | 54
The new fast registration API does not reuqire a page vector
so we can't avoid allocating it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Bart Van Assche <bart.vanass...@sandisk.com>
---
drivers/infiniband/ulp/srp/ib_srp.c | 20 +++-
1 file changed, 1
Instead of constructing a page list, call ib_map_mr_sg
and post a new ib_reg_wr. srp_map_finish_fr now returns
the number of sg elements registered.
Remove srp_finish_mapping since no one is calling it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Bart Van Assche <ba
No callers left, remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Bart Van Assche <bart.vanass...@sandisk.com>
---
drivers/infiniband/ulp/srp/ib_srp.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
b/driver
(ib_mr)
- page array (ocrdma_mr)
- key (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/ocrdma/ocrdma.h |
, length, access flags (ib_mr)
- page array (mlx5_ib_mr)
- key (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/mlx5/cq
ble at: https://github.com/sagigrimberg/linux reg_api.6
Sagi Grimberg (26):
IB/core: Introduce new fast registration API
IB/mlx5: Remove dead fmr code
IB/mlx5: Support the new memory registration API
IB/mlx4: Support the new memory registration API
RDMA/ocrdma: Support the new mem
.
This API will allow ULPs to remove the duplicated code of constructing
a page vector from a given sg list.
The send work request ib_reg_wr also shrinks as it will contain only
mr, key and access flags in addition.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Christoph Hell
Instead of maintaining a fastreg page list, keep an sg table
and convert an array of pages to a sg list. Then call ib_map_mr_sg
and construct ib_reg_wr.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
Tested-by: Steve Wise <sw...@opengr
, length, access flags (ib_mr)
- page array (mlx4_ib_mr)
- key (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/
Get rid of fast_reg page list and its construction.
Instead, just pass the RDS sg list to ib_map_mr_sg
and post the new ib_reg_wr.
This is done both for server IW RDMA_READ registration
and the client remote key registration.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Chr
Just function declarations - no need for those
laying arround. If for some reason someone will want
FMR support in mlx5, it should be easy enough to restore
a few structs.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.c
)
- page array (nes_mr)
- key, access flags (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/nes/nes_v
(c4iw_mr)
- key, access flags (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
Tested-by: Steve Wise <sw...@opengridcomputing.co
(iwch_mr)
- key, access flags (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/cxgb3/iwch_pro
No ULP uses it anymore, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/mlx4/cq.c | 3 +--
drivers/infiniband/hw/mlx4/main.c| 2 --
drivers/infiniband/hw/mlx4/ml
Remove fastreg page list allocation as the page vector
is now private to the provider. Instead of constructing
the page list and fast_req work request, call ib_map_mr_sg
and construct ib_reg_wr.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h.
(qib_mr)
- key, access flags (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/qib/qib_
No ULP uses it anymore, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/qib/qib_keys.c | 56 ---
drivers/infiniband/hw/qib/qib_mr.c| 32 +
No ULP uses it anymore, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/nes/nes_hw.h| 6 --
drivers/infiniband/hw/nes/nes_verbs.c | 162 +-
2 file
can benefit greatly as as it would reduce
the length of the HW descriptors array.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Reviewed-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --g
No ULP uses it anymore, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/cxgb3/iwch_cq.c | 2 +-
drivers/infiniband/hw/cxgb3/iwch_provider.c | 24 ---
drivers/infinib
This is a preparation patch for the new registration API
conversion. It splits srp_map_sg per registration strategy
(srp_map_sg[fmr|fr|dma]. On its own it adds some code duplication,
but it makes the API switch easier to comprehend.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
boundary
- or, bounce buffer SG_IOs that are not aligned to the virtual boundary
Since iser is working in 4K page size, set the virt_boundary to
4K pages. With this setting, we can now safely remove the bounce
buffering logic in iser.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Re
net_device *dev = mcast->dev;
int tx_dropped = 0;
Hey Christoph,
Thanks for the quick patch. When you re-spin this as
a proper patch you can add my:
Tested-by: Sagi Grimberg <sa...@mellanox.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma"
Hey,
I stepped on this lockdep circular locking complaint on 4.3-rc when
unloading the device driver (mlx5 in my case). Has anyone seen this?
I have seen such warnings with kernfs_mutex when deleting iscsi
devices on the fly.
I wander if kernfs_remove() should use mutex_lock_nested?
output:
On 10/12/2015 9:57 AM, Christoph Hellwig wrote:
This patch gets rid of struct ib_device_attr and cleans up drivers nicely.
It goes on top of my send_wr cleanups and the memory registration udpates
from Sagi.
Changes since V1:
- rebased on top of the Sagi's latest reg_api.6 branch
, length, access flags (ib_mr)
- page array (mlx4_ib_mr)
- key (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/
n't supported
anyway). I assume that the correct place to get the support back would
be in a shared SW library (hfi1, qib, rxe).
- Updated the change logs
The code is available at: https://github.com/sagigrimberg/linux/tree/reg_api.6
Sagi Grimberg (26):
IB/core: Introduce new fast registration
Instead of constructing a page list, call ib_map_mr_sg
and post a new ib_reg_wr. srp_map_finish_fr now returns
the number of sg elements registered.
Remove srp_finish_mapping since no one is calling it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Bart Van Assche <ba
Just function declarations - no need for those
laying arround. If for some reason someone will want
FMR support in mlx5, it should be easy enough to restore
a few structs.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.c
No callers left, remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Bart Van Assche <bart.vanass...@sandisk.com>
---
drivers/infiniband/ulp/srp/ib_srp.c | 10 --
1 file changed, 10 deletions(-)
diff --git a/drivers/infiniband/ulp/srp/ib_srp.c
b/driver
, length, access flags (ib_mr)
- page array (mlx5_ib_mr)
- key (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/mlx5/cq
No callers and no providers left, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/core/verbs.c | 25 ---
include/rdma/ib_verbs.h | 54
(c4iw_mr)
- key, access flags (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
Tested-by: Steve Wise <sw...@opengridcomputing.co
Get rid of fast_reg page list and its construction.
Instead, just pass the RDS sg list to ib_map_mr_sg
and post the new ib_reg_wr.
This is done both for server IW RDMA_READ registration
and the client remote key registration.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Chr
The new fast registration API does not reuqire a page vector
so we can't avoid allocating it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Bart Van Assche <bart.vanass...@sandisk.com>
---
drivers/infiniband/ulp/srp/ib_srp.c | 20 +++-
1 file changed, 1
Instead of maintaining a fastreg page list, keep an sg table
and convert an array of pages to a sg list. Then call ib_map_mr_sg
and construct ib_reg_wr.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
Tested-by: Steve Wise <sw...@opengr
No ULP uses it anymore, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/cxgb3/iwch_cq.c | 2 +-
drivers/infiniband/hw/cxgb3/iwch_provider.c | 24 ---
drivers/infinib
No ULP uses it anymore, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/ocrdma/ocrdma_main.c | 2 -
drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 104 +---
driver
No ULP uses it anymore, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/nes/nes_hw.h| 6 --
drivers/infiniband/hw/nes/nes_verbs.c | 162 +-
2 file
No ULP uses it anymore, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/mlx4/cq.c | 3 +--
drivers/infiniband/hw/mlx4/main.c| 2 --
drivers/infiniband/hw/mlx4/ml
No ULP uses it anymore, go ahead and remove it.
Keep only the local invalidate part of the handlers.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/mlx5/cq.c | 3 --
drivers/infiniband/hw/mlx5/main.c|
Remove fastreg page list allocation as the page vector
is now private to the provider. Instead of constructing
the page list and fast_req work request, call ib_map_mr_sg
and construct ib_reg_wr.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h.
No ULP uses it anymore, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/qib/qib_keys.c | 56 ---
drivers/infiniband/hw/qib/qib_mr.c| 32 +
This is a preparation patch for the new registration API
conversion. It splits srp_map_sg per registration strategy
(srp_map_sg[fmr|fr|dma]. On its own it adds some code duplication,
but it makes the API switch easier to comprehend.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
(ib_mr)
- page array (ocrdma_mr)
- key (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/ocrdma/ocrdma.h |
)
- page array (nes_mr)
- key, access flags (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/nes/nes_v
.
This API will allow ULPs to remove the duplicated code of constructing
a page vector from a given sg list.
The send work request ib_reg_wr also shrinks as it will contain only
mr, key and access flags in addition.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Christoph Hell
(iwch_mr)
- key, access flags (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/cxgb3/iwch_pro
(qib_mr)
- key, access flags (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/qib/qib_
On 10/10/2015 10:33 PM, Or Gerlitz wrote:
On Sat, Oct 10, 2015 at 3:27 AM, Sagi Grimberg <sa...@mellanox.com> wrote:
The block layer reliably enforces no SG lists with gaps
to a 4k virtual boundary so we can completely remove the
entire bounce buffering logic.
Hi Sagi,
Hey Or,
but with arbitrary SG list support it will benefit greatly.
Y? please put some wording here to clarify.
Well, because when a device will accept true SG lists then
it would benefit the HCA caching/fetching to have less SG elements.
I'll add a sentence to the change log.
--
To unsubscribe from
By limiting the sg lists that we are allowing to meet
and 4k virtual boundary, we can completely remove the
entire bounce buffering logic.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Reviewed-by: Christoph Hellwig <h...@lst.de>
Cc: Jens Axboe <ax...@kernel.dk>
Cc:
iser can handle it and it can dramatically reduce the
number of SG elements. It doesn't make much of a difference at
the moment, but with arbitrary SG list support it will benefit
greatly.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 2
.
Changes from v0:
- Added Reviewed-by tags
- Fixed patch (1) title
Sagi Grimberg (2):
iser: set block queue_virt_boundary
IB/iser: Enable SG clustering
drivers/infiniband/ulp/iser/iscsi_iser.c | 14 +-
drivers/infiniband/ulp/iser/iscsi_iser.h | 7 +-
drivers/infiniband/ulp/iser
Yes. I'm seeing this too. The last time this popped up I fixed it by
adding the code for reaping ahs. I suspect that the new code to timeout
sendonly multicast joins combined with us now creating and joining what
used to be sendonly groups is the likely culprit here.
Is someone looking at
On 10/11/2015 6:35 PM, Sagi Grimberg wrote:
iser can handle it and it can dramatically reduce the
number of SG elements. It doesn't make much of a difference at
the moment, but with arbitrary SG list support it will benefit
greatly.
Bahh, I updated the change-log in the previous revision
On 9/24/2015 4:35 PM, Christoph Hellwig wrote:
On Thu, Sep 24, 2015 at 08:41:17AM +0300, Or Gerlitz wrote:
We had a smaller volume move to cache the device attributes on the IB
device structure, and I just
realized it was dropped on the floor. Ira, that was a reviewer comment you
got when
What happens now when an app wants to use 1K, 2K, 3K IOs? they can
only use 1/4, 1/2 or 3/4 of the available memory for these
transactions?
What? I'm not sure what you are talking about. what available memory?
and we are going to fix it with devices like mlx5 over
the new API you're
I can do a rebase to whatever you want. Initially this was
over your reg_api branch. Is a rebase to the latest reg_api.6
fine?
That would be great.
Sagi.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majord...@vger.kernel.org
More
out_list_err:
- rc = PTR_ERR(f->fr_pgl);
+ rc = -ENOMEM;
dprintk("RPC: %s: ib_alloc_fast_reg_page_list status %i\n”,
Should you update this debugging message?
Yes I will.
+ n = ib_map_mr_sg(mr, frmr->sg, frmr->sg_nents, PAGE_SIZE);
+ if (unlikely(n !=
The block layer reliably enforces no SG lists with gaps
to a 4k virtual boundary so we can completely remove the
entire bounce buffering logic.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 12 +-
drivers/infiniband/ulp/iser/iscsi_
.
Sagi Grimberg (2):
iser: set block queue_virt_boundary
IB/iser: Enable SG clustering
drivers/infiniband/ulp/iser/iscsi_iser.c | 14 +-
drivers/infiniband/ulp/iser/iscsi_iser.h | 7 +-
drivers/infiniband/ulp/iser/iser_initiator.c | 51 +
drivers/infiniband/ulp/iser/iser_memory.c
iser can handle it and it can dramatically reduce the
number of SG elements. It doesn't make much of a difference at
the moment, but with arbitrary SG list support it will benefit
greatly.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
---
drivers/infiniband/ulp/iser/iscsi_iser.c | 2
On 10/8/2015 11:01 AM, Christoph Hellwig wrote:
On Thu, Oct 08, 2015 at 10:50:43AM +0300, Sagi Grimberg wrote:
- Rebased against Doug's for-4.4 tree (4.3.0-rc1) + 4.3-rc fixes
Does this means its not on top of the send_wr changes now? I'm fine
with that as I think your series is even more
Instead of maintaining a fastreg page list, keep an sg table
and convert an array of pages to a sg list. Then call ib_map_mr_sg
and construct ib_reg_wr.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
Tested-by: Steve Wise <sw...@opengr
)
- page array (nes_mr)
- key, access flags (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/nes/nes_v
, length, access flags (ib_mr)
- page array (mlx5_ib_mr)
- key (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/mlx5/cq
(ib_mr)
- page array (ocrdma_mr)
- key (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/ocrdma/ocrdma.h |
uld
be in a shared SW library (hfi1, qib, rxe).
- Updated the change logs
The code is available at: https://github.com/sagigrimberg/linux/tree/reg_api.6
Sagi Grimberg (26):
IB/core: Introduce new fast registration API
IB/mlx5: Remove dead fmr code
IB/mlx5: Support the new memory registration API
IB/m
=143677002622296=2).
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
Tested-by: Steve Wise <sw...@opengridcomputing.com>
Tested-by: Selvin Xavier <selvin.xav...@avagotech.com>
---
net/sunrpc/xp
(iwch_mr)
- key, access flags (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/cxgb3/iwch_pro
Just function declarations - no need for those
laying arround. If for some reason someone will want
FMR support in mlx5, it should be easy enough to restore
a few structs.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Reviewed-by: Bart Van Assche <bart.vanass...@sandisk.c
No ULP uses it anymore, go ahead and remove it.
Keep only the local invalidate part of the handlers.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/mlx5/cq.c | 3 --
drivers/infiniband/hw/mlx5/main.c|
No ULP uses it anymore, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/mlx4/cq.c | 3 +--
drivers/infiniband/hw/mlx4/main.c| 2 --
drivers/infiniband/hw/mlx4/ml
Get rid of fast_reg page list and its construction.
Instead, just pass the RDS sg list to ib_map_mr_sg
and post the new ib_reg_wr.
This is done both for server IW RDMA_READ registration
and the client remote key registration.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Chr
(qib_mr)
- key, access flags (ib_reg_wr)
The IB_WR_FAST_REG_MR handlers will be removed later when
all the ULPs will be converted.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/qib/qib_
No ULP uses it anymore, go ahead and remove it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h...@lst.de>
---
drivers/infiniband/hw/qib/qib_keys.c | 56 ---
drivers/infiniband/hw/qib/qib_mr.c| 32 +
Instead of constructing a page list, call ib_map_mr_sg
and post a new ib_reg_wr. srp_map_finish_fr now returns
the number of sg elements registered.
Remove srp_finish_mapping since no one is calling it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Bart Van Assche <ba
This is a preparation patch for the new registration API
conversion. It splits srp_map_sg per registration strategy
(srp_map_sg[fmr|fr|dma]. On its own it adds some code duplication,
but it makes the API switch easier to comprehend.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
The new fast registration API does not reuqire a page vector
so we can't avoid allocating it.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Bart Van Assche <bart.vanass...@sandisk.com>
---
drivers/infiniband/ulp/srp/ib_srp.c | 20 +++-
1 file changed, 1
Remove fastreg page list allocation as the page vector
is now private to the provider. Instead of constructing
the page list and fast_req work request, call ib_map_mr_sg
and construct ib_reg_wr.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Acked-by: Christoph Hellwig <h.
.
This API will allow ULPs to remove the duplicated code of constructing
a page vector from a given sg list.
The send work request ib_reg_wr also shrinks as it will contain only
mr, key and access flags in addition.
Signed-off-by: Sagi Grimberg <sa...@mellanox.com>
Tested-by: Christoph Hell
201 - 300 of 1199 matches
Mail list logo
