Re: [PATCH v3 07/28] IB/Verbs: Reform IB-ulp ipoib

2015-04-13 Thread ira.weiny
On Mon, Apr 13, 2015 at 01:27:01PM -0600, Jason Gunthorpe wrote: On Mon, Apr 13, 2015 at 02:25:16PM +0200, Michael Wang wrote: dev_list = kmalloc(sizeof *dev_list, GFP_KERNEL); if (!dev_list) @@ -1673,13 +1671,19 @@ static void ipoib_add_one(struct ib_device *device) }

Re: [PATCH v2 01/17] IB/Verbs: Implement new callback query_transport() for each HW

2015-04-10 Thread ira.weiny
On Fri, Apr 10, 2015 at 12:04:55PM -0600, Jason Gunthorpe wrote: On Fri, Apr 10, 2015 at 01:38:38PM -0400, ira.weiny wrote: I don't think that is appropriate. You have been advocating that the checks be clear as to what support we need. Right, but this is narrow, and we

Re: [PATCH v2 01/17] IB/Verbs: Implement new callback query_transport() for each HW

2015-04-10 Thread ira.weiny
On Fri, Apr 10, 2015 at 01:17:23PM -0600, Jason Gunthorpe wrote: On Fri, Apr 10, 2015 at 02:24:26PM -0400, Doug Ledford wrote: IPoIB is more than just an ULP. It's a spec. And it's very IB specific. It will only work with OPA because OPA is imitating IB. To run it on another fabric,

Re: [PATCH v4 12/19] IB/mad: Add MAD size parameters to process_mad

2015-04-08 Thread ira.weiny
On Tue, Apr 07, 2015 at 11:53:00AM -0600, Hefty, Sean wrote: Rather than calling device-process_mad() directly, would it be better to call a common function? So we can avoid adding: + struct ib_mad *in_mad = (struct ib_mad *)in; + struct ib_mad *out_mad = (struct

Re: [PATCH v4 02/19] IB/core: Cache device attributes for use by upper level drivers

2015-04-08 Thread ira.weiny
On Mon, Apr 06, 2015 at 04:43:01PM -0600, Hefty, Sean wrote: I understand your point and I originally called this attributes but it was suggested to call it cached_dev_attrs. https://www.mail-archive.com/linux-rdma%40vger.kernel.org/msg22486.html I can change it back if we are all

Re: [PATCH v4 15/19] IB/mad: Create jumbo_mad data structures

2015-04-08 Thread ira.weiny
On Fri, Apr 03, 2015 at 05:08:53PM -0600, Hefty, Sean wrote: Define jumbo_mad and jumbo_rmpp_mad. I would just use 'opa_mad' in place of 'jumbo_mad'. Jumbo sounds like a marketing term or elephant name. Done in v5. Jumbo MAD structures are 2K versions of ib_mad and ib_rmpp_mad

Re: [PATCH v4 18/19] IB/mad: Implement Intel Omni-Path Architecture SMP processing

2015-04-08 Thread ira.weiny
On Fri, Apr 03, 2015 at 05:47:49PM -0600, Hefty, Sean wrote: @@ -236,6 +252,24 @@ enum smi_action smi_handle_dr_smp_recv(struct ib_smp *smp, u8 node_type, smp-dr_slid == IB_LID_PERMISSIVE); } +/* + * Adjust information for a received SMP + *

Re: [PATCH v4 19/19] IB/mad: Implement Intel Omni-Path Architecture MAD processing

2015-04-08 Thread ira.weiny
On Tue, Apr 07, 2015 at 11:19:20AM -0600, Jason Gunthorpe wrote: On Tue, Apr 07, 2015 at 05:15:07PM +, Hefty, Sean wrote: IMO, a MAD should be self-identifying. A MAD is self-identifying (contains versions and classes). IBoE CM MADs are a sub-set of the IB MADs. As are the PMA MADs

Re: [PATCH v4 12/19] IB/mad: Add MAD size parameters to process_mad

2015-04-07 Thread ira.weiny
On Fri, Apr 03, 2015 at 04:40:20PM -0600, Hefty, Sean wrote: -static struct ib_mad_private *alloc_mad_priv(struct ib_device *dev) +static struct ib_mad_private *alloc_mad_priv(struct ib_device *dev, +size_t *mad_size) { + *mad_size =

Re: [RFC PATCH 00/11] IB/Verbs: IB Management Helpers

2015-04-06 Thread ira.weiny
On Fri, Mar 27, 2015 at 04:39:54PM +0100, Michael Wang wrote: There are plenty of lengthy code to check the transport type of IB device, or the link layer type of it's port, but actually we are just speculating whether a particular management is supported by the device/port. Michael, There

Re: [PATCH v4 02/19] IB/core: Cache device attributes for use by upper level drivers

2015-04-06 Thread ira.weiny
On Fri, Apr 03, 2015 at 02:43:46PM -0600, Hefty, Sean wrote: diff --git a/include/rdma/ib_verbs.h b/include/rdma/ib_verbs.h index 0d74f1d..0116e4b 100644 --- a/include/rdma/ib_verbs.h +++ b/include/rdma/ib_verbs.h @@ -1675,6 +1675,7 @@ struct ib_device { u32

Re: [PATCH v4 14/19] IB/core: Add IB_DEVICE_OPA_MAD_SUPPORT device cap flag

2015-04-02 Thread ira.weiny
On Wed, Mar 25, 2015 at 11:30:32AM +0100, Michael Wang wrote: Hi, Sean On 03/24/2015 01:49 PM, Michael Wang wrote: On 03/23/2015 05:31 PM, Hefty, Sean wrote: [snip] To restate my suggesting, I was thinking of defining something like this: enum { IB_MGMT_PROTO_SM = (1 0), /*

Re: [PATCH for-next 0/9] mlx4 changes in virtual GID management

2015-04-02 Thread ira.weiny
On Thu, Apr 02, 2015 at 05:32:53PM +0300, Or Gerlitz wrote: On Wed, Apr 1, 2015 at 12:33 AM, Hefty, Sean sean.he...@intel.com wrote: [snip] Your claim says more or less don't touch the good old include/rdma/ib_verbs.h from 2.6.12, just add new low-level drivers -- this is very close to

Re: [PATCH] ib_ipoib: Scatter-Gather support in connected mode

2015-04-01 Thread ira.weiny
On Mon, Mar 23, 2015 at 11:17:49AM -0600, Jason Gunthorpe wrote: On Sun, Mar 22, 2015 at 11:21:50AM +0200, Yuval Shaia wrote: On Sun, Mar 15, 2015 at 05:16:16PM +0200, Yuval Shaia wrote: Hi, I didn't got any further comments on this one. Any idea why SG in CM is un-welcome? By

Re: [RFC PATCH 06/11] IB/Verbs: Use management helper has_sa() and cap_sa(), for sa-check

2015-03-31 Thread ira.weiny
On Tue, Mar 31, 2015 at 05:12:02PM -0600, Jason Gunthorpe wrote: On Mon, Mar 30, 2015 at 01:02:03PM -0400, Doug Ledford wrote: If we use something like this, then the above is all you need. Then every place in the code that checks for something like has_sa or cap_sa can be replaced with

Re: [PATCH 0/9] IB/ipoib: fixup multicast locking issues

2015-03-31 Thread ira.weiny
On Sun, Mar 15, 2015 at 11:52:44AM -0700, Doug Ledford wrote: On Mar 13, 2015, at 1:41 AM, Or Gerlitz gerlitz...@gmail.com wrote: On Sun, Feb 22, 2015 at 2:26 AM, Doug Ledford dledf...@redhat.com wrote: This is the re-ordered, squashed version of my 22 patch set that I posted on Feb

Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check

2015-03-30 Thread ira.weiny
On Mon, Mar 30, 2015 at 06:20:48PM +0200, Michael Wang wrote: On 03/30/2015 06:11 PM, Doug Ledford wrote: On Fri, 2015-03-27 at 16:46 +0100, Michael Wang wrote: Introduce helper has_mcast() and cap_mcast() to help us check if an IB device or it's port support Multicast. This probably

Re: [RFC PATCH 06/11] IB/Verbs: Use management helper has_sa() and cap_sa(), for sa-check

2015-03-27 Thread ira.weiny
On Fri, Mar 27, 2015 at 04:46:11PM +0100, Michael Wang wrote: Introduce helper has_sa() and cap_sa() to help us check if an IB device or it's port support Subnet Administrator. I think these 2 should be combined. The question is if a port requires the use of the SA depending on the network

Re: [RFC PATCH 07/11] IB/Verbs: Use management helper has_mcast() and, cap_mcast() for mcast-check

2015-03-27 Thread ira.weiny
On Fri, Mar 27, 2015 at 10:28:20AM -0600, Jason Gunthorpe wrote: On Fri, Mar 27, 2015 at 04:46:57PM +0100, Michael Wang wrote: Introduce helper has_mcast() and cap_mcast() to help us check if an IB device or it's port support Multicast. Cc: Jason Gunthorpe

Re: [RFC PATCH 08/11] IB/Verbs: Use management helper has_iwarp() for, iwarp-check

2015-03-27 Thread ira.weiny
On Fri, Mar 27, 2015 at 10:13:19AM -0600, Jason Gunthorpe wrote: On Fri, Mar 27, 2015 at 04:47:36PM +0100, Michael Wang wrote: Introduce helper has_iwarp() to help us check if an IB device support IWARP protocol. Should probably be !has_rdma_read_sges() True if the device can handle

<    1   2   3