Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-24 Thread Or Gerlitz
On 12/24/2015 9:57 AM, Matan Barak wrote: I totally agree that it's better to use the local IP address and not just get a random device by using 127.0.0.1. You could get a specific device by binding it, but then - use its local IP instead of 127.0.0.1. Yes guys, it might be better but the user

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-23 Thread Matan Barak
On Wed, Dec 23, 2015 at 6:08 PM, Doug Ledford wrote: > On 12/22/2015 02:26 PM, Matan Barak wrote: >> On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford wrote: >>> On 12/22/2015 05:47 AM, Or Gerlitz wrote: On 12/21/2015 5:01 PM, Matan Barak wrote: >

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-23 Thread Doug Ledford
On 12/22/2015 02:26 PM, Matan Barak wrote: > On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford wrote: >> On 12/22/2015 05:47 AM, Or Gerlitz wrote: >>> On 12/21/2015 5:01 PM, Matan Barak wrote: Previously, cma_match_net_dev called cma_protocol_roce which tried to verify

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-23 Thread Matan Barak
On Wed, Dec 23, 2015 at 6:08 PM, Doug Ledford wrote: > On 12/22/2015 02:26 PM, Matan Barak wrote: >> On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford wrote: >>> On 12/22/2015 05:47 AM, Or Gerlitz wrote: On 12/21/2015 5:01 PM, Matan Barak wrote: >

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-23 Thread Doug Ledford
On 12/23/2015 11:35 AM, Matan Barak wrote: > On Wed, Dec 23, 2015 at 6:08 PM, Doug Ledford wrote: >> On 12/22/2015 02:26 PM, Matan Barak wrote: >>> On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford wrote: On 12/22/2015 05:47 AM, Or Gerlitz wrote: >

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-23 Thread Matan Barak
On Wed, Dec 23, 2015 at 7:57 PM, Doug Ledford wrote: > On 12/23/2015 11:35 AM, Matan Barak wrote: >> On Wed, Dec 23, 2015 at 6:08 PM, Doug Ledford wrote: >>> On 12/22/2015 02:26 PM, Matan Barak wrote: On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-23 Thread Sagi Grimberg
FWIW, looks good to me, Reviewed-by: Sagi Grimberg -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-22 Thread Doug Ledford
On 12/22/2015 05:47 AM, Or Gerlitz wrote: > On 12/21/2015 5:01 PM, Matan Barak wrote: >> Previously, cma_match_net_dev called cma_protocol_roce which >> tried to verify that the IB device uses RoCE protocol. However, >> if rdma_id didn't have a bounded port, it used the first port >> of the

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-22 Thread Matan Barak
On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford wrote: > On 12/22/2015 05:47 AM, Or Gerlitz wrote: >> On 12/21/2015 5:01 PM, Matan Barak wrote: >>> Previously, cma_match_net_dev called cma_protocol_roce which >>> tried to verify that the IB device uses RoCE protocol. However,

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-22 Thread Doug Ledford
On 12/22/2015 02:26 PM, Matan Barak wrote: > On Tue, Dec 22, 2015 at 8:58 PM, Doug Ledford wrote: >> On 12/22/2015 05:47 AM, Or Gerlitz wrote: >>> On 12/21/2015 5:01 PM, Matan Barak wrote: Previously, cma_match_net_dev called cma_protocol_roce which tried to verify

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-22 Thread Or Gerlitz
On 12/21/2015 5:01 PM, Matan Barak wrote: Previously, cma_match_net_dev called cma_protocol_roce which tried to verify that the IB device uses RoCE protocol. However, if rdma_id didn't have a bounded port, it used the first port of the device. In VPI systems, the first port might be an IB port

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-22 Thread Or Gerlitz
On 12/22/2015 9:17 AM, Or Gerlitz wrote: On 12/21/2015 5:01 PM, Matan Barak wrote: This patch fixes a bug in VPI systems, where the first port is configured as IB and the second one is configured as Ethernet. In this case, if the rdma_id isn't bounded to a port, cma_match_net_dev will try to

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-21 Thread Or Gerlitz
On 12/21/2015 5:01 PM, Matan Barak wrote: Previously, cma_match_net_dev called cma_protocol_roce which tried to verify that the IB device uses RoCE protocol. However, if rdma_id didn't have a bounded port, it used the first port of the device. maybe prefer a higher then code speak language e.g

Re: [PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-21 Thread Or Gerlitz
On 12/21/2015 5:01 PM, Matan Barak wrote: This patch fixes a bug in VPI systems, where the first port is configured as IB and the second one is configured as Ethernet. In this case, if the rdma_id isn't bounded to a port, cma_match_net_dev will try to verify that the first port is a RoCE port

[PATCH] IB/cma: cma_match_net_dev needs to take into account port_num

2015-12-21 Thread Matan Barak
Previously, cma_match_net_dev called cma_protocol_roce which tried to verify that the IB device uses RoCE protocol. However, if rdma_id didn't have a bounded port, it used the first port of the device. In VPI systems, the first port might be an IB port while the second one could be an Ethernet