Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-30 Thread Wengang
于 2014年12月30日 12:25, David Miller 写道: From: Wengang wen.gang.w...@oracle.com Date: Tue, 30 Dec 2014 11:01:42 +0800 There are more than one way we do things. For this case, considering needs, complexity and stability I think moving ipoib_header_ops is the right way to go. I completely

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-29 Thread David Miller
From: Wengang wen.gang.w...@oracle.com Date: Mon, 29 Dec 2014 15:11:32 +0800 So, what information else do you need? I need a patch formally (re-)submitted. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-29 Thread Wengang
于 2014年12月30日 05:32, Cong Wang 写道: On Mon, Nov 24, 2014 at 9:36 PM, Wengang Wang wen.gang.w...@oracle.com wrote: When last slave of a bonding master is removed, the bonding then does not work. At the time if packet_snd is called against with a master net_device, it calls then header_ops-create

[PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-29 Thread Wengang Wang
When last slave of a bonding master is removed, the bonding then does not work. At the time if packet_snd is called against with a master net_device, it calls then header_ops-create which points to slave's header_ops. In case the slave is ipoib and the module is unloaded, header_ops would point to

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-29 Thread David Miller
From: Wengang Wang wen.gang.w...@oracle.com Date: Tue, 30 Dec 2014 11:04:42 +0800 When last slave of a bonding master is removed, the bonding then does not work. At the time if packet_snd is called against with a master net_device, it calls then header_ops-create which points to slave's

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-29 Thread David Miller
From: Wengang wen.gang.w...@oracle.com Date: Tue, 30 Dec 2014 11:01:42 +0800 There are more than one way we do things. For this case, considering needs, complexity and stability I think moving ipoib_header_ops is the right way to go. I completely disagree, it's a gross hack at best. It's

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-28 Thread Wengang
Hi David, This is a real case not a potential crash. The call stack is like this: crash bt PID: 47323 TASK: 881722954140 CPU: 13 COMMAND: arping #0 [881518437860] machine_kexec at 8103aac9 #1 [8815184378d0] crash_kexec at 810b9943 #2 [8815184379a0] oops_end at

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-21 Thread Wengang
Hi, Anyone please review this patch? David? Jay? please. thanks, wengang 于 2014年12月15日 09:12, Wengang 写道: Anyone please respond to this? thanks, wengang 于 2014年12月03日 09:50, Wengang Wang 写道: Hi David and Jay, Then about about the change in this patch? thanks, wengang 在 2014年11月26日 09:30,

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-14 Thread Wengang
Anyone please respond to this? thanks, wengang 于 2014年12月03日 09:50, Wengang Wang 写道: Hi David and Jay, Then about about the change in this patch? thanks, wengang 在 2014年11月26日 09:30, Wengang 写道: 于 2014年11月26日 02:44, David Miller 写道: From: Jay Vosburgh jay.vosbu...@canonical.com Date: Tue,

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-12-02 Thread Wengang Wang
Hi David and Jay, Then about about the change in this patch? thanks, wengang 在 2014年11月26日 09:30, Wengang 写道: 于 2014年11月26日 02:44, David Miller 写道: From: Jay Vosburgh jay.vosbu...@canonical.com Date: Tue, 25 Nov 2014 10:41:17 -0800 Or Gerlitz ogerl...@mellanox.com wrote: On 11/25/2014

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-11-25 Thread Jay Vosburgh
Or Gerlitz ogerl...@mellanox.com wrote: On 11/25/2014 8:07 AM, David Miller wrote: IPOIB should not work over bonding as it requires that the device use ARPHRD_ETHER. Hi Dave, IPoIB devices can be enslaved to both bonding and teaming in their HA mode, the bond device type becomes

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-11-25 Thread David Miller
From: Jay Vosburgh jay.vosbu...@canonical.com Date: Tue, 25 Nov 2014 10:41:17 -0800 Or Gerlitz ogerl...@mellanox.com wrote: On 11/25/2014 8:07 AM, David Miller wrote: IPOIB should not work over bonding as it requires that the device use ARPHRD_ETHER. Hi Dave, IPoIB devices can be enslaved

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-11-25 Thread Wengang
于 2014年11月26日 02:44, David Miller 写道: From: Jay Vosburgh jay.vosbu...@canonical.com Date: Tue, 25 Nov 2014 10:41:17 -0800 Or Gerlitz ogerl...@mellanox.com wrote: On 11/25/2014 8:07 AM, David Miller wrote: IPOIB should not work over bonding as it requires that the device use ARPHRD_ETHER.

[PATCH] bonding: move ipoib_header_ops to vmlinux

2014-11-24 Thread Wengang Wang
When last slave of a bonding master is removed, the bonding then does not work. At the time if packet_snd is called against with a master net_device, it calls then header_ops-create which points to slave's header_ops. In case the slave is ipoib and the module is unloaded, header_ops would point to

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-11-24 Thread David Miller
From: Wengang Wang wen.gang.w...@oracle.com Date: Tue, 25 Nov 2014 13:36:08 +0800 When last slave of a bonding master is removed, the bonding then does not work. At the time if packet_snd is called against with a master net_device, it calls then header_ops-create which points to slave's

Re: [PATCH] bonding: move ipoib_header_ops to vmlinux

2014-11-24 Thread Or Gerlitz
On 11/25/2014 8:07 AM, David Miller wrote: IPOIB should not work over bonding as it requires that the device use ARPHRD_ETHER. Hi Dave, IPoIB devices can be enslaved to both bonding and teaming in their HA mode, the bond device type becomes ARPHRD_INFINIBAND when this happens. Or. -- To