Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-09-01 Thread Sasha Khapyorsky
On 16:14 Thu 26 Aug , Doron Shoham wrote: add '-f' flag to show full information (ports' speed and witdh). mainly to work with ibsim (using links real speed and width). Signed-off-by: Doron Shoham dor...@voltaire.com Applied. Thanks. Sasha -- To unsubscribe from this list: send the line

Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-09-01 Thread Sasha Khapyorsky
On 17:18 Tue 31 Aug , Eli Dorfman (Voltaire) wrote: Sasha Khapyorsky wrote: On 09:45 Tue 24 Aug , Hal Rosenstock wrote: What about the flag? do we still need it if we pass the output after the comment? I wouldn't think so. I also think we've made commentary changes to the

Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-08-31 Thread Eli Dorfman (Voltaire)
Sasha Khapyorsky wrote: On 09:45 Tue 24 Aug , Hal Rosenstock wrote: What about the flag? do we still need it if we pass the output after the comment? I wouldn't think so. I also think we've made commentary changes to the ibnetdiscover output format like this before. If we wanted to be

Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-08-31 Thread Hal Rosenstock
On Tue, Aug 31, 2010 at 10:18 AM, Eli Dorfman (Voltaire) dorfman@gmail.com wrote: Sasha Khapyorsky wrote: On 09:45 Tue 24 Aug     , Hal Rosenstock wrote: What about the flag? do we still need it if we pass the output after the comment? I wouldn't think so. I also think we've made

Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-08-26 Thread Hal Rosenstock
On Thu, Aug 26, 2010 at 3:43 AM, Doron Shoham dor...@voltaire.com wrote: add '-f' flag to show full information (ports' speed and witdh). mainly to work with ibsim (using links real speed and width). Just a couple of (output formatting) nits below... Signed-off-by: Doron Shoham

Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-08-26 Thread Doron Shoham
add '-f' flag to show full information (ports' speed and witdh). mainly to work with ibsim (using links real speed and width). Signed-off-by: Doron Shoham dor...@voltaire.com --- infiniband-diags/src/ibnetdiscover.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff

Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-08-25 Thread Sasha Khapyorsky
On 09:45 Tue 24 Aug , Hal Rosenstock wrote: What about the flag? do we still need it if we pass the output after the comment? I wouldn't think so. I also think we've made commentary changes to the ibnetdiscover output format like this before. If we wanted to be absolutely sure it

Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-08-24 Thread Doron Shoham
On 08/24/2010 07:03 AM, Sasha Khapyorsky wrote: On 11:30 Wed 18 Aug , Doron Shoham wrote: add '-f' flag to show full information (ports' speed and witdh). mainly to work with ibsim (using links real speed and width). Seems almost fine. However see the comments below. Signed-off-by:

Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-08-24 Thread Hal Rosenstock
On Tue, Aug 24, 2010 at 7:55 AM, Doron Shoham dor...@voltaire.com wrote: On 08/24/2010 07:03 AM, Sasha Khapyorsky wrote: On 11:30 Wed 18 Aug     , Doron Shoham wrote: add '-f' flag to show full information (ports' speed and witdh). mainly to work with ibsim (using links real speed and width).

Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-08-24 Thread Doron Shoham
On 08/24/2010 04:10 PM, Hal Rosenstock wrote: On Tue, Aug 24, 2010 at 7:55 AM, Doron Shoham dor...@voltaire.com wrote: On 08/24/2010 07:03 AM, Sasha Khapyorsky wrote: On 11:30 Wed 18 Aug , Doron Shoham wrote: add '-f' flag to show full information (ports' speed and witdh). mainly to work

Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-08-24 Thread Hal Rosenstock
On Tue, Aug 24, 2010 at 9:27 AM, Doron Shoham dor...@voltaire.com wrote: On 08/24/2010 04:10 PM, Hal Rosenstock wrote: On Tue, Aug 24, 2010 at 7:55 AM, Doron Shoham dor...@voltaire.com wrote: On 08/24/2010 07:03 AM, Sasha Khapyorsky wrote: On 11:30 Wed 18 Aug     , Doron Shoham wrote: add

Re: [PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-08-23 Thread Sasha Khapyorsky
On 11:30 Wed 18 Aug , Doron Shoham wrote: add '-f' flag to show full information (ports' speed and witdh). mainly to work with ibsim (using links real speed and width). Seems almost fine. However see the comments below. Signed-off-by: Doron Shoham dor...@voltaire.com ---

[PATCH] ibnetdiscover: add '-f' flag to show full information (ports' speed and width).

2010-08-18 Thread Doron Shoham
add '-f' flag to show full information (ports' speed and witdh). mainly to work with ibsim (using links real speed and width). Signed-off-by: Doron Shoham dor...@voltaire.com --- infiniband-diags/src/ibnetdiscover.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git