Re: [PATCH] mlx5: Expose correct page_size_cap in device attributes

2015-07-26 Thread Sagi Grimberg
On 7/24/2015 12:48 AM, Jason Gunthorpe wrote: On Thu, Jul 23, 2015 at 05:41:38PM -0400, Doug Ledford wrote: I assume this prevents the driver from working at all on certain arches (like ppc with 64k page size)? Nothing uses page_size_cap correctly, so it has no impact. Sagi, that is a good

Re: [PATCH] mlx5: Expose correct page_size_cap in device attributes

2015-07-24 Thread Doug Ledford
On 07/23/2015 05:48 PM, Jason Gunthorpe wrote: On Thu, Jul 23, 2015 at 05:41:38PM -0400, Doug Ledford wrote: I assume this prevents the driver from working at all on certain arches (like ppc with 64k page size)? Nothing uses page_size_cap correctly, so it has no impact. OK, then I'm going

Re: [PATCH] mlx5: Expose correct page_size_cap in device attributes

2015-07-23 Thread Jason Gunthorpe
On Thu, Jul 23, 2015 at 05:41:38PM -0400, Doug Ledford wrote: I assume this prevents the driver from working at all on certain arches (like ppc with 64k page size)? Nothing uses page_size_cap correctly, so it has no impact. Sagi, that is a good point, your generic code for the cleanup series

Re: [PATCH] mlx5: Expose correct page_size_cap in device attributes

2015-07-21 Thread Jason Gunthorpe
On Tue, Jul 21, 2015 at 02:40:12PM +0300, Sagi Grimberg wrote: Should be all the page sizes that are supported by the device. Reported-by: Jason Gunthorpe jguntho...@obsidianresearch.com Signed-off-by: Sagi Grimberg sa...@mellanox.com drivers/infiniband/hw/mlx5/main.c |3 ++- 1 files

[PATCH] mlx5: Expose correct page_size_cap in device attributes

2015-07-21 Thread Sagi Grimberg
Should be all the page sizes that are supported by the device. Reported-by: Jason Gunthorpe jguntho...@obsidianresearch.com Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/hw/mlx5/main.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git