Re: [PATCH] opensm/mcast_tbl: set max_mlid_ho as actually configured mlid

2009-11-02 Thread Sasha Khapyorsky
On 12:18 Mon 02 Nov , Hal Rosenstock wrote: Yet another (likely even more efficient) approach would be memset()ing MFTs in realloc function above requested mlid_offset, then we will be able to remove osm_mcast_tbl_clear_mlid() completely. Isn't mlid clearing done on a per mlid basis

Re: [PATCH] opensm/mcast_tbl: set max_mlid_ho as actually configured mlid

2009-11-02 Thread Sasha Khapyorsky
On 12:44 Mon 02 Nov , Hal Rosenstock wrote: clear_mlid could be implemented with memset rather than loop. Yes, memset() would be better. Sasha -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [PATCH] opensm/mcast_tbl: set max_mlid_ho as actually configured mlid

2009-10-30 Thread Hal Rosenstock
On Thu, Oct 29, 2009 at 3:19 PM, Sasha Khapyorsky sas...@voltaire.com wrote: Set switch's mcast table max_mlid_ho as actually configured mlid for the switch instead of a value extended to MFT block size aligned. This makes mlid handling checks to be more reliable. Signed-off-by: Sasha

Re: [PATCH] opensm/mcast_tbl: set max_mlid_ho as actually configured mlid

2009-10-30 Thread Sasha Khapyorsky
On 09:48 Fri 30 Oct , Hal Rosenstock wrote: diff --git a/opensm/opensm/osm_mcast_tbl.c b/opensm/opensm/osm_mcast_tbl.c index b5ae6f2..eee9290 100644 --- a/opensm/opensm/osm_mcast_tbl.c +++ b/opensm/opensm/osm_mcast_tbl.c @@ -122,7 +122,7 @@ int osm_mcast_tbl_realloc(IN

[PATCH] opensm/mcast_tbl: set max_mlid_ho as actually configured mlid

2009-10-29 Thread Sasha Khapyorsky
Set switch's mcast table max_mlid_ho as actually configured mlid for the switch instead of a value extended to MFT block size aligned. This makes mlid handling checks to be more reliable. Signed-off-by: Sasha Khapyorsky sas...@voltaire.com --- opensm/opensm/osm_mcast_tbl.c |5 +++-- 1 files

Re: [PATCH] opensm/mcast_tbl: set max_mlid_ho as actually configured mlid

2009-10-29 Thread Sasha Khapyorsky
Hi Ira, Thanks for reporting. On 15:44 Thu 29 Oct , Ira Weiny wrote: OpenSM $ mlid_ho 49152; p_tbl-max_mlid_ho 49152 mlid_ho 49154; p_tbl-max_mlid_ho 49153 opensm: osm_mcast_tbl.c:107: osm_mcast_tbl_set: Assertion `mlid_ho = p_tbl-max_mlid_ho' failed. Aborted (core dumped) Small