Re: [PATCH 26/37] IB/rdmavt: Move memory registration into rdmavt

2015-12-10 Thread Sagi Grimberg
/** @@ -83,7 +357,31 @@ struct ib_mr *rvt_reg_phys_mr(struct ib_pd *pd, int num_phys_buf, int acc, u64 *iova_start) { Why do we even bother with reg_phys_mr? Let's drop it entirely. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in

Re: [PATCH 26/37] IB/rdmavt: Move memory registration into rdmavt

2015-12-10 Thread Christoph Hellwig
On Thu, Dec 10, 2015 at 10:14:56AM -0500, Dennis Dalessandro wrote: > Why? Because, it exists in qib and hfi1. > > However, it seems no one is actually using this in the kernel these days and > the core support was removed in commit 1241d7bf. Yet the function pointer > still exists in struct

Re: [PATCH 26/37] IB/rdmavt: Move memory registration into rdmavt

2015-12-10 Thread Dennis Dalessandro
On Thu, Dec 10, 2015 at 04:24:44PM +0200, Sagi Grimberg wrote: /** @@ -83,7 +357,31 @@ struct ib_mr *rvt_reg_phys_mr(struct ib_pd *pd, int num_phys_buf, int acc, u64 *iova_start) { Why do we even bother with reg_phys_mr? Let's drop it entirely. Why?

[PATCH 26/37] IB/rdmavt: Move memory registration into rdmavt

2015-12-07 Thread Dennis Dalessandro
Use the memory registration routines in hfi1 and move them to rdmavt. A follow on patch will address removing the duplicated code in the hfi1 and qib drivers. Reviewed-by: Ira Weiny Reviewed-by: Mike Marciniszyn Signed-off-by: Dennis Dalessandro