Re: [PATCH 37/37] IB/rdmavt: Add support for new memory registration API

2015-12-17 Thread Christoph Hellwig
On Thu, Dec 17, 2015 at 10:52:29AM -0500, Dennis Dalessandro wrote: > I am not opposed to leaving the code in rdmavt. It gets removed from qib in > the other patch series I posted. My preference is to leave it in rdmavt > since it will be needed down the road. However I can go either way here, its

Re: [PATCH 37/37] IB/rdmavt: Add support for new memory registration API

2015-12-17 Thread Dennis Dalessandro
On Thu, Dec 17, 2015 at 08:35:53AM -0800, Christoph Hellwig wrote: On Thu, Dec 17, 2015 at 10:52:29AM -0500, Dennis Dalessandro wrote: I am not opposed to leaving the code in rdmavt. It gets removed from qib in the other patch series I posted. My preference is to leave it in rdmavt since it

Re: [PATCH 37/37] IB/rdmavt: Add support for new memory registration API

2015-12-17 Thread Dennis Dalessandro
On Wed, Dec 16, 2015 at 04:37:39PM +0200, Sagi Grimberg wrote: This patch exists to provide parity for what is in qib. Should we not have it? If not, why do we have: commit 38071a461f0a ("IB/qib: Support the new memory registration API") That was done by me because I saw this in qib and

Re: [PATCH 37/37] IB/rdmavt: Add support for new memory registration API

2015-12-16 Thread Dennis Dalessandro
On Wed, Dec 16, 2015 at 03:21:02PM +0200, Sagi Grimberg wrote: This question is not directly related to this patch, but given that this is a copy-paste from the qib driver I'll go ahead and take it anyway. How does qib (and rvt now) do memory key invalidation? I didn't see any reference to

Re: [PATCH 37/37] IB/rdmavt: Add support for new memory registration API

2015-12-16 Thread Sagi Grimberg
This patch exists to provide parity for what is in qib. Should we not have it? If not, why do we have: commit 38071a461f0a ("IB/qib: Support the new memory registration API") That was done by me because I saw this in qib and assumed that it was supported. Now that I found out that it isn't,

Re: [PATCH 37/37] IB/rdmavt: Add support for new memory registration API

2015-12-16 Thread Sagi Grimberg
This question is not directly related to this patch, but given that this is a copy-paste from the qib driver I'll go ahead and take it anyway. How does qib (and rvt now) do memory key invalidation? I didn't see any reference to IB_WR_LOCAL_INV anywhere in the qib driver... What am I missing?

Re: [PATCH 37/37] IB/rdmavt: Add support for new memory registration API

2015-12-14 Thread Sagi Grimberg
Hi Dennis and Ira, This question is not directly related to this patch, but given that this is a copy-paste from the qib driver I'll go ahead and take it anyway. How does qib (and rvt now) do memory key invalidation? I didn't see any reference to IB_WR_LOCAL_INV anywhere in the qib driver...

Re: [PATCH 37/37] IB/rdmavt: Add support for new memory registration API

2015-12-14 Thread Dennis Dalessandro
On Mon, Dec 14, 2015 at 06:18:48PM +0200, Sagi Grimberg wrote: This question is not directly related to this patch, but given that this is a copy-paste from the qib driver I'll go ahead and take it anyway. How does qib (and rvt now) do memory key invalidation? I didn't see any reference to

Re: [PATCH 37/37] IB/rdmavt: Add support for new memory registration API

2015-12-10 Thread Sagi Grimberg
commit 38071a461f0a ("IB/qib: Support the new memory registration API")" added support for map_mr_sg to qib. This patch brings that support into rdmavt, it also adds a register mr function that will be called from the post send routine which is inline with the qib patch. Hi Dennis and Ira,