Re: [PATCH 5/9] ib_srpt: Fix sport-port_guid formatting code

2011-10-26 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 10:25 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:57 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +               snprintf(sport-port_guid, sizeof(sport-port_guid),

Re: [PATCH 5/9] ib_srpt: Fix sport-port_guid formatting code

2011-10-26 Thread Nicholas A. Bellinger
On Wed, 2011-10-26 at 20:23 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 10:25 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:57 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +

Re: [PATCH 5/9] ib_srpt: Fix sport-port_guid formatting code

2011-10-24 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +               snprintf(sport-port_guid, sizeof(sport-port_guid), +                               0x%016llx, +                               be64_to_cpu(sport-gid.global.interface_id)); If I

[PATCH 5/9] ib_srpt: Fix sport-port_guid formatting code

2011-10-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes the sport-port_guid formatting code in srpt_add_one() to properly use sport-gid.global.interface_id instead of device-node_guid w/ a port offset. This requires using ib_query_gid() from srpt_refresh_port(), so the sport-port_guid