Re: [PATCH for-next 05/10] iser: Have initiator and target to share protocol structures and definitions

On 19/11/2015 09:20, Or Gerlitz wrote: On 11/16/2015 6:37 PM, Sagi Grimberg wrote: +/** + * struct iser_hello - iSER Hello header + * + * @opcode: opcode (must be set to ISER_HELLO) + * @max_min_ver: maximum and minimum iser versions + * @iser_ird: iSER IRD + * @rsvd:

Re: [PATCH for-next 05/10] iser: Have initiator and target to share protocol structures and definitions

On Tue, Nov 17, 2015 at 11:58:26AM +0200, Sagi Grimberg wrote: > I don't know... Shouldn't it? > > I just copied include/scsi/srp.h and changed it... Not a major issue, it just seemed a little strange to me. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of

Re: [PATCH for-next 05/10] iser: Have initiator and target to share protocol structures and definitions

On Mon, Nov 16, 2015 at 06:37:36PM +0200, Sagi Grimberg wrote: > The iser RDMA_CM negotiation protocol is shared by > the initiator and the target, so have a shared header > for the defines and structure. Move relevant items from > the initiator and target headers. Nice! But should a header that

[PATCH for-next 05/10] iser: Have initiator and target to share protocol structures and definitions

The iser RDMA_CM negotiation protocol is shared by the initiator and the target, so have a shared header for the defines and structure. Move relevant items from the initiator and target headers. Signed-off-by: Sagi Grimberg Signed-off-by: Jenny Derzhavetz