Re: [PATCH for-next V3 01/11] IB/core: Add gid_type to gid attribute

On Wed, Dec 23, 2015 at 02:56:47PM +0200, Matan Barak wrote: > In order to support multiple GID types, we need to store the gid_type > with each GID. This is also aligned with the RoCE v2 annex "RoCEv2 PORT > GID table entries shall have a "GID type" attribute that denotes the L3 > Address type".

Re: [PATCH for-next V3 01/11] IB/core: Add gid_type to gid attribute

+static const char * const gid_type_str[] = { ^^ ^^ IMHO, The white spaces can be a little bit confusing to understand. Pay attention to the double const - I think it's more clear that way. I agree. + [IB_GID_TYPE_IB]= "IB/RoCE v1", +}; + +const char

Re: [PATCH for-next V3 01/11] IB/core: Add gid_type to gid attribute

On Wed, Dec 23, 2015 at 3:40 PM, Leon Romanovsky wrote: > On Wed, Dec 23, 2015 at 02:56:47PM +0200, Matan Barak wrote: >> In order to support multiple GID types, we need to store the gid_type >> with each GID. This is also aligned with the RoCE v2 annex "RoCEv2 PORT >> GID table

[PATCH for-next V3 01/11] IB/core: Add gid_type to gid attribute

In order to support multiple GID types, we need to store the gid_type with each GID. This is also aligned with the RoCE v2 annex "RoCEv2 PORT GID table entries shall have a "GID type" attribute that denotes the L3 Address type". The currently supported GID is IB_GID_TYPE_IB which is also RoCE v1