Re: [PATCH v2 02/10] IB/iser: Reuse ib_sg_to_pages

2015-12-10 Thread Sagi Grimberg
On 09/12/2015 21:28, Christoph Hellwig wrote: On Wed, Dec 09, 2015 at 02:12:00PM +0200, Sagi Grimberg wrote: We have in iser iser_sg_to_page_vec which has exactly the same role as ib_sg_to_pages. Customize the page_vec to hold a fake MR so we can reuse ib_sg_to_pages. Looks good. In the

Re: [PATCH v2 02/10] IB/iser: Reuse ib_sg_to_pages

2015-12-10 Thread Christoph Hellwig
On Thu, Dec 10, 2015 at 10:28:59AM +0200, Sagi Grimberg wrote: > We can do that. We'd need to add ib_mr a list member just for fmr > routines. We'll also need that for a FR pool abstraction that would be very helpful. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the

[PATCH v2 02/10] IB/iser: Reuse ib_sg_to_pages

2015-12-09 Thread Sagi Grimberg
We have in iser iser_sg_to_page_vec which has exactly the same role as ib_sg_to_pages. Customize the page_vec to hold a fake MR so we can reuse ib_sg_to_pages. Signed-off-by: Sagi Grimberg --- drivers/infiniband/ulp/iser/iscsi_iser.h | 5 +-

Re: [PATCH v2 02/10] IB/iser: Reuse ib_sg_to_pages

2015-12-09 Thread Christoph Hellwig
On Wed, Dec 09, 2015 at 02:12:00PM +0200, Sagi Grimberg wrote: > We have in iser iser_sg_to_page_vec which has exactly > the same role as ib_sg_to_pages. Customize the page_vec > to hold a fake MR so we can reuse ib_sg_to_pages. Looks good. In the long run we should simply kill struct ib_fmr and