Hi all, As discussed on the linux-rdma list, there is plenty of room for improvement in our memory registration APIs. We keep finding ULPs that are duplicating code, sometimes use wrong strategies and mis-use our current API.
As a first step, this patch set replaces the fast registration API to accept a kernel common struct scatterlist and takes care of the page vector construction in the core layer with hooks for the drivers HW specific assignments. This allows to remove a common code duplication as it was done in each and every ULP driver. Changes from v3: - Addressed some xprtrdma comments (Chuck) - Removed xprtrdma change-log paragraph (Or) Changes from v2: - Fixed alignment for page lists allocations in mlx4, mlx5 (Bart) - Rebased against Doug's for-4.4 tree (4.3.0-rc1) + 4.3-rc fixes - Added Acked/Tested tags Changes from v1: - Add ib_map_mr_sg_zbva() for RDS which uses it (preferred it over polluting the API). - Replaced coherent allocations in mlx4, mlx5 with DMA streaming APIs (Bart) - Changed ib_map_mr_sg description (Bart) - Split SRP driver patches (Bart) - Added missing wr->next = NULL from various ULPs (Steve, Santosh) - Fixed 0-day testing errors in nes driver, xprtrdma and svcrdma - Fixed checkpatch issues Changes from v0: - Rebased on top of 4.3-rc1 + Christoph's ib_send_wr conversion patches - Allow the ULP to pass page_size argument to ib_map_mr_sg in order to have it work better in some specific workloads. This suggestion came from Bart Van Assche which pointed out that some applications might use page sizes significantly smaller than the system PAGE_SIZE of specific architectures - Fixed some logical bugs in ib_sg_to_pages - Added a set_page function pointer for drivers to pass to ib_sg_to_pages so some drivers (e.g mlx4, mlx5, nes) can avoid keeping a second page vector and/or re-iterate on the page vector in order to perform HW specific assignments (big/little endian conversion, extra flags) - Converted SRP initiator and RDS iwarp ULPs to the new API - Removed fast registration code from hfi1 driver (as it isn't supported anyway). I assume that the correct place to get the support back would be in a shared SW library (hfi1, qib, rxe). - Updated the change logs The code is available at: https://github.com/sagigrimberg/linux/tree/reg_api.6 Sagi Grimberg (26): IB/core: Introduce new fast registration API IB/mlx5: Remove dead fmr code IB/mlx5: Support the new memory registration API IB/mlx4: Support the new memory registration API RDMA/ocrdma: Support the new memory registration API RDMA/cxgb3: Support the new memory registration API iw_cxgb4: Support the new memory registration API IB/qib: Support the new memory registration API RDMA/nes: Support the new memory registration API IB/iser: Port to new fast registration API iser-target: Port to new memory registration API xprtrdma: Port to new memory registration API svcrdma: Port to new memory registration API RDS/IW: Convert to new memory registration API IB/srp: Split srp_map_sg IB/srp: Convert to new registration API IB/srp: Remove srp_finish_mapping IB/srp: Dont allocate a page vector when using fast_reg IB/mlx5: Remove old FRWR API support IB/mlx4: Remove old FRWR API support RDMA/ocrdma: Remove old FRWR API RDMA/cxgb3: Remove old FRWR API iw_cxgb4: Remove old FRWR API IB/qib: Remove old FRWR API RDMA/nes: Remove old FRWR API IB/core: Remove old fast registration API drivers/infiniband/core/verbs.c | 132 +++++++++++--- drivers/infiniband/hw/cxgb3/iwch_cq.c | 2 +- drivers/infiniband/hw/cxgb3/iwch_provider.c | 39 +++-- drivers/infiniband/hw/cxgb3/iwch_provider.h | 2 + drivers/infiniband/hw/cxgb3/iwch_qp.c | 37 ++-- drivers/infiniband/hw/cxgb4/cq.c | 2 +- drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 25 +-- drivers/infiniband/hw/cxgb4/mem.c | 61 +++---- drivers/infiniband/hw/cxgb4/provider.c | 3 +- drivers/infiniband/hw/cxgb4/qp.c | 47 +++-- drivers/infiniband/hw/mlx4/cq.c | 2 +- drivers/infiniband/hw/mlx4/main.c | 3 +- drivers/infiniband/hw/mlx4/mlx4_ib.h | 25 ++- drivers/infiniband/hw/mlx4/mr.c | 149 ++++++++++------ drivers/infiniband/hw/mlx4/qp.c | 34 ++-- drivers/infiniband/hw/mlx5/cq.c | 4 +- drivers/infiniband/hw/mlx5/main.c | 3 +- drivers/infiniband/hw/mlx5/mlx5_ib.h | 48 +----- drivers/infiniband/hw/mlx5/mr.c | 135 ++++++++++----- drivers/infiniband/hw/mlx5/qp.c | 140 +++++++-------- drivers/infiniband/hw/nes/nes_hw.h | 6 - drivers/infiniband/hw/nes/nes_verbs.c | 163 +++++++----------- drivers/infiniband/hw/nes/nes_verbs.h | 4 + drivers/infiniband/hw/ocrdma/ocrdma.h | 2 + drivers/infiniband/hw/ocrdma/ocrdma_main.c | 3 +- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 154 ++++++++--------- drivers/infiniband/hw/ocrdma/ocrdma_verbs.h | 7 +- drivers/infiniband/hw/qib/qib_keys.c | 42 ++--- drivers/infiniband/hw/qib/qib_mr.c | 46 ++--- drivers/infiniband/hw/qib/qib_verbs.c | 13 +- drivers/infiniband/hw/qib/qib_verbs.h | 13 +- drivers/infiniband/ulp/iser/iscsi_iser.h | 8 +- drivers/infiniband/ulp/iser/iser_memory.c | 54 +++--- drivers/infiniband/ulp/iser/iser_verbs.c | 16 +- drivers/infiniband/ulp/isert/ib_isert.c | 130 +++----------- drivers/infiniband/ulp/isert/ib_isert.h | 2 - drivers/infiniband/ulp/srp/ib_srp.c | 256 +++++++++++++++++----------- drivers/infiniband/ulp/srp/ib_srp.h | 11 +- include/linux/sunrpc/svc_rdma.h | 6 +- include/rdma/ib_verbs.h | 86 +++++----- net/rds/iw.h | 5 +- net/rds/iw_rdma.c | 128 +++++--------- net/rds/iw_send.c | 57 +++---- net/sunrpc/xprtrdma/frwr_ops.c | 118 +++++++------ net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 76 +++++---- net/sunrpc/xprtrdma/svc_rdma_transport.c | 34 ++-- net/sunrpc/xprtrdma/xprt_rdma.h | 3 +- 47 files changed, 1160 insertions(+), 1176 deletions(-) -- 1.8.4.3 -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
