RE: [patch v2 12/37] add rxe_verbs.h

2011-08-31 Thread Bob Pearson
-Original Message- From: bart.vanass...@gmail.com [mailto:bart.vanass...@gmail.com] On Behalf Of Bart Van Assche Sent: Monday, August 15, 2011 7:32 AM To: rpear...@systemfabricworks.com Cc: linux-rdma@vger.kernel.org Subject: Re: [patch v2 12/37] add rxe_verbs.h On Sun, Jul 24

RE: [patch v2 12/37] add rxe_verbs.h

2011-08-31 Thread Bob Pearson
-Original Message- From: bart.vanass...@gmail.com [mailto:bart.vanass...@gmail.com] On Behalf Of Bart Van Assche Sent: Monday, August 15, 2011 8:00 AM To: rpear...@systemfabricworks.com Cc: linux-rdma@vger.kernel.org Subject: Re: [patch v2 12/37] add rxe_verbs.h On Sun, Jul 24

Re: [patch v2 12/37] add rxe_verbs.h

2011-08-15 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: +static inline int pkey_match(u16 key1, u16 key2) +{ + return (((key1 0x7fff) != 0) + ((key1 0x7fff) == (key2 0x7fff)) + ((key1 0x8000) || (key2 0x8000))) ? 1 : 0; +} Shouldn't the

Re: [patch v2 12/37] add rxe_verbs.h

2011-08-15 Thread Bart Van Assche
On Sun, Jul 24, 2011 at 9:43 PM, rpear...@systemfabricworks.com wrote: + rxe_qp.c:char *rxe_qp_state_name[] = { One more comment about rxe_verbs.h: why is the above declaration present in this header file ? As far as I can see it's only used in rxe_qp.c and not in any other source file. Bart.

[patch v2 12/37] add rxe_verbs.h

2011-07-25 Thread rpearson
declarations for rxe interface to rdma/core Signed-off-by: Bob Pearson rpear...@systemfabricworks.com --- drivers/infiniband/hw/rxe/rxe_verbs.h | 571 ++ 1 file changed, 571 insertions(+) Index: infiniband/drivers/infiniband/hw/rxe/rxe_verbs.h