On Oct 17, 2011, at 5:28 PM, Hal Rosenstock wrote:
A couple of minor comments:
1. Why not move the OSM_EVENT_ID_LIGHT_SWEEP_DONE event to where LIGHT
SWEEP COMPLETE is indicated in osm_state_mgr.c ? That's actually more
accurate as all the transactions have completed.
2. The new events
Thanks for explaining the enum convention - quite logical indeed. Also, thanks
for some of the off-list discussion where we tried to see if any of the current
event callbacks could be used to achieve the desired support. As it stands, it
still sounds like including light sweep events is the
Hi Karl,
On 10/17/2011 5:43 PM, Karl Schulz wrote:
Thanks for explaining the enum convention - quite logical indeed. Also,
thanks for some
of the off-list discussion where we tried to see if any of the current event
callbacks
could be used to achieve the desired support. As it stands,
Hi Karl,
The idea in that if the received event is = OSM_EVENT_ID_MAX,
then the plug-in knows that something went wrong (wrong version,
something changed in API, etc).
Also, you might want to know about more stuff if you're pulling
topology/routing info from SM, such as when SM became
Hello,
Would it be possible to consider exposing light-sweep events to the current
OpenSM plugin interface? Something along the lines of the attached patch is
what we are using locally against opensm-3.3.9.
The motivation is to support a plugin module we have written to expose topology
I think this is a reasonable idea.
Comment on the patch.
- OSM_EVENT_ID_MAX
+ OSM_EVENT_ID_MAX,
+ OSM_EVENT_ID_LIGHT_SWEEP_START,
+ OSM_EVENT_ID_LIGHT_SWEEP_DONE,
Traditionally the MAX value in the enum is kept at the end.
Ira
On Wed, 12 Oct 2011 14:31:07 -0700
Thanks Ira,
My apologies for not following the conventional standard. Should I generate a
new patch?
-k
On Oct 12, 2011, at 5:13 PM, Ira Weiny wrote:
I think this is a reasonable idea.
Comment on the patch.
- OSM_EVENT_ID_MAX
+ OSM_EVENT_ID_MAX,
+
