Re: [PATCH for-next 1/2] IB/core: Fix build warnings

2013-11-03 Thread Or Gerlitz
On 31/10/2013 21:28, David Dillow wrote: We want to know about those comparisons, because they often indicate a bug -- either in one's thinking, or in the code they've written. Changing attr.state from unsigned to signed is unlikely to ever happen, as a massive audit would be needed -- this is

Re: [PATCH for-next 1/2] IB/core: Fix build warnings

2013-10-31 Thread Bart Van Assche
On 31/10/2013 9:21, Or Gerlitz wrote: Fix the below few make W=1 build warnings we have on the IB core. drivers/infiniband/core/sysfs.c: In function ‘state_show’: drivers/infiniband/core/sysfs.c:107: warning: comparison of unsigned expression = 0 is always true drivers/infiniband/core/verbs.c:

RE: [PATCH for-next 1/2] IB/core: Fix build warnings

2013-10-31 Thread Hefty, Sean
diff --git a/drivers/infiniband/core/iwcm.c b/drivers/infiniband/core/iwcm.c index c47c203..ab8ebf8 100644 --- a/drivers/infiniband/core/iwcm.c +++ b/drivers/infiniband/core/iwcm.c @@ -327,7 +327,6 @@ static void destroy_cm_id(struct iw_cm_id *cm_id) { struct iwcm_id_private

Re: [PATCH for-next 1/2] IB/core: Fix build warnings

2013-10-31 Thread David Dillow
On Thu, 2013-10-31 at 10:02 -0700, Bart Van Assche wrote: On 31/10/2013 9:21, Or Gerlitz wrote: --- a/drivers/infiniband/core/sysfs.c +++ b/drivers/infiniband/core/sysfs.c @@ -104,7 +104,7 @@ static ssize_t state_show(struct ib_port *p, struct port_attribute *unused, return

Re: [PATCH for-next 1/2] IB/core: Fix build warnings

2013-10-31 Thread Or Gerlitz
On Thu, Oct 31, 2013 at 7:59 PM, Hefty, Sean sean.he...@intel.com wrote: removing 'ret' is one thing, removing the call to destroy_listen() is another. sure, I will fix and resubmit -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to