On Fri, Jun 20, 2014 at 08:58:32PM +0300, Dan Carpenter wrote:
976
977err_create:
978if (qp-create_type == MLX5_QP_USER)
979destroy_qp_user(pd, qp);
^^^
But we dereference it inside
Hello Eli Cohen,
This is a semi-automatic email about new static checker warnings.
The patch e126ba97dba9: mlx5: Add driver for Mellanox Connect-IB
adapters from Jul 7, 2013, leads to the following Smatch complaint:
drivers/infiniband/hw/mlx5/qp.c:979 create_qp_common()
error: we
On 10/07/2013 13:55, Dan Carpenter wrote:
Hello Eli Cohen,
The patch e126ba97dba9: mlx5: Add driver for Mellanox Connect-IB
adapters from Jul 7, 2013, leads to the following Smatch warning:
drivers/net/ethernet/mellanox/mlx5/core/cmd.c:822
mlx5_alloc_cmd_msg()
warn: use 'flags' here
for Mellanox Connect-IB
adapters from Jul 7, 2013, leads to the following Smatch warning:
drivers/net/ethernet/mellanox/mlx5/core/cmd.c:822
mlx5_alloc_cmd_msg()
warn: use 'flags' here instead of GFP_XXX?
811 static struct mlx5_cmd_msg *mlx5_alloc_cmd_msg(struct mlx5_core_dev
*dev
messages. I feel like we
shouldn't do that.
/* Shut up warnings after an error */
max_warnings = 0;
---
Hello Eli Cohen,
The patch e126ba97dba9: mlx5: Add driver for Mellanox Connect-IB
adapters from Jul 7, 2013, has an endian related bug:
drivers/net/ethernet/mellanox/mlx5
Hello Eli Cohen,
The patch e126ba97dba9: mlx5: Add driver for Mellanox Connect-IB
adapters from Jul 7, 2013, leads to the following Smatch warning:
drivers/net/ethernet/mellanox/mlx5/core/cmd.c:822
mlx5_alloc_cmd_msg()
warn: use 'flags' here instead of GFP_XXX?
811 static struct
noident
do_error() in Sparse disables warning messages. I feel like we
shouldn't do that.
/* Shut up warnings after an error */
max_warnings = 0;
---
Hello Eli Cohen,
The patch e126ba97dba9: mlx5: Add driver for Mellanox Connect-IB
adapters from Jul 7, 2013, has an endian related
On Wed, Jul 10, 2013 at 01:54:15PM +0300, Dan Carpenter wrote:
---
Side note: Sparse should warn about endian bugs but in linux-next
endian checking is disabled because we hit:
include/uapi/linux/swab.h:71:16: error: undefined identifier
'__builtin_bswap64'
