Re: [PATCH] RDMA/cxgb4: Mark the QP in error before disabling the Q in the firmware

2011-10-28 Thread Steve Wise
On 10/25/2011 06:08 AM, Kumar Sanghvi wrote: From: Tom Tuckert...@ogc.us The QP needs to be moved to error before telling the firwmare to shutdown the queue. Otherwise, the application can submit WR that will never get fetched by the hardware and never flushed by the driver. Signed-off-by:

Re: [PATCH 1/2] RDMA/cxgb4: Serialize calls to cq's comp_handler by lock

2011-10-28 Thread Steve Wise
On 10/24/2011 10:50 AM, Kumar Sanghvi wrote: Commit 01e7da6ba53ca4d6189a1eae45607c0331c871f2 introduced a potential problem wherein the cq's comp_handler can get called simultaneously from different places in iw_cxgb4 driver. This does not comply with Documentation/infiniband/core_locking.txt,

Re: [PATCH 2/2] RDMA/cxgb3: Serialize calls to cq's comp_handler by lock

2011-10-28 Thread Steve Wise
On 10/24/2011 10:50 AM, Kumar Sanghvi wrote: iw_cxgb3 has a potential problem wherein the cq's comp_handler can get called simultaneously from different places in iw_cxgb3 driver. This does not comply with Documentation/infiniband/core_locking.txt, which states that at a given point of time,

Re: [PATCH] RDMA/nes: ip address print changes

2011-10-28 Thread Roland Dreier
On Thu, Oct 27, 2011 at 9:10 AM, Faisal Latif faisal.la...@intel.com wrote: Fix printing of ip addresses to use %pI4. Thanks, looks fine, I'll apply this. But looking at this patch makes me wonder why nes ever stores IPv4 addresses in host order? Couldn't a ton of swapping be eliminated by

Re: [PATCH V2 02/10] cxgb4: Common platform specific changes for DB Drop Recovery

2011-10-28 Thread Roland Dreier
On Thu, Oct 20, 2011 at 10:18 AM, Felix Marti fe...@chelsio.com wrote: Don't add stuff to the t4fw_interface.h, that is owned by firmware. Vipul, do you plan to respin to handle Felix's comment? - R. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a

Re: [PATCH V2 02/10] cxgb4: Common platform specific changes for DB Drop Recovery

2011-10-28 Thread Kumar Sanghvi
Hi Roland, On Fri, Oct 28, 2011 at 10:59:47 -0700, Roland Dreier wrote: On Thu, Oct 20, 2011 at 10:18 AM, Felix Marti fe...@chelsio.com wrote: Don't add stuff to the t4fw_interface.h, that is owned by firmware. Vipul, do you plan to respin to handle Felix's comment? - R. Vipul is on

Re: [PATCH V2 02/10] cxgb4: Common platform specific changes for DB Drop Recovery

2011-10-28 Thread Roland Dreier
Vipul did a respin of this patch, and posted the V3 version. Its available here: http://www.mail-archive.com/linux-rdma@vger.kernel.org/msg09659.html Got it, thanks. - R. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to