[PATCH 1/2] RDMA/ocrdma: Remove redundant check in ocrdma_build_fr.

2013-10-28 Thread bgottumukkala
From: Naresh Gottumukkala bgottumukk...@emulex.com Remove the redundant check of comparing if 32 bit value is greater than 0xULL. This is reported by Dan Carpenter. Signed-off-by: Naresh Gottumukkala bgottumukk...@emulex.com --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +--- 1

[PATCH] RDMA/ocrdma: Fix the driver crash during rmmod.

2013-10-28 Thread bgottumukkala
From: Naresh Gottumukkala bgottumukk...@emulex.com ocrdma_remove_free funtion can be called in a bottom-half context. So the code in this funtion should not sleep. Moved the resource cleanup code to ocrdma_remove instead of ocrdma_remove_free. Signed-off-by: Naresh Gottumukkala

[PATCH 2/2] RDMA/ocrdma: Fix the driver crash during rmmod.

2013-10-28 Thread bgottumukkala
From: Naresh Gottumukkala bgottumukk...@emulex.com ocrdma_remove_free funtion can be called in a bottom-half context. So the code in this funtion should not sleep. Moved the resource cleanup code to ocrdma_remove instead of ocrdma_remove_free. Signed-off-by: Naresh Gottumukkala

[PATCH 1/2] RDMA/ocrdma: Remove redundant check in ocrdma_build_fr.

2013-10-28 Thread bgottumukkala
From: Naresh Gottumukkala bgottumukk...@emulex.com Remove the redundant check of comparing if 32 bit value is greater than 0xULL. This is reported by Dan Carpenter. Signed-off-by: Naresh Gottumukkala bgottumukk...@emulex.com --- drivers/infiniband/hw/ocrdma/ocrdma_verbs.c | 4 +--- 1

[PATCH 0/2] Fixe for rmmod crash and warnings.

2013-10-28 Thread bgottumukkala
From: Naresh Gottumukkala bgottumukk...@emulex.com Please neglect my last two patches. I am resending those. Naresh Gottumukkala (2): RDMA/ocrdma: Remove redundant check in ocrdma_build_fr. RDMA/ocrdma: Fix the driver crash during rmmod. drivers/infiniband/hw/ocrdma/ocrdma_main.c | 7

[PATCH opensm] osm_link_mgr.c: active_transition parameter in PortInfo(Set) context may not be initialized

2013-10-28 Thread Hal Rosenstock
Signed-off-by: Vladimir Koushnir vladim...@mellanox.com --- opensm/osm_link_mgr.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/opensm/osm_link_mgr.c b/opensm/osm_link_mgr.c index 98126f1..0d00984 100644 --- a/opensm/osm_link_mgr.c +++ b/opensm/osm_link_mgr.c @@

[PATCH RFC v1 00/10] Introduce Signature feature

2013-10-28 Thread Sagi Grimberg
This patchset Introduces Verbs level support for signature handover feature. Siganture is intended to implement end-to-end data integrity on a transactional basis in a completely offloaded manner. There are several end-to-end data integrity methods used today in various applications and/or upper

[PATCH RFC v1 09/10] IB/mlx5: Collect signature error completion

2013-10-28 Thread Sagi Grimberg
This commit takes care of the generated signature error cqe generated by the HW (if happened) and stores it on the QP signature error list. Once the user will get the completion for the transaction he must check for signature errors on signature memory region using a new lightweight verb

[PATCH RFC v1 06/10] IB/mlx5: remove MTT access mode from umr flags helper function

2013-10-28 Thread Sagi Grimberg
get_umr_flags helper function might be used for types of access modes other than ACCESS_MODE_MTT, such as ACCESS_MODE_KLM. so remove it from helper and caller will add it's own access mode flag. This patch does not add/change functionality. Signed-off-by: Sagi Grimberg sa...@mellanox.com ---

[PATCH RFC v1 05/10] IB/mlx5: Break wqe handling to begin finish routines

2013-10-28 Thread Sagi Grimberg
As a preliminary step for signature feature which will reuqire posting multiple (3) WQEs for a single WR, we break post_send routine WQE indexing into begin and finish routines. This patch does not change any functionality. Signed-off-by: Sagi Grimberg sa...@mellanox.com ---

[PATCH RFC v1 04/10] IB/mlx5: Initialize mlx5_ib_qp signature related

2013-10-28 Thread Sagi Grimberg
If user requested signature enable we Initialize relevant mlx5_ib_qp members. we mark the qp as sig_enable we initiatlize empty sig_err_list, and we increase qp size. Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/hw/mlx5/mlx5_ib.h |3 +++

[PATCH RFC v1 02/10] IB/core: Introduce Signature Verbs API

2013-10-28 Thread Sagi Grimberg
This commit Introduces the Verbs Interface for signature related operations. A signature handover operation shall configure the layouts of data and protection attributes both in memory and wire domains. Signature operations are: - INSERT Generate and insert protection information when handing

[PATCH RFC v1 10/10] IB/mlx5: Publish support in signature feature

2013-10-28 Thread Sagi Grimberg
Currently support only T10-DIF types of signature handover operations (typs 1|2|3). Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/infiniband/hw/mlx5/main.c |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/mlx5/main.c

[PATCH RFC v1 08/10] IB/mlx5: Support IB_WR_REG_SIG_MR

2013-10-28 Thread Sagi Grimberg
This patch implements IB_WR_REG_SIG_MR posted by the user. Baisically this WR involvs 3 WQEs in order to prepare and properly register the signature layout: 1. post UMR WR to register the sig_mr in one of two possible ways: * In case the user registered a single MR for data so the UMR data

[PATCH RFC v1 07/10] IB/mlx5: Keep mlx5 MRs in a radix tree under device

2013-10-28 Thread Sagi Grimberg
This will be useful when processing signature errors on a specific key. The mlx5 driver will lookup the matching mlx5 memory region structure and mark it as dirty (contains signature errors). Signed-off-by: Sagi Grimberg sa...@mellanox.com --- drivers/net/ethernet/mellanox/mlx5/core/main.c |

[PATCH RFC v1 03/10] IB/mlx5, mlx5_core: Support for create_mr and destroy_mr

2013-10-28 Thread Sagi Grimberg
Support create_mr and destroy_mr verbs. The user may request signature enable memory region attribute where in this case the memory region shall be indirect MR and shall be attached to with signature attributes (BSF, PSVs). Otherwise, the create_mr routine is equivalent to alloc_fast_reg_mr.

[PATCH RFC v1 01/10] IB/core: Introduce protected memory regions

2013-10-28 Thread Sagi Grimberg
This commit introduces verbs for creating/destoying memory regions which will allow new types of memory key operations such as protected memory registration. Indirect memory registration is registering several (one of more) pre-registered memory regions in a specific layout. The Indirect region

[PATCH opensm] osm_ucast_cache.c: Fix memory leak in ucast_cache

2013-10-28 Thread Hal Rosenstock
From: Alex Netes ale...@mellanox.com When invalidating cache p_sw-hops[i] arrays aren't cleared. Signed-off-by: Alex Netes ale...@mellanox.com Signed-off-by: Hal Rosenstock h...@mellanox.com --- opensm/osm_ucast_cache.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff

RE: smatch warnings on the IB core

2013-10-28 Thread Hefty, Sean
drivers/infiniband/core/cma.c:1336 cma_req_handler() warn: inconsistent returns mutex:listen_id-handler_mutex: locked (1271 [(-22)], 1274 [(-103)]) unlocked (1323 [0], 1336 [s32min-(-1),1-s32max], 1336 [(-12)]) drivers/infiniband/core/cma.c:1535 iw_conn_req_handler() warn:

ACK behaviour difference LRO/GRO

2013-10-28 Thread Markus Stockhausen
Hello, about two month we had some problems with IPoIB transfer speeds . See more http://marc.info/?l=linux-rdmam=137823326109158w=2 After some quite hard test iterations the problem seems to come from the IPoIB switch from LRO to GRO between kernels 2.6.37 and 2.6.38. I built a test setup

RE: [PATCH RFC v1 01/10] IB/core: Introduce protected memory regions

2013-10-28 Thread Hefty, Sean
+enum ib_mr_create_flags { + IB_MR_SIGNATURE_EN = 1, +}; + +/** + * ib_mr_init_attr - Memory region init attributes passed to routine + * ib_create_mr. + * @max_reg_descriptors: max number of registration units that + * may be used with UMR work requests. + * @flags: MR

RDMA reads/writes per second

2013-10-28 Thread Anuj Kalia
Hi. I'm measuring the number of RDMA reads and writes per second. In my experimental setup I have one server connected to several clients and I want to extract the maximum IOs from the server. I had two questions regarding this: 1. What is the expected number of small (16 byte values) RDMA reads

RDMA reads/writes per second

2013-10-28 Thread akalia
Hi. I'm measuring the number of RDMA reads and writes per second. In my experimental setup I have one server connected to several clients and I want to extract the maximum IOs from the server. I had two questions regarding this: 1. What is the expected number of small (16 byte values) RDMA reads

[PATCH] iser-target: fix error return code in isert_create_device_ib_res()

2013-10-28 Thread Wei Yongjun
From: Wei Yongjun yongjun_...@trendmicro.com.cn Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn --- drivers/infiniband/ulp/isert/ib_isert.c | 16 1 file