On Mon, 21 Dec 2015, Hal Rosenstock wrote:
> > Don't we need to change all the sysfs_remove_groups to use
> > get_counter_table as
> > well?
>
> Looks like it to me too. Good catch.
Fix follows:
From: Christoph Lameter
Subject: Fix sysfs entry removal by storing the table
On Mon, Dec 21, 2015 at 11:36:03AM -0500, ira.weiny wrote:
> It would be nice if we were not having to do this for staging then. Also
> perhaps it should be removed from checkpatch --strict?
Don't use checkpatch --strict ever. It's full of weird items that
defintively don't apply to the
On 12/21/2015 2:47 PM, ira.weiny wrote:
> On Mon, Dec 21, 2015 at 01:31:31PM -0600, Christoph Lameter wrote:
>> On Mon, 21 Dec 2015, Hal Rosenstock wrote:
>>
Don't we need to change all the sysfs_remove_groups to use
get_counter_table as
well?
>>>
>>> Looks like it to me too. Good
On Mon, Dec 21, 2015 at 01:31:31PM -0600, Christoph Lameter wrote:
> On Mon, 21 Dec 2015, Hal Rosenstock wrote:
>
> > > Don't we need to change all the sysfs_remove_groups to use
> > > get_counter_table as
> > > well?
> >
> > Looks like it to me too. Good catch.
>
> Fix follows:
>
> From:
On Mon, Dec 14, 2015 at 04:30:09PM -0500, Chuck Lever wrote:
> Minor optimization: when dealing with write chunk XDR roundup, do
> not post a Write WR for the zero bytes in the pad. Simply update
> the write segment in the RPC-over-RDMA header to reflect the extra
> pad bytes.
>
> The Reply chunk
On Mon, Dec 21, 2015 at 04:15:23PM -0500, Chuck Lever wrote:
>
> > On Dec 21, 2015, at 4:07 PM, J. Bruce Fields wrote:
> >
> > On Mon, Dec 14, 2015 at 04:30:09PM -0500, Chuck Lever wrote:
> >> Minor optimization: when dealing with write chunk XDR roundup, do
> >> not post
> On Dec 21, 2015, at 4:07 PM, J. Bruce Fields wrote:
>
> On Mon, Dec 14, 2015 at 04:30:09PM -0500, Chuck Lever wrote:
>> Minor optimization: when dealing with write chunk XDR roundup, do
>> not post a Write WR for the zero bytes in the pad. Simply update
>> the write
This (V1) series contains the addition of the i40iw.ko driver after
incorporating the feedback from Christoph Hellwig and Joe Perches for
initial series.
This driver provides iWARP RDMA functionality for the Intel(R) X722 Ethernet
controller for PCI Physical Functions. It also has support for
On Mon, Dec 21, 2015 at 02:02:35PM -0800, gre...@linuxfoundation.org wrote:
> On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny wrote:
> > Greg, Doug,
> >
> > As mentioned below, these patches depend on the new rdmavt library
> > submitted to
> > Doug on linux-rdma.
> >
> > We continue to
On Tue, Dec 01, 2015 at 02:47:57PM -0500, ira.we...@intel.com wrote:
> From: Dean Luick
>
> Correctly set half-swing for integrated devices. A0 needs all fields set for
> CcePcieCtrl. B0 and later only need a few fields set.
>
> Reviewed-by: Stuart Summers
Kconfig and Kbuild needed to build iwarp module.
Signed-off-by: Faisal Latif
---
drivers/infiniband/hw/i40iw/Kbuild | 43 +
drivers/infiniband/hw/i40iw/Kconfig | 7 ++
2 files changed, 50 insertions(+)
create mode 100644
i40iw_main.c contains routines for i40e <=> i40iw interface and setup.
i40iw.h is header file for main device data structures.
i40iw_status.h is for return status codes.
Acked-by: Anjali Singhai Jain
Acked-by: Shannon Nelson
Signed-off-by:
i40iw_cm.c i40iw_cm.h are used for connection management.
Acked-by: Anjali Singhai Jain
Acked-by: Shannon Nelson
Signed-off-by: Faisal Latif
---
drivers/infiniband/hw/i40iw/i40iw_cm.c |
i40iw_user.h and i40iw_uk.c are used by both user library as well as
kernel requests.
Acked-by: Anjali Singhai Jain
Acked-by: Shannon Nelson
Signed-off-by: Faisal Latif
---
drivers/infiniband/hw/i40iw/i40iw_uk.c |
Add entry for port mapper services.
Signed-off-by: Faisal Latif
---
include/uapi/rdma/rdma_netlink.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/rdma/rdma_netlink.h b/include/uapi/rdma/rdma_netlink.h
index c19a5dc..4fa418d 100644
---
From: Anjali Singhai Jain
This patch adds a Client interface for i40iw driver
support. Also expands the Virtchannel to support messages
from i40evf driver on behalf of i40iwvf driver.
This client API is used by the i40iw and i40iwvf driver
to access the core driver
i40iw_pble.[ch] to manage pble resource for iwarp clients.
Acked-by: Anjali Singhai Jain
Acked-by: Shannon Nelson
Signed-off-by: Faisal Latif
---
drivers/infiniband/hw/i40iw/i40iw_pble.c | 618
i40iw_vf.[ch] and i40iw_virtchnl[ch] are used for virtual
channel support for iWARP VF module.
Acked-by: Anjali Singhai Jain
Acked-by: Shannon Nelson
Signed-off-by: Faisal Latif
---
On Mon, Dec 21, 2015 at 04:13:49PM -0800, gre...@linuxfoundation.org wrote:
> On Mon, Dec 21, 2015 at 06:48:03PM -0500, ira.weiny wrote:
> > On Tue, Dec 08, 2015 at 05:10:08PM -0500, ira.we...@intel.com wrote:
> > > From: Ira Weiny
> > >
> > > Various improvements to the
On Tue, Dec 08, 2015 at 05:10:08PM -0500, ira.we...@intel.com wrote:
> From: Ira Weiny
>
> Various improvements to the SDMA engine code.
Greg,
Thanks for reviewing and accepting our patches to staging-testing. I apologize
for the conflicts we had between the 3 of us
On Tue, Dec 01, 2015 at 03:38:14PM -0500, Jubin John wrote:
> From: Edward Mascarenhas
>
> Clean up comments by deleting numbering and terms internal to Intel.
>
> The information on the actual bugs is not deleted.
>
> Reviewed-by: Mike Marciniszyn
On Mon, Dec 21, 2015 at 06:48:03PM -0500, ira.weiny wrote:
> On Tue, Dec 08, 2015 at 05:10:08PM -0500, ira.we...@intel.com wrote:
> > From: Ira Weiny
> >
> > Various improvements to the SDMA engine code.
>
> Greg,
>
> Thanks for reviewing and accepting our patches to
On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny wrote:
> Greg, Doug,
>
> As mentioned below, these patches depend on the new rdmavt library submitted
> to
> Doug on linux-rdma.
>
> We continue to identify (and rework) patches by our other developers which can
> be submitted without
On Mon, Nov 16, 2015 at 09:59:23PM -0500, Jubin John wrote:
> This patch fixes the checkpatch issue:
> CHECK: Prefer using the BIT macro
>
> Use of BIT macro for HDRQ_INCREMENT in chip.h causes a change in
> format specifier for error message in init.c in order to avoid a
> build warning.
>
>
> On Dec 21, 2015, at 4:29 PM, J. Bruce Fields wrote:
>
> On Mon, Dec 21, 2015 at 04:15:23PM -0500, Chuck Lever wrote:
>>
>>> On Dec 21, 2015, at 4:07 PM, J. Bruce Fields wrote:
>>>
>>> On Mon, Dec 14, 2015 at 04:30:09PM -0500, Chuck Lever wrote:
On Mon, Dec 21, 2015 at 07:19:43PM -0500, ira.weiny wrote:
> On Mon, Dec 21, 2015 at 02:02:35PM -0800, gre...@linuxfoundation.org wrote:
> > On Mon, Dec 21, 2015 at 01:12:14AM -0500, ira.weiny wrote:
> > > Greg, Doug,
> > >
> > > As mentioned below, these patches depend on the new rdmavt library
i40iw_ctrl.c provides for hardware wqe supporti and cqp.
Acked-by: Anjali Singhai Jain
Acked-by: Shannon Nelson
Signed-off-by: Faisal Latif
---
drivers/infiniband/hw/i40iw/i40iw_ctrl.c | 4740
X722 Hardware registers defines for iWARP component.
Acked-by: Anjali Singhai Jain
Acked-by: Shannon Nelson
Signed-off-by: Faisal Latif
---
drivers/infiniband/hw/i40iw/i40iw_register.h | 1027
i40iw_hmc.[ch] are to manage hmc for the device.
Acked-by: Anjali Singhai Jain
Acked-by: Shannon Nelson
Signed-off-by: Faisal Latif
---
drivers/infiniband/hw/i40iw/i40iw_hmc.c | 821
i40iw_hw.c, i40iw_utils.c and i40iw_osdep.h are files to handle
interrupts and processing.
Added feeback from Cristoph Hellwig.
Acked-by: Anjali Singhai Jain
Acked-by: Shannon Nelson
Signed-off-by: Faisal Latif
---
i40iw_puda.[ch] are files to handle iwarp connection packets as
well as exception packets over multiple privilege mode uda queues.
Acked-by: Anjali Singhai Jain
Acked-by: Shannon Nelson
Signed-off-by: Faisal Latif
---
MAINTAINERS, Kconfig, and Makefile to build i40iw module
Signed-off-by: Faisal Latif
---
MAINTAINERS| 10 ++
drivers/infiniband/Kconfig | 1 +
drivers/infiniband/hw/Makefile | 1 +
3 files changed, 12 insertions(+)
diff --git
i40iw_verbs.[ch] are to handle iwarp interface.
Added feedback provided by Christoph Hellwig
Acked-by: Anjali Singhai Jain
Acked-by: Shannon Nelson
Signed-off-by: Faisal Latif
---
header files for hardware accesses
Signed-off-by: Faisal Latif
---
drivers/infiniband/hw/i40iw/i40iw_d.h| 1713 ++
drivers/infiniband/hw/i40iw/i40iw_p.h| 106 ++
drivers/infiniband/hw/i40iw/i40iw_type.h | 1307 +++
Hi Faisal,
[auto build test ERROR on net/master]
[also build test ERROR on v4.4-rc6 next-20151221]
[cannot apply to net-next/master]
url:
https://github.com/0day-ci/linux/commits/Faisal-Latif/add-Intel-R-X722-iWARP-driver/20151222-071852
config: x86_64-allmodconfig (attached as .config
On Mon, Dec 21, 2015 at 08:20:29AM -0600, Christoph Lameter wrote:
> V2->V3: Add check for NOIETF mode and create special table
> for that case.
>
> Check if the extended counters are available and if so
> create the proper extended and additional counters.
>
> Reviewed-by: Hal Rosenstock
On 12/21/2015 12:53 PM, ira.weiny wrote:
> On Mon, Dec 21, 2015 at 08:20:29AM -0600, Christoph Lameter wrote:
>> V2->V3: Add check for NOIETF mode and create special table
>> for that case.
>>
>> Check if the extended counters are available and if so
>> create the proper extended and additional
Hey Nic,
Applied to target-pending/for-next as v4.5-rc1 material, along with
Reviewed-by tags from HCH.
Thanks for picking this up!
Note that I expect this patchset will conflict with Doug's pull request
in case he's taking Christoph's device_attr and CQ abstraction patches
for 4.5.
Doug,
V2->V3: Add check for NOIETF mode and create special table
for that case.
Check if the extended counters are available and if so
create the proper extended and additional counters.
Reviewed-by: Hal Rosenstock
Signed-off-by: Christoph Lameter
---
V2->V3
- Also add support for NOIETF counter mode where we have 64 bit
counters but not the multicast/unicast counters.
- Add Reviewed-by's from Hal.
V1->V2
- Add detection of the capability for 64 bit counter support
- Lots of improvements as a result of suggestions by Hal
Add the attr_id on port_table_attribute since we will have to add
a different port_table_attribute for the extended attribute soon.
Reviewed-by: Hal Rosenstock
Signed-off-by: Christoph Lameter
---
drivers/infiniband/core/sysfs.c | 7 +--
1 file changed, 5
Sagi, are you going to spin an increment in the initiator version?
I don't know if it's worth a driver version update?
In case we do increment, I can send an incremental patch instead of
re-spinning the entire series.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma"
Create a new function to retrieve performance management
data from the existing code in get_pma_counter().
Reviewed-by: Hal Rosenstock
Signed-off-by: Christoph Lameter
---
drivers/infiniband/core/sysfs.c | 62 ++---
1 file
Code cleanup to remove multicast specific code from ipoib_main.c
The removal of a list of multicast groups occurs in three places.
Create a new function ipoib_mcast_remove_list(). Use this new
function in ipoib_main.c too.
That in turn allows the dropping of two functions that were
exported from
V1->V2:
- Rename function as requested by Ira
Code cleanup to move multicast specific code that checks for
a sendonly join to ipoib_multicast.c. This allows the removal
of the export of __ipoib_mcast_find().
Signed-off-by: Christoph Lameter
---
V1->V2
- Add Reviewed by's for first patch from Ira Weiny
- Change name of ipoib_check_mcast_sendonly() to
ipoib_check_and_add_mcast_sendonly() as requested by Ira
This patchset cleans up the code a bit after the last round of multicast
patches related to the sendonly join logic. Some
From: Vennila Megavannan
Added the following per sdma engine stats:
- SendDmaDescFetchedCnt
- software maintained count of SDMA interrupts
(SDmaInt, SDmaIdleInt, SDmaProgressInt)
- software maintained counts of SDMA error cases
Reviewed-by: Dennis
From: Mark F. Brown
The krcvqs parameter is displayed incorrectly in sysfs.
The workaround is to set the param type as uint.
Reviewed-by: Mike Marciniszyn
Reviewed-by: Mitko Haralanov
Signed-off-by: Mark F. Brown
From: Dean Luick
The variable "index" increments the same as dd->ndevcntrs.
Just use the later. Remove uneeded usage of "index" in the
fill loop - it is not used there or later in the function.
Reviewed-by: Dennis Dalessandro
Signed-off-by:
Change the default number of krcvqs to number of numa nodes + 1
based on the performance data collected.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Jubin John
---
Changes in v2:
- None
Changes in v3:
- Refreshed patch against
From: Harish Chegondi
This would reduce L2 cache misses on s_sde in the _hfi1_schedule_send
function when invoked from post_send thereby improving performance of
post_send.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Harish Chegondi
These patches were part of series:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-December/082248.html
but did not apply cleanly to the staging-testing branch.
Refreshed the remaining 2 patches against the latest staging-testing.
Changes in v2:
- Added more
From: Ira Weiny
Total XMIT wait needs to sum the xmit wait values of all the VLs not just
those requested in the query. Also, make the algorithm used for both
PortStatus and PortDataCounters the same.
Reviewed-by: Arthur Kepner
Reviewed-by: Breyer,
From: Edward Mascarenhas
Clean up comments by deleting numbering and terms internal to Intel.
The information on the actual bugs is not deleted.
Reviewed-by: Mike Marciniszyn
Signed-off-by: Edward Mascarenhas
On 12/21/2015 5:01 PM, Matan Barak wrote:
Previously, cma_match_net_dev called cma_protocol_roce which
tried to verify that the IB device uses RoCE protocol. However,
if rdma_id didn't have a bounded port, it used the first port
of the device.
maybe prefer a higher then code speak language e.g
On Mon, Dec 21, 2015 at 08:37:26AM +0200, Leon Romanovsky wrote:
> You are right and it is a preferred way for me too, however the
> downside of such change will be one of two:
> 1. Change this structure only => we will have style mix of BITs and
> shifts in the same file. IMHO it looks awful.
>
On Wed, Dec 16, 2015 at 7:53 AM, Or Gerlitz wrote:
> On 12/15/2015 9:03 PM, Doug Ledford wrote:
>> Or, you specifically asked me to wait until this week. I made my
>> initial impressions clear (I don't necessarily like the removal of the
>> attr struct, but I like the
From: Ira Weiny
This was a single patch before. The change to dev_dbg required a precursor
patch to add the dd_dev_dbg which is consistent with the other dev_* macros
which automatically use struct hfi1_devdata.
Changes from V4:
Fix build error which arose from
From: Ira Weiny
To be used in future patches add dd_dev_dbg. dd_* functions properly decode
the hfi1_devdata structure used throughout the driver
Signed-off-by: Ira Weiny
---
drivers/staging/rdma/hfi1/hfi.h | 4
1 file changed, 4 insertions(+)
From: Dean Luick
Correctly set half-swing for integrated devices. A0 needs all fields set for
CcePcieCtrl. B0 and later only need a few fields set.
Reviewed-by: Stuart Summers
Signed-off-by: Dean Luick
Signed-off-by: Ira
These patches were part of patch series:
http://driverdev.linuxdriverproject.org/pipermail/driverdev-devel/2015-November/081566.html
but did not apply cleanly to the staging-testing branch.
Refreshed the remaining 6 patches against the latest staging-testing.
Changes in v2:
- 01/13:
This patch fixes the checkpatch issue:
CHECK: Prefer using the BIT macro
Use of BIT macro for HDRQ_INCREMENT in chip.h causes a change in
format specifier for error message in init.c in order to avoid a
build warning.
Reviewed-by: Dean Luick
Reviewed-by: Ira Weiny
On 12/21/2015 5:01 PM, Matan Barak wrote:
This patch fixes a bug in VPI systems, where the first port is configured
as IB and the second one is configured as Ethernet. In this case, if the
rdma_id isn't bounded to a port, cma_match_net_dev will try to verify that the
first port is a RoCE port
On Mon, Dec 21, 2015 at 6:20 AM, Nicholas A. Bellinger
wrote:
> Applied to target-pending/for-next as v4.5-rc1 material, along with
> Reviewed-by tags from HCH.
Hi Nic, thanks for stepping in and picking that.
Sagi, are you going to spin an increment in the initiator
On Mon, Dec 21, 2015 at 12:03:46AM -0800, Christoph Hellwig wrote:
> On Mon, Dec 21, 2015 at 08:37:26AM +0200, Leon Romanovsky wrote:
> > You are right and it is a preferred way for me too, however the
> > downside of such change will be one of two:
> > 1. Change this structure only => we will
On 12/21/2015 10:08 AM, Matan Barak wrote:
> On Sun, Dec 20, 2015 at 9:29 AM, Or Gerlitz wrote:
>> On 12/17/2015 3:58 PM, Or Gerlitz wrote:
>>>
>>> Using 4.4-rc5+ [1] and **not** applying any of the patches I sent today,
>>> I noted that RoCE passive side isn't working
On Mon, 21 Dec 2015, Leon Romanovsky wrote:
> On Mon, Dec 21, 2015 at 08:42:53AM -0600, Christoph Lameter wrote:
> > Code cleanup to remove multicast specific code from ipoib_main.c
> >
> > The removal of a list of multicast groups occurs in three places.
> > Create a new function
Previously, cma_match_net_dev called cma_protocol_roce which
tried to verify that the IB device uses RoCE protocol. However,
if rdma_id didn't have a bounded port, it used the first port
of the device.
In VPI systems, the first port might be an IB port while the second
one could be an Ethernet
On Sun, Dec 20, 2015 at 9:29 AM, Or Gerlitz wrote:
> On 12/17/2015 3:58 PM, Or Gerlitz wrote:
>>
>> Using 4.4-rc5+ [1] and **not** applying any of the patches I sent today,
>> I noted that RoCE passive side isn't working (rdma-cm, ibv_rc_pingpong
>> works).
>>
>> I have two
On Mon, Dec 21, 2015 at 08:42:53AM -0600, Christoph Lameter wrote:
> Code cleanup to remove multicast specific code from ipoib_main.c
>
> The removal of a list of multicast groups occurs in three places.
> Create a new function ipoib_mcast_remove_list(). Use this new
> function in ipoib_main.c
On Mon, Dec 21, 2015 at 08:20:27AM -0600, Christoph Lameter wrote:
> Create a new function to retrieve performance management
> data from the existing code in get_pma_counter().
>
> Reviewed-by: Hal Rosenstock
Reviewed-by: Ira Weiny
> Signed-off-by:
On Mon, Dec 21, 2015 at 08:20:28AM -0600, Christoph Lameter wrote:
> Add the attr_id on port_table_attribute since we will have to add
> a different port_table_attribute for the extended attribute soon.
>
> Reviewed-by: Hal Rosenstock
Reviewed-by: Ira Weiny
72 matches
Mail list logo