Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1

2011-10-25 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 8:33 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: It would have been nice if you bothered to mention these in any of the pre merge window reviews, but given your delay responsed on these items they will have to be something we'll fix post merge. Sorry for that

Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1

2011-10-25 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 11:01 PM, Roland Dreier rol...@purestorage.com wrote: On Mon, Oct 24, 2011 at 11:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: - Handle IB completion timeouts. Although the InfiniBand Architecture Manual specifies that a HCA must generate an error completion

Re: [PATCH 7/9] ib_srpt: Convert srp_max_rdma_size into per port configfs attribute

2011-10-25 Thread Nicholas A. Bellinger
On Mon, 2011-10-24 at 13:29 -0700, Nicholas A. Bellinger wrote: On Mon, 2011-10-24 at 05:33 +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch converts the srp_max_rdma_size module parameter into a per endpoint configfs attribute. This includes

[PATCH] rdma/cma: fixed resource leak in case of an error in udaddy

2011-10-25 Thread Dotan Barak
Fixed a resource leak in case of an error level in the udaddy example. Signed-off-by: Dotan Barak dot...@dev.mellanox.co.il --- examples/udaddy.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/examples/udaddy.c b/examples/udaddy.c index 637306a..1534df5 100644 ---

Re: [PATCH 7/9] ib_srpt: Convert srp_max_rdma_size into per port configfs attribute

2011-10-25 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 10:29 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: @@ -114,6 +114,7 @@ enum {       MIN_SRPT_SRQ_SIZE = 4,       DEFAULT_SRPT_SRQ_SIZE = 4095,       MAX_SRPT_SRQ_SIZE = 65535, +     MAX_SRPT_RDMA_SIZE = 256U, Hey btw, what should the proper

Re: [PATCH 7/9] ib_srpt: Convert srp_max_rdma_size into per port configfs attribute

2011-10-25 Thread Nicholas A. Bellinger
On Tue, 2011-10-25 at 12:32 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 10:29 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: @@ -114,6 +114,7 @@ enum { MIN_SRPT_SRQ_SIZE = 4, DEFAULT_SRPT_SRQ_SIZE = 4095, MAX_SRPT_SRQ_SIZE = 65535, +

[PATCH] RDMA/cxgb4: Mark the QP in error before disabling the Q in the firmware

2011-10-25 Thread Kumar Sanghvi
From: Tom Tucker t...@ogc.us The QP needs to be moved to error before telling the firwmare to shutdown the queue. Otherwise, the application can submit WR that will never get fetched by the hardware and never flushed by the driver. Signed-off-by: Kumar Sanghvi kuma...@chelsio.com ---

mlx4 missing completions (was Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1)

2011-10-25 Thread Roland Dreier
On Mon, Oct 24, 2011 at 11:07 PM, Bart Van Assche bvanass...@acm.org wrote: As far as I know every HCA supported by Linux does implement this correctly.  Which class did you have in mind as not doing that? At least QDR ConnectX 2 HCAs with fairly recent firmware. This behavior can be

Re: [PATCH 07/10] RDMA/cxgb4: DB Drop Recovery for RDMA and LLD queues.

2011-10-25 Thread Roland Dreier
On Mon, Oct 24, 2011 at 2:12 PM, David Miller da...@davemloft.net wrote: 1. We would like to recommend that all the patches get included in Roland's infiniband tree since it has build dependencies. This is fine with me.  It just means that Roland's tree has to have net-next included in it

[PATCH] IB/qib: Fix kernel panic on QME7342 boards

2011-10-25 Thread Mike Marciniszyn
From: Mitko Haralanov mi...@qlogic.com Fix a kernel panic on QME7342 (and any Mezz boards without QSFP connectors) caused by scheduling work on uninitialized workqueue introduced by 62066fc8df4632c772d723813ce7af456d62ddf7. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike

Re: mlx4 missing completions (was Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1)

2011-10-25 Thread Bart Van Assche
On Tue, Oct 25, 2011 at 1:17 PM, Roland Dreier rol...@purestorage.com wrote: On Mon, Oct 24, 2011 at 11:07 PM, Bart Van Assche bvanass...@acm.org wrote: As far as I know every HCA supported by Linux does implement this correctly.  Which class did you have in mind as not doing that? At

Re: mlx4 missing completions (was Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1)

2011-10-25 Thread Roland Dreier
On Tue, Oct 25, 2011 at 11:09 AM, Bart Van Assche bvanass...@acm.org wrote: It's a little more complex than that. The original version of ib_srpt stops polling for completions as soon as the last WQE event has been received and after that the queue has been drained. So I don't know whether