[PATCH 1/3] ib_srpt: Update encode_wr_id() argument type

2011-11-11 Thread Bart Van Assche
Since commit 6b7227866 the first argument passed to encode_wr_id() is always of type enum srpt_opcode. Make this explicit by updating the function declaration. Also insert a blank line between function definitions as is done in the rest of the Linux kernel. Signed-off-by: Bart Van Assche

[PATCH 2/3] ib_srpt: Spelling fixes

2011-11-11 Thread Bart Van Assche
Fix spelling in one error message and in several source code comments. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Nicholas Bellinger n...@linux-iscsi.org Cc: Roland Dreier rol...@purestorage.com Cc: Christoph Hellwig h...@infradead.org --- drivers/infiniband/ulp/srpt/ib_srpt.c | 10

[PATCH 3/3] ib_srpt: Simplify __srpt_lookup_port()

2011-11-11 Thread Bart Van Assche
The sdev-device pointer is initialized in srpt_add_one() and is not modified until the sdev structure is freed in srpt_remove_one(). An sdev structure is only added to srpt_dev_list after the device pointer has been initialized and is removed from that list before srpt_remove_one() returns. Calls

Re: [opensm] [PATCH 1/2] Fix segfault corner case

2011-11-11 Thread Alex Netes
Hi Al, On 10:01 Thu 10 Nov , Albert Chu wrote: On rescan, data segment memory could be attempted to be freed by config file parsing code. Signed-off-by: Albert L. Chu ch...@llnl.gov --- opensm/osm_subnet.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

[PATCH 6/6] infiniband/nes: Disable ASPM

2011-11-11 Thread Matthew Garrett
The Windows driver .inf disables ASPM on hpsa devices. Do the same. Signed-off-by: Matthew Garrett m...@redhat.com Cc: faisal.la...@intel.com Cc: linux-rdma@vger.kernel.org --- drivers/infiniband/hw/nes/nes.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git

[PATCH V2 6/6] infiniband/nes: Disable ASPM

2011-11-11 Thread Matthew Garrett
The Windows driver .inf disables ASPM on hpsa devices. Do the same. Signed-off-by: Matthew Garrett m...@redhat.com Cc: faisal.la...@intel.com Cc: linux-rdma@vger.kernel.org --- drivers/infiniband/hw/nes/nes.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git

Linux 3.2-rc1 vs. OFED 1.5.4-rc4: Packets are looped back

2011-11-11 Thread Christoph Lameter
We have an app here that runs fine with OFED. But if I try to use the kernel IB subsystem in 3.2 it complains about packets being looped back to the application. That seems to be controlled by IB_DEVICE_BLOCK_MULTICAST_LOOPBACK and IB_QP_CREATE_BLOCK_MULTICAST_LOOPBACK. Why does it not work in

Re: [PATCH 6/6] infiniband/nes: Disable ASPM

2011-11-11 Thread Roland Dreier
On Fri, Nov 11, 2011 at 8:05 AM, Matthew Garrett m...@redhat.com wrote: The Windows driver .inf disables ASPM on hpsa devices. Do the same. This isn't a patch to the hpsa driver... cut and paste in the description, or misfire on the patch? Faisal, any info on whether this is needed/desired for

Re: [opensm] [PATCH 1/2] Fix segfault corner case

2011-11-11 Thread Albert Chu
On Fri, 2011-11-11 at 04:19 -0800, Alex Netes wrote: Hi Al, On 10:01 Thu 10 Nov , Albert Chu wrote: On rescan, data segment memory could be attempted to be freed by config file parsing code. Signed-off-by: Albert L. Chu ch...@llnl.gov --- opensm/osm_subnet.c |2 +- 1

Re: [opensm] [PATCH 1/2] Fix memleak and segfault

2011-11-11 Thread Albert Chu
If invalid input specified by user, memory would not be freed. On rescan with new value, data segment memory could be attempted to be freed. Signed-off-by: Albert L. Chu ch...@llnl.gov --- opensm/osm_subnet.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git

Re: [PATCH 6/6] infiniband/nes: Disable ASPM

2011-11-11 Thread Roland Dreier
Sorry, yes, cut and paste in the description. It should say nes. OK. Just got a vacation message from Faisal that he's out til next week, let's see if Intel has a comment on this. Thanks, Roland -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message

Re: [opensm] [PATCH] Fix potential memleak

2011-11-11 Thread Albert Chu
Hey Alex, Argh! You can forget about this patch. It is a memleak, but I see why an earlier author did it this way. I'll solve the memleak in a different way in a different patch series. Al On Thu, 2011-11-10 at 16:51 -0800, Albert Chu wrote: Strings may have been already strduped from