re: mlx5: Add driver for Mellanox Connect-IB adapters

2013-07-10 Thread Dan Carpenter
--- Side note: Sparse should warn about endian bugs but in linux-next endian checking is disabled because we hit: include/uapi/linux/swab.h:71:16: error: undefined identifier '__builtin_bswap64' include/uapi/linux/swab.h:71:33: error: not a function noident do_error() in Sparse disables warning

re: mlx5: Add driver for Mellanox Connect-IB adapters

2013-07-10 Thread Dan Carpenter
Hello Eli Cohen, The patch e126ba97dba9: mlx5: Add driver for Mellanox Connect-IB adapters from Jul 7, 2013, leads to the following Smatch warning: drivers/net/ethernet/mellanox/mlx5/core/cmd.c:822 mlx5_alloc_cmd_msg() warn: use 'flags' here instead of GFP_XXX? 811 static struct

[patch -next] mlx5_core: return -EFAULT if copy_to_user() fails

2013-07-10 Thread Dan Carpenter
This should return an error code instead of the number of bytes remaining to be copied. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c b/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c index a550a8e..4273c06 100644 ---

[patch -next] mlx5: return -EFAULT instead of -EPERM

2013-07-10 Thread Dan Carpenter
For copy_to/from_user() failure, the correct error code is -EFAULT not -EPERM. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index e2daa8f..bd41df9 100644 --- a/drivers/infiniband/hw/mlx5/mr.c +++

Re: mlx5: Add driver for Mellanox Connect-IB adapters

2013-07-10 Thread Or Gerlitz
On 10/07/2013 13:54, Dan Carpenter wrote: --- Side note: Sparse should warn about endian bugs but in linux-next endian checking is disabled because we hit: include/uapi/linux/swab.h:71:16: error: undefined identifier '__builtin_bswap64' include/uapi/linux/swab.h:71:33: error: not a function

[PATCH] mlx5_core: Adjust hca_cap.uar_page_sz to conform to Connect-IB spec

2013-07-10 Thread Or Gerlitz
From: Moshe Lazer mos...@mellanox.com Sparse check reported an endianness bug regarding assignment to hca_cap.uar_page_sz. Fix the declaration of this field to be __be16 (which is what is indicated in the firmware spec), renaming the field to log_uar_pg_size to conform to the spec, and

Re: [patch -next] mlx5: return -EFAULT instead of -EPERM

2013-07-10 Thread Or Gerlitz
On 10/07/2013 13:58, Dan Carpenter wrote: For copy_to/from_user() failure, the correct error code is -EFAULT not -EPERM. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/infiniband/hw/mlx5/mr.c b/drivers/infiniband/hw/mlx5/mr.c index e2daa8f..bd41df9 100644 ---

Re: [patch -next] mlx5_core: return -EFAULT if copy_to_user() fails

2013-07-10 Thread Or Gerlitz
On 10/07/2013 13:57, Dan Carpenter wrote: This should return an error code instead of the number of bytes remaining to be copied. Signed-off-by: Dan Carpenter dan.carpen...@oracle.com diff --git a/drivers/net/ethernet/mellanox/mlx5/core/debugfs.c

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-10 Thread Jeff Squyres (jsquyres)
On Jul 8, 2013, at 1:26 PM, Jason Gunthorpe jguntho...@obsidianresearch.com wrote: Jeff's patch doesn't break old binaries, old binaries, running with normal IB MTUs work fine. The structure layouts all stay the same, etc. FWIW, I did a simple test to confirm this. I installed a stock git

Re: [GIT PULL] please pull infiniband.git

2013-07-10 Thread Roland Dreier
On Wed, Jul 10, 2013 at 7:35 AM, Sebastian Riemer sebastian.rie...@profitbricks.com wrote: I've checked the commits on that tag and the following commit is not what we've agreed on: Sorry about that. The discussion was long and complex and I probably made a mistake in aplying the patches.

Re: [GIT PULL] please pull infiniband.git

2013-07-10 Thread Bart Van Assche
On 07/10/13 16:38, Roland Dreier wrote: On Wed, Jul 10, 2013 at 7:35 AM, Sebastian Riemer sebastian.rie...@profitbricks.com wrote: I've checked the commits on that tag and the following commit is not what we've agreed on: Sorry about that. The discussion was long and complex and I probably

[PATCH] IB/srp: Let srp_abort() return FAST_IO_FAIL if TL offline

2013-07-10 Thread Bart Van Assche
If the transport layer is offline it is more appropriate to let srp_abort() return FAST_IO_FAIL instead of SUCCESS. Signed-off-by: Bart Van Assche bvanass...@acm.org Reported-by: Sebastian Riemer sebastian.rie...@profitbricks.com Cc: David Dillow dillo...@ornl.gov Cc: Roland Dreier

Re: [PATCH] IB/srp: Let srp_abort() return FAST_IO_FAIL if TL offline

2013-07-10 Thread Sebastian Riemer
Hi Bart, my patch looks very similar. I was in a company meeting so I couldn't send it fast enough. Can be applied that way! Thanks! Cheers, Sebastian On 10.07.2013 17:36, Bart Van Assche wrote: If the transport layer is offline it is more appropriate to let srp_abort() return FAST_IO_FAIL

Re: [PATCH] IB/srp: Let srp_abort() return FAST_IO_FAIL if TL offline

2013-07-10 Thread David Dillow
On Wed, 2013-07-10 at 17:36 +0200, Bart Van Assche wrote: If the transport layer is offline it is more appropriate to let srp_abort() return FAST_IO_FAIL instead of SUCCESS. Signed-off-by: Bart Van Assche bvanass...@acm.org Reported-by: Sebastian Riemer sebastian.rie...@profitbricks.com Cc:

Re: mlx5: Add driver for Mellanox Connect-IB adapters

2013-07-10 Thread Josh Triplett
On Wed, Jul 10, 2013 at 01:54:15PM +0300, Dan Carpenter wrote: --- Side note: Sparse should warn about endian bugs but in linux-next endian checking is disabled because we hit: include/uapi/linux/swab.h:71:16: error: undefined identifier '__builtin_bswap64'

[PATCH] libibverbs: Add the use of IBV_SEND_INLINE to example pingpong programs

2013-07-10 Thread Jeff Squyres
If the send size is less than the cap.max_inline_data reported by the qp, use the IBV_SEND_INLINE flag. This now only shows the example of using ibv_query_qp(), it also reduces the latency time shown by the pingpong programs when the sends can be inlined. Signed-off-by: Jeff Squyres