ibutils license problems + a few other minor issues

2010-02-11 Thread Doug Ledford
Are in man1, but have no corresponding executables. Perhaps they should be in a different man section? -- Doug Ledford dledf...@redhat.com GPG KeyID: CFBFF194 http://people.redhat.com/dledford Infiniband specific RPMs available at http://people.redhat.com

Re: [PATCH 2/2] ib/cm: Bump reference count on cm_id before invoking callback

2011-02-23 Thread Doug Ledford
. This problem was noticed as part of a larger investigation with kernel crashes in the rdma_cm when running on a real time OS. Signed-off-by: Sean Hefty sean.he...@intel.com Acked-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/core/cm.c |1 + 1 files changed, 1 insertions(+), 0

Re: [PATCH 1/2] rdma/cm: Fix crash in request handlers

2011-02-23 Thread Doug Ledford
On Wed, 2011-02-23 at 08:11 -0800, Hefty, Sean wrote: Doug Ledford and RedHat reported a crash when running the rdma_cm on a real time OS. The crash has the following call trace: cm_process_work cma_req_handler cma_disable_callback rdma_create_id

Re: [PATCH 1/2] rdma/cm: Fix crash in request handlers

2011-03-15 Thread Doug Ledford
function more than once. -- Doug Ledford dledf...@redhat.com GPG KeyID: CFBFF194 http://people.redhat.com/dledford Infiniband specific RPMs available at http://people.redhat.com/dledford/Infiniband signature.asc Description: This is a digitally signed

[Patch] mlx4: make mcg entry size a module parameter

2011-03-23 Thread Doug Ledford
. This has been tested at our customer's site and solves their problem. commit ff608ce370b49d2e5b614ff91f4e23b5deaac8a4 Author: Doug Ledford dledf...@redhat.com Date: Wed Mar 23 12:20:47 2011 -0400 mlx4: make the size of the mcg entry a module parameter Testing showed that the default size

[Patch infiniband-diags:perfquery] Loop through all local HCAs/ports

2011-07-29 Thread Doug Ledford
The -a mode of perfquery is intended to loop through all ports on a single HCA and provide aggregated output across all ports. The -l mode is intended to loop through all ports of a single HCA and output non-aggregated data. Neither mode addresses a machine with more than one HCA.

Re: [Patch infiniband-diags:perfquery] Loop through all local HCAs/ports

2011-07-29 Thread Doug Ledford
On 07/29/2011 05:57 PM, Doug Ledford wrote: + if (umad_get_ca(name_list[cur_name], ca)) + /* We're done, the next name was +* empty, just exit gracefully

Re: [Patch infiniband-diags:perfquery] Loop through all local HCAs/ports

2011-07-29 Thread Doug Ledford
On 07/29/2011 06:09 PM, Jason Gunthorpe wrote: On Fri, Jul 29, 2011 at 05:57:57PM -0400, Doug Ledford wrote: The -a mode of perfquery is intended to loop through all ports on a single HCA and provide aggregated output across all ports. The -l mode is intended to loop through all ports

Re: [Patch infiniband-diags:perfquery] Loop through all local HCAs/ports

2011-07-30 Thread Doug Ledford
, and then loops over all the ports as returned by libibumad's umad_get_ca(). -- Doug Ledford dledf...@redhat.com GPG KeyID: CFBFF194 http://people.redhat.com/dledford Infiniband specific RPMs available at http://people.redhat.com/dledford/Infiniband

[Patch libibverbs-1.1.5] Fix broken compat assumption on ppc arch

2011-08-02 Thread Doug Ledford
will attempt a simple memcpy if possible, or two memcpy's in the case that wr needed padding to be aligned (as is the case on ppc), and fall back to field based copy just in case this is compiled on some arch with really odd field alignment characteristics. Signed-off-by: Doug Ledford dledf

Re: Building 3.1-rc9 in kernel infiniband support with OFED libraries

2011-10-14 Thread Doug Ledford
we don't follow OFED in RHEL6. -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info

ibacm fixes/updates

2012-02-28 Thread Doug Ledford
that should not see the time of day ;-) OK, gotta run. Would like to see this stuff picked up, especially the init stuff. Getting it in your release before we have one init script, SuSE another, and OFED another will help keep things uniform. -- Doug Ledford dledf...@redhat.com GPG

Re: ibacm fixes/updates

2012-02-28 Thread Doug Ledford
On 02/28/2012 04:08 PM, Doug Ledford wrote: By default ibacm expects to find its configuration files in /etc/ibacm. This adds to the proliferation of directories in /etc/ needlessly. We already have a number of RDMA related directories to choose from depending on your install (OFED == /etc

[Patch opensm] Allow for easily configuring multiple fabrics on one opensm server

2012-02-28 Thread Doug Ledford
quite so often? -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford #!/bin/bash # # Bring up/down opensm # # chkconfig: - 15 85 # description: Activates/Deactivates InfiniBand Subnet Manager # config: /etc/ofed/opensm.conf

Re: [Patch opensm] Allow for easily configuring multiple fabrics on one opensm server

2012-03-01 Thread Doug Ledford
On 02/29/2012 09:15 PM, Brian Ginsbach wrote: On Wed, Feb 29, 2012 at 02:47:00PM -0500, Doug Ledford wrote: On 02/29/2012 02:22 PM, Ira Weiny wrote: Doug, First thanks for this. Some comments below. On Wed, 29 Feb 2012 00:01:16 -0500 Doug Ledford dledf...@redhat.com wrote: There are two

Re: [Patch opensm] Allow for easily configuring multiple fabrics on one opensm server

2012-03-02 Thread Doug Ledford
On 3/2/2012 5:30 AM, Alex Netes wrote: On 11:22 Wed 29 Feb , Ira Weiny wrote: Doug, First thanks for this. Some comments below. On Wed, 29 Feb 2012 00:01:16 -0500 Doug Ledford dledf...@redhat.com wrote: There are two things that stand in the way of opensm being run on redundant

Re: [Patch opensm] Allow for easily configuring multiple fabrics on one opensm server

2012-03-02 Thread Doug Ledford
On 3/2/2012 10:31 AM, Doug Ledford wrote: On 3/2/2012 5:30 AM, Alex Netes wrote: What the default opensm.conf would be used for? Just as a reference to the default values? No, he's referring to having a default config file that is parsed, then an override config file that is parsed where

Re: [Patch opensm] Allow for easily configuring multiple fabrics on one opensm server

2012-03-05 Thread Doug Ledford
- Original Message - On 3/1/2012 8:31 AM, Doug Ledford wrote: I would say we are simply getting to the point where we *know* we need opensm to handle more than one fabric from a single instance ;-) Why does a single OpenSM need to handle multiple subnets/fabrics ? What's

Re: [Patch opensm] Allow for easily configuring multiple fabrics on one opensm server

2012-03-05 Thread Doug Ledford
- Original Message - On 3/5/2012 10:28 AM, Doug Ledford wrote: - Original Message - On 3/1/2012 8:31 AM, Doug Ledford wrote: I would say we are simply getting to the point where we *know* we need opensm to handle more than one fabric from a single instance ;-) Why

Re: [RFC] Proposal to change Node Description naming scheme for HCA's

2012-04-01 Thread Doug Ledford
I'm fine with this change. If people agree, I'll make it so in our products. Sent from my ASUS Eee Pad Ira Weiny wei...@llnl.gov wrote: First, a question: what package installs the openibd script in OFED? For the life of me I can't find this script in 1.5.4.1 or 3.2 ... :-/ [*] Right now

Re: ibacm fixes/updates

2012-04-05 Thread Doug Ledford
)$(sysconfdir)/acm_addr.cfg; OK, will do. -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford signature.asc Description: OpenPGP digital signature

Re: [PATCH] ibacm: Fixes to ACM package to support distros

2012-04-05 Thread Doug Ledford
On 04/03/2012 03:10 PM, Hefty, Sean wrote: Set of changes to fixup the ibacm package for inclusion into RedHat 6. Changes are based on feedback from Doug Ledford dledf...@redhat.com. These are primarily changes to the build files, along with name changes to the man pages and sample

Re: [RFC] Proposal to change Node Description naming scheme for HCA's

2012-04-05 Thread Doug Ledford
for a major release update. -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford signature.asc Description: OpenPGP digital signature

Re: [PATCH] ibacm: Fixes to ACM package to support distros

2012-04-05 Thread Doug Ledford
--rebuild name_of_tarball rpm -Uvh ~/rpmbuild/RPMS/arch/rpmlist You might need this in your ~/.rpmmacros file: %_topdir %(echo $HOME)/rpmbuild -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford signature.asc Description

Re: [PATCH] ibacm: Fixes to ACM package to support distros

2012-04-17 Thread Doug Ledford
seemingly never ending ToDo list :-/ -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford signature.asc Description: OpenPGP digital signature

Re: [PATCH v2] ibacm: Fixes to ACM package to support distros

2012-04-17 Thread Doug Ledford
On 04/06/2012 01:12 PM, Hefty, Sean wrote: ibacm: Fixes to ACM package to support distros From: Sean Hefty sean.he...@intel.com Set of changes to fixup the ibacm package for inclusion into RedHat 6. Changes are based on feedback from Doug Ledford dledf...@redhat.com. These are primarily

Re: [PATCH for-next V2 01/22] IB/core: Reserve bits in enum ib_qp_create_flags for low-level driver use

2012-09-05 Thread Doug Ledford
*/ + IB_QP_CREATE_RESERVED_START = 1 26, + IB_QP_CREATE_RESERVED_END = 1 31, }; struct ib_qp_init_attr { Reserving 6 bits for driver use out of 32 seems reasonable. Acked-by: Doug Ledford dledf...@redhat.com -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD

Re: [PATCH for-next V2 02/22] IB/core: change pkey table lookups to support full and partial membership for the same pkey

2012-09-11 Thread Doug Ledford
) { + *index = partial_ix; + return 0; + } return -ENOENT; } EXPORT_SYMBOL(ib_find_pkey); -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford Infiniband specific RPMs available

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Doug Ledford
of the device to query. -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford Infiniband specific RPMs available at http://people.redhat.com/dledford/Infiniband signature.asc Description: OpenPGP digital signature

Re: [PATCH for-next V2 04/22] IB/mlx4: SRIOV IB context objects and proxy/tunnel sqp support

2012-09-11 Thread Doug Ledford
the time, or would it be better to save off your status on device init and just refer to that when you would do math in this patch? -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford Infiniband specific RPMs available

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Doug Ledford
these should be generally useful and used by all drivers. Mike? -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford Infiniband specific RPMs available at http://people.redhat.com/dledford/Infiniband signature.asc

Re: [PATCH for-next V2 03/22] IB/core: Add ib_find_exact_cached_pkey() to search for 16-bit pkey match

2012-09-11 Thread Doug Ledford
On 9/11/2012 4:43 PM, Roland Dreier wrote: On Tue, Sep 11, 2012 at 1:34 PM, Doug Ledford dledf...@redhat.com wrote: Well, at this point, the mlx4 driver uses them, the rdmacm kernel driver uses them, and both QLogic/Intel drivers have their own internal pkey table implementation. So, it isn't

Re: [PATCH for-next V2 02/22] IB/core: change pkey table lookups to support full and partial membership for the same pkey

2012-09-12 Thread Doug Ledford
. My concern is that I could see a valid scenario that a user might want to implement for security reasons that I think makes your assumption above incorrect. -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford signature.asc

Problem running rping over Intel adapters

2012-10-03 Thread Doug Ledford
number? Matters not to me... -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford Infiniband specific RPMs available at http://people.redhat.com/dledford/Infiniband signature.asc Description: OpenPGP digital signature

Re: Problem running rping over Intel adapters

2012-10-03 Thread Doug Ledford
rdma cm should probably check for a valid value and reduce it accordingly. Then it's also fair to say that right now rping passes a known invalid value and needs fixed ;-) -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford

[Patch libibverbs 0/5] Minor updates

2012-10-14 Thread Doug Ledford
This is a short series of fixes for minor issues. The most important being a memcpy buffer overrun on ppc arch for the compatibility wrapper. The rest are usability fixes for the example programs. Doug Ledford (5): Add an error when the user specifies an invalid port Don't allow port == 0

[Patch libibverbs 1/5] Add an error when the user specifies an invalid port

2012-10-14 Thread Doug Ledford
Signed-off-by: Doug Ledford dledf...@redhat.com --- examples/devinfo.c |8 +++- 1 files changed, 7 insertions(+), 1 deletions(-) diff --git a/examples/devinfo.c b/examples/devinfo.c index 7dc0463..b1a3b2e 100644 --- a/examples/devinfo.c +++ b/examples/devinfo.c @@ -218,10 +218,16

[Patch libibverbs 4/5] Don't print link phys state on iWARP

2012-10-14 Thread Doug Ledford
The physical link state on iWARP transports has no meaning, so don't print it out at all. Signed-off-by: Doug Ledford dledf...@redhat.com --- examples/devinfo.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/examples/devinfo.c b/examples/devinfo.c index d6e9218

[Patch libibverbs 3/5] Fix the compatibility wrapper on ppc

2012-10-14 Thread Doug Ledford
Jelinek from the gcc team inside Red Hat. Signed-off-by: Doug Ledford dledf...@redhat.com --- src/compat-1_0.c | 42 -- 1 files changed, 40 insertions(+), 2 deletions(-) diff --git a/src/compat-1_0.c b/src/compat-1_0.c index fff6412..36884bb 100644

[Patch libibverbs 2/5] Don't allow port == 0 as an option

2012-10-14 Thread Doug Ledford
We special case port == 0 to mean all ports, and it's the default, so if a user passes in 0, they likely meant 1 instead. Throw an error because they probably didn't mean to specify the default behavior of scan all ports. Path of least surprise and all that. Signed-off-by: Doug Ledford dledf

[Patch libibverbs 5/5] Don't try to send UD messages larger than MTU

2012-10-14 Thread Doug Ledford
The UD protocol doesn't support message sizes larger than the path MTU. We don't go so far as to check path MTU, but we do check port MTU. This prevents failed runs of the pingpong_ud program with large MTUs. Signed-off-by: Doug Ledford dledf...@redhat.com --- examples/ud_pingpong.c | 14

[Patch] ib/mlx4: Fix build error on platforms where UL is not 64bit

2012-10-16 Thread Doug Ledford
Line 110 uses UL as a compiler cast for the 0x constant, but it's not large enough to hold a 64bit value on 32bit arches. Use ULL instead. Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/hw/mlx4/alias_GUID.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff

Re: [PATCH 3/4 for opensm] /etc/init.d/opensmd: Improve systemd integration

2012-10-24 Thread Doug Ledford
need a pidfile so make sure that one gets created. Also, correct the opensm service dependency list. Signed-off-by: Bart Van Assche bvanass...@acm.org Cc: Doug Ledford dledf...@redhat.com --- configure.in |6 ++ scripts/opensm.init.in| 26

Re: [PATCH 3/4 for opensm] /etc/init.d/opensmd: Improve systemd integration

2012-10-24 Thread Doug Ledford
On 10/24/2012 10:45 AM, Bart Van Assche wrote: On 10/24/12 16:33, Doug Ledford wrote: On 10/24/2012 9:27 AM, Alex Netes wrote: On 16:44 Fri 21 Sep , Bart Van Assche wrote: start () { +if [ -e $pidfile ]; then On opensm segfault (happens one in a while :), pidfile won't be removed

Re: [PATCH] opensm/configure.in: Remove Default-Start from opensmd init script

2013-01-30 Thread Doug Ledford
On 1/30/2013 11:00 AM, Bart Van Assche wrote: On 01/30/13 16:43, Doug Ledford wrote: On 01/30/13 03:59, Bart Van Assche wrote: On 01/29/13 18:18, Alex Netes wrote: During opensm RPM packaging, `chkconfig --add opensmd` is called. `chkconfig --add` creates the appropriate entry as specified

Re: [PATCH] opensm/configure.in: Remove Default-Start from opensmd init script

2013-01-30 Thread Doug Ledford
On 1/30/2013 2:12 PM, Bart Van Assche wrote: On 01/30/13 18:48, Doug Ledford wrote: On 1/30/2013 11:00 AM, Bart Van Assche wrote: Which convention is followed for other packages ? This is what I found in the Fedora 18 iscsi-initiator-utils package (http://be.mirror.eurid.eu/fedora/linux

Re: [PATCH] opensm/configure.in: Remove Default-Start from opensmd init script

2013-01-31 Thread Doug Ledford
On 01/31/13 02:21, Alex Netes wrote: On 14:24 Wed 30 Jan , Doug Ledford wrote: On 1/30/2013 2:12 PM, Bart Van Assche wrote: On 01/30/13 18:48, Doug Ledford wrote: On 1/30/2013 11:00 AM, Bart Van Assche wrote: Which convention is followed for other packages ? This is what I found

[PATCH] ipoib: fix hard_header return value

2013-03-26 Thread Doug Ledford
is immediately referenced in the ipoib_start_xmit routine, so I'm wondering how this ever worked in distro/ofed kernels that also have this bug, but fixing the bug here makes things work in upstream kernels. Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 2

Re: [PATCH] ipoib: fix hard_header return value

2013-03-26 Thread Doug Ledford
a good catch. Cool, thanks! -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford signature.asc Description: OpenPGP digital signature

Re: [PATCH] ipoib: fix hard_header return value

2013-03-27 Thread Doug Ledford
On 03/26/2013 02:16 PM, Jason Gunthorpe wrote: On Tue, Mar 26, 2013 at 09:46:28AM -0700, Roland Dreier wrote: Checkpatch recommends since some time to use sizeof(e) instead of sizeof e, isn't it ? I actually prefer sizeof e since sizeof is an operator, not a function. sizeof(e) looks just

Re: [PATCH 2/2] Ad IB_MTU_1500|9000 enums.

2013-04-19 Thread Doug Ledford
On 04/19/2013 11:24 AM, Jeff Squyres (jsquyres) wrote: On Apr 12, 2013, at 11:40 AM, Jeff Squyres (jsquyres) jsquy...@cisco.com wrote: As an aside I like the use of RDMA_MTU_* for these values. Again to distinguish them from the IBTA values. But I know that is poor form. So what's the

Re: [PATCH 2/2] Ad IB_MTU_1500|9000 enums.

2013-04-22 Thread Doug Ledford
On 04/20/2013 07:29 PM, Hefty, Sean wrote: This seems reasonable, but still concerns me a bit. The original version was flat out wrong because you can't re-arrange any exposed enum like this without requiring that all user space apps be recompiled. This is especially true because

Re: [PATCH 2/2] Ad IB_MTU_1500|9000 enums.

2013-04-22 Thread Doug Ledford
On 04/22/2013 02:00 PM, Jeff Squyres (jsquyres) wrote: 2. Change all instances of ib_mtu/ibv_mtu to an int. Code such as switch(mtu) case IBV_MTU_1024: ... will need to be updated to switch(mtu) case 1024: PRO: solves the problem for all MTU values PRO: eliminates the num-to-int

Re: [PATCH] ipoib: fix hard_header return value

2013-04-23 Thread Doug Ledford
On 04/01/13 17:25, Or Gerlitz wrote: Doug Ledford dledf...@redhat.com wrote: If you have a patched up dhcp server (and dhclient), Could you be more specific, I assume you refer to the ISC dhcp bits, which version and which patches? Any version of dhcp server, and the improved-xid and lpf-ib

Re: libibverbs / libmlx4 release

2013-05-20 Thread Doug Ledford
On 05/20/2013 12:49 PM, Roland Dreier wrote: On Mon, May 20, 2013 at 5:37 AM, Or Gerlitz ogerl...@mellanox.com wrote: Following what we discussed last week during the Linux Foundation EU summit, I think it would be good to follow what you said and have a point release for libibverbs and

Re: BUG: unable to handle kernel paging request at 0000000000070a78 IPoIB

2013-05-23 Thread Doug Ledford
handling, and some of your traces look vaguely familiar to that old failuer). -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford signature.asc Description: OpenPGP digital signature

Re: BUG: unable to handle kernel paging request at 0000000000070a78 IPoIB

2013-05-23 Thread Doug Ledford
On 05/23/2013 02:53 PM, Jack Wang wrote: On 2013年05月23日 19:41, Doug Ledford wrote: On 05/23/2013 11:38 AM, Jack Wang wrote: Tainted: G O 3.4.23-pserver-hotfix+ #109 System manufacturer ^^^ I would try a newer kernel. There are a couple known issues

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU.

2013-06-20 Thread Doug Ledford
On 06/20/2013 10:21 AM, Jeff Squyres wrote: Keep IBV_MTU_* enums values as they are, but pass MTU values around as int's. This is an ABI-compatible change; legacy applications will use the enum values, I'm not really concerned with what the legacy apps use so much as what they are presented

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU.

2013-06-20 Thread Doug Ledford
On 06/20/2013 12:34 PM, Doug Ledford wrote: On 06/20/2013 10:21 AM, Jeff Squyres wrote: Keep IBV_MTU_* enums values as they are, but pass MTU values around as int's. This is an ABI-compatible change; legacy applications will use the enum values, I'm not really concerned with what

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU.

2013-06-20 Thread Doug Ledford
On 06/20/2013 12:53 PM, Jason Gunthorpe wrote: On Thu, Jun 20, 2013 at 12:34:04PM -0400, Doug Ledford wrote: On 06/20/2013 10:21 AM, Jeff Squyres wrote: Keep IBV_MTU_* enums values as they are, but pass MTU values around as int's. This is an ABI-compatible change; legacy applications will use

Re: [PATCH] libibverbs: Allow arbitrary int values for MTU

2013-06-20 Thread Doug Ledford
On 06/18/2013 02:49 PM, Jason Gunthorpe wrote: This is simpler: { static char str[16]; snprintf(str, sizeof(str), %d, ibv_mtu_to_num(max_mtu)); return str; } That is not, however, multi-thread safe nor advisable unless you clearly indicate in the man page to the

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU.

2013-06-20 Thread Doug Ledford
On 06/20/2013 05:14 PM, Jason Gunthorpe wrote: On Thu, Jun 20, 2013 at 04:31:14PM -0400, Doug Ledford wrote: happened for iwarp, rocee, etc. If it happened once, then I would agree with you above. That it *keeps* happening is the issue. To me, that's a clear indication that instead

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU.

2013-06-21 Thread Doug Ledford
On 06/21/2013 02:36 AM, Jason Gunthorpe wrote: On Thu, Jun 20, 2013 at 08:31:07PM -0400, Doug Ledford wrote: The new transports have new requirements, and the apps have new required behaviors - the API simply can't hide all this in every case. The changes before had nothing to do with MTU

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU.

2013-06-21 Thread Doug Ledford
On 06/21/2013 02:26 PM, Jason Gunthorpe wrote: On Fri, Jun 21, 2013 at 01:36:01PM -0400, Doug Ledford wrote: The new transports have new requirements, and the apps have new required behaviors - the API simply can't hide all this in every case. The changes before had nothing to do with MTU

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-17 Thread Doug Ledford
On 07/16/2013 08:16 PM, Roland Dreier wrote: On Tue, Jul 16, 2013 at 10:11 AM, Jeff Squyres (jsquyres) jsquy...@cisco.com wrote: - doing it this way preserves ABI, so existing binaries are safe I still don't get this. Wouldn't an existing binary be pretty surprised to get a value wildly

Re: [PATCH V2] libibverbs: Allow arbitrary int values for MTU

2013-07-30 Thread Doug Ledford
On 07/30/2013 02:45 PM, Atchley, Scott wrote: http://en.wikipedia.org/wiki/Internet_forum#Thread When a member posts in a thread it will jump to the top since it is the latest updated thread. Similarly, other threads will jump in front of it when they receive posts. When a member posts in a

[PATCH] IB/cma: use cached gids

2013-09-08 Thread Doug Ledford
of slow function that allowed us to track down the fact that the original patch I mentioned above backed out cache usage and identify just how much that impacted the system. Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/core/cma.c | 35

Re: [PATCH] IB/cma: use cached gids

2013-09-10 Thread Doug Ledford
On 09/10/2013 09:17 PM, Roland Dreier wrote: On Sun, Sep 8, 2013 at 2:44 PM, Doug Ledford dledf...@redhat.com wrote: - ret = find_gid_port(cma_dev-device, iboe_gid, port); + ret = ib_find_cached_gid(cma_dev-device

[Patch v2 3/3] IB/cache: don't fill the cache with junk

2013-09-24 Thread Doug Ledford
, and the cmtime utilitity from librdmacm does not do that. Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/core/cache.c | 132 +++- 1 file changed, 103 insertions(+), 29 deletions(-) diff --git a/drivers/infiniband/core/cache.c b/drivers/infiniband

[Patch v2 2/3] IB/cma: Check for GID on listening device first

2013-09-24 Thread Doug Ledford
8876.00 586.49 Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/core/cma.c | 36 ++-- 1 file changed, 30 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c index c62ff9e..dadc486

[Patch v2 1/3] IB/cma: use cached gids

2013-09-24 Thread Doug Ledford
the fact that the original patch I mentioned above backed out cache usage and identify just how much that impacted the system. Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/core/cma.c | 35 ++- 1 file changed, 6 insertions(+), 29 deletions

[Patch v2 0/3] Fix GID lookup performance regression

2013-09-24 Thread Doug Ledford
. As a mathematical experiment, mlx4 hardware (dual port) has a 128 entry GID table, and without this patch, if the GID you are looking for is on a second port, or God forbid a second card, then the slowdown to search for the right GID is entirely unlivable. Doug Ledford (3): IB/cma: use cached gids IB/cma

Re: [Patch v2 3/3] IB/cache: don't fill the cache with junk

2013-10-20 Thread Doug Ledford
On 10/20/2013 02:51 AM, Jack Morgenstein wrote: On Tue, 24 Sep 2013 17:16:29 -0400 Doug Ledford dledf...@redhat.com wrote: @@ -85,13 +91,26 @@ int ib_get_cached_gid(struct ib_device *device, cache = device-cache.gid_cache[port_num - start_port(device)]; - if (index 0 || index

Re: [PATCH librdmacm] cmtime: rework program to be multithread

2014-04-01 Thread Doug Ledford
On 9/24/2013 4:44 PM, Doug Ledford wrote: When using very large numbers of connections (10,000 was in use here), we ran into a problem where when we resolved a performance problem in the kernel cma.c code, we suddenly developed a new problem. That new problem turned out to be the fact

Re: [PATCH librdmacm] cmtime: rework program to be multithread

2014-04-03 Thread Doug Ledford
On 4/3/2014 5:00 PM, Hefty, Sean wrote: Ping. I noticed this never got picked up. Was there a problem, or just overlooked? Sorry - but I think it just got dropped or lost. Can you resend? I don't see this available on patchworks, and it's not in my inbox any longer. I'll add it to the

Re: NFSoRDMA developers bi-weekly meeting announcement (4/30)

2014-04-30 Thread Doug Ledford
...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord

Re: [PATCH] IB/mlx4: Allow to always block UD multicast loopback

2014-04-30 Thread Doug Ledford
); if (err) goto err_malloc; -- 1.7.1 -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html -- Doug Ledford dledf...@redhat.com

Re: [PATCH] IB/mlx4: Allow to always block UD multicast loopback

2014-05-01 Thread Doug Ledford
- Original Message - On Wed, 30 Apr 2014, Doug Ledford wrote: Add a module param to the mlx4_ib driver which allows to force all QP attachements to be carried out with multicast loopback prevented. This seems like driving a thumb tack with a sledge hammer. No doubt

Re: [PATCH] IB/mlx4: Allow to always block UD multicast loopback

2014-05-01 Thread Doug Ledford
- Original Message - On 01/05/2014 02:28, Doug Ledford wrote: This seems like driving a thumb tack with a sledge hammer. No doubt the correct path here is to get the proper flag added to verbs multicast attach command. Or, do you still have a patch that does this the right

Re: NFSoRDMA developers bi-weekly meeting announcement (4/30)

2014-05-01 Thread Doug Ledford
On 05/01/2014, Shirley Ma wrote: On 04/30/2014 04:58 PM, Doug Ledford wrote: On 04/302014 Shirley Ma wrote: I've created Xen guest on DomU. Dom0 PF works which has no mtts been enabled, however DomU I hit this problem by just mounting the file system: mlx4_core :00:04.0: Failed

Re: [PATCH V3 00/17] NFS/RDMA client-side patches

2014-05-02 Thread Doug Ledford
rsize/wsize 32768 Fix DOA of ocrdma driver Tested-by: Doug Ledford dledf...@redhat.com -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body

Re: [PATCH V3 00/17] NFS/RDMA client-side patches

2014-05-02 Thread Doug Ledford
- Original Message - On May 2, 2014, at 3:27 PM, Doug Ledford dledf...@redhat.com wrote: I tested nfsv3 in both IB and RoCE modes with rsize=32768 and wsize=32768 - not DOA, reliable, did data verification and passed I tested nfsv3 in both IB and RoCE modes with rsize=65536

Re: [PATCH] IB/mlx4: Allow to always block UD multicast loopback

2014-05-06 Thread Doug Ledford
work with limited applications that know it is being done, but it can also lead to hard to diagnose problems if you add a new application into the mix and it is unaware of this hammer being used and unable to handle the situation. -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD

Re: [PATCH] IB/mlx4: Allow to always block UD multicast loopback

2014-05-06 Thread Doug Ledford
- Original Message - On Tue, 6 May 2014, Doug Ledford wrote: That table only tells the NIC to listen to specific multicast addresses on the wire. This is roughly equivalent to telling the SM to subscribe the port to the multicast groups it needs subscribed too. In both cases

Re: [PATCH libibverbs V3 3/3] Add ibv_query_port_ex support

2014-05-13 Thread Doug Ledford
won't know to look there when working specifically on an extension. -- Doug Ledford dledf...@redhat.com GPG KeyID: 0E572FDD http://people.redhat.com/dledford -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord

[PATCH] uapi/rdma_user_cm.h: include socket.h

2014-07-17 Thread Doug Ledford
other headers, add linux/socket.h to the list of includes in this file. This patch resolves Red Hat bugzilla #1072645. The above referenced commit was added during the 3.11 release cycle, so this fix is suitable for any stable kernels from that point on. Signed-off-by: Doug Ledford dledf

[PATCH 4/8] IB/mlx4: use ARRAY_SIZE instead of sizeof/sizeof[0]

2014-08-12 Thread Doug Ledford
From: Fabian Frederick f...@skynet.be use macro definition Cc: Roland Dreier rol...@kernel.org Cc: Sean Hefty sean.he...@intel.com Cc: linux-rdma@vger.kernel.org Signed-off-by: Fabian Frederick f...@skynet.be Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/hw/mlx4/main.c

[PATCH 1/8] RDMA/amso1100: integer overflow in c2_alloc_cq_buf()

2014-08-12 Thread Doug Ledford
...@oracle.com Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/hw/amso1100/c2_cq.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/amso1100/c2_cq.c b/drivers/infiniband/hw/amso1100/c2_cq.c index 49e0e8533f7..1b63185b4ad 100644

[PATCH 6/8] ib/srpt: Enhance printk output

2014-08-12 Thread Doug Ledford
The ib_srpt module has a metric ton of printks for debugging and warnings and such. And it never prefaces a single one of them with information to allow an admin to know what errant module is spewing garbage all through their dmesg output. Fix that. Signed-off-by: Doug Ledford dledf

[PATCH 5/8] IB/mlx5: use ARRAY_SIZE instead of sizeof/sizeof[0]

2014-08-12 Thread Doug Ledford
From: Fabian Frederick f...@skynet.be use macro definition Cc: Eli Cohen e...@mellanox.com Cc: Roland Dreier rol...@kernel.org Cc: linux-rdma@vger.kernel.org Acked-by: Eli Cohen e...@mellanox.com Signed-off-by: Fabian Frederick f...@skynet.be Signed-off-by: Doug Ledford dledf...@redhat.com

[PATCH 7/8] ib/srpt: Handle GID change events

2014-08-12 Thread Doug Ledford
GID change events need a refresh just like LID change events and several others. Handle this the same as the others. Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/ulp/srpt/ib_srpt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/infiniband/ulp/srpt

[PATCH 4/8] IPoIB: fix mcast_dev_flush/mcast_restart_task race

2014-08-12 Thread Doug Ledford
(mcast A) As mcast_leave calls ib_sa_multicast_leave, and as member in core/multicast.c is ref counted, we run into an unbalanced refcount issue. To avoid stomping on each others removes, take the rtnl lock specifically when we are deleting the entries from the remove list. Signed-off-by: Doug

[PATCH 2/8] IPoIB: Make the carrier_on_task race aware

2014-08-12 Thread Doug Ledford
don't need to do anything anyway and we just return. Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 21 +++-- 1 file changed, 15 insertions(+), 6 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_multicast.c b/drivers

[PATCH 8/8] IPoIB: No longer use flush as a parameter

2014-08-12 Thread Doug Ledford
Various places in the IPoIB code had a deadlock related to flushing the ipoib workqueue. Now that we have per device workqueues and a specific flush workqueue, there is no longer a deadlock issue with flushing the device specific workqueues and we can do so unilaterally. Signed-off-by: Doug

[PATCH 5/8] IPoIB: change init sequence ordering

2014-08-12 Thread Doug Ledford
-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/ulp/ipoib/ipoib_main.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c index 217cb77157d..949948a46d4

[PATCH 6/8] IPoIB: Use dedicated workqueues per interface

2014-08-12 Thread Doug Ledford
the global workqueue, but now limit it to only flush tasks. In this way, the flush tasks can always flush the device specific work queues without having deadlock issues. Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/ulp/ipoib/ipoib.h | 1 + drivers/infiniband/ulp/ipoib

[PATCH 3/8] IPoIB: fix MCAST_FLAG_BUSY usage

2014-08-12 Thread Doug Ledford
. In this way, mcast_dev_flush always sees consistent state in regards to mcast-mc membership at the time that the wait_for_completion() returns. Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/ulp/ipoib/ipoib.h | 10 +- drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 148

[PATCH 7/8] IPoIB: Make ipoib_mcast_stop_thread flush the workqueue

2014-08-12 Thread Doug Ledford
taken the fact that it is queued on a single thread workqueue with all of the ipoib_mcast_join_task's and therefore has no need to stop the join task while it runs, we can do away with the flush parameter and unilaterally flush always. Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers

[PATCH 0/8] IPoIB: Fix multiple race conditions

2014-08-12 Thread Doug Ledford
mlx4_ib0 up is in fact racing with both ups and downs of mlx4_ib0.8002. The same is true for the mlx4_ib1 interface and its child. With my patch set in place, these loops are currently running without a problem and have passed 15,000 up/down cycles per interface. Doug Ledford (8): IPoIB

[PATCH 1/8] IPoIB: Consolidate rtnl_lock tasks in workqueue

2014-08-12 Thread Doug Ledford
Setting the mtu can safely be moved to the carrier_on_task, which keeps us from needing to take the rtnl lock in the join_finish section. Signed-off-by: Doug Ledford dledf...@redhat.com --- drivers/infiniband/ulp/ipoib/ipoib_multicast.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions

  1   2   3   4   5   6   7   8   >