[PATCH 21/24] IB/qib: Issue pre-emptive NAKs on eager buffer overflow

2010-12-28 Thread Mike Marciniszyn
are currently only supported for RDMA Writes. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_driver.c | 141 +++- 1 files changed, 137 insertions(+), 4 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_driver.c b

[PATCH 07/24] IB/qib: UD send with immediate Rx completion has wrong size

2010-12-28 Thread Mike Marciniszyn
The code to generate receive completion entries for UD send with immediate contains the wrong payload length. This is because when the code to compute the payload size was moved, the value of hdrsize didn't get moved too. The fix is to update tlen directly. Signed-off-by: Mike Marciniszyn

[PATCH 09/24] IB/qib: Multi Florida HCA Hosts panic on reboot

2010-12-28 Thread Mike Marciniszyn
Add check when setting configured contexts that the value does not exceed the number of contexts allocated for the card. If the value exceeds the already allocated count, set it to what is already allocated. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw

[PATCH 04/24] IB/qib: add thresholds to VendorPortCounters PMA operation

2010-12-28 Thread Mike Marciniszyn
This adds thresholds to be specified in the VendorPortCounters PMA operation. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_mad.c | 87 +++ 1 files changed, 57 insertions(+), 30 deletions(-) diff --git a/drivers

[PATCH 02/24] IB/qib: add receive header queue size module parameters

2010-12-28 Thread Mike Marciniszyn
The receive header queue sizes need to modified to support performance tuning. Three module parameters are added to support this. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 28 1 files changed, 24

[PATCH 08/24] IB/qib: Handle transitions from ACTIVE_DEFERRED to ACTIVE better

2010-12-28 Thread Mike Marciniszyn
When the link transitions from ACTIVE_DEFERRED to ACTIVE, the driver only sees the ACTIVE state. With this change, it will check whether the state was already ACTIVE and if so, it will not generated IB events and will not clear symbol error counts. Signed-off-by: Mike Marciniszyn mike.marcinis

[PATCH 18/24] IB/qib: adding fix missing from earlier patch

2010-12-28 Thread Mike Marciniszyn
rcv/error race fix was missing part of a fix that makes merges impossible. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_ud.c | 55 1 files changed, 24 insertions(+), 31 deletions(-) diff --git a/drivers

[PATCH 12/24] IB/qib: New SERDES init routine and improvements to SI quality

2010-12-28 Thread Mike Marciniszyn
Implement new SERDES initialization routine and improvements to SI - disable LE1 adaptation, disable LOS after link-up, set better SERDES parameters. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 270 +-- 1

[PATCH 06/24] IB/qib: set port physical state even if other fields are invalid

2010-12-28 Thread Mike Marciniszyn
but still attempts to set fields that are in range including PortInfo:PortPhysicalState. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_mad.c | 45 +++ 1 files changed, 25 insertions(+), 20 deletions(-) diff --git

[PATCH 20/24] IB/qib: RDMA lkey/rkey validation is inefficient for large MRs

2010-12-28 Thread Mike Marciniszyn
by shifts/mods instead of looping. The existing loop is preserved for phys memory regions for now. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_keys.c | 74 - drivers/infiniband/hw/qib/qib_mr.c|8

[PATCH 01/24] IB/qib: remove IB latency turnoff

2010-12-28 Thread Mike Marciniszyn
This is required for hardware testing. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c |2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b/drivers/infiniband/hw/qib

[PATCH 11/24] IB/qib: clear WAIT_SEND flags when setting QP to error state

2010-12-28 Thread Mike Marciniszyn
If these flags are set when the QP is transitioned to the error state, it will wait until the flags are cleared, which may never happen if the error transition is due to a link going down. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_qp.c |4

[PATCH 16/24] IB/qib: interrupt mitigation fix

2010-12-28 Thread Mike Marciniszyn
before the timer is enabled. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib.h |2 +- drivers/infiniband/hw/qib/qib_driver.c |4 ++-- drivers/infiniband/hw/qib/qib_iba6120.c |2 +- drivers/infiniband/hw/qib/qib_iba7220.c |2

[PATCH 05/24] IB/qib: generate completion callback on errors

2010-12-28 Thread Mike Marciniszyn
According to IBTA vol. 1, C11-30.1.1, a notification callback is invoked if the CQ is armed for the next solicited completion event or an error completion. The error case wasn't being generated previously. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib

[PATCH 24/24] IB/qib: Improve SERDES tunning on QMH boards

2010-12-28 Thread Mike Marciniszyn
Improve the QMH SERDES tunning on initial driver load by removing the delay after SERDES init and having the driver go through a link state change. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 28 +++- 1 files

[PATCH 14/24] IB/qib: Add a few new SERDES tunings

2010-12-28 Thread Mike Marciniszyn
Add new SERDES tuning to aid manufacturing. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 29 ++--- 1 files changed, 26 insertions(+), 3 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b

[PATCH 13/24] IB/qib: Reset packet list after freeing

2010-12-28 Thread Mike Marciniszyn
Reset the list pointers after freeing the SDMA packet list. This is done to any potential double-free cases. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_user_sdma.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCH 23/24] IB/qib: Add a delay to allow SERDES to initialize

2010-12-28 Thread Mike Marciniszyn
Adding a small delay would allow the SERDES to adapt better, which would improve the link negotiation. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCH 22/24] IB/qib: Un-necessary delayed completions on RC connection

2010-12-28 Thread Mike Marciniszyn
is complete. Ensure that SDMA queue is progressed appropriately before determining if a send has delayed completions. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_rc.c | 24 1 files changed, 24 insertions(+), 0 deletions

[PATCH 03/24] IB/qib: add support for the new QME7362 card

2010-12-28 Thread Mike Marciniszyn
This patch adds support to recognize another board variation named QME7362. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c

[PATCH 17/24] IB/qib: change rcv queue/qpn selection

2010-12-28 Thread Mike Marciniszyn
if the QPN to context falls within [zero..dd-n_krcv_queues). Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7220.c |2 +- drivers/infiniband/hw/qib/qib_iba7322.c |8 ++-- drivers/infiniband/hw/qib/qib_qp.c | 26

[PATCH 15/24] IB/qib: Avoid duplicate writes to the rcv head register

2010-12-28 Thread Mike Marciniszyn
Avoid duplicate writes to the head register as this can lead to lost interrupts if the context goes full before the second write is done. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_driver.c | 10 +- 1 files changed, 9 insertions(+), 1

[PATCH 0/24] various fixes for QIB driver

2010-12-28 Thread Mike Marciniszyn
The following patches (ordered first to last) are for various bug fixes found during internal testing. IB/qib: remove IB latency turnoff IB/qib: add receive header queue size module parameters IB/qib: add support for the new QME7362 card IB/qib: add thresholds to VendorPortCounters PMA operation

[PATCH 19/24] IB/qib: change qpn increment

2010-12-28 Thread Mike Marciniszyn
Changing from +1 to +2 allows for better QP distribution across receive contexts. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_qp.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_qp.c b

RE: [PATCH 24/24] IB/qib: Improve SERDES tunning on QMH boards

2011-01-04 Thread Mike Marciniszyn
, 2011 1:55 PM To: Mike Marciniszyn Cc: linux-rdma@vger.kernel.org Subject: Re: [PATCH 24/24] IB/qib: Improve SERDES tunning on QMH boards @@ -7596,8 +7616,6 @@ static int serdes_7322_init_new(struct qib_pportdata *ppd) /* VGA output common mode */ ibsd_wr_allchans(ppd, 12, (3 2

RE: [PATCH 0/24] various fixes for QIB driver

2011-01-04 Thread Mike Marciniszyn
Understood on the volume. We hadn't had any fixes for a bit, there was a considerable backlog. Mike -Original Message- From: Roland Dreier [mailto:rdre...@cisco.com] Sent: Tuesday, January 04, 2011 1:59 PM To: Mike Marciniszyn Cc: linux-rdma@vger.kernel.org Subject: Re: [PATCH 0/24

RE: [PATCH 0/24] various fixes for QIB driver

2011-01-05 Thread Mike Marciniszyn
Thanks! I'm working on a v2 patch for the lone holdout. Mike -Original Message- From: Roland Dreier [mailto:rdre...@cisco.com] Sent: Wednesday, January 05, 2011 1:08 PM To: Mike Marciniszyn Cc: linux-rdma@vger.kernel.org Subject: Re: [PATCH 0/24] various fixes for QIB driver OK, I

[PATCH] IB/qib: fix refcount leak in lkey/rkey validation

2011-01-07 Thread Mike Marciniszyn
From: Mike Marciniszyn mike.marcinis...@qlogic.org The mr optimization introduced a reference count leak on an exception test. The lock/refcount manipulation is moved down and the problematic exception test now calls bail to insure that the lock is released. Additional fixes as suggested

[PATCH] IB/qib: Hold link for Tx SERDES settings

2011-01-21 Thread Mike Marciniszyn
From: Mitko Haralanov mi...@qlogic.com Hold the IB link at DISABLED until we get the correct TX settings on mezz boards. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 30 +++--- 1 files changed, 11 insertions

[PATCH v2] IB/qib: add thresholds to VendorPortCounters PMA operation

2011-02-01 Thread Mike Marciniszyn
This adds thresholds to be specified in the VendorPortCounters PMA operation. The reserved fields are now defined in the appropriate header file. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_mad.c | 97

[PATCH] IPoIB: fix faulty list maintenance in path and neigh list

2011-02-01 Thread Mike Marciniszyn
are initialized correctly. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/ulp/ipoib/ipoib_main.c |4 drivers/infiniband/ulp/ipoib/ipoib_multicast.c |1 + 2 files changed, 5 insertions(+), 0 deletions(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c

[PATCH] IB/qib: Kernel BUG at include/linux/timer.h:82

2011-02-10 Thread Mike Marciniszyn
that had changed the state to reset, but the missing test caused to response handling code to run on into the panic. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_rc.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/drivers

[PATCH] IB/qib: Prevent double completions after a timeout or RNR error

2011-02-16 Thread Mike Marciniszyn
completed in the past The fix avoids starting the timer since another packet will never arrive. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_rc.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/qib

[PATCH] IB/qib: Return correct MAD when setting link width to 255

2011-02-18 Thread Mike Marciniszyn
From: Mitko Haralanov mi...@qlogic.com Fix a bug which cause the driver to return incorrect MADs as a response to Set(PortInfo) which sets the link width to 0xFF or link speed to 0xF. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com

[PATCH] IB/qib: Set default LE2 value for active cables to 0

2011-02-28 Thread Mike Marciniszyn
From: Mitko Haralanov mi...@qlogic.com For active and far-EQ cables use an LE2 value of 0 for improved SI. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 13 ++--- drivers

[PATCH] IB/qib: Fix M_Key field in SubnGet and SubnGetResp MADs

2011-03-02 Thread Mike Marciniszyn
From: Mitko Haralanov mi...@qlogic.com Set the M_Key field in SubnGet and SugnGetResp MADs based on correctly interpreting the protection level specified in the M_KeyProtBits field. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com

IB/qib: Fix M_Key field in SubnGet and SubnGetResp MADs

2011-03-02 Thread Mike Marciniszyn
Roland, Please hold on this. There will be a v2! Mike This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy, distribute, or use this

[PATCH v2] IB/qib: Fix M_Key field in SubnGet and SubnGetResp MADs

2011-03-04 Thread Mike Marciniszyn
From: Mitko Haralanov mi...@qlogic.com Set the M_Key field in SubnGet and SugnGetResp MADs based on correctly interpreting the protection level specified in the M_KeyProtBits field. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com

[PATCH] IB/qib: Prevent driver hang with unprogrammed boards

2011-04-11 Thread Mike Marciniszyn
From: Mitko Haralanov mi...@qlogic.com The time limit test now correctly checks the against current jiffies to avoid the hang. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c |3 ++- 1

RE: [PATCH] IB/qib: Prevent driver hang with unprogrammed boards

2011-04-11 Thread Mike Marciniszyn
-Original Message- From: Roland Dreier [mailto:rol...@purestorage.com] Sent: Monday, April 11, 2011 4:25 PM To: Mike Marciniszyn Cc: linux-rdma@vger.kernel.org Subject: Re: [PATCH] IB/qib: Prevent driver hang with unprogrammed boards On Mon, Apr 11, 2011 at 6:45 AM, Mike Marciniszyn

RE: [PATCH] IB/qib: Prevent driver hang with unprogrammed boards

2011-04-12 Thread Mike Marciniszyn
at a more global effort beyond the scope of this patch? Mike -Original Message- From: Roland Dreier [mailto:rol...@purestorage.com] Sent: Monday, April 11, 2011 4:25 PM To: Mike Marciniszyn Cc: linux-rdma@vger.kernel.org Subject: Re: [PATCH] IB/qib: Prevent driver hang with unprogrammed

RE: [PATCH 2/2] qib: use pci_dev-revision

2011-05-09 Thread Mike Marciniszyn
The driver reads PCI revision ID from the PCI configuration register while it's already stored by PCI subsystem in the 'revision' field of 'struct pci_dev'... Thanks for the patch. qib: use pci_dev-revision Acked-by: Mike Marciniszyn mike.marcinis...@qlogic.com -Original Message

[PATCH] IB/qib: Fix potential deadlock with link down interrupt

2011-05-27 Thread Mike Marciniszyn
in interrupt context which can lead to a deadlock when running on the same cpu. The fix is to replace spin_lock() and spin_unlock() with spin_lock_irqsave() and spin_unlock_irqrestore() respectively in qib_set_uevent_bits(). Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers

RE: [PATCH] infiniband, ipath: convert old cpumask api into new one

2011-05-31 Thread Mike Marciniszyn
++) { .. } Thanks for the patch! Acked-by: Mike Marciniszyn mike.marcinis...@qlogic.com This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy

RE: [PATCH] infiniband, qib: convert old cpumask api into new one.

2011-05-31 Thread Mike Marciniszyn
Adapt new APIs. we plan to remove old one later and plan to change current-cpus_allowed implementation. No functional change. Thanks for the patch! Acked-by: Mike Marciniszyn mike.marcinis...@qlogic.com This message and any attached documents contain information from QLogic Corporation

[PATCH] IB/qib: Ensure that LOS and DFE are being turned off

2011-06-09 Thread Mike Marciniszyn
set, timing is no longer an issue. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 25 ++--- drivers/infiniband/hw/qib/qib_intr.c|6 +- 2 files changed, 23

RE: [PATCH V1 7/9] ib/pma: add include file for IBA performance counters definitions

2011-06-16 Thread Mike Marciniszyn
with https://patchwork.kernel.org/patch/523041/ to reduce those impacts. Mike -Original Message- From: Or Gerlitz [mailto:ogerl...@mellanox.com] Sent: Thursday, June 16, 2011 10:19 AM To: Mike Marciniszyn Cc: linux-rdma Subject: Re: [PATCH V1 7/9] ib/pma: add include file for IBA

RE: [PATCH 05/19] qib: remove unnecessary read of PCI_CAP_ID_EXP

2011-06-28 Thread Mike Marciniszyn
...@kudzu.us Thanks for the patch! Acked-by: Mike Marciniszyn mike.marcinis...@qlogic.com This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read, copy

[PATCH] MAINTAINERS: modify information for ipath/qib

2011-06-28 Thread Mike Marciniszyn
The maintainer information for the Qlogic infiniband hardware was out of date. This patch corrects the issue. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- MAINTAINERS | 11 --- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS

RE: Warning: mthca/qib : removal of PCI_CAP_ID_EXP

2011-07-01 Thread Mike Marciniszyn
The patch was ok here, but we only support x86_64. Mike -Original Message- From: James Smart [mailto:james.sm...@emulex.com] Sent: Friday, July 01, 2011 10:49 AM To: linux-rdma@vger.kernel.org Cc: James Smart; Jon Mason; Richard Lary; Mike Marciniszyn; e...@dev.mellanox.co.il; jlb

RE: [PATCH V1 7/9] ib/pma: add include file for IBA performance counters definitions

2011-07-05 Thread Mike Marciniszyn
To: Mike Marciniszyn Cc: Or Gerlitz; linux-rdma Subject: Re: [PATCH V1 7/9] ib/pma: add include file for IBA performance counters definitions Mike Marciniszyn mike.marcinis...@qlogic.com wrote: Yes, I'm the maintainer for both qib and ipath. I'm currently looking over these fixes. thanks

RE: [PATCH] drivers/infiniband/hw/qib/qib_iba7322: remove double define

2011-07-11 Thread Mike Marciniszyn
Double define removed. Signed-off-by: Edwin van Vliet ed...@cheatah.nl --- drivers/infiniband/hw/qib/qib_iba7322.c |1 - 1 files changed, 0 insertions(+), 1 deletions(-) Thanks for the patch! Acked-by: Mike Marciniszyn mike.marcinis...@qlogic.com This message and any attached

[PATCH] IB/qib: Update active link width

2011-07-14 Thread Mike Marciniszyn
From: Mitko Haralanov mi...@qlogic.com Update the active link width on QLE7220 chips when link goes down if chip width does not match shadowed width. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib

[PATCH] IB/qib: defer hca error events to tasklet

2011-07-21 Thread Mike Marciniszyn
read in the default handler. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib.h |3 + drivers/infiniband/hw/qib/qib_iba7322.c | 71 ++- 2 files changed, 53 insertions(+), 21 deletions(-) diff --git a/drivers

RE: [PATCH] IB/qib: defer hca error events to tasklet

2011-07-21 Thread Mike Marciniszyn
-Original Message- From: rol...@purestorage.com [mailto:rol...@purestorage.com] On Behalf Of Roland Dreier Sent: Thursday, July 21, 2011 11:47 AM To: Mike Marciniszyn Cc: linux-rdma@vger.kernel.org Subject: Re: [PATCH] IB/qib: defer hca error events to tasklet +static ushort

[PATCH] IB/qib: Correct nfreectxts for multiple HCAs

2011-09-21 Thread Mike Marciniszyn
)qib_stats.sps_ctxts); The qib_stats is global to the module, not per HCA, so the code is broken for multiple HCAs. This patch adds a qib_devdata field, freectxts, that reflects the free contexts for this HCA. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com Reviewed-by: Ram Vepa ram.v...@qlogic.com

[PATCH 4/7] IB/qib: qpn lookup optimizations

2011-09-23 Thread Mike Marciniszyn
structures. The patch also adds a lookaside_qp (pointer) and a lookaside_qpn in the context. The interrupt handler will test the current packet's qpn against lookaside_qpn if the lookaside_qp pointer is non-null. The pointer is NULL'ed when the interrupt handler exits. Signed-off-by: Mike Marciniszyn

[PATCH 1/7] IB/qib: Optimize RC/UC code by IB operation

2011-09-23 Thread Mike Marciniszyn
. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_rc.c | 19 +-- drivers/infiniband/hw/qib/qib_uc.c | 14 +++--- 2 files changed, 24 insertions(+), 9 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_rc.c b/drivers

[PATCH 7/7] IB/qib: remove s_lock around header validation

2011-09-23 Thread Mike Marciniszyn
. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_driver.c |5 - drivers/infiniband/hw/qib/qib_rc.c |4 +--- drivers/infiniband/hw/qib/qib_ruc.c|7 ++- drivers/infiniband/hw/qib/qib_uc.c |7 +-- 4 files changed

[PATCH 6/7] IB/qib: memcpy optimizations

2011-09-23 Thread Mike Marciniszyn
packet delivery performance to the send engine. The existing copy as well as a new stub probe routine are maintained as weak symbols for other architectures. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/Makefile |2 .../infiniband

[PATCH] IB/qib: Add logic for affinity hint

2011-09-23 Thread Mike Marciniszyn
. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib.h | 10 +++ drivers/infiniband/hw/qib/qib_iba7322.c | 107 ++- drivers/infiniband/hw/qib/qib_pcie.c| 21 ++ 3 files changed, 104 insertions(+), 34 deletions

[PATCH 3/7] IB/qib: Eliminate divide/mod in converting idx to egr buf pointer

2011-09-23 Thread Mike Marciniszyn
The context init now saves a shift from rcvegrbufs_perchunk rcvegrbufs_perchunk_shift using ilog2. A BUG_ON protects the power of 2 assumption. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib.h |8 ++-- drivers/infiniband/hw/qib

[PATCH 2/7] IB/qib: decode path mtu optimization

2011-09-23 Thread Mike Marciniszyn
Store both the encoded and decoded mtu in the qp structure as a minor optimization UC/RC receive routines. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_qp.c|4 +++- drivers/infiniband/hw/qib/qib_rc.c|6 +++--- drivers/infiniband/hw

[PATCH 0/7] qib optimizations

2011-09-23 Thread Mike Marciniszyn
The following patch series contains optimizations that benefit qib verbs performance. -- To unsubscribe from this list: send the line unsubscribe linux-rdma in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

RE: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

2011-10-10 Thread Mike Marciniszyn
As do I. I've confirmed that patch does no harm, but I would like to see the error. Which of the github repos exposes the error? Mike -Original Message- From: Roland Dreier [mailto:rol...@purestorage.com] Sent: Friday, October 07, 2011 5:21 PM To: Randy Dunlap Cc: Stephen

RE: [PATCH -next] infiniband: fix ipath_chip_init.c build errors

2011-10-11 Thread Mike Marciniszyn
/ipath_init_chip.c:67:1: error: 'S_IWUSR' undeclared here (not in a function) drivers/infiniband/hw/ipath/ipath_init_chip.c:67:1: error: bit-field 'anonymous' width not an integer constant Signed-off-by: Randy Dunlap rdun...@xenotime.net Thanks for the patch! Acked-by: Mike Marciniszyn mike.marcinis

[PATCH] IB/qib: cleanup checkpatch issue

2011-10-19 Thread Mike Marciniszyn
This was probably present from initial submission. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b/drivers/infiniband/hw

[PATCH] IB/qib: cleanup checkpatch issue

2011-10-19 Thread Mike Marciniszyn
This was probably present from initial submission. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b/drivers/infiniband/hw

RE: [PATCH] IB/qib: cleanup checkpatch issue

2011-10-19 Thread Mike Marciniszyn
Disregard. This was a duplicate send. Mike -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Mike Marciniszyn Sent: Wednesday, October 19, 2011 6:15 PM To: rol...@purestorage.com Cc: linux-rdma@vger.kernel.org

[PATCH 0/2] serdes interoperabilty fixes

2011-10-19 Thread Mike Marciniszyn
The following series implements serdes fixes for interoperabilty. --- Mitko Haralanov (2): IB/qib: Hold links until tuning data is available IB/qib: Fix issue with link states and QSFP cables drivers/infiniband/hw/qib/qib_iba7322.c | 128 +--

[PATCH 1/2] IB/qib: Hold links until tuning data is available

2011-10-19 Thread Mike Marciniszyn
-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 118 --- drivers/infiniband/hw/qib/qib_init.c|4 - drivers/infiniband/hw/qib/qib_qsfp.c| 25 --- drivers

[PATCH 2/2] IB/qib: Fix issue with link states and QSFP cables

2011-10-19 Thread Mike Marciniszyn
From: Mitko Haralanov mi...@qlogic.com Fix an issue where the link would come up after replugging a cable even if it has been DISABLED manually. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322

[PATCH V2 1/2] IB/qib: Hold links until tuning data is available

2011-10-24 Thread Mike Marciniszyn
avoids scheduling work on non-qsfp cards. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 120 --- drivers/infiniband/hw/qib/qib_init.c|4 - drivers

[PATCH] IB/qib: Fix kernel panic on QME7342 boards

2011-10-25 Thread Mike Marciniszyn
From: Mitko Haralanov mi...@qlogic.com Fix a kernel panic on QME7342 (and any Mezz boards without QSFP connectors) caused by scheduling work on uninitialized workqueue introduced by 62066fc8df4632c772d723813ce7af456d62ddf7. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike

[PATCH] IB/qib: Fix panic in RC error flushing logic

2011-11-04 Thread Mike Marciniszyn
. Reviewed-by: Ram Vepa ram.v...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_rc.c | 10 +++--- 1 files changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_rc.c b/drivers/infiniband/hw/qib/qib_rc.c index

[PATCH] IB/qib: Eliminate schedule_work

2011-11-08 Thread Mike Marciniszyn
It was mistakenly introduced by dde05cbdf8b1c404344c370fe6e18ff160d6da6a. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/infiniband/hw/qib/qib_iba7322.c b

[PATCH V2 6/7] IB/qib: memcpy optimizations

2011-11-09 Thread Mike Marciniszyn
packet delivery performance to the send engine. The existing copy as well as a new stub probe routine are maintained as weak symbols for other architectures. This version adds the include for module.h to fix a syntax error. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers

[PATCH] IB/qib: Eliminate 64 bit jiffies

2011-11-09 Thread Mike Marciniszyn
The qib driver makes use of the the 64 bit jiffies API. Code inspection reveals that that version of the API is not really required. This patch converts to use the normal jiffies. Reviewed-by: Ram Vepa ram.v...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers

ARCH_HAS_PREFETCH in (x86)asm/processor.h?

2011-11-09 Thread Mike Marciniszyn
Does anyone know any reason what this is only set on 32 bit x86 platforms and not on x86_64 platforms? #ifdef CONFIG_X86_32 # define BASE_PREFETCH ASM_NOP4 # define ARCH_HAS_PREFETCH #else # define BASE_PREFETCH prefetcht0 (%1)

[PATCH] IB/qib: Fix over-scheduling of QSFP work.

2011-11-09 Thread Mike Marciniszyn
to start training early with wrong settings. Signed-off-by: Mitko Haralanov mi...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_iba7322.c | 16 drivers/infiniband/hw/qib/qib_qsfp.c| 12 2 files changed, 8

[PATCH] IB/ipoib: Prevent hung task or softlockup processing multicast response

2011-11-21 Thread Mike Marciniszyn
Reviewed-by: Gary Leshner gary.lesh...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/ulp/ipoib/ipoib_ib.c| 13 - drivers/infiniband/ulp/ipoib/ipoib_main.c |2 +- drivers/infiniband/ulp/ipoib/ipoib_multicast.c |7

RE: [PATCH] IB/ipoib: Prevent hung task or softlockup processing multicast response

2011-11-21 Thread Mike Marciniszyn
AM To: Mike Marciniszyn; rol...@purestorage.com Cc: linux-rdma@vger.kernel.org Subject: RE: [PATCH] IB/ipoib: Prevent hung task or softlockup processing multicast response --- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c @@ -57,21 +57,24 @@ struct

RE: [PATCH] IB/ipoib: Prevent hung task or softlockup processing multicast response

2011-11-21 Thread Mike Marciniszyn
Thanks for clarifying. I misread the patch. The resulting function looks clear enough with everything together. Thanks! I'm also interested in comments the bug in the caller, if you have looked there... Mike This message and any attached documents contain information from QLogic

RE: [PATCH] IB/ipoib: Prevent hung task or softlockup processing multicast response

2011-11-29 Thread Mike Marciniszyn
The test that induced the failure is associated with a host SM on the same server during a shutdown. There was a bug unrelated to this that made is more reproducible. So another bug lead to this one. Mike This message and any attached documents contain information from QLogic

[PATCH] IB/qib: correct sense on freectxts increment and decrement

2011-12-02 Thread Mike Marciniszyn
The maintenance of dd-nfreectxts was incorrectly opposite of the patch intention in 53ab1c64983 (IB/qib: Correct nfreectxts for multiple HCAs) Reviewed-by: Ram Vepa ram.v...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_file_ops.c |4

[PATCH] IB/qib: Optimize locking for get_txreq()

2011-12-23 Thread Mike Marciniszyn
. This will save a lock of s_lock in the normal case. The observation is that the sdma descriptors will deplete at twice the rate of txreq's, so this should be rare. Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_verbs.c | 43

[PATCH] IB/qib: Default some module parameters optimally

2011-12-23 Thread Mike Marciniszyn
rather than a sender jiffies-based timeout. The pcie_caps default of 0x51 will set the proposed MaxPayload and MaxReceiveReqest to 256 and 4096 respectively. The capabilities on the root complex will be used to limit those values. Reviewed-by: Ram Vepa ram.v...@qlogic.com Signed-off-by: Mike

RE: [PATCH 1/4] drivers/infiniband/hw/qib/qib_iba6120.c: convert GFP_KERNEL to GFP_ATOMIC

2012-01-09 Thread Mike Marciniszyn
/locks/call_kern.cocci. More information about semantic patching is available at http://coccinelle.lip6.fr/ Signed-off-by: Julia Lawall julia.law...@lip6.fr Thanks for the patch! Acked-by: Mike Marciniszyn mike.marcinis...@qlogic.com This message and any attached documents contain information

[PATCH] IB/qib: detour pcie_caps for certain chip sets

2012-01-11 Thread Mike Marciniszyn
is not used on the suspect chip sets. Reviewed-by: Mark Debbage mark.debb...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_pcie.c | 19 ++- 1 files changed, 14 insertions(+), 5 deletions(-) diff --git a/drivers

RE: [PATCH] IB/qib: detour pcie_caps for certain chip sets

2012-01-12 Thread Mike Marciniszyn
Should whatever this issue is be a general PCI fixup? Like broken MSI, etc. Can you point me to some details on this? Might be nice to include what 0x51 tunes in the commit to aide other peoole with the broken chipset :) Isn't it necesary to check the PCI vendor as well as the devid? Will

RE: [PATCH] IB/qib: detour pcie_caps for certain chip sets

2012-01-12 Thread Mike Marciniszyn
Does this work on systems where the broken chipset might not be the immediate parent of the qib device (ie there are some PCIe switches in between)? The code figures this out at the top of routine and returns, changing nothing. This message and any attached documents contain information

RE: [PATCH] IB/qib: detour pcie_caps for certain chip sets

2012-01-12 Thread Mike Marciniszyn
if (parent-vendor != 0x8086) return 1; so I guess you don't need another vendor check. Actually, Jason is right. The vendor check you reference here is in qib_tune_pcie_coalesce() and not the routine being patched. A bit of background here is that the issue was

RE: [PATCH] IB/qib: detour pcie_caps for certain chip sets

2012-01-12 Thread Mike Marciniszyn
It doesn't seem to me like this has any place in the quirks thing either. Things seem to be working properly, the MaxPayLoad of 128 is clearly the highest the system will support correctly. Jason Probably the best thing to do unwind the module parameter default in 8d4548f2b which would

[PATCH] IB/qib: unwind pcie change

2012-01-12 Thread Mike Marciniszyn
DMA memory read] Restore the module paramter default to zero with will avoid any changes in the root complex. Reviewed-by: Mark Debbage mark.debb...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers/infiniband/hw/qib/qib_pcie.c |2 +- 1 files changed, 1

RE: races in ipathfs

2012-01-20 Thread Mike Marciniszyn
We are currently investigating this. Thanks for the review on this issue! Mike -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Al Viro Sent: Thursday, January 19, 2012 3:20 PM To: Dept_Infinipath Cc:

RE: [patch] infiniband: calling PTR_ERR() on wrong variable in create_file()

2012-01-26 Thread Mike Marciniszyn
From: Dan Carpenter [mailto:dan.carpen...@oracle.com] Subject: [patch] infiniband: calling PTR_ERR() on wrong variable in Signed-off-by: Dan Carpenter dan.carpen...@oracle.com I double checked the qib driver, and the equivalent code is ok there. Thanks for the patch! Acked-by: Mike

RE: [PATCH] IB/qib: Add logic for affinity hint

2012-02-02 Thread Mike Marciniszyn
Roland, I haven't seen this merged. Mike -Original Message- From: linux-rdma-ow...@vger.kernel.org [mailto:linux-rdma- ow...@vger.kernel.org] On Behalf Of Mike Marciniszyn Sent: Friday, September 23, 2011 1:17 PM To: rol...@purestorage.com Cc: linux-rdma@vger.kernel.org Subject

[PATCH] IB/qib: Avoid filtering lid on SMA portinfo

2012-02-10 Thread Mike Marciniszyn
The current get portinfo handling filters the lid being sent, modifying zero to 0x. The causes issues with OpenSM logging excessive warning messages. Reviewed-by: Edward Mascarenhas edward.mascaren...@qlogic.com Signed-off-by: Mike Marciniszyn mike.marcinis...@qlogic.com --- drivers

ARCH_HAS_PREFETCH in (x86)asm/processor.h?

2012-02-17 Thread Mike Marciniszyn
Is the a reason that this define is 32 specific? I'm proposing the following: diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h index aa9088c..9310c06 100644 --- a/arch/x86/include/asm/processor.h +++ b/arch/x86/include/asm/processor.h @@ -815,10 +815,10 @@ extern

RE: ARCH_HAS_PREFETCH in (x86)asm/processor.h?

2012-02-17 Thread Mike Marciniszyn
The lack of the define causes prefetch_range() on 64 bit platforms. To be a no-op... Mike This message and any attached documents contain information from QLogic Corporation or its wholly-owned subsidiaries that may be confidential. If you are not the intended recipient, you may not read,

  1   2   3   4   >