Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +static ssize_t srpt_tpg_attrib_store_srp_max_rsp_size( +       struct se_portal_group *se_tpg, +       const char *page, +       size_t count) +{ +       struct srpt_port *sport = container_of(se_tpg, struct

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Nicholas A. Bellinger
On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +static ssize_t srpt_tpg_attrib_store_srp_max_rsp_size( + struct se_portal_group *se_tpg, + const char *page, + size_t count)

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +static ssize_t srpt_tpg_attrib_store_srp_max_rsp_size( +      

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Nicholas A. Bellinger
On Mon, 2011-10-24 at 21:58 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote:

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 10:05 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:58 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: On Mon,

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: Also, isn't kstrto*() preferred over strict_strto*() ? Not AFAIK. This is what I found in the description of commit 33ee3b2: kstrto*: converting

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Nicholas A. Bellinger
On Mon, 2011-10-24 at 22:11 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 10:05 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:58 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Nicholas A. Bellinger
On Mon, 2011-10-24 at 22:16 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: Also, isn't kstrto*() preferred over strict_strto*() ? Not AFAIK. This is what I found

[PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-23 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch converts the srp_max_rsp_size module parameter into a per port configfs attribute. This includes adding the necessary bits for show + store attributes w/ min/max bounds checking, and dropping the legacy WARN_ON() as sport_port is not