Re: [PATCH RFC v2 02/10] IB/core: Introduce Signature Verbs API

2013-11-03 Thread Sagi Grimberg
On 11/1/2013 5:13 PM, Bart Van Assche wrote: On 31/10/2013 5:24, Sagi Grimberg wrote: +/** + * struct ib_sig_domain - Parameters specific for T10-DIF + * domain. + * @sig_type: specific signauture type + * @sig: union of all signature domain attributes that may + * be used to set

Re: [PATCH RFC v2 02/10] IB/core: Introduce Signature Verbs API

2013-11-03 Thread Sagi Grimberg
On 11/2/2013 12:23 AM, Bart Van Assche wrote: On 31/10/2013 5:24, Sagi Grimberg wrote: + * @type3_inc_reftag: T10-DIF type 3 does not state + *about the reference tag, it is the user + *choice to increment it or not. Can you explain this further ? Does this

Re: [PATCH RFC v2 02/10] IB/core: Introduce Signature Verbs API

2013-11-03 Thread Sagi Grimberg
On 11/1/2013 8:46 PM, Bart Van Assche wrote: On 31/10/2013 5:24, Sagi Grimberg wrote: +/** + * Signature T10-DIF block-guard types + */ +enum ib_t10_dif_bg_type { +IB_T10DIF_CRC, +IB_T10DIF_CSUM +}; In SPC-4 paragraph 4.22.4 I found that the T10-PI guard is the CRC computed from the

Re: [PATCH RFC v2 02/10] IB/core: Introduce Signature Verbs API

2013-11-03 Thread Bart Van Assche
On 3/11/2013 4:15, Sagi Grimberg wrote: On 11/1/2013 8:46 PM, Bart Van Assche wrote: On 31/10/2013 5:24, Sagi Grimberg wrote: +/** + * Signature T10-DIF block-guard types + */ +enum ib_t10_dif_bg_type { +IB_T10DIF_CRC, +IB_T10DIF_CSUM +}; In SPC-4 paragraph 4.22.4 I found that the

Re: [PATCH RFC v2 02/10] IB/core: Introduce Signature Verbs API

2013-11-03 Thread Sagi Grimberg
On 11/3/2013 4:41 PM, Bart Van Assche wrote: On 3/11/2013 4:15, Sagi Grimberg wrote: On 11/1/2013 8:46 PM, Bart Van Assche wrote: On 31/10/2013 5:24, Sagi Grimberg wrote: +/** + * Signature T10-DIF block-guard types + */ +enum ib_t10_dif_bg_type { +IB_T10DIF_CRC, +IB_T10DIF_CSUM +};

Re: [PATCH RFC v2 02/10] IB/core: Introduce Signature Verbs API

2013-11-01 Thread Bart Van Assche
On 31/10/2013 5:24, Sagi Grimberg wrote: +/** + * struct ib_sig_domain - Parameters specific for T10-DIF + * domain. + * @sig_type: specific signauture type + * @sig: union of all signature domain attributes that may + * be used to set domain layout. + * @dif: + *

Re: [PATCH RFC v2 02/10] IB/core: Introduce Signature Verbs API

2013-11-01 Thread Bart Van Assche
On 31/10/2013 5:24, Sagi Grimberg wrote: + * @type3_inc_reftag: T10-DIF type 3 does not state + * about the reference tag, it is the user + * choice to increment it or not. Can you explain this further ? Does this mean that the HCA can check

[PATCH RFC v2 02/10] IB/core: Introduce Signature Verbs API

2013-10-31 Thread Sagi Grimberg
This commit Introduces the Verbs Interface for signature related operations. A signature handover operation shall configure the layouts of data and protection attributes both in memory and wire domains. Signature operations are: - INSERT Generate and insert protection information when handing