Re: [PATCH v2.6.36-rc7] infiniband: update workqueue usage

2010-10-20 Thread Tejun Heo
Hello, On 10/19/2010 07:22 PM, Ralph Campbell wrote: On Tue, 2010-10-19 at 08:24 -0700, Tejun Heo wrote: * qib_cq_wq is a separate singlethread workqueue. Does the queue require strict single thread execution ordering? IOW, does each work have to be executed in the exact queued order

Re: [PATCH v2.6.36-rc7] infiniband: update workqueue usage

2010-10-20 Thread Tejun Heo
Hello, On 10/19/2010 08:40 PM, Bart Van Assche wrote: On Tue, Oct 19, 2010 at 5:24 PM, Tejun Heo t...@kernel.org wrote: [ ... ] This is to prepare for deprecation of flush_scheduled_work(). [ ... ] Index: work/include/rdma/ib_verbs.h [ ... ] +extern struct workqueue_struct *ib_wq; [ ... ]

Re: [PATCH v2.6.36-rc7] infiniband: update workqueue usage

2010-10-20 Thread Bart Van Assche
On Wed, Oct 20, 2010 at 10:38 AM, Tejun Heo t...@kernel.org wrote: Hello, On 10/19/2010 08:40 PM, Bart Van Assche wrote: On Tue, Oct 19, 2010 at 5:24 PM, Tejun Heo t...@kernel.org wrote: [ ... ] This is to prepare for deprecation of flush_scheduled_work(). [ ... ] Index:

Re: [PATCH v2.6.36-rc7] infiniband: update workqueue usage

2010-10-20 Thread Tejun Heo
Hello, On 10/20/2010 12:21 PM, Bart Van Assche wrote: Hmm... that's one very interesting reason to be unhappy. Can you please elaborate why addition of a global variable doesn't make you happy? In the past every time I saw a global variable being added in a software project that meant

[PATCH v2.6.36-rc7] infiniband: update workqueue usage

2010-10-19 Thread Tejun Heo
* ib_wq is added, which is used as the common workqueue for infiniband instead of the system workqueue. All system workqueue usages including flush_scheduled_work() callers are converted to use and flush ib_wq. * cancel_delayed_work() + flush_scheduled_work() converted to

Re: [PATCH v2.6.36-rc7] infiniband: update workqueue usage

2010-10-19 Thread Ralph Campbell
On Tue, 2010-10-19 at 08:24 -0700, Tejun Heo wrote: * qib_cq_wq is a separate singlethread workqueue. Does the queue require strict single thread execution ordering? IOW, does each work have to be executed in the exact queued order and no two works should execute in parallel? Or was

Re: [PATCH v2.6.36-rc7] infiniband: update workqueue usage

2010-10-19 Thread Bart Van Assche
On Tue, Oct 19, 2010 at 5:24 PM, Tejun Heo t...@kernel.org wrote: [ ... ] This is to prepare for deprecation of flush_scheduled_work(). [ ... ] Index: work/include/rdma/ib_verbs.h [ ... ] +extern struct workqueue_struct *ib_wq; [ ... ] This patch adds a declaration of a global variable to