RE: [PATCH] rdma_cm.h: Fix SCTP protocol ID

2010-01-13 Thread Sean Hefty
Should be 132 rather than 131 according to IANA IP protocol IDs Signed-off-by: Hal Rosenstock hal.rosenst...@gmail.com Acked-by: Sean Hefty sean.he...@intel.com --- Thanks. I just noticed this this morning after reviewing the luster patches. You beat me to the patch. diff --git

Re: [PATCH] rdma_cm.h: Fix SCTP protocol ID

2010-01-13 Thread Roland Dreier
-RDMA_PS_SCTP = 0x0183 +RDMA_PS_SCTP = 0x0184 The old wrong value has been there since we first merged this. So changing it means anything using this in userspace would be broken. But is PS_SCTP exported to userspace? And as far as I can tell PS_SCTP is not implemented (this

RE: [PATCH] rdma_cm.h: Fix SCTP protocol ID

2010-01-13 Thread Sean Hefty
The old wrong value has been there since we first merged this. So changing it means anything using this in userspace would be broken. But is PS_SCTP exported to userspace? And as far as I can tell PS_SCTP is not implemented (this line is the only reference to RDMA_PS_SCTP in the whole kernel).

Re: [PATCH] rdma_cm.h: Fix SCTP protocol ID

2010-01-13 Thread Roland Dreier
Technically, I believe it's available to userspace, though the librdmacm doesn't define it. I'd be surprised if anything uses it. Wouldn't trying to use RDMA_PS_SCTP hit the default: return -EPROTONOSUPPORT; case in cma_get_port()? So one couldn't actually do

RE: [PATCH] rdma_cm.h: Fix SCTP protocol ID

2010-01-13 Thread Sean Hefty
Wouldn't trying to use RDMA_PS_SCTP hit the default: return -EPROTONOSUPPORT; case in cma_get_port()? So one couldn't actually do anything with RDMA_PS_SCTP? Or is there some way to avoid binding? You're right. There isn't any way to actually do anything with it. All