[PATCH for-3.2 v2 3/5] ib/mlx4: Add extended port capabilities support

2011-10-24 Thread Marcel Apfelbaum
An Extended Port Info packet is sent to each hw port during HCA init and if returns without error it is assumed the port supports extended port capabilities. Signed-off-by: Marcel Apfelbaum marc...@dev.mellanox.co.il Reviewed-by: Jack Morgenstein ja...@dev.mellanox.com --- Changes from v1 -

[PATCH V2 05/10] RDMA/cxgb4: Add DB Overflow Avoidance.

2011-10-24 Thread Vipul Pandya
- get FULL/EMPTY/DROP events from LLD - on FULL event, disable normal user mode DB rings. - add modify_qp semantics to allow user processes to call into the kernel to ring doobells without overflowing. Add DB Full/Empty/Drop stats. Mark queues

Re: [PATCH 07/10] RDMA/cxgb4: DB Drop Recovery for RDMA and LLD queues.

2011-10-24 Thread Vipul Pandya
On 21-10-2011 02:27, David Miller wrote: From: Steve Wise sw...@opengridcomputing.com Date: Thu, 20 Oct 2011 12:28:07 -0500 On 10/20/2011 12:17 PM, Roland Dreier wrote: I believe 5 and 7 have build dependencies. Right, missed that one too. But it seems 4,6,8,9,10 are independent of the

[PATCH 1/2] RDMA/cxgb4: Serialize calls to cq's comp_handler by lock

2011-10-24 Thread Kumar Sanghvi
Commit 01e7da6ba53ca4d6189a1eae45607c0331c871f2 introduced a potential problem wherein the cq's comp_handler can get called simultaneously from different places in iw_cxgb4 driver. This does not comply with Documentation/infiniband/core_locking.txt, which states that at a given point of time,

[PATCH 2/2] RDMA/cxgb3: Serialize calls to cq's comp_handler by lock

2011-10-24 Thread Kumar Sanghvi
iw_cxgb3 has a potential problem wherein the cq's comp_handler can get called simultaneously from different places in iw_cxgb3 driver. This does not comply with Documentation/infiniband/core_locking.txt, which states that at a given point of time, there should be only one callback per CQ should be

RE: [PATCH] An argument for allowing applications to manually send RMPP packets if desired

2011-10-24 Thread Mike Heinz
I'm not sure I understand the resistance to this patch. The patch does not break existing functionality and can demonstrably improve the performance of tools that can take advantage of it. What's wrong with implementing this patch now and working on an improved mechanism for the future?

Re: [PATCH 6/9] ib_srpt: Remove legacy use_port_guid_in_session_name module parameter

2011-10-24 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: This patch removes the legacy use_port_guid_in_session_name module parameter that is no longer required in modern ib_srpt code. The patch looks fine to me but the description could be improved: the

Re: [PATCH 7/9] ib_srpt: Convert srp_max_rdma_size into per port configfs attribute

2011-10-24 Thread Nicholas A. Bellinger
On Mon, 2011-10-24 at 18:34 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: This patch converts the srp_max_rdma_size module parameter into a per endpoint configfs attribute. This includes adding the necessary bits for show

[PATCH V2 1/2] IB/qib: Hold links until tuning data is available

2011-10-24 Thread Mike Marciniszyn
From: Mitko Haralanov mi...@qlogic.com Hold the link state machine until the tuning data is read from the QSFP EEPROM so correct tuning settings are applied before the state machine attempts to bring the link up. Link is also held on cable unplug in case a different cable is used. This version

Re: OpenSM plugin patch request

2011-10-24 Thread Karl Schulz
On Oct 17, 2011, at 5:28 PM, Hal Rosenstock wrote: A couple of minor comments: 1. Why not move the OSM_EVENT_ID_LIGHT_SWEEP_DONE event to where LIGHT SWEEP COMPLETE is indicated in osm_state_mgr.c ? That's actually more accurate as all the transactions have completed. 2. The new events

[PATCH 1/2] ib_srpt: Fix possible race with srp_sq_size in srpt_create_ch_ib

2011-10-24 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes a possible race with srp_sq_size in srpt_create_ch_ib() where changing sport-port_attrib.srp_sq_size via configfs could have unintended consequences. It uses a local assignment for srp_sq_size to ensure the values for ib_create_cq()

[PATCH 2/2] ib_srpt: Fix possible race with srp_max_rsp_size in srpt_release_channel_work

2011-10-24 Thread Nicholas A. Bellinger
From: Nicholas Bellinger n...@linux-iscsi.org This patch fixes a possible race with srp_max_rsp_size in srpt_release_channel_work() when changing sport-port_attrib.srp_max_rsp_size via configfs could have unintended consequences. It uses a new srpt_rdma_ch-rsp_size and assign the value during

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +static ssize_t srpt_tpg_attrib_store_srp_max_rsp_size( +       struct se_portal_group *se_tpg, +       const char *page, +       size_t count) +{ +       struct srpt_port *sport = container_of(se_tpg, struct

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Nicholas A. Bellinger
On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +static ssize_t srpt_tpg_attrib_store_srp_max_rsp_size( + struct se_portal_group *se_tpg, + const char *page, + size_t count)

Re: [PATCH 5/9] ib_srpt: Fix sport-port_guid formatting code

2011-10-24 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +               snprintf(sport-port_guid, sizeof(sport-port_guid), +                               0x%016llx, +                               be64_to_cpu(sport-gid.global.interface_id)); If I

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +static ssize_t srpt_tpg_attrib_store_srp_max_rsp_size( +      

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Nicholas A. Bellinger
On Mon, 2011-10-24 at 21:58 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 7:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote:

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 10:05 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:58 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: On Mon,

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: Also, isn't kstrto*() preferred over strict_strto*() ? Not AFAIK. This is what I found in the description of commit 33ee3b2: kstrto*: converting

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Nicholas A. Bellinger
On Mon, 2011-10-24 at 22:11 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 10:05 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:58 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On

Re: [PATCH 8/9] ib_srpt: Convert srp_max_rsp_size into per port configfs attribute

2011-10-24 Thread Nicholas A. Bellinger
On Mon, 2011-10-24 at 22:16 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 9:49 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: On Mon, 2011-10-24 at 21:44 +0200, Bart Van Assche wrote: Also, isn't kstrto*() preferred over strict_strto*() ? Not AFAIK. This is what I found

Re: [PATCH 7/9] ib_srpt: Convert srp_max_rdma_size into per port configfs attribute

2011-10-24 Thread Nicholas A. Bellinger
On Mon, 2011-10-24 at 05:33 +, Nicholas A. Bellinger wrote: From: Nicholas Bellinger n...@linux-iscsi.org This patch converts the srp_max_rdma_size module parameter into a per endpoint configfs attribute. This includes adding the necessary bits for show + store attributes w/ min/max

Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1

2011-10-24 Thread Roland Dreier
On Mon, Oct 24, 2011 at 11:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: - Handle IB completion timeouts. Although the InfiniBand Architecture Manual specifies that a HCA must generate an error completion for each pending work item when a queue pair reset is issued, an important

Re: [PATCH 07/10] RDMA/cxgb4: DB Drop Recovery for RDMA and LLD queues.

2011-10-24 Thread David Miller
From: Vipul Pandya vi...@chelsio.com Date: Mon, 24 Oct 2011 20:46:31 +0530 1. We would like to recommend that all the patches get included in Roland's infiniband tree since it has build dependencies. This is fine with me. It just means that Roland's tree has to have net-next included in it