Hello,
On 09/20/2010 10:35 PM, Roland Dreier wrote:
Looks fine to me as an improvement over the status quo, but I wonder how
many of these places could use the radix_tree stuff instead? If you're
not using the ability of the idr code to assign an id for you, then it
seems the radix_tree API
Hello,
On 09/23/2010 01:42 PM, Paul Mundt wrote:
On Mon, Sep 20, 2010 at 11:26:47PM +0200, Tejun Heo wrote:
Hello,
On 09/20/2010 10:35 PM, Roland Dreier wrote:
Looks fine to me as an improvement over the status quo, but I wonder how
many of these places could use the radix_tree stuff
to
cancel_delayed_work_sync().
* qib_wq is removed and ib_wq is used instead.
This is to prepare for deprecation of flush_scheduled_work().
Signed-off-by: Tejun Heo t...@kernel.org
---
Hello,
I think this patch is safe but don't have any experience with or
access to infiniband stuff and it's only compile tested
Hello,
On 10/19/2010 07:22 PM, Ralph Campbell wrote:
On Tue, 2010-10-19 at 08:24 -0700, Tejun Heo wrote:
* qib_cq_wq is a separate singlethread workqueue. Does the queue
require strict single thread execution ordering? IOW, does each
work have to be executed in the exact queued order
Hello,
On 10/19/2010 08:40 PM, Bart Van Assche wrote:
On Tue, Oct 19, 2010 at 5:24 PM, Tejun Heo t...@kernel.org wrote:
[ ... ]
This is to prepare for deprecation of flush_scheduled_work().
[ ... ]
Index: work/include/rdma/ib_verbs.h
[ ... ]
+extern struct workqueue_struct *ib_wq
Hello,
On 10/20/2010 12:21 PM, Bart Van Assche wrote:
Hmm... that's one very interesting reason to be unhappy. Can you
please elaborate why addition of a global variable doesn't make you
happy?
In the past every time I saw a global variable being added in a
software project that meant
Hello,
On Tue, Jan 11, 2011 at 06:29:52PM +0100, Bart Van Assche wrote:
On Tue, Jan 11, 2011 at 2:45 AM, Roland Dreier rdre...@cisco.com wrote:
git://git.kernel.org/pub/scm/linux/kernel/git/dad/srp-initiator.git
srp-lock-scaling
Thanks, pulled.
Will try to merge Tejun's work
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Roland Dreier rol...@kernel.org
Cc: Sean Hefty sean.he...@intel.com
Cc: Hal Rosenstock hal.rosenst...@gmail.com
Cc: linux-rdma@vger.kernel.org
---
This patch depends on an earlier idr
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Roland Dreier rol...@purestorage.com
Cc: linux-rdma@vger.kernel.org
---
This patch depends on an earlier idr changes and I think it would be
best to route these together through -mm
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Jack Morgenstein ja...@dev.mellanox.co.il
Cc: Or Gerlitz ogerl...@mellanox.com
Cc: Roland Dreier rol...@purestorage.com
Cc: linux-rdma@vger.kernel.org
---
This patch depends
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Mike Marciniszyn infinip...@intel.com
Cc: linux-rdma@vger.kernel.org
---
This patch depends on an earlier idr changes and I think it would be
best to route these together through -mm
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Mike Marciniszyn infinip...@intel.com
Cc: linux-rdma@vger.kernel.org
---
This patch depends on an earlier idr changes and I think it would be
best to route these together through -mm
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Tom Tucker t...@opengridcomputing.com
Cc: Steve Wise sw...@opengridcomputing.com
Cc: linux-rdma@vger.kernel.org
---
This patch depends on an earlier idr changes and I think it would
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Hoang-Nam Nguyen hngu...@de.ibm.com
Cc: Christoph Raisch rai...@de.ibm.com
Cc: linux-rdma@vger.kernel.org
---
This patch depends on an earlier idr changes and I think it would be
best
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Steve Wise sw...@chelsio.com
Cc: linux-rdma@vger.kernel.org
---
This patch depends on an earlier idr changes and I think it would be
best to route these together through -mm. Please
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Steve Wise sw...@chelsio.com
Cc: linux-rdma@vger.kernel.org
---
This patch depends on an earlier idr changes and I think it would be
best to route these together through -mm. Please
Hello,
On Sun, Feb 3, 2013 at 6:18 AM, Steve Wise sw...@opengridcomputing.com wrote:
Is there a git tree somewhere that I can use to test these patches out?
git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git convert-to-idr_alloc
- return ret;
+ if (lock) {
+
Hello,
On Mon, Feb 04, 2013 at 04:15:52PM +, Marciniszyn, Mike wrote:
I tried the branch you indicated in the initial patch cover.
When run with a qib driver, and ipoib ping of another system produces:
...
Looks like this is tripping during the arp/neighbour path resolution:
void
Convert to the much saner new idr interface.
Only compile tested.
v2: Mike triggered WARN_ON() in idr_preload() because send_mad(),
which may be used from non-process context, was calling
idr_preload() unconditionally. Preload iff @gfp_mask has
__GFP_WAIT.
Signed-off-by: Tejun Heo
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Hoang-Nam Nguyen hngu...@de.ibm.com
Cc: Christoph Raisch rai...@de.ibm.com
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/hw/ehca/ehca_cq.c | 27
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Reviewed-by: Steve Wise sw...@opengridcomputing.com
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/hw/cxgb4/iw_cxgb4.h | 27 ++-
1 file changed, 14
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Roland Dreier rol...@purestorage.com
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/hw/ocrdma/ocrdma_main.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Mike Marciniszyn infinip...@intel.com
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/hw/qib/qib_init.c | 21 -
1 file changed, 8 insertions(+), 13 deletions
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Jack Morgenstein ja...@dev.mellanox.co.il
Cc: Or Gerlitz ogerl...@mellanox.com
Cc: Roland Dreier rol...@purestorage.com
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/hw/mlx4
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Mike Marciniszyn infinip...@intel.com
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/hw/ipath/ipath_driver.c | 16
1 file changed, 4 insertions(+), 12 deletions
Convert to the much saner new idr interface.
Only compile tested.
Signed-off-by: Tejun Heo t...@kernel.org
Reviewed-by: Steve Wise sw...@opengridcomputing.com
Cc: linux-rdma@vger.kernel.org
---
drivers/infiniband/hw/cxgb3/iwch.h | 24 +++-
1 file changed, 11 insertions
Convert to the much saner new idr interface.
Only compile tested.
v2: Mike triggered WARN_ON() in idr_preload() because send_mad(),
which may be used from non-process context, was calling
idr_preload() unconditionally. Preload iff @gfp_mask has
__GFP_WAIT.
Signed-off-by: Tejun Heo
MAX_IDR_* constants to lib/idr.c.
Signed-off-by: Tejun Heo t...@kernel.org
Cc: Jean Delvare kh...@linux-fr.org
Cc: linux-...@vger.kernel.org
Cc: Roland Dreier rol...@kernel.org
Cc: Sean Hefty sean.he...@intel.com
Cc: Hal Rosenstock hal.rosenst...@gmail.com
Cc: Marciniszyn, Mike mike.marcinis
Hello,
On Fri, Feb 08, 2013 at 10:09:13PM +, Hefty, Sean wrote:
Used to wrap cyclic @start. Can be replaced with max(next, 0).
Note that this type of cyclic allocation using idr is buggy. These
are prone to spurious -ENOSPC failure after the first wraparound.
The replacement
On Wed, Feb 20, 2013 at 9:45 PM, Wei Yongjun weiyj...@gmail.com wrote:
From: Wei Yongjun yongjun_...@trendmicro.com.cn
A spin lock is taken here so we should use GFP_NOWAIT like
other case.
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
Acked-by: Tejun Heo t...@kernel.org
Thanks
On Thu, Feb 21, 2013 at 7:33 AM, Tejun Heo t...@kernel.org wrote:
Signed-off-by: Wei Yongjun yongjun_...@trendmicro.com.cn
Acked-by: Tejun Heo t...@kernel.org
Just noticed akpm isn't cc'd. Can you please repost w/
a...@linux-foundation.org cc'd? All related patches are going through
-mm
On Wed, Mar 27, 2013 at 09:18:04AM -0400, Jeff Layton wrote:
void c2_init_qp_table(struct c2_dev *c2dev)
{
spin_lock_init(c2dev-qp_table.lock);
- idr_init(c2dev-qp_table.idr);
+ idr_init_cyclic(c2dev-qp_table.idr, 0);
}
Why is this necessary? In general, why is
Hey, guys.
On Sun, Oct 06, 2013 at 09:10:30AM +0200, Alexander Gordeev wrote:
On Sun, Oct 06, 2013 at 05:19:46PM +1100, Benjamin Herrenschmidt wrote:
On Sun, 2013-10-06 at 08:02 +0200, Alexander Gordeev wrote:
In fact, in the current design to address the quota race decently the
drivers
Hello,
On Wed, Oct 02, 2013 at 12:48:21PM +0200, Alexander Gordeev wrote:
Make pci_msix_table_size() to return a error code if the device
does not support MSI-X. This update is needed to facilitate a
forthcoming re-design MSI/MSI-X interrupts enabling pattern.
Device drivers will use this
Hello,
On Wed, Oct 02, 2013 at 12:48:23PM +0200, Alexander Gordeev wrote:
+static int foo_driver_enable_msi(struct foo_adapter *adapter, int nvec)
+{
+ rc = pci_get_msi_cap(adapter-pdev);
+ if (rc 0)
+ return rc;
+
+ nvec = min(nvec, rc);
+ if (nvec
Hello, Alexander.
On Wed, Oct 02, 2013 at 12:48:16PM +0200, Alexander Gordeev wrote:
Alexander Gordeev (77):
PCI/MSI: Fix return value when populate_msi_sysfs() failed
PCI/MSI/PPC: Fix wrong RTAS error code reporting
PCI/MSI/s390: Fix single MSI only check
PCI/MSI/s390: Remove
Hello,
On Tue, Oct 08, 2013 at 02:22:16PM +0200, Alexander Gordeev wrote:
If we talk about pSeries quota, then the current pSeries pci_enable_msix()
implementation is racy internally and could fail if the quota went down
*while* pci_enable_msix() is executing. In this case the loop will have
Hello,
On Wed, Oct 09, 2013 at 02:57:16PM +0200, Alexander Gordeev wrote:
On Mon, Oct 07, 2013 at 02:01:11PM -0400, Tejun Heo wrote:
Hmmm... yean, the race condition could be an issue as multiple msi
allocation might fail even if the driver can and explicitly handle
multiple allocation
On Mon, Oct 07, 2013 at 09:48:01PM +0100, Ben Hutchings wrote:
There is one major flaw in min-max approach - the generic MSI layer
will have to take decisions on exact number of MSIs to request, not
device drivers.
[...
No, the min-max functions should be implemented using the same loop
Hello, Alexander.
On Tue, Oct 08, 2013 at 09:48:26AM +0200, Alexander Gordeev wrote:
If there are many which duplicate the above pattern, it'd probably be
worthwhile to provide a helper? It's usually a good idea to reduce
the amount of boilerplate code in drivers.
I wanted to limit
Hello,
On Tue, Oct 08, 2013 at 11:07:16AM +0200, Alexander Gordeev wrote:
Multipe MSIs is just a handful of drivers, really. MSI-X impact still
Yes, so it's pretty nice to try out things there before going full-on.
will be huge. But if we opt a different name for the new pci_enable_msix()
On Fri, Jul 24, 2015 at 05:04:00AM +0530, Devesh Sharma wrote:
replace module_license from GPL to Dual BSD/GPL
Cc: Tejun Heo t...@kernel.org
Cc: Duan Jiong duanj.f...@cn.fujitsu.com
Cc: Roland Dreier rol...@purestorage.com
Cc: Jes Sorensen jes.soren...@redhat.com
Cc: Sasha Levin levinsasha
On Fri, Jul 24, 2015 at 05:03:59AM +0530, Devesh Sharma wrote:
Change of license from GPLv2 to dual-license (GPLv2 and BSD 2-Clause)
Cc: Tejun Heo t...@kernel.org
Cc: Duan Jiong duanj.f...@cn.fujitsu.com
Cc: Roland Dreier rol...@purestorage.com
Cc: Jes Sorensen jes.soren...@redhat.com
Cc
Hello, Parav.
On Tue, Sep 08, 2015 at 02:08:16AM +0530, Parav Pandit wrote:
> Currently user space applications can easily take away all the rdma
> device specific resources such as AH, CQ, QP, MR etc. Due to which other
> applications in other cgroup or kernel space ULPs may not even get chance
Hello, Parav.
On Wed, Sep 09, 2015 at 09:27:40AM +0530, Parav Pandit wrote:
> This is one old white paper, but most of the reasoning still holds true on
> RDMA.
> http://h10032.www1.hp.com/ctg/Manual/c00257031.pdf
Just read it. Much appreciated.
...
> These resources include are- QP (queue
Hello, Parav.
On Mon, Sep 14, 2015 at 07:34:09PM +0530, Parav Pandit wrote:
> I missed to acknowledge your point that we need both - hard limit and
> soft limit/weight. Current patchset is only based on hard limit.
> I see that weight would be another helfpul layer in chain that we can
>
Hello, Parav.
On Fri, Sep 11, 2015 at 09:09:58AM +0530, Parav Pandit wrote:
> The fact is that user level application uses hardware resources.
> Verbs layer is software abstraction for it. Drivers are hiding how
> they implement this QP or CQ or whatever hardware resource they
> project via API
Hello, Parav.
On Fri, Sep 11, 2015 at 09:56:31PM +0530, Parav Pandit wrote:
> Resource run away by application can lead to (a) kernel and (b) other
> applications left out with no resources situation.
Yeap, that this controller would be able to prevent to a reasonable
extent.
> Both the
Hello, Parav.
On Fri, Sep 11, 2015 at 10:09:48PM +0530, Parav Pandit wrote:
> > If you're planning on following what the existing memcg did in this
> > area, it's unlikely to go well. Would you mind sharing what you have
> > on mind in the long term? Where do you see this going?
>
> At least
Hello, Doug.
On Fri, Sep 11, 2015 at 12:24:33AM -0400, Doug Ledford wrote:
> > My uneducated suspicion is that the abstraction is just not developed
> > enough.
>
> The abstraction is 10+ years old. It has had plenty of time to ferment
> and something better for the specific use case has not
Hello, Parav.
On Fri, Sep 11, 2015 at 10:13:59AM +0530, Parav Pandit wrote:
> > My uneducated suspicion is that the abstraction is just not developed
> > enough. It should be possible to virtualize these resources through,
> > most likely, time-sharing to the level where userland simply says "I
Hello, Parav.
On Thu, Sep 10, 2015 at 11:16:49PM +0530, Parav Pandit wrote:
> >> These resources include are- QP (queue pair) to transfer data, CQ
> >> (Completion queue) to indicate completion of data transfer operation,
> >> MR (memory region) to represent user application memory as source or
Hello,
On Thu, Jan 07, 2016 at 04:14:26AM +0530, Parav Pandit wrote:
> Yes. I read through. I can see two changes to be made in V2 version of
> this patch.
> 1. rdma.resource.verb.usage and rdma.resource.verb.limit to change
> respectively to,
> 2. rdma.resource.verb.stat and
Hello, Parav.
On Thu, Jan 07, 2016 at 04:43:20AM +0530, Parav Pandit wrote:
> > If different controllers can't agree upon the
> > same set of resources, which probably is a pretty good sign that this
> > isn't too well thought out to begin with,
>
> When you said "different controller" you meant
On Thu, Jan 07, 2016 at 04:46:19AM +0530, Parav Pandit wrote:
> On Wed, Jan 6, 2016 at 3:26 AM, Tejun Heo <t...@kernel.org> wrote:
> > On Wed, Jan 06, 2016 at 12:28:02AM +0530, Parav Pandit wrote:
> >> Added function pointer table to store resource pool specific
> >
On Wed, Jan 06, 2016 at 12:28:02AM +0530, Parav Pandit wrote:
> Added function pointer table to store resource pool specific
> operation for each resource type (verb and hw).
> Added list node to link device to rdma cgroup so that it can
> participate in resource accounting and limit
Hello,
On Wed, Jan 06, 2016 at 12:28:00AM +0530, Parav Pandit wrote:
> Resources are not defined by the RDMA cgroup. Resources are defined
> by RDMA/IB stack & optionally by HCA vendor device drivers.
As I wrote before, I don't think this is a good idea. Drivers will
inevitably add non-sensical
Hello,
On Wed, Jan 06, 2016 at 12:28:06AM +0530, Parav Pandit wrote:
> +5-4-1. RDMA Interface Files
> +
> + rdma.resource.verb.list
> + rdma.resource.verb.limit
> + rdma.resource.verb.usage
> + rdma.resource.verb.failcnt
> + rdma.resource.hw.list
> + rdma.resource.hw.limit
> +
Hello,
On Wed, Jan 06, 2016 at 12:28:03AM +0530, Parav Pandit wrote:
> +/* hash table to keep map of tgid to owner cgroup */
> +DEFINE_HASHTABLE(pid_cg_map_tbl, 7);
> +DEFINE_SPINLOCK(pid_cg_map_lock);/* lock to protect hash table access */
> +
> +/* Keeps mapping of pid to its owning cgroup
Hello, chiming in late.
On Wed, Oct 28, 2015 at 01:59:15PM +0530, Parav Pandit wrote:
> Design guidelines:
> ---
> 1. There will be new rdma cgroup for accounting rdma resources
> (instead of extending device cgroup).
> Rationale: RDMA tracks different type of resources and it
60 matches
Mail list logo
