Re: mlx4 missing completions (was Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1)

2011-10-27 Thread Bart Van Assche
On Wed, Oct 26, 2011 at 10:06 PM, Roland Dreier rol...@purestorage.com wrote: On Wed, Oct 26, 2011 at 11:05 AM, Bart Van Assche bvanass...@acm.org wrote: Can I conclude from your reply that the last WQE event refers to the SRQ only and that it does not provide any information about the send

Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1

2011-10-26 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 7:57 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +static int srpt_write_pending(struct se_cmd *se_cmd) +{ +       struct srpt_rdma_ch *ch; +       struct srpt_send_ioctx *ioctx; +       enum srpt_command_state new_state; +       enum rdma_ch_state ch_state;

Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1

2011-10-26 Thread Nicholas A. Bellinger
On Wed, 2011-10-26 at 08:09 +0200, Bart Van Assche wrote: On Mon, Oct 24, 2011 at 7:57 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: +static int srpt_write_pending(struct se_cmd *se_cmd) +{ + struct srpt_rdma_ch *ch; + struct srpt_send_ioctx *ioctx; + enum

Re: mlx4 missing completions (was Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1)

2011-10-26 Thread Bart Van Assche
On Wed, Oct 26, 2011 at 12:04 AM, Roland Dreier rol...@purestorage.com wrote: Sorry, but now I confused about what the bug is.  You have a QP associated with an SRQ, and you transition the QP to error.  At some point you get a last WQE received event for that QP (which means all receive

Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1

2011-10-25 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 8:33 PM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: It would have been nice if you bothered to mention these in any of the pre merge window reviews, but given your delay responsed on these items they will have to be something we'll fix post merge. Sorry for that

Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1

2011-10-25 Thread Bart Van Assche
On Mon, Oct 24, 2011 at 11:01 PM, Roland Dreier rol...@purestorage.com wrote: On Mon, Oct 24, 2011 at 11:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: - Handle IB completion timeouts. Although the InfiniBand Architecture Manual specifies that a HCA must generate an error completion

mlx4 missing completions (was Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1)

2011-10-25 Thread Roland Dreier
On Mon, Oct 24, 2011 at 11:07 PM, Bart Van Assche bvanass...@acm.org wrote: As far as I know every HCA supported by Linux does implement this correctly.  Which class did you have in mind as not doing that? At least QDR ConnectX 2 HCAs with fairly recent firmware. This behavior can be

Re: mlx4 missing completions (was Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1)

2011-10-25 Thread Bart Van Assche
On Tue, Oct 25, 2011 at 1:17 PM, Roland Dreier rol...@purestorage.com wrote: On Mon, Oct 24, 2011 at 11:07 PM, Bart Van Assche bvanass...@acm.org wrote: As far as I know every HCA supported by Linux does implement this correctly.  Which class did you have in mind as not doing that? At

Re: mlx4 missing completions (was Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1)

2011-10-25 Thread Roland Dreier
On Tue, Oct 25, 2011 at 11:09 AM, Bart Van Assche bvanass...@acm.org wrote: It's a little more complex than that. The original version of ib_srpt stops polling for completions as soon as the last WQE event has been received and after that the queue has been drained. So I don't know whether

Re: [PATCH-v2] ib_srpt: Initial SRP Target merge for v3.2-rc1

2011-10-24 Thread Roland Dreier
On Mon, Oct 24, 2011 at 11:33 AM, Nicholas A. Bellinger n...@linux-iscsi.org wrote: - Handle IB completion timeouts. Although the InfiniBand Architecture Manual specifies that a HCA must generate an error completion for each pending work item when a queue pair reset is issued, an important