mean the
regulator isn't present. If devm_regulator_get_optional() returns an
error, convert it to NULL (or don't do the assignment to
exynos_ehci-vdd?? in the first place).
The same criticism applies to the other patch in this series.
Alan Stern
--
To unsubscribe from this list: send
:
Acked-by: Alan Stern st...@rowland.harvard.edu
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 12 Feb 2015, amit daniel kachhap wrote:
Hi Alan,
On Mon, Feb 9, 2015 at 9:28 PM, Alan Stern st...@rowland.harvard.edu wrote:
On Mon, 9 Feb 2015, Amit Daniel Kachhap wrote:
This API creates a pm runtime slave type device which does not itself
participates in pm runtime
, doesn't the no_callbacks flag already do more or less what you
want?
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
when the
bus called _get_noresume()), and therefore the device will never be
runtime-suspended.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
, not just when
they are discovered. For example, a device might get probed when a
driver module is loaded, and that can occur at any time. So in general
it might indeed be necessary for the bus to wake up the parent before
calling the driver's probe routine.)
Alan Stern
--
To unsubscribe from
,
like PCI does, but in general it's a nuisance.)
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
for invoking the driver's
probe routine. Therefore the PM core doesn't _need_ to provide this
extra information to the subsystem. Rather, the subsystem just needs
to keep track of the information it already has available.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe
On Mon, 17 Nov 2014, Dmitry Torokhov wrote:
On Mon, Nov 17, 2014 at 02:54:53PM -0500, Alan Stern wrote:
On Mon, 17 Nov 2014, Dmitry Torokhov wrote:
For devices that aren't part of a power domain, things are simpler.
The bus does _get_noresume() to make sure the device won't
hasn't been probed yet, or if
the driver has already been unbound from the device.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
probing the
driver, because the driver will expect runtime PM to work properly
while its probe routine runs. For example, the probe routine might
want to leave the device in a runtime-suspended state. It can't do
that if the device isn't enabled for runtime PM.
Alan Stern
--
To unsubscribe
prefer to say
return ret here?
With or without that change, for both these two patches:
Acked-by: Alan Stern st...@rowland.harvard.edu
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
, wherein
in the absence of SAMSUNG_USB2PHY config symbol, we end up getting
the NOP_USB_XCEIV phy when the same is enabled. And thus the PHYs
are not configured properly.
Reported-by: Sachin Kamat sachin.ka...@samsung.com
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Alan Stern st
(pdev-dev, Regulator 3.3V Vdd supply not found\n);
+ }
What if this is one of the controllers that don't need to use a VDD
regulator? Do you really want to print out a warning in that case?
Should you call devm_regulator_get_optional() instead?
Alan Stern
--
To unsubscribe from this list
changed, 21 insertions(+), 36 deletions(-)
For all six patches,
Acked-by: Alan Stern st...@rowland.harvard.edu
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On Wed, 30 Apr 2014, Vivek Gautam wrote:
Change to use struct device instead of struct platform_device
for some static functions.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Alan Stern st...@rowland.harvard.edu
Acked-by: Jingoo Han jg1@samsung.com
---
For all four
in the device nodes for ohci, we can
remove the support for older phys.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Jingoo Han jg1@samsung.com
Cc: Alan Stern st...@rowland.harvard.edu
---
+static int exynos_ohci_phy_enable(struct device *dev)
{
struct usb_hcd *hcd
in the device nodes for ohci, we can
remove the support for older phys.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Jingoo Han jg1@samsung.com
Cc: Alan Stern st...@rowland.harvard.edu
+static int exynos_ohci_phyg_on(struct phy *phy[])
+{
+ int i;
+ int ret = 0
-phy);
+ exynos_ehci_phyg_off(exynos_ehci-phy_g);
+
In both these places, you need to test exynos_ehci-phyg before calling
exynos_ehci_phyg_off().
Maybe it would help to add exynos_ehci_phy_enable/disable routines,
like in the OHCI driver.
Alan Stern
--
To unsubscribe from this list
in the device nodes for ohci, we can
remove the support for older phys.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Jingoo Han jg1@samsung.com
Cc: Alan Stern st...@rowland.harvard.edu
+static int exynos_ohci_phyg_on(struct phy *phy, bool on)
+{
+ int ret = 0
both are needed to move to the new generic phy framework, keeping
support for older usb-phy
so as to have smooth transition, in order to avoid any regression.
I lost my copies of the ehci-exynos patch, but probably the same
comments apply as for the ohci-exynos patch.
Alan Stern
not proceed further with
its suspend callback, rather should return immediately to avoid
powering down the essential things, like phy.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Alan Stern st...@rowland.harvard.edu
Cc: Hauke Mehrtens ha...@hauke-m.de
Cc: Hans de Goede hdego
not proceed further with
its suspend callback, rather should return immediately to avoid
powering down the essential things, like phy.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Cc: Alan Stern st...@rowland.harvard.edu
---
Changes from v1
not proceed further with
its suspend callback, rather should return immediately to avoid
powering down the essential things, like phy.
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Cc: Alan Stern st...@rowland.harvard.edu
Cc: Jingoo Han jg1@samsung.com
---
Based on 'usb-next' branch
; they look like two unrelated things.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
;
Here, for example. Wouldn't it be better to goto fail_clk?
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
xhci_resume
(assuming you know what to test for) as well as putting a warm reset in
the port-power handler of xhci_hub_control.
Of course, doing simultaneous warm resets on multiple ports will use
less time than resetting each port individually, in sequence.
Alan Stern
--
To unsubscribe from
belongs in xhci-hcd, not in the
hub driver.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
. It depends on the reason why
hub_port_logical_disconnect got called.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
why you put this in hub_activate(). Isn't it more
closely connected with the reset-resume procedure for the child device?
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
:
- if (exynos_ehci-phy)
- usb_phy_shutdown(exynos_ehci-phy);
+ exynos_phys_off(exynos_ehci-phy);
+fail_phys_on:
fail_io:
clk_disable_unprepare(exynos_ehci-clk);
fail_clk:
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc
);
- clk_disable(usb_clk);
+ clk_disable_unprepare(clk);
+ clk_disable_unprepare(usb_clk);
}
/* ohci_s3c2410_hub_status_data
Any chance to get your ack on this?
Sorry, this must have slipped past. It's fine with me.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe
would use phy1 or phy2, and the PHY
consumers would use host1 or host2.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
not a layering violation for one region of the kernel to store
private data in a structure defined by another part of the kernel.
This happens all the time (e.g., dev_set_drvdata).
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord
.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
, this was simply meant to be a suggestion to show that it
is relatively easy to do what you need without using name or ID
strings.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http
?
phy_create is the API by which the PHY's driver (the supplier) hook into the
PHY framework. It's like the controller driver will always interact with the
PHY driver through the PHY framework.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body
does phy_create() fit into this picture?
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
the name string. Have the
consumer pass the data structure's address when it calls phy_create,
instead of passing the name. Then you don't have to worry about two
PHYs accidentally ending up with the same name or any other similar
problems.
Alan Stern
--
To unsubscribe from this list: send
? That routine would do the opposite of usb_phy_init(),
putting the PHY back into its initialized state.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On Tue, 23 Apr 2013, Vivek Gautam wrote:
Hi,
On Tue, Apr 23, 2013 at 10:23 PM, Alan Stern st...@rowland.harvard.edu
wrote:
On Tue, 23 Apr 2013, Vivek Gautam wrote:
Alright, so here's my understanding:
I suggested letting e.g. DWC3 enable the PHY's runtime_pm; Alan said
the DWC3 driver call to register itself
as a consumer of the PHY?
Likewise, what routine does it call to unregister itself?
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More
implements the above logic, making EHCI and OHCI work on
Arndale systems for me.
Signed-off-by: Alexander Graf ag...@suse.de
CC: Vivek Gautam gautam.vi...@samsung.com
CC: Jingoo Han jg1@samsung.com
CC: Alan Stern st...@rowland.harvard.edu
CC: Kukjin Kim kgene@samsung.com
CC: Felipe Balbi ba
was suspended even though it was really at full power.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
that these two calls don't invoke the
driver's runtime-PM callbacks!)
Probably nobody has thought these problems through very carefully for
the platform subsystem. Nevertheless, that's where the decisions need
to be made.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux
);
This is very strange. Why have a pm_runtime_put with no balancing
pm_runtime_get?
And why use an async routine when you're about to unbind the driver?
Don't you want the callback to occur before the unbinding?
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux
remain unsuspended even after the
driver does a pm_runtime_put(). For example, this will happen if the
user wrote on to /sys/.../power/control.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More
missed it; probably because it
came right in the middle of the holidays.
Acked-by: Alan Stern st...@rowland.harvard.edu
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org
and disconnections.
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
diand...@chromium.org
Acked-by: Alan Stern st...@rowland.harvard.edu
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Fri, 11 Jan 2013, Vivek Gautam wrote:
Adding the phy driver to ehci-s5p. Keeping the platform data
for continuing the smooth operation for boards which still uses it
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Acked-by: Alan Stern st
On Fri, 11 Jan 2013, Vivek Gautam wrote:
Adding the phy-driver to ohci-exynos. Keeping the platform data
for continuing the smooth operation for boards which still uses it
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Acked-by: Alan Stern st
which still uses it
Signed-off-by: Vivek Gautam gautam.vi...@samsung.com
Acked-by: Jingoo Han jg1@samsung.com
Missing Alan's Acked-by here.
Any comments on this patch-series ?
Sorry, this patch and the ohci-exynos one slipped through my net.
Acked-by's have been sent.
Alan
On Mon, 19 Nov 2012, Bill Pemberton wrote:
CONFIG_HOTPLUG is going away as an option so __devinit is no longer
needed.
Signed-off-by: Bill Pemberton wf...@virginia.edu
For all the __devinit* annotations and all the EHCI, OHCI, and UHCI
drivers:
Acked-by: Alan Stern st
= s3c_hsudc_set_halt,
+};
There's no .set_wedge method. Why do people always leave this out?
Alan Stern
--
To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo
On Thu, 14 Apr 2011, Greg KH wrote:
On Thu, Apr 14, 2011 at 11:35:43AM -0400, Alan Stern wrote:
On Thu, 14 Apr 2011, Heiko [iso-8859-1] St?bner wrote:
From: Thomas Abraham thomas...@samsung.com
The Samsung's S3C2416, S3C2443 and S3C2450 includes a USB High-Speed
device
56 matches
Mail list logo
