RE: [PATCH] net: sxgbe: Added tail point update

2014-05-08 Thread Byungho An
Francois Romieu wrote : Byungho An bh74...@samsung.com : Florian Fainelli wrote: [...] I think that at some point you should revisit your abstraction, all the patches that I see do take a void __iomem * argument as the first function argument, you should probably use your driver

[PATCH 3/3] net: sxgbe: fixed mtl and dma channel feature

2014-05-08 Thread Byungho An
This patch fixes mtl queue and dma channel value and adds mtl qsize for FIFO setting. Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet

[PATCH 1/3] net: sxgbe: Added condition for non fix_burst mode

2014-05-08 Thread Byungho An
This patch adds the condition for non fixed burst mode and seperates into two conditions for pbl value. Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.c | 32 --- drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.h |2

[PATCH 2/3] net: sxgbe: Added tail point update

2014-05-08 Thread Byungho An
This patch adds tail point update function for rx path after rx_refill function. It indicate tail point to rx dma. Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.c | 14 +- drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.h |4

[PATCH] net: sxgbe: Added tail point update

2014-05-07 Thread Byungho An
This patch adds tail point update function for rx path after rx_refill function. It indicates tail point for rx dma. Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.c | 14 +- drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.h |4

[PATCH] net: sxgbe: fixed mtl and dma channel feature

2014-05-07 Thread Byungho An
This patch fixes mtl queue and dma channel value and adds mtl qsize for FIFO setting. Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/net/ethernet

[PATCH] net: sxgbe: Added condition for non fix_burst mode

2014-05-07 Thread Byungho An
This patch adds the condition for non fixed burst mode and separates into two conditions depending on pbl value. Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.c | 32 --- drivers/net/ethernet/samsung/sxgbe/sxgbe_dma.h

RE: [PATCH] net: sxgbe: Added condition for non fix_burst mode

2014-05-07 Thread Byungho An
David Miller wrote: Please start numbering your patches and submit patch sets properly. You need to provide: 1) A header posting with subject [PATCH 0/${N}] blah blah blah that describes at a high level what the patch series does. 2) The patches, in the correct order, numbered in

RE: [PATCH] net: sxgbe: Added tail point update

2014-05-07 Thread Byungho An
Florian Fainelli wrote: 2014-05-07 1:14 GMT-07:00 Byungho An bh74...@samsung.com: This patch adds tail point update function for rx path after rx_refill function. It indicates tail point for rx dma. Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung

[PATCH] net: sxgbe: Added set function for interrupt on complete

2014-04-28 Thread Byungho An
This patch adds set_rx_int_on_com function for interrupt when dma is completed. Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.c |7 +++ drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.h |3 +++ drivers/net/ethernet/samsung/sxgbe

[PATCH] net: sxgbe: Added rxqueue enable function

2014-04-28 Thread Byungho An
This patch adds rxqueue enable function according to number of rxqueue and adds rxqueue disable function for removing. Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h |2 ++ drivers/net/ethernet/samsung/sxgbe/sxgbe_core.c | 22

[PATCH] net: sxgbe: Added phy_found error path

2014-04-18 Thread Byungho An
This patch adds phy_found error path when there is no phy device and changes bus_name. Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_mdio.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet

[PATCH net-next] net: sxgbe: fix potential null dereference

2014-03-28 Thread Byungho An
From: Byungho An bh74...@samsung.com This fixes following: drivers/net/ethernet/samsung/sxgbe/sxgbe_main.c:1828 sxgbe_hw_init() error: potential null dereference 'priv-hw'. (kmalloc returns null) Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Byungho An bh74

[PATCH net-next] net: sxgbe: fix sparse warnings about static declaration

2014-03-28 Thread Byungho An
From: Byungho An bh74...@samsung.com This fixes followings: sparse warnings: (new ones prefixed by ) drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c:197:5: sparse: symbol 'sxgbe_platform_freeze' was not declared. Should it be static? drivers/net/ethernet/samsung/sxgbe/sxgbe_platform.c

[PATCH V14 7/7] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-25 Thread Byungho An
From: Byungho An bh74...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported

[PATCH V14 1/7] sxgbe: Add device-tree binding support document

2014-03-25 Thread Byungho An
From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- .../devicetree/bindings/net/samsung-sxgbe.txt | 52

[PATCH V14 5/7] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-25 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V14 0/7] add new Samsung SXGBE driver

2014-03-25 Thread Byungho An
codes for irqs as per Francois's comment - removed unsupported functions for ehttoolirq as per Ben's comment Byungho An (1): MAINTAINERS: add maintainer for Samsung sxgbe driver Girish K S (1): net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe Siva Reddy (2): sxgbe

[PATCH V14 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-25 Thread Byungho An
From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe

RE: [PATCH V13 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-24 Thread Byungho An
Francois Romieu rom...@fr.zoreil.com : +static int sxgbe_platform_probe(struct platform_device *pdev) [...] + /* Get the SXGBE common INT information */ + priv-irq = irq_of_parse_and_map(node, 0); + if (priv-irq = 0) { + dev_err(dev, sxgbe common irq parsing failed\n);

[PATCH V13 0/7] add new Samsung SXGBE driver

2014-03-23 Thread Byungho An
mdio_read/write codes as per Francois's comment - changed irq acquisition error path as per Francois's comment - updated mdio and platform related codes as per Tomasz'comment - clean up dma related codes as per Vince's comment Changes since v12: - fixed typo Byungho An (1): MAINTAINERS: add

[PATCH V13 5/7] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-23 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V13 7/7] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-23 Thread Byungho An
From: Byungho An bh74...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported

[PATCH V13 1/7] sxgbe: Add device-tree binding support document

2014-03-23 Thread Byungho An
From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- .../devicetree/bindings/net/samsung-sxgbe.txt | 52

[PATCH V13 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-23 Thread Byungho An
From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe

[PATCH V13 6/7] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-23 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds ethtool related functions. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25

[PATCH V13 3/7] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-23 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com Enable TSO during initialization for each DMA channels Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V11 0/7] add new Samsung SXGBE driver

2014-03-22 Thread Byungho An
and depends statement from vendor sub-section as per Dave's comment Changes since v9: - removed adv-add-map, force-sf-dma-modei and force-thresh-dma-mode from binding documnet as per Mark's comment Changes since v10: - clean up codes as per Francois's comment Byungho An (1): MAINTAINERS

[PATCH V11 5/7] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-22 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V11 3/7] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-22 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com Enable TSO during initialization for each DMA channels Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V11 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-22 Thread Byungho An
From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe

[PATCH V11 7/7] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-22 Thread Byungho An
From: Byungho An bh74...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported

[PATCH V11 6/7] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-22 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds ethtool related functions. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25

[PATCH V11 1/7] sxgbe: Add device-tree binding support document

2014-03-22 Thread Byungho An
From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- .../devicetree/bindings/net/samsung-sxgbe.txt | 52

RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Francois Romieu rom...@fr.zoreil.com wrote : Byungho An bh74...@samsung.com : [...] +static int sxgbe_init_rx_buffers(struct net_device *dev, +struct sxgbe_rx_norm_desc *p, int i, +unsigned int dma_buf_sz

RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Tomasz Figa tomasz.f...@gmail.com : Hi, I have reviewed the non-net-specific parts of this driver, e.g. platform driver and Device Tree code. Please see my comments inline. On 22.03.2014 07:23, Byungho An wrote: From: Siva Reddy siva.kal...@samsung.com This patch adds support

RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Tomasz Figa tomasz.f...@gmail.com : On 22.03.2014 22:55, Byungho An wrote: Tomasz Figa tomasz.f...@gmail.com : [snip] + if (priv-irq = 0) { + dev_err(dev, sxgbe common irq parsing failed\n); + sxgbe_drv_remove(ndev); + return -EINVAL; + } + + /* Get

RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Vince Bridgers vbridgers2...@gmail.com : See comments inline On Sat, Mar 22, 2014 at 1:23 AM, Byungho An bh74...@samsung.com wrote: From: Siva Reddy siva.kal...@samsung.com This patch adds support for Samsung 10Gb ethernet driver(sxgbe). [snip] + /* program desc registers

RE: [PATCH V11 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-22 Thread Byungho An
Vince Bridgers vbridgers2...@gmail.com : On Sat, Mar 22, 2014 at 1:23 AM, Byungho An bh74...@samsung.com wrote: From: Siva Reddy siva.kal...@samsung.com This patch adds support for Samsung 10Gb ethernet driver(sxgbe). [snip] + /* Stop Advertising 1000BASE Capability if interface

[PATCH V12 0/7] add new Samsung SXGBE driver

2014-03-22 Thread Byungho An
mdio_read/write codes as per Francois's comment - changed irq acquisition error path as per Francois's comment - updated mdio and platform related codes as per Tomasz'comment - clean up dma related codes as per Vince's comment Byungho An (1): MAINTAINERS: add maintainer for Samsung sxgbe driver

[PATCH V12 1/7] sxgbe: Add device-tree binding support document

2014-03-22 Thread Byungho An
From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- .../devicetree/bindings/net/samsung-sxgbe.txt | 52

[PATCH V12 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-22 Thread Byungho An
From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe

[PATCH V12 6/7] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-22 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds ethtool related functions. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25

[PATCH V12 5/7] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-22 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V12 7/7] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-22 Thread Byungho An
From: Byungho An bh74...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported

RE: [PATCH V8 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-21 Thread Byungho An
Mark Rutland mark.rutl...@arm.com wrote: On Thu, Mar 20, 2014 at 05:26:06PM +, Byungho An wrote: From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe

RE: [PATCH V8 1/7] sxgbe: Add device-tree binding support document

2014-03-21 Thread Byungho An
Mark Rutland mark.rutl...@arm.com wrote: +Example: + + aliases { + ethernet0 = sxgbe0; + }; + + sxgbe0: ethernet@1a04 { + compatible = samsung,sxgbe-v2.0a; + reg = 0 0x1a04 0 0x1; + interrupt-parent = gic; +

RE: [PATCH V4 1/8] sxgbe: Add device-tree binding support document

2014-03-21 Thread Byungho An
Mark Rutland mark.rutl...@arm.com wrote : On Wed, Mar 19, 2014 at 10:32:48PM +, Byungho An wrote: Mark Rutland mark.rutl...@arm.com : On Tue, Mar 18, 2014 at 04:27:46PM +, Byungho An wrote: Mark Rutland mark.rutl...@arm.com : Hi, As a general note it's helpful

RE: [PATCH V7 6/7] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-21 Thread Byungho An
Vince Bridgers vbridgers2...@gmail.com wrote : On Wed, Mar 19, 2014 at 9:26 PM, Byungho An bh74...@samsung.com wrote: From: Vipul Pandya vipul.pan...@samsung.com This patch adds ethtool related functions. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches

[PATCH V10 0/7] add new Samsung SXGBE driver

2014-03-21 Thread Byungho An
and depends statement from vendor sub-section as per Dave's comment Changes since v9: - removed adv-add-map, force-sf-dma-modei and force-thresh-dma-mode from binding document and updated platform_get_irq as per Mark's comment Byungho An (1): MAINTAINERS: add maintainer for Samsung sxgbe

[PATCH V10 3/7] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-21 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com Enable TSO during initialization for each DMA channels Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V10 1/7] sxgbe: Add device-tree binding support document

2014-03-21 Thread Byungho An
From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- .../devicetree/bindings/net/samsung-sxgbe.txt | 52

[PATCH V10 5/7] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-21 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V10 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-21 Thread Byungho An
From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe

[PATCH V10 7/7] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-21 Thread Byungho An
From: Byungho An bh74...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported

RE: [PATCH V10 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-21 Thread Byungho An
Francois Romieu rom...@fr.zoreil.com : Byungho An bh74...@samsung.com : [...] +static int sxgbe_hw_init(struct sxgbe_priv_data * const priv) { struct sxgbe_ops *hw = priv-hw; + u32 ctrl_ids; [...] +struct sxgbe_priv_data *sxgbe_dvr_probe(struct device *device, nit: s/dvr

RE: [PATCH V7 3/7] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-20 Thread Byungho An
Rayagond Kokatanur rayag...@vayavyalabs.com wrote : On Thu, Mar 20, 2014 at 7:56 AM, Byungho An bh74...@samsung.com wrote: From: Vipul Pandya vipul.pan...@samsung.com Enable TSO during initialization for each DMA channels Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening

[PATCH V8 0/7] add new Samsung SXGBE driver

2014-03-20 Thread Byungho An
Joe's comment Changes since v6: - updated TSO related functions as per Rayagond's comment - updated binding document as per Mark's comment - removed WoL patch from this patch set Changes since v7: - updated TSO related functions as per Rayagond's comment Byungho An (1): MAINTAINERS: add

[PATCH V8 7/7] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-20 Thread Byungho An
From: Byungho An bh74...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported

[PATCH V8 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-20 Thread Byungho An
From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe

[PATCH V8 3/7] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-20 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com Enable TSO during initialization for each DMA channels Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V8 6/7] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-20 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds ethtool related functions. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25

[PATCH V8 1/7] sxgbe: Add device-tree binding support document

2014-03-20 Thread Byungho An
From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- .../devicetree/bindings/net/samsung-sxgbe.txt | 60

[PATCH V8 5/7] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-20 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

RE: [PATCH V8 2/7] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-20 Thread Byungho An
David Miller da...@davemloft.net : From: Byungho An bh74...@samsung.com Date: Thu, 20 Mar 2014 10:25:59 -0700 +config NET_VENDOR_SAMSUNG + bool Samsung Ethernet device + default y + depends on HAS_IOMEM HAS_DMA + select PHYLIB + select CRC32 + select PTP_1588_CLOCK

[PATCH V9 3/7] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-20 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com Enable TSO during initialization for each DMA channels Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V9 6/7] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-20 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds ethtool related functions. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25

[PATCH V9 0/7] add new Samsung SXGBE driver

2014-03-20 Thread Byungho An
and depends statement from vendor sub-section as per Dave's comment Byungho An (1): MAINTAINERS: add maintainer for Samsung sxgbe driver Girish K S (1): net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe Siva Reddy (2): sxgbe: Add device-tree binding support document

[PATCH V9 7/7] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-20 Thread Byungho An
From: Byungho An bh74...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported

[PATCH V9 5/7] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-20 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V9 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-20 Thread Byungho An
From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe

[PATCH V9 1/7] sxgbe: Add device-tree binding support document

2014-03-20 Thread Byungho An
From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- .../devicetree/bindings/net/samsung-sxgbe.txt | 60

RE: [PATCH V6 3/8] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-19 Thread Byungho An
Rayagond Kokatanur rayag...@vayavyalabs.com wrote: On Wed, Mar 19, 2014 at 11:02 AM, Byungho An bh74...@samsung.com wrote: [snip] /* save the skb address */ tqueue-tx_skbuff[entry] = skb; if (!is_jumbo) { - tx_desc-tdes01 = dma_map_single(priv

RE: [PATCH V4 1/8] sxgbe: Add device-tree binding support document

2014-03-19 Thread Byungho An
Mark Rutland mark.rutl...@arm.com : On Tue, Mar 18, 2014 at 04:27:46PM +, Byungho An wrote: Mark Rutland mark.rutl...@arm.com : Hi, As a general note it's helpful for devicetree to be Cc'd on the entire series (though the binding document should be a separate patch

[PATCH V7 0/7] add new Samsung SXGBE driver

2014-03-19 Thread Byungho An
Joe's comment Changes since v6: - updated TSO related functions as per Rayagond's comment - updated binding document as per Mark's comment - removed WoL from this patch set Byungho An (1): MAINTAINERS: add maintainer for Samsung sxgbe driver Girish K S (1): net: sxgbe: add EEE(Energy

[PATCH V7 1/7] sxgbe: Add device-tree binding support document

2014-03-19 Thread Byungho An
From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- .../devicetree/bindings/net/samsung-sxgbe.txt | 60

[PATCH V7 3/7] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-19 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com Enable TSO during initialization for each DMA channels Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V7 7/7] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-19 Thread Byungho An
From: Byungho An bh74...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported

[PATCH V7 5/7] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-19 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V7 6/7] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-19 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds ethtool related functions. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25

[PATCH V7 4/7] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-19 Thread Byungho An
From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe

[PATCH V4 3/8] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-18 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com Enable TSO during initialization for each DMA channels Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.h

[PATCH V4 0/8] add new Samsung SXGBE driver

2014-03-18 Thread Byungho An
- removed reference of net_device.{irq, base_addr} Byungho An (1): MAINTAINERS: add maintainer for Samsung sxgbe driver Girish K S (2): net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe net: sxgbe: add WOL(Wakeup-On-Lan)support for Samsung sxgbe Siva Reddy (2

[PATCH V4 8/8] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-18 Thread Byungho An
From: Byungho An bh74...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported

[PATCH V4 4/8] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-18 Thread Byungho An
From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe

[PATCH V4 5/8] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-18 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V4 7/8] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-18 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds ethtool related functions. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25

[PATCH V4 6/8] net: sxgbe: add WOL(Wakeup-On-Lan)support for Samsung sxgbe

2014-03-18 Thread Byungho An
From: Girish K S ks.g...@samsung.com This patch adds support for wake up on magic frame arrival. Also remote wake up on all other packets (unicast, multicast broadcast) is supported. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho

[PATCH V4 1/8] sxgbe: Add device-tree binding support document

2014-03-18 Thread Byungho An
From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- .../devicetree/bindings/net/samsung-sxgbe.txt | 53

RE: [PATCH V4 1/8] sxgbe: Add device-tree binding support document

2014-03-18 Thread Byungho An
Mark Rutland mark.rutl...@arm.com : Hi, As a general note it's helpful for devicetree to be Cc'd on the entire series (though the binding document should be a separate patch) as it provides useful context for reviewing the binding. OK. On Tue, Mar 18, 2014 at 06:47:13AM +, Byungho

[PATCH V5 3/8] net: sxgbe: add TSO support for Samsung sxgbe

2014-03-18 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com Enable TSO during initialization for each DMA channels Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_desc.h

[PATCH V5 1/8] sxgbe: Add device-tree binding support document

2014-03-18 Thread Byungho An
From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- .../devicetree/bindings/net/samsung-sxgbe.txt | 52

[PATCH V5 0/8] add new Samsung SXGBE driver

2014-03-18 Thread Byungho An
- removed reference of net_device.{irq, base_addr} Changes since v4: - updated binding document and DT related function per Mark's comment Byungho An (1): MAINTAINERS: add maintainer for Samsung sxgbe driver Girish K S (2): net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung

[PATCH V5 5/8] net: sxgbe: add Checksum offload support for Samsung sxgbe

2014-03-18 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds TX and RX checksum offload support. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h

[PATCH V5 4/8] net: sxgbe: add EEE(Energy Efficient Ethernet) for Samsung sxgbe

2014-03-18 Thread Byungho An
From: Girish K S ks.g...@samsung.com Added support for the EEE(Energy Efficient Ethernet) in 10G ethernet driver. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe

[PATCH V5 8/8] MAINTAINERS: add maintainer for Samsung sxgbe driver

2014-03-18 Thread Byungho An
From: Byungho An bh74...@samsung.com Signed-off-by: Byungho An bh74...@samsung.com --- MAINTAINERS |9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index b7befe7..aeb81f2 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -7536,6 +7536,15 @@ S: Supported

[PATCH V5 6/8] net: sxgbe: add WOL(Wakeup-On-Lan)support for Samsung sxgbe

2014-03-18 Thread Byungho An
From: Girish K S ks.g...@samsung.com This patch adds support for wake up on magic frame arrival. Also remote wake up on all other packets (unicast, multicast broadcast) is supported. Signed-off-by: Girish K S ks.g...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho

[PATCH V5 7/8] net: sxgbe: add ethtool related functions support Samsung sxgbe

2014-03-18 Thread Byungho An
From: Vipul Pandya vipul.pan...@samsung.com This patch adds ethtool related functions. Signed-off-by: Vipul Pandya vipul.pan...@samsung.com Neatening-by: Joe Perches j...@perches.com Signed-off-by: Byungho An bh74...@samsung.com --- drivers/net/ethernet/samsung/sxgbe/sxgbe_common.h | 25

RE: [PATCH V5 2/8] net: sxgbe: add basic framework for Samsung 10Gb ethernet driver

2014-03-18 Thread Byungho An
Joe Perches j...@perches.com wrote : On Tue, 2014-03-18 at 11:19 -0700, Byungho An wrote: From: Siva Reddy siva.kal...@samsung.com This patch adds support for Samsung 10Gb ethernet driver(sxgbe). More trivia, nothing that should stop this from being applied and updated later

RE: [PATCH V5 1/8] sxgbe: Add device-tree binding support document

2014-03-18 Thread Byungho An
Florian Fainelli f.faine...@gmail.com wrote : 2014-03-18 11:19 GMT-07:00 Byungho An bh74...@samsung.com: From: Siva Reddy siva.kal...@samsung.com This patch adds binding document for SXGBE ethernet driver via device-tree. Signed-off-by: Siva Reddy Kallam siva.kal...@samsung.com Signed

  1   2   >