Re: [PATCH 11/25] drm/exynos: introduce exynos_drm_plane_state structure

ate_plane, > .disable_plane = drm_atomic_helper_disable_plane, > .destroy= drm_plane_cleanup, > - .reset = drm_atomic_helper_plane_reset, > - .atomic_duplicate_state = drm_atomic_helper_plane_duplicate_state, > - .atomic_destroy_state = drm_atomic_helper_plane_destroy_sta

Re: [PATCH 12/25] drm/exynos: mixer: use crtc->state->adjusted_mode instead of crtc->mode

; > --- > drivers/gpu/drm/exynos/exynos_mixer.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of

Re: [PATCH 14/25] drm/exynos: introduce exynos_drm_plane_config structure

Hi Marek, 2015-11-10 Marek Szyprowski : > This patch adds common structure for keeping plane configuration and > capabilities data. This patch is inspired by similar code developed by > Tobias Jakobi. > > Signed-off-by: Marek Szyprowski > ---

Re: [PATCH 13/25] drm/exynos: mixer: enable video overlay plane only when VP is available

/drm/exynos/exynos_mixer.c | 3 +++ > 1 file changed, 3 insertions(+) Good catch. Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to major

Re: [PATCH] drm/atomic: only run atomic_check() if crtc is active

Hi Ville, 2015-11-13 Ville Syrjälä <ville.syrj...@linux.intel.com>: > On Fri, Nov 13, 2015 at 11:45:58AM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> > > > > Fixes an regression added by 3ae2436 (drm/exynos/mixer: rep

[PATCH] drm/atomic: only run atomic_check() if crtc is active

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Fixes an regression added by 3ae2436 (drm/exynos/mixer: replace direct cross-driver call with drm mode) and while this regression was caused by a change in the exynos driver it makes sense to add the check on atomic core to benefit

Re: [PATCH 15/25] drm/exynos: add generic check for plane state

m.szyprow...@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 ++ > drivers/gpu/drm/exynos/exynos_drm_plane.c | 51 > +++ > 2 files changed, 53 insertions(+) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk>

Re: [PATCH 16/25] drm/exynos: mixer: use ratio precalculated in exynos_state

> --- > drivers/gpu/drm/exynos/exynos_mixer.c | 33 +++-- > 1 file changed, 3 insertions(+), 30 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscribe

[PATCH] drm/exynos: only run atomic_check() if crtc is active

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Fixes an regression added by 3ae2436 (drm/exynos/mixer: replace direct cross-driver call with drm mode). The whole atomic update was failing if the hdmi display is not present/active. Add a test to only run atomic_check() if th

Re: [PATCH 04/25] drm/exynos: gsc: fix wrong pm_runtime state

t; > Signed-off-by: Seung-Woo Kim <sw0312@samsung.com> > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co

Re: [PATCH 03/25] drm/exynos: gsc: prepare and unprepare gsc clock

oo Kim <sw0312@samsung.com> > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_drm_gsc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk>

Re: [PATCH 08/25] drm/exynos: rotator: convert to common clock framework

Szyprowski <m.szyprow...@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_drm_rotator.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line &

Re: [PATCH 09/25] drm/exynos: exynos7-decon: remove excessive check

xynos/exynos7_drm_decon.c | 10 -- > 1 file changed, 10 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to major

Re: [PATCH 10/25] drm/exynos: move dma_addr attribute from exynos plane to exynos fb

s/exynos_drm_vidi.c | 5 - > drivers/gpu/drm/exynos/exynos_mixer.c | 7 --- > 9 files changed, 38 insertions(+), 53 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line

Re: [PATCH v4 05/79] exynos_drm.h: use __u64 from linux/types.h

1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH] drm/exynos: fimd: actually disable dp clock

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> fimd_dp_clock_enable() was setting the always to enabled, this patch fix this to actually use the value that is set to 'val'. Reported-by: Emilio López <emilio.lo...@collabora.co.uk> Signed-off-by: Gustavo Padovan &

Re: [PATCH] drm/exynos: dp: remove suspend/resume functions

; > Signed-off-by: Inki Dae <inki@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_dp_core.c | 23 --- > 1 file changed, 23 deletions(-) This sounds reasonable to me. Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo

Re: [PATCH 04/16] drm/exynos/hdmi: move PLL stabilization check code to separate function

- > drivers/gpu/drm/exynos/exynos_hdmi.c | 68 > ++-- > 1 file changed, 26 insertions(+), 42 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 01/16] drm/exynos/hdmi: remove support for deprecated compatible

<a.ha...@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 10 -- > 1 file changed, 10 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [PATCH 02/16] dt-bindings: remove deprecated compatible string from exynos-hdmi

ings/video/exynos_hdmi.txt | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to major

Re: [PATCH 03/16] drm/exynos/hdmi: use mappings for registers with IP dependent address

> > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 56 > +++- > drivers/gpu/drm/exynos/regs-hdmi.h | 4 +-- > 2 files changed, 38 insertions(+), 22 deletions(-) Reviewed-by: Gustav

Re: [PATCH 05/16] drm/exynos/hdmi: simplify HDMI-PHY power sequence

dxu3. > > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 93 > > 1 file changed, 8 insertions(+), 85 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora

Re: [PATCH 06/16] drm/exynos/hdmi: replace all writeb with writel

s(+), 3 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 15/16] drm/exynos/hdmi: remove unused field

Hi Andrzej, 2015-09-25 Andrzej Hajda <a.ha...@samsung.com>: > The patch removes unused hdmi_context field. > > Signed-off-by: Andrzej Hajda <a.ha...@samsung.com> > --- > drivers/gpu/drm/exynos/exynos_hdmi.c | 1 - > 1 file changed, 1 deletion(-) Reviewed-by:

Re: [PATCH 09/16] drm/exynos/hdmi: use constant size array for regulators

+ > 1 file changed, 9 insertions(+), 16 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a message to major

Re: [PATCH 13/16] drm/exynos/hdmi: convert container_of macro to inline function

s/gpu/drm/exynos/exynos_hdmi.c | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) Reviewed-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Gustavo -- To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in the body of a me

[PATCH 3/3] drm/exynos: remove unused mode_fixup() code

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> CRTC's mode_fixup() isn't used anymore in exynos, remove it. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 15 --- drivers/gpu/drm/exynos/exynos_drm

[PATCH 2/3] drm/exynos: remove decon_mode_fixup()

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> The only thing mode_fixup was doing was set the adjusted_mode->vrefresh to 60, but it already has the value of 60 when the decon_mode_fixup() is called. That means this call is actually pointless and can be removed. Signed-off-by

[PATCH] drm/exynos: Remove useless EXPORT_SYMBOL_GPLs

From: Daniel Kurtz <djku...@chromium.org> All the user of these functions are inside exynos-drm driver and you don't need to export the symbols for that case. Signed-off-by: Daniel Kurtz <djku...@chromium.org> Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --

[PATCH 03/10] drm/exynos: add pm_runtime to HDMI

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- drivers/gp

[PATCH 01/10] drm/exynos: do not start enabling DP at bind() phase

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> The DP device will be properly enabled at the enable() call just after the bind call finishes. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- drivers/gpu/drm/exynos/exynos_dp_core.c | 4 1 fil

[PATCH 02/10] drm/exynos: add pm_runtime to DP

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- drivers/gp

[PATCH 00/10] drm/exynos: add pm_runtime support

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Hi, This series adds proper runtime PM suport to CRTCs and Encoders, so now instead of relying on 'suspended' or 'enabled' flags to track when the CRTC or Encoder is enabled we let the pm_runtime subsystem do it for us and remo

[PATCH 04/10] drm/exynos: add pm_runtime to Mixer

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- drivers/gp

[PATCH 06/10] drm/exynos: Remove exynos_crtc commit() callback

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> This callback is no longer used by any of the exynos_crtc drivers, remove it. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 10 -- drivers/gp

[PATCH 07/10] drm/exynos: add pm_runtime to FIMD

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- drivers/gp

[PATCH 05/10] drm/exynos: remove exynos_crtc commit() callback

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> It turns out that .commit() was never executed, because at the time .mode_set_nofb() called it ctx->suspended was still false and .commit() would return. It removes the callback from FIMD DECON 7 and DECON 5433. Signed-off-by

[PATCH 08/10] drm/exynos: Enable DP clock directly from FIMD

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Instead of having a .clock_enable callback enable the dp clock directly from FIMD. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- drivers/gpu/drm/exynos/exynos_dp_core.c | 13 --- drivers/gp

[PATCH 09/10] drm/exynos: add pm_runtime to DECON 5433

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- drivers/gp

[PATCH 10/10] drm/exynos: add pm_runtime to DECON 7

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Let pm_runtime handle the enabling/disabling of the device with proper refcnt instead of rely on specific flags to track the enabled state. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- drivers/gp

Re: [PATCH] drm/exynos: add cursor plane support

Hi Inki, 2015-09-04 Inki Dae <inki@samsung.com>: > Hi Gustavo, > > I had already a review but I didn't give any comment to you. Sorry about > that. This patch looks good to me but one thing isn't clear. Below is my > comment. > > > On 2015년 09월 04일 05:14, G

[PATCH 2/2] drm/exynos: add cursor plane support

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Set one of the planes for each crtc driver as a cursor plane enabled window managers to fully work on exynos. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- v2: use the top window for cursor on each crtc

[PATCH 1/2] drm/exynos: add global macro for the default primary plane

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Define DEFAULT_WIN as zero to help set the primary plane on all CRTCs. Some CRTCs were defining a variable to store the default window, but that is not necessary as the default (primary) window is always the window zero. Sign

[PATCH] drm/exynos: add cursor plane support

From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Set one of the planes for each crtc driver as a cursor plane enabled window managers to fully work on exynos. Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> --- drivers/gpu/drm/exynos/exynos5433_drm_

[PATCH v2 10/11] drm/exynos: remove wait queue for pending page flip

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Exynos atomic commit procedures already does this job of waiting for pending updates to finish, that means using pending_flip_queue is pointless now because the disable CRTC procedure will never happen during a page_flip. Signed-off

[PATCH v2 11/11] drm/exynos: Enable atomic modesetting feature

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Now that atomic modesetting is implemented for exynos enable the DRIVER_ATOMIC flag on the driver's features. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 ++- 1 file changed

Re: [PATCH 1/2] drm/exynos: remove legacy -suspend()/resume()

Hi, What about this patch? We need it to avoid the WARN_ON added by patch 2/2 that was already picked up by Daniel. Gustavo 2015-08-13 Gustavo Padovan gust...@padovan.org: From: Gustavo Padovan gustavo.pado...@collabora.co.uk These legacy helpers should only be used by shadow

Re: [PATCH 03/11] drm/exynos: add prepare and cleanup phases for planes

Hi Inki, 2015-08-24 Inki Dae inki@samsung.com: On 2015년 08월 16일 01:26, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk .prepare_plane() and .cleanup_plane() allows to perform extra operations before and after the update of planes. For FIMD for example

[PATCH v2 09/11] drm/exynos: wait all planes updates to finish

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Add infrastructure to wait for all planes updates to finish by using an atomic_t variable to track how many pending updates we are waiting plus a wait_queue for the wait part. It also changes vblank behaviour and keeps it enabled for all

[PATCH v2 08/11] drm/exynos: add atomic asynchronous commit

From: Gustavo Padovan gustavo.pado...@collabora.co.uk The atomic modesetting interfaces supports async commits that should be implemented by the drivers. If drm core requests an async commit exynos_atomic_commit() will now schedule a work task to run the update later. It also serializes commits

[PATCH v2 02/11] drm/exynos: fimd: unify call to exynos_drm_crtc_finish_pageflip()

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Unify handling of finished plane update to prepare for a following patch that will check for the START and START_S regs to really make sure that the plane was updated. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk

[PATCH v2 04/11] drm/exynos: fimd: move window protect code to atomic_begin/flush

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Only set/clear the update bit in the CRTC's .atomic_begin()/flush() so all planes are really committed at the same time. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- v2: rename prepare_plane/cleanup_plane

[PATCH v2 03/11] drm/exynos: add begin and flush phases for planes

From: Gustavo Padovan gustavo.pado...@collabora.co.uk .atomic_begin() and .atomic_flush() allows to perform extra operations before and after the update of planes. For FIMD for example this will be used to enable disable the shadow protection bit. Signed-off-by: Gustavo Padovan gustavo.pado

[PATCH v2 00/11] drm/exynos: improve atomic modesetting

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Hi, This patchset adds a couple of changes to improve atomic modesetting: * add check for the START shadow register for FIMD to only finish the update when the screen was actually updated. * add asynchronous atomic commit, so now page

[PATCH v2 06/11] drm/exynos: add macro to get the address of START_S reg

From: Gustavo Padovan gustavo.pado...@collabora.co.uk This macro is need to get the value of the START shadow register, that will tell if an framebuffer is currently displayed on the screen or not. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- include/video/samsung_fimd.h

[PATCH] drm/exynos: fimd: move window protect code to prepare/atomic_flush

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Only set/clear the update bit in the CRTC's .atomic_begin()/flush() so all planes are really committed at the same time. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 57

[PATCH v2 05/11] drm/exynos: check for pending fb before finish update

From: Gustavo Padovan gustavo.pado...@collabora.co.uk The current code was ignoring the end of update for all overlay planes, caring only for the primary plane update in case of pageflip. This change adds a change to start to check for pending updates for all planes through exynos_plane

[PATCH v2 01/11] drm/exynos: don't track enabled state at exynos_crtc

From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct drm_crtc already stores the enabled state of the crtc thus we don't need to replicate enabled in exynos_drm_crtc. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 16

[PATCH] drm/exynos: add cursor plane support

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Set one of the planes for each crtc driver as a cursor plane enabled window managers to fully work on exynos. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos5433_drm_decon.c | 9

[PATCH -v3 11/11] drm/exynos: remove struct exynos_drm_encoder layer

From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had only a drm_encoder member and the internal exynos_drm_encoders ops that was directly mapped to the drm_encoder helper funcs. So now exynos DRM uses struct drm_encoder

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

Hi Inki, 2015-08-15 Inki Dae inki@samsung.com: 2015-08-13 0:54 GMT+09:00 Gustavo Padovan gust...@padovan.org: 2015-08-12 Gustavo Padovan gustavo.pado...@collabora.co.uk: Hi Inki, 2015-08-11 Inki Dae inki@samsung.com: On 2015년 08월 11일 09:38, Gustavo Padovan wrote: Hi

[PATCH 05/11] drm/exynos: check for pending fb before finish update

From: Gustavo Padovan gustavo.pado...@collabora.co.uk The current code was ignoring the end of update for all overlay planes, caring only for the primary plane update in case of pageflip. This change adds a change to start to check for pending updates for all planes through exynos_plane

[PATCH 01/11] drm/exynos: don't track enabled state at exynos_crtc

From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct drm_crtc already stores the enabled state of the crtc thus we don't need to replicate enabled in exynos_drm_crtc. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_crtc.c | 16

[PATCH 09/11] drm/exynos: wait all planes updates to finish

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Add infrastructure to wait for all planes updates to finish by using an atomic_t variable to track how many pending updates we are waiting plus a wait_queue for the wait part. It also changes vblank behaviour and keeps it enabled for all

[PATCH 04/11] drm/exynos: fimd: move window protect code to prepare/cleanup_plane

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Only set/clear the update bit in the CRTC's .atomic_begin()/flush() so all planes are really committed at the same time. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_fimd.c | 57

[PATCH 11/11] drm/exynos: Enable atomic modesetting feature

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Now that atomic modesetting is implemented for exynos enable the DRIVER_ATOMIC flag on the driver's features. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 3 ++- 1 file changed

[PATCH 08/11] drm/exynos: add atomic asynchronous commit

From: Gustavo Padovan gustavo.pado...@collabora.co.uk The atomic modesetting interfaces supports async commits that should be implemented by the drivers. If drm core requests an async commit exynos_atomic_commit() will now schedule a work task to run the update later. It also serializes commits

[PATCH 10/11] drm/exynos: remove wait queue for pending page flip

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Exynos atomic commit procedures already does this job of waiting for pending updates to finish, that means using pending_flip_queue is pointless now because the disable CRTC procedure will never happen during a page_flip. Signed-off

[PATCH 07/11] drm/exynos: fimd: only finish update if START == START_S

From: Gustavo Padovan gustavo.pado...@collabora.co.uk fimd_update_plane() programs BUF_START[win] and during the update BUF_START[win] is copied to BUF_START_S[win] (its shadow register) and starts scanning out, then it raises a irq. The fimd_irq_handler, in the case we have a pending_fb

[PATCH 06/11] drm/exynos: add macro to get the address of START_S reg

From: Gustavo Padovan gustavo.pado...@collabora.co.uk This macro is need to get the value of the START shadow register, that will tell if an framebuffer is currently displayed on the screen or not. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- include/video/samsung_fimd.h

[PATCH 00/11] drm/exynos: improve atomic modesetting

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Hi, This patchset adds a couple of changes to improve atomic modesetting: * add check for the START shadow register for FIMD to only finish the update when the screen was actually updated. * add asynchronous atomic commit, so now page

[PATCH 02/11] drm/exynos: fimd: unify call to exynos_drm_crtc_finish_pageflip()

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Unify handling of finished plane update to prepare for a following patch that will check for the START and START_S regs to really make sure that the plane was updated. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk

[PATCH 03/11] drm/exynos: add prepare and cleanup phases for planes

From: Gustavo Padovan gustavo.pado...@collabora.co.uk .prepare_plane() and .cleanup_plane() allows to perform extra operations before and after the update of planes. For FIMD for example this will be used to enable disable the shadow protection bit. Signed-off-by: Gustavo Padovan gustavo.pado

[PATCH 2/2] drm: WARN_ON if a modeset driver uses legacy suspend/resume helpers

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Legacy s/r hooks are only used for shadow-attaching drivers, warn when a KMS driver tries to use them. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/drm_drv.c | 2 ++ 1 file changed, 2 insertions(+) diff

[PATCH 1/2] drm/exynos: remove legacy -suspend()/resume()

From: Gustavo Padovan gustavo.pado...@collabora.co.uk These legacy helpers should only be used by shadow-attaching drivers. KMS drivers has its own way to handle suspend/resume and don't need to use these two helpers. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

Hi Inki, 2015-08-11 Inki Dae inki@samsung.com: On 2015년 08월 11일 09:38, Gustavo Padovan wrote: Hi Inki, 2015-08-07 Inki Dae inki@samsung.com: Hi Gustavo, On 2015년 08월 06일 22:31, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-12 Gustavo Padovan gustavo.pado...@collabora.co.uk: Hi Inki, 2015-08-11 Inki Dae inki@samsung.com: On 2015년 08월 11일 09:38, Gustavo Padovan wrote: Hi Inki, 2015-08-07 Inki Dae inki@samsung.com: Hi Gustavo, On 2015년 08월 06일 22:31, Gustavo Padovan wrote

Re: [PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

Hi Inki, 2015-08-07 Inki Dae inki@samsung.com: Hi Gustavo, On 2015년 08월 06일 22:31, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had only a drm_encoder member and the internal

Re: [PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder

Hi Inki, 2015-08-06 Inki Dae inki@samsung.com: On 2015년 08월 06일 08:24, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk Hi, This patchset is another important step in the exynos clean up, it removes two exynos internal structs in favor of wider use

[PATCH v2 11/11] drm/exynos: remove struct exynos_drm_encoder layer

From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had only a drm_encoder member and the internal exynos_drm_encoders ops that was directly mapped to the drm_encoder helper funcs. So now exynos DRM uses struct drm_encoder

[PATCH v2 10/11] drm/exynos: fold encoder setup into exynos_drm_load()

From: Gustavo Padovan gustavo.pado...@collabora.co.uk As we are removing the exynos encoder move the encoder setup operation directly inside the exynos_drm_load() Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 12

Re: [PATCH 11/11] drm/exynos: remove struct exynos_drm_encoder layer

2015-08-05 Inki Dae inki@samsung.com: Hi Inki, On 2015년 08월 04일 23:47, Gustavo Padovan wrote: Hi Inki, 2015-08-04 Inki Dae inki@samsung.com: On 2015년 08월 04일 04:09, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct exynos_drm_encoder

[PATCH v2 00/11] drm/exynos: remove exynos_drm_display and exynos_drm_encoder

From: Gustavo Padovan gustavo.pado...@collabora.co.uk Hi, This patchset is another important step in the exynos clean up, it removes two exynos internal structs in favor of wider use of struct drm_encoder. Structs exynos_drm_display and exynos_drm_encoder were doing exactly what struct

[PATCH v2 09/11] drm/exynos: remove exynos_drm_create_enc_conn()

From: Gustavo Padovan gustavo.pado...@collabora.co.uk This functions was just hiding the encoder and connector creation in a way that was less clean than if we get rid of it. For example, exynos_encoder ops had .create_connector() defined only because we were handing off the encoder and connector

[PATCH v2 03/11] drm/exynos: remove unused .remove() and .check_mode() ops from display

From: Gustavo Padovan gustavo.pado...@collabora.co.uk These two display_ops are not used anywhere, remove them. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v2 04/11] drm/exynos: simplify calculation of possible CRTCs

From: Gustavo Padovan gustavo.pado...@collabora.co.uk All CRTCs can only be LCD, HDMI or VIDI, so basically all CRTCs will be a possible CRTCs. This patch removes an extra function with switch that was only checking if the CRTC type was one of those three above. Signed-off-by: Gustavo Padovan

[PATCH v2 07/11] drm/exynos: remove extra call to exynos_dp_commit()

From: Gustavo Padovan gustavo.pado...@collabora.co.uk exynos_dp_commit() was getting called twice by exynos encoder core, once inside the .enable() call and another time by .commit() itself. The remove of the second call caused the wake of a bug, the operations orders inside exynos_dp_commit

[PATCH v2 08/11] drm/exynos: remove exynos_encoder's .commit() op

From: Gustavo Padovan gustavo.pado...@collabora.co.uk .commit() is not used anymore, Exynos encoders now follow the .enable()/.disable() semantics from drm atomic core, so remove this callback. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos

[PATCH v2 06/11] drm/exynos: remove extra call to hdmi_commit()

From: Gustavo Padovan gustavo.pado...@collabora.co.uk hdmi_commit() was getting called twice by exynos encoder core, once inside the .enable() call and another time by .commit() itself. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_hdmi.c | 13

[PATCH v2 02/11] drm/exynos: remove wrappers for phy_power_{on,off}

From: Gustavo Padovan gustavo.pado...@collabora.co.uk phy_power_on() and phy_power_off() already checks for NULL pointer. This patch removes the wrappers exynos_dp_phy_init() and exynos_dp_phy_exit() since the only think they were doing was a check for NULL phy. Signed-off-by: Gustavo Padovan

[PATCH v2 05/11] drm/exynos: remove struct exynos_drm_display

From: Gustavo Padovan gustavo.pado...@collabora.co.uk This struct was just representing encoder information, it was a member of struct exynos_drm_encoder, so any code trying to access encoder data would have to go through the encoder struct, get the display struct and then get the data it want

[PATCH v2 01/11] drm/exynos: split display's .dpms() into .enable() and .disable()

From: Gustavo Padovan gustavo.pado...@collabora.co.uk The DRM Core doesn't have a dpms() operation anymore, everything now is enable() or disable(). Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- v2: set dp-dpms_mode after enable/disable --- drivers/gpu/drm/exynos

Re: [PATCH 11/11] drm/exynos: remove struct exynos_drm_encoder layer

Hi Inki, 2015-08-04 Inki Dae inki@samsung.com: On 2015년 08월 04일 04:09, Gustavo Padovan wrote: From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had only a drm_encoder member and the internal

[PATCH 01/11] drm/exynos: split display's .dpms() into .enable() and .disable()

From: Gustavo Padovan gustavo.pado...@collabora.co.uk The DRM Core doesn't have a dpms() operation anymore, everything now is enable() or disable(). Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_dp_core.c | 37 drivers/gpu

[PATCH 11/11] drm/exynos: remove struct exynos_drm_encoder layer

From: Gustavo Padovan gustavo.pado...@collabora.co.uk struct exynos_drm_encoder was justing wrapping struct drm_encoder, it had only a drm_encoder member and the internal exynos_drm_encoders ops that was directly mapped to the drm_encoder helper funcs. So now exynos DRM uses struct drm_encoder

[PATCH 02/11] drm/exynos: remove wrappers for phy_power_{on,off}

From: Gustavo Padovan gustavo.pado...@collabora.co.uk phy_power_on() and phy_power_off() already checks for NULL pointer. This patch removes the wrappers exynos_dp_phy_init() and exynos_dp_phy_exit() since the only think they were doing was a check for NULL phy. Signed-off-by: Gustavo Padovan

[PATCH 06/11] drm/exynos: remove extra call to hdmi_commit()

From: Gustavo Padovan gustavo.pado...@collabora.co.uk hdmi_commit() was getting called twice by exynos encoder core, once inside the .enable() call and another time by .commit() itself. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos/exynos_hdmi.c | 13

[PATCH 05/11] drm/exynos: remove struct exynos_drm_display

From: Gustavo Padovan gustavo.pado...@collabora.co.uk This struct was just representing encoder information, it was a member of struct exynos_drm_encoder, so any code trying to access encoder data would have to go through the encoder struct, get the display struct and then get the data it want

[PATCH 08/11] drm/exynos: remove exynos_encoder's .commit() op

From: Gustavo Padovan gustavo.pado...@collabora.co.uk .commit() is not used anymore, Exynos encoders now follow the .enable()/.disable() semantics from drm atomic core, so remove this callback. Signed-off-by: Gustavo Padovan gustavo.pado...@collabora.co.uk --- drivers/gpu/drm/exynos

[PATCH 04/11] drm/exynos: simplify calculation of possible CRTCs

From: Gustavo Padovan gustavo.pado...@collabora.co.uk All CRTCs can only be LCD, HDMI or VIDI, so basically all CRTCs will be a possible CRTCs. This patch removes an extra function with switch that was only checking if the CRTC type was one of those three above. Signed-off-by: Gustavo Padovan

  1   2   3   4   5   6   >