Re: [PATCH v12 16/18] drm: bridge: analogix/dp: expand the wait time for looking AUX CH reply flag

2015-12-25 Thread Jingoo Han
On Thursday, December 24, 2015 10:23 AM, Yakir Yang wrote: > > Hi Jingoo, > > Okay, fine, I would drop this patch, until I found the the root cause. OK, I see. Best regards, Jingoo Han > > - Yakir > > On 12/23/2015 11:10 PM, Jingoo Han wrote: > > On Wednes

Re: [PATCH v12 16/18] drm: bridge: analogix/dp: expand the wait time for looking AUX CH reply flag

2015-12-23 Thread Jingoo Han
wait_time_aux = 10; > usleep_range(10, 11); If there is NO new wait time value from DT file, the default value '10' is used for sleep. But, if there is new wait time value from DT file, new wait time value can be used for sleep. usleep_range(dp->wait_time_aux

Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply

2015-12-23 Thread Jingoo Han
On Wednesday, December 23, 2015 3:01 PM, Yakir Yang wrote: > > Hi Jingoo, > > On 12/23/2015 12:24 PM, Yakir Yang wrote: > > Hi Jingoo, > > > > On 12/22/2015 08:26 PM, Jingoo Han wrote: > >> On Wednesday, December 16, 2015 12:58 PM, Yakir Yang wrote: &g

Re: [PATCH v11 06/19] ARM: dts: exynos/dp: remove some properties that deprecated by analogix_dp driver

2015-12-22 Thread Jingoo Han
ztof Kozlowski <k.kozlow...@samsung.com> > Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Reviewed-by: Jingoo Han < jingooh...@gmail.com > Best regards, Jingoo Han > --- > Changes in v11: None > Changes in v10: None > Changes in v9: None > Chang

Re: [PATCH v11 09/19] phy: Add driver for rockchip Display Port PHY

2015-12-22 Thread Jingoo Han
+ * > + * This program is free software; you can redistribute it and/or modify > + * it under the terms of the GNU General Public License as published by > + * the Free Software Foundation; either version 2 of the License. > + */ > + > +#include > +#include > +#include > +#i

Re: [PATCH v11 03/19] drm: bridge: analogix/dp: remove duplicate configuration of link rate and link count

2015-12-22 Thread Jingoo Han
x_dp_core.h > +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h > @@ -21,8 +21,9 @@ > #define MAX_EQ_LOOP 5 > > enum link_rate_type { > - LINK_RATE_1_62GBPS = 0x06, > - LINK_RATE_2_70GBPS = 0x0a > + LINK_RATE_1_62GBPS = DP_LINK_BW_1_62, > + LIN

Re: [PATCH v11 02/19] drm: bridge: analogix/dp: fix some obvious code style

2015-12-22 Thread Jingoo Han
zysztof Kozlowski <k.kozlow...@samsung.com> > Tested-by: Javier Martinez Canillas <jav...@osg.samsung.com> Acked-by: Jingoo Han <jingooh...@gmail.com> Best regards, Jingoo Han > --- > Changes in v11: None > Changes in v10: None > Changes in v9: None > Changes in

Re: [PATCH v11 17/19] drm: bridge: analogix/dp: expand the look time for waiting AUX CH reply

2015-12-22 Thread Jingoo Han
{ > timeout_loop++; > - if (DP_TIMEOUT_LOOP_COUNT < timeout_loop) { > + if (DP_TIMEOUT_LOOP_COUNT * 10 < timeout_loop) { No, I hate this coding. analogix_dp_reg.c is the common code that can be shared by various SoCs. Please, find another

Re: [PATCH v3 06/14] Documentation: drm/bridge: add document for analogix_dp

2015-08-24 Thread Jingoo Han
will not change the codes of ARM Exynos Architecture. Best regards, Jingoo Han Best regards, Krzysztof Signed-off-by: Yakir Yang y...@rock-chips.com --- Changes in v3: - Take Heiko suggest, add devicetree binding documents. - Take Thierry Reding suggest, remove sync pol colorimetry

Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver

2015-08-21 Thread Jingoo Han
/analogix_dp-exynos.c| 347 + Would you change this file name to exynos_dp.c? Best regards, Jingoo Han drivers/gpu/drm/exynos/exynos_dp_core.c| 1416 drivers/gpu/drm/exynos/exynos_dp_core.h| 282 drivers/gpu/drm/exynos/exynos_dp_reg.c

Re: [PATCH v3 13/14] drm: bridge/analogix_dp: move hpd detect to connector detect function

2015-08-20 Thread Jingoo Han
On 2015. 8. 19., at PM 11:52, Yakir Yang y...@rock-chips.com wrote: What is the reason to make this patch? Please make commit message including the reason. Best regards, Jingoo Han Signed-off-by: Yakir Yang y...@rock-chips.com --- Changes in v3: - move dp hpd detect to connector detect

Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver

2015-08-20 Thread Jingoo Han
On 2015. 8. 20., at PM 3:23, Yakir Yang y...@rock-chips.com wrote: Hi Jingoo Archit, On 08/20/2015 12:54 AM, Jingoo Han wrote: On 2015. 8. 20., at PM 1:29, Archit Taneja arch...@codeaurora.org wrote: Hi, On 08/19/2015 08:18 PM, Yakir Yang wrote: Hi all, The Samsung Exynos eDP

Re: [PATCH v3 05/14] drm: bridge/analogix_dp: fix link_rate lane_count bug

2015-08-20 Thread Jingoo Han
configuration of link rate and link count Best regards, Jingoo Han so we don't need to config those repeatly after training finished, just remove them out. Beside Display Port 1.2 already support 5.4Gbps link rate, the maximum sets would change from {1.62Gbps, 2.7Gbps} to {1.62Gbps, 2.7Gbps, 5.4Gbps

Re: [PATCH v3 12/14] drm: bridge/analogix_dp: expand the delay time for hpd detect

2015-08-20 Thread Jingoo Han
on the existing Exynos boards, due to unrelated reasons. Best regards, Jingoo Han Signed-off-by: Yakir Yang y...@rock-chips.com --- Changes in v3: None Changes in v2: None drivers/gpu/drm/bridge/analogix_dp_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers

Re: [PATCH v3 0/14] Add Analogix Core Display Port Driver

2015-08-19 Thread Jingoo Han
= + exynos_dp_read_bytes_from_i2c(..); - Take Jingoo Han suggest, just remove my name from author list. - Take Jingoo Han suggest, remove new copyright - Fix compiled failed dut to analogix_dp_device misspell - Take Heiko suggest, get panel node with remote-endpoint method, and create devicetree

Re: [RFC PATCH 2/8] drm: exynos/dp: convert to drm bridge mode

2015-08-06 Thread Jingoo Han
/exynos_dp_core.c index a8097a4..aa99e23 100644 --- a/drivers/gpu/drm/exynos/exynos_dp_core.c +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c @@ -3,6 +3,7 @@ * * Copyright (C) 2012 Samsung Electronics Co., Ltd. * Author: Jingoo Han jg1@samsung.com + * Yakir Yang y...@rock

Re: [RFC PATCH 0/8] Add Analogix Core Display Port Driver

2015-08-06 Thread Jingoo Han
also cannot find the exact IP name. The analogix may be the vendor name of this IP. Best regards, Jingoo Han Beyond that, there are three light registers setting differents bewteen exynos and rk3288. 1. RK3288 have five special pll resigters which not indicata in exynos dp controller. 2

Re: [PATCH] drm/exynos: dp: Lower level of EDID read success message

2015-05-18 Thread Jingoo Han
Don't pollute the dmesg with EDID read success message as an error. Printing as debug should be fine. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Right, dev_err() is not right. Thank you for sending the patch. Acked-by: Jingoo Han jingooh...@gmail.com Best regards, Jingoo Han

Re: [PATCH V2 RESEND] arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy

2014-12-02 Thread Jingoo Han
node. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Reviewed-by: Jingoo Han jg1@samsung.com Tested-by: Javier Martinez Canillas javier.marti...@collabora.co.uk Cc: Kukjin Kim kg...@kernel.org Any opinions about $subject? This patch is -rc material since is needed after

Re: [PATCH] drm / exynos / PM: Replace CONFIG_PM_RUNTIME with CONFIG_PM

2014-12-02 Thread Jingoo Han
now be changed to depend on CONFIG_PM. Replace CONFIG_PM_RUNTIME with CONFIG_PM in 4 files under gpu/drm/exynos/. Signed-off-by: Rafael J. Wysocki rafael.j.wyso...@intel.com Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- Note: This depends on commit

Re: [PATCH 1/3] drm/exynos: free DP if probe fails to find a panel or bridge

2014-11-23 Thread Jingoo Han
? Inki/Jingoo - Is this change really necessary? As far as I know, this devm_kfree() in unnecessary, even though PROBE_DEFER is returned. If I am wrong, please let me know. Thanks. Best regards, Jingoo Han Ajay return ret; } -- 1.9.3 -- To unsubscribe from this list

Re: [PATCH v3 1/2] drm/exynos: dp: Remove support for unused dptx-phy

2014-11-12 Thread Jingoo Han
Cc: Inki Dae inki@samsung.com Cc: Jingoo Han jg1@samsung.com Acked-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- Changes from V2: - Moved devm_phy_get() call out of exynos_dp_dt_parse_phydata() to exynos_dp_bind() function and, removed

Re: [PATCH v2 1/2] drm/exynos: dp: Remove support for unused dptx-phy

2014-11-11 Thread Jingoo Han
, it was not removed for DT compatibility. I think that now these old DT properties can be removed. I added some comments below. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Inki Dae inki@samsung.com Cc: Jingoo Han jg1@samsung.com --- Changes from V1: - Reworked error

Re: [PATCH v2 2/2] arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy

2014-11-11 Thread Jingoo Han
On Thursday, October 30, 2014 10:24 PM, Vivek Gautam wrote: DP PHY now require pmu-system-controller to handle PMU register to control PHY's power isolation. Adding the same to dp-phy node. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Jingoo Han jg1@samsung.com Reviewed

Re: [PATCH] usb: Remove references to non-existent PLAT_S5P symbol

2014-10-06 Thread Jingoo Han
...@tiscali.nl Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- drivers/usb/host/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig

Re: [PATCH v3 1/2] usb: host: ehci-exynos: Remove unnecessary usb-phy support

2014-09-17 Thread Jingoo Han
-off-by: Vivek Gautam gautam.vi...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- drivers/usb/host/ehci-exynos.c | 81 1 file changed, 23 insertions(+), 58 deletions(-) diff --git a/drivers/usb/host/ehci

Re: [PATCH] usb: dwc3: exynos: remove usb_phy_generic support

2014-08-27 Thread Jingoo Han
Transceiver Driver. So, usb_phy_generic can be removed from Exynos dwc3 driver. Is there any reason to support 'usb_phy_generic' for Exynos dwc3? If so, please let me know. Thank you. Best regards, Jingoo Han Cc: Olof Johansson o...@lixom.net Cc: Kukjin Kim kgene@samsung.com Cc: Vivek

Re: [PATCH v5 4/4] phy: exynos5-usbdrd: Calibrate LOS levels for exynos5420/5800

2014-08-26 Thread Jingoo Han
Address */ + writel(EXYNOS5_DRD_PHYREG0_CR_DATA_IN(addr), + phy_drd-reg_phy + EXYNOS5_DRD_PHYREG0); + crport_handshake(phy_drd, EXYNOS5_DRD_PHYREG0_CR_DATA_IN(addr), +EXYNOS5_DRD_PHYREG0_CR_CAP_ADDR); Best regards, Jingoo Han + + /* Write

Re: [PATCH 3/5] usb: phy: samsung: remove old USB 2.0 PHY driver

2014-08-20 Thread Jingoo Han
this driver completely and use the new generic PHY based driver once that comes (from Tomasz). I agree with this opinion. I shall drop the patches for cleaning up the usb-phy drivers from my series. Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 0/5] usb: phy: samsung: remove old USB PHY code

2014-08-20 Thread Jingoo Han
usb: phy: samsung: remove old USB 2.0 PHY driver usb: phy: samsung: remove old USB 3.0 PHY driver usb: phy: samsung: remove old common USB PHY code Reviewed-by: Vivek Gautam gautam.vi...@samsung.com Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han

Re: [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow

2014-08-11 Thread Jingoo Han
On Sunday, August 10, 2014 6:15 PM, Andreas Farber wrote: Am 05.08.2014 13:16, schrieb Jingoo Han: On Saturday, August 02, 2014 5:57 AM, Tomasz Figa wrote: On 01.08.2014 22:54, Andreas Färber wrote: Am 01.08.2014 22:33, schrieb Doug Anderson: On Thu, Jul 31, 2014 at 9:54 PM, Andreas

Re: [PATCH RESEND] usb: ehci/ohci-exynos: Fix PHY getting sequence

2014-08-05 Thread Jingoo Han
: Alan Stern st...@rowland.harvard.edu Cc: Jingoo Han jg1@samsung.com Acked-by: Jingoo Han jg1@samsung.com Right, we would get the generic PHYs first, then get the older usb-phys. Then, the older one will be removed from the kernel. Thank you. Best regards, Jingoo Han --- Based

Re: [PATCH v5 05/10] ARM: dts: Move dp_hpd from exynos5250 into smdk5250 and snow

2014-08-05 Thread Jingoo Han
6 0; So, you need to follow the second case. dp_hpd_gpio can be used for Spring board. Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs

2014-07-08 Thread Jingoo Han
will re-spin the patch. I agree with Tomasz Figa's statement. Personally, I think that it would be good to amend the commit message and add a dependency on USB_DWC2. :-) Thank you. Best regards, Jingoo Han -- Regards, Sachin. -- To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH RESEND] clk: samsung: Make of_device_id array const

2014-06-30 Thread Jingoo Han
On Thursday, June 26, 2014 9:00 PM, Krzysztof Kozlowski wrote: Array of struct of_device_id may be be const as expected by of_match_table field and of_find_matching_node_and_match() function. Signed-off-by: Krzysztof Kozlowski k.kozlow...@samsung.com Reviewed-by: Jingoo Han jg1

Re: [PATCH 06/17] video: fbdev: s3c-fb: remove s5p64x0 related fimd codes

2014-06-30 Thread Jingoo Han
On Tuesday, July 01, 2014 6:32 AM, Kukjin Kim wrote: This patch removes fimd codes for s5p6440 and s5p6450 SoCs. Signed-off-by: Kukjin Kim kgene@samsung.com Cc: Tomi Valkeinen tomi.valkei...@ti.com Acked-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han

Re: [PATCH V3 1/7] drm/exynos: Support DP CLKCON register in FIMD driver

2014-06-29 Thread Jingoo Han
register and call it by DP driver. Best regards, Jingoo Han Regards, Ajay [] -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2] drm/exynos: Support DP CLKCON register in FIMD driver

2014-06-26 Thread Jingoo Han
. Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- Changes since V1: - Remove usage of driver_data to configure DP CLKCON register drivers/gpu/drm/exynos/exynos_dp_core.c | 2 ++ drivers/gpu/drm/exynos/exynos_drm_drv.h | 8 drivers/gpu/drm/exynos

Re: [PATCH] drm/exynos: dpi: Fix NULL pointer dereference with legacy bindings

2014-06-17 Thread Jingoo Han
, which in turns calls exynos_dpi_detect(), which dereferences ctx-panel without a check, causing a NULL pointer derefrence. This patch fixes the issue by adding necessary NULL pointer check. Signed-off-by: Tomasz Figa tomasz.f...@gmail.com (+cc Inki Dae) Reviewed-by: Jingoo Han jg1

Re: [PATCH v2 1/2] usb: ehci-exynos: Make provision for vdd regulators

2014-06-11 Thread Jingoo Han
() instead? I agree with Alan's suggestion. This warning message is not proper, when USB controllers that don't need a VDD regulator are used. The devm_regulator_get_optional() looks better. Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH 1/1] PCI: exynos: Fix section mismatch warning

2014-05-29 Thread Jingoo Han
add_pcie_port lacks a __init annotation or the annotation of dw_pcie_host_init is wrong. Reported-by: kbuild test robot fengguang...@intel.com Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Acked-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- drivers/pci/host/pci

Re: [PATCH] drm/exynos: hdmi: remove the i2c drivers and use devtree - continued

2014-05-29 Thread Jingoo Han
to remove this 'exynos_hdmi.h' should be submitted. Thank you. [1] http://git.kernel.org/cgit/linux/kernel/git/daeinki/drm-exynos.git/commit/?h=exynos-drm-nextid=73c0a75ca9919c12525fd02eb49f9c3a34e0 d2d9 Best regards, Jingoo Han Signed-off-by: Lee Jones lee.jo...@linaro.org --- drivers

[PATCH] drm/exynos: remove unnecessary exynos_hdmi.h file

2014-05-29 Thread Jingoo Han
The exynos_hdmi.h has been used for the dedicated i2c drivers that were already removed. Thus, the unnecessary exynos_hdmi.h should be removed. Signed-off-by: Jingoo Han jg1@samsung.com --- drivers/gpu/drm/exynos/exynos_hdmi.h | 23 --- 1 file changed, 23 deletions

Re: [PATCH 5/5] ARM: dts: Update watchdog node name in exynos5440.dtsi

2014-05-23 Thread Jingoo Han
On Friday, May 23, 2014 3:09 PM, Sachin Kamat wrote: Made it as per DT node naming convention name@reg_addr. Signed-off-by: Sachin Kamat sachin.ka...@linaro.org Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- arch/arm/boot/dts/exynos5440.dtsi |2 +- 1 file

Re: [PATCH 1/2] ARM: dts: enable display controller for exynos5800 based peach-pi board

2014-05-12 Thread Jingoo Han
On Monday, May 12, 2014 3:45 PM, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com Enable display controller with timing information for 1080p panel in Exynos5800 peach-pi board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com Reviewed-by: Jingoo Han jg1

Re: [PATCH 2/2] ARM: dts: enable fimd for exynos5800 based peach-pi board

2014-05-12 Thread Jingoo Han
On Monday, May 12, 2014 3:45 PM, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com Enable FIMD for peach-pi board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- arch/arm/boot/dts/exynos5800

Re: [PATCH] crypto: s5p-sss: fix multiplatform build

2014-05-11 Thread Jingoo Han
...@samsung.com Cc: linux-samsung-soc@vger.kernel.org Cc: Vladimir Zapolskiy v...@mleia.com Cc: Herbert Xu herb...@gondor.apana.org.au I checked that these machine specific headers are unnecessary. Thanks! Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- Please apply on top

Re: [PATCH v3 0/4] ARM: dts: enable display for peach-pit and snow boards

2014-05-11 Thread Jingoo Han
On Friday, May 09, 2014 7:16 PM, Rahul Sharma wrote: + Jingoo Han. If you want to get Acked-by from maintainer, please add the maintainer to CC list for all patches. Anyway, I will review this patch. However, if you don't add me to CC list in the future, I am not sure that I will review your

Re: [PATCH v3 1/4] ARM: dts: enable fimd for exynos5250 based snow board

2014-05-11 Thread Jingoo Han
On Friday, May 09, 2014 7:10 PM, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com Enable fimd node for snow board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- arch/arm/boot/dts

Re: [PATCH v3 3/4] ARM: dts: enable fimd for exynos5420 based peach-pit board

2014-05-11 Thread Jingoo Han
On Friday, May 09, 2014 7:10 PM, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com Enable fimd for peach-pit board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- arch/arm/boot/dts

Re: [PATCH v3 2/4] ARM: dts: enable dp-controller for exynos5250 based snow board

2014-05-11 Thread Jingoo Han
On Friday, May 09, 2014 7:10 PM, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com Enable dp-controller for snow board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- arch/arm/boot/dts

Re: [PATCH v3 4/4] ARM: dts: enable dp-controller for exynos5420 based peach-pit board

2014-05-11 Thread Jingoo Han
On Friday, May 09, 2014 7:10 PM, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com Enable dp-controller for peach-pit board. Signed-off-by: Rahul Sharma rahul.sha...@samsung.com Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- arch/arm/boot/dts

Re: [PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

2014-05-08 Thread Jingoo Han
agreed that standard HPD pin part should be included to 'exynos5250-pinctrl.dtsi'. (https://lkml.org/lkml/2013/5/11/134) Best regards, Jingoo Han pinctrl@1341 { diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts index 6910485..62d38c8

Re: [PATCH v2 2/5] ARM: dts: enable fimd for exynos5250 based snow board

2014-05-08 Thread Jingoo Han
; }; }; + + fimd@1440 { + status = okay; (+cc Sachin Kamat, Tomasz Figa) For readability, how about moving 'status' to the last entry of the node? The same comment applies to other patches, too. Best regards, Jingoo Han + samsung,invert-vclk

Re: [PATCH v2 3/5] ARM: dts: enable dp-controller for exynos5250 based snow board

2014-05-08 Thread Jingoo Han
to the 5th patch. ([PATCH v2 5/5] ARM: dts: enable dp-controller for exynos5420 based peach-pit board) Best regards, Jingoo Han + native-mode = timing1; + timing1: timing@1 { + clock-frequency = 70589280

Re: [PATCH 1/5] ARM: dts: move dp hpd line to the board file for exynos5420

2014-05-08 Thread Jingoo Han
On Thursday, May 08, 2014 6:08 PM, Rahul Sharma wrote: On 8 May 2014 12:02, Jingoo Han jg1@samsung.com wrote: On Sunday, April 20, 2014 8:49 PM, Rahul Sharma wrote: From: Rahul Sharma rahul.sha...@samsung.com Display controller HPD Gpio line is board specific. This patch is moving

Re: [PATCH V2 1/9] drm/exynos: dp: support hotplug detection via GPIO

2014-05-08 Thread Jingoo Han
On Tuesday, April 22, 2014 4:14 PM, Jingoo Han wrote: On Tuesday, April 22, 2014 7:39 AM, Ajay Kumar wrote: From: Andrew Bresticker abres...@chromium.org Certain bridge chips use a GPIO to indicate the cable status instead of the I_DP_HPD pin. This adds an optional device-tree property

Re: [PATCH 0/5] ARM: dts: enable display for peach-pit and snow boards

2014-05-07 Thread Jingoo Han
, due to patch breakage. Best regards, Jingoo Han Rahul Sharma (5): ARM: dts: move dp hpd line to the board file for exynos5420 ARM: dts: enable fimd for exynos5250 based snow board ARM: dts: enable dp-controller for exynos5250 based snow board ARM: dts: enable fimd for exynos5420

Re: [PATCH 1/4] usb: ohci-exynos: Use struct device instead of platform_device

2014-04-28 Thread Jingoo Han
On Monday, April 28, 2014 6:25 PM, Vivek Gautam wrote: Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Jingoo Han jg1@samsung.com Acked-by: Jingoo Han jg1@samsung.com Best regards

Re: [PATCH 2/4] usb: ehci-exynos: Use struct device instead of platform_device

2014-04-28 Thread Jingoo Han
On Monday, April 28, 2014 6:26 PM, Vivek Gautam wrote: Change to use struct device instead of struct platform_device for some static functions. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Jingoo Han jg1@samsung.com Acked-by: Jingoo Han jg1@samsung.com Best regards

Re: [PATCH 7/8] PCI: designware: make MSI isr shared irq aware

2014-04-27 Thread Jingoo Han
device is using legacy INTD and another one using MSI, but better fix it now. Signed-off-by: Lucas Stach l.st...@pengutronix.de (+cc Mohit KUMAR DCG, Pratyush ANAND) Acked-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- drivers/pci/host/pci-exynos.c | 4 +--- drivers

Re: [PATCH 1/3] usb: ohci-exynos: Make provision for vdd regulators

2014-04-24 Thread Jingoo Han
On Thursday, April 24, 2014 3:40 PM, Vivek Gautam wrote: On Thu, Apr 24, 2014 at 6:56 AM, Jingoo Han jg1@samsung.com wrote: On Thursday, April 24, 2014 9:33 AM, Jingoo Han wrote: On Thursday, April 24, 2014 9:18 AM, Anton Tikhomirov wrote: On Monday, April 21, 2014 9:17 PM, Vivek

Re: [PATCH 3/3] usb: dwc3-exynos: Make provision for vdd regulators

2014-04-23 Thread Jingoo Han
in this series. Oh, I see. Thank you for your explanation. I shall be sending the dt patch for this soon. OK, I will wait for your patch. Best regards, Jingoo Han -- Best Regards Vivek Gautam Samsung RD Institute, Bangalore India -- To unsubscribe from this list: send the line

Re: [PATCH 1/3] usb: ohci-exynos: Make provision for vdd regulators

2014-04-23 Thread Jingoo Han
for smdk5250, certain perripherals will now need to ensure that, they request VDD regulators in their drivers, and enable them so as to make them working. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Jingoo Han jg1@samsung.com Acked-by: Jingoo Han jg1@samsung.com Best

Re: [PATCH 2/3] usb: ehci-exynos: Make provision for vdd regulators

2014-04-23 Thread Jingoo Han
for smdk5250, certain perripherals will now need to ensure that, they request VDD regulators in their drivers, and enable them so as to make them working. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Jingoo Han jg1@samsung.com Acked-by: Jingoo Han jg1@samsung.com Best

Re: [PATCH 1/3] usb: ohci-exynos: Make provision for vdd regulators

2014-04-23 Thread Jingoo Han
entries to smdk5420 275dcd2 ARM: dts: add max77686 pmic node for smdk5250, certain perripherals will now need to ensure that, they request VDD regulators in their drivers, and enable them so as to make them working. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Jingoo Han

Re: [PATCH 1/3] usb: ohci-exynos: Make provision for vdd regulators

2014-04-23 Thread Jingoo Han
On Thursday, April 24, 2014 9:33 AM, Jingoo Han wrote: On Thursday, April 24, 2014 9:18 AM, Anton Tikhomirov wrote: On Monday, April 21, 2014 9:17 PM, Vivek Gautam wrote: Facilitate getting required 3.3V and 1.0V VDD supply for OHCI controller on Exynos. With patches

Re: [PATCH V2 1/9] drm/exynos: dp: support hotplug detection via GPIO

2014-04-22 Thread Jingoo Han
rahul.sha...@samsung.com Signed-off-by: Ajay Kumar ajaykumar...@samsung.com Acked-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- Changes since V1: Address reiew comments from Jingoo Han .../devicetree/bindings/video/exynos_dp.txt|4 ++ drivers/gpu/drm

Re: [PATCH V2 3/9] drm/panel: Add driver for exynos_dp based panels

2014-04-22 Thread Jingoo Han
VIDEOMODE_HELPERS +config DRM_PANEL_EXYNOS_DP + tristate support for DP panels It looks very general. Please fix it as below. + tristate support for Exynos DP panels Best regards, Jingoo Han + depends on OF DRM_PANEL DRM_EXYNOS_DP + help + DRM panel driver for DP panels

Re: [PATCH V2 8/9] drm/bridge: Add PS8622 bridge driver

2014-04-22 Thread Jingoo Han
: + mutex_unlock(ps_bridge-enable_mutex); +} + +static void ps8622_post_disable(struct drm_bridge *bridge) +{ +} How about just removing this empty function? [.] Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH V4 1/5] phy: Add new Exynos5 USB 3.0 PHY driver

2014-04-21 Thread Jingoo Han
regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 4/7] drm/exynos: add exynos_dp_panel driver registration to drm driver

2014-04-20 Thread Jingoo Han
On Saturday, April 19, 2014 4:51 AM, Ajay Kumar wrote: On Fri, Apr 18, 2014 at 2:27 PM, Jingoo Han jg1@samsung.com wrote: On Wednesday, April 16, 2014 11:33 PM, Ajay Kumar wrote: [.] +#ifdef CONFIG_DRM_PANEL_EXYNOS_DP + platform_driver_unregister(exynos_dp_panel_driver

Re: [PATCH 3/7] drm/panel: Add driver for exynos_dp based panels

2014-04-20 Thread Jingoo Han
On Saturday, April 19, 2014 4:43 AM, Ajay kumar wrote: On Fri, Apr 18, 2014 at 2:17 PM, Jingoo Han jg1@samsung.com wrote: On Wednesday, April 16, 2014 11:33 PM, Ajay Kumar wrote: [.] +struct panel_exynos_dp { + struct drm_panelbase; + struct regulator

Re: [PATCH 1/7] drm/exynos: dp: support hotplug detection via GPIO

2014-04-18 Thread Jingoo Han
) + return DP_IRQ_TYPE_HP_CHANGE; + } return DP_IRQ_TYPE_UNKNOWN; } Best regards, Jingoo Han /* Parse hotplug interrupt status register */ reg = readl(dp-reg_base + EXYNOS_DP_COMMON_INT_STA_4); @@ -402,9 +417,14 @@ int

Re: [PATCH 3/7] drm/panel: Add driver for exynos_dp based panels

2014-04-18 Thread Jingoo Han
. Change the return type to 'void' Best regards, Jingoo Han +{ + struct panel_exynos_dp *dp_panel = to_panel(panel); + bool enable_delay = false; + + if (dp_panel-enabled) + return 0; + + if (!IS_ERR_OR_NULL(dp_panel-lcd_fet)) { + if (regulator_enable

Re: [PATCH 4/7] drm/exynos: add exynos_dp_panel driver registration to drm driver

2014-04-18 Thread Jingoo Han
, Jingoo Han + #ifdef CONFIG_DRM_EXYNOS_IPP exynos_platform_device_ipp_unregister(); err_unregister_ipp: diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h index 257ce09..f606290 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h +++ b

Re: [PATCH 1/2] usb: ehci-exynos: Return immediately from suspend if ehci_suspend fails

2014-04-09 Thread Jingoo Han
: Jingoo Han jg1@samsung.com --- Based on 'usb-next' branch of Greg's usb tree. drivers/usb/host/ehci-exynos.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/usb/host/ehci-exynos.c b/drivers/usb/host/ehci-exynos.c index d1d8c47..a4550eb 100644

Re: [PATCH RESEND] usb: ohci-exynos: Remove locks for 'ohci' in suspend callback

2014-04-08 Thread Jingoo Han
. Right, this spin_lock/unlock is unnecessary, because it is already used in ohci_suspend(). Acked-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Manjunath Goudar csmanjuvi...@gmail.com Cc: Alan Stern st

Re: [PATCH 1/2] usb: ehci-exynos: Return immediately from suspend if ehci_suspend fails

2014-04-08 Thread Jingoo Han
controller should not proceed further with its suspend callback, rather should return immediately to avoid powering down the essential things, like phy. Signed-off-by: Vivek Gautam gautam.vi...@samsung.com Cc: Alan Stern st...@rowland.harvard.edu Cc: Jingoo Han jg1@samsung.com Acked-by: Jingoo

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-04-07 Thread Jingoo Han
); return 0; /* Proper return code 0 == NO_IRQ */ Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pata_samsung_cf: fix ata_host_activate() failure handling

2014-03-31 Thread Jingoo Han
On Tuesday, April 01, 2014 2:53 AM, Tejun Heo wrote: Add missing clk_disable() call to ata_host_activate() failure path. Cc: Ben Dooks ben-li...@fluff.org Cc: Kukjin Kim kgene@samsung.com Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com Reviewed-by: Jingoo Han jg1

[PATCH] ARM: dts: Increase the size of PCIe configuration space for EXYNOS5440

2014-03-31 Thread Jingoo Han
...@st.com Signed-off-by: Jingoo Han jg1@samsung.com --- arch/arm/boot/dts/exynos5440.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/exynos5440.dtsi b/arch/arm/boot/dts/exynos5440.dtsi index d600733..5d08be8 100644 --- a/arch/arm/boot/dts

Re: [PATCH] ARM: dts: Increase the size of PCIe configuration space for EXYNOS5440

2014-03-31 Thread Jingoo Han
On Tuesday, April 01, 2014 12:44 PM, Pratyush Anand wrote: On Tue, Apr 01, 2014 at 10:54:57AM +0800, Jingoo Han wrote: Increase the size of PCIe configuration space to 8kB from 4kB, because 4kB for cfg0 and 4kB for cfg1 are required respectively. If 2kB for cfg0 and 2kB for cfg1 are set

[PATCH V2] ARM: dts: Increase the size of PCIe configuration space for EXYNOS5440

2014-03-31 Thread Jingoo Han
...@st.com Signed-off-by: Jingoo Han jg1@samsung.com --- Changes since v1: - Fix unintentional modification of I/O size, per Pratyush Anand. arch/arm/boot/dts/exynos5440.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts/exynos5440.dtsi b

Re: [PATCHv3 5/8] devfreq: exynos4: Use SET_SYSTEM_SLEEP_PM_OPS macro

2014-03-16 Thread Jingoo Han
SIMPLE_DEV_PM_OPS(exynos4_busfreq_pm, NULL, exynos4_busfreq_resume); However, if runtime pm functions will be added later, SIMPLE_DEV_PM_OPS is not necessary. Best regards, Jingoo Han }; static const struct platform_device_id exynos4_busfreq_id[] = { -- 1.8.0 -- To unsubscribe from this list: send

Re: [PATCH v2 2/6] PCI: tegra: use new OF interrupt mapping when possible

2014-03-06 Thread Jingoo Han
message can be the good way to do it. Thank you. Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2 4/6] ARM: dts: exynos5440: fix PCIe interrupt mapping

2014-03-05 Thread Jingoo Han
On Wednesday, March 05, 2014 10:26 PM, Lucas Stach wrote: So it actually works. Signed-off-by: Lucas Stach l.st...@pengutronix.de Acked-by: Arnd Bergmann a...@arndb.de Acked-by: Jingoo Han jg1@samsung.com It works properly on Exynos platform. Thank you. Best regards, Jingoo Han

Re: [PATCH v2 6/6] PCI: designware: use new OF interrupt mapping when possible

2014-03-05 Thread Jingoo Han
Zhu, Pratyush Anand, Marek Vasut, Kishon Vijay Abraham I) Acked-by: Jingoo Han jg1@samsung.com It works properly on Exynos platform. Thank you. Best regards, Jingoo Han --- v2: pass in parent dev to relevant functions, to make DT parsing work (spotted by Tim Harvey thar

Re: [PATCH 0/7] PCI irq mapping fixes and cleanups

2014-03-03 Thread Jingoo Han
-dev, sys-busnr, dw_pcie_ops, sys, sys-resources); } else { bus = NULL; However, I think that we may need to replace 'pci_common_init()' with 'pci_common_init_dev()'. Best regards, Jingoo Han -- To unsubscribe from this list: send

Re: [PATCH 4/7] ARM: dts: exynos5440: fix PCIe interrupt mapping

2014-03-02 Thread Jingoo Han
:289.33-34 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [arch/arm/boot/dts/exynos5440-ssdk5440.dtb] Error 1 make: *** [exynos5440-ssdk5440.dtb] Error 2 Would you fix it? Best regards, Jingoo Han num-lanes = 4; status = disabled

Re: [PATCH 4/7] ARM: dts: exynos5440: fix PCIe interrupt mapping

2014-03-02 Thread Jingoo Han
On Monday, March 03, 2014 4:41 PM, Jingoo Han wrote: On Saturday, March 01, 2014 2:29 AM, Lucas Stach wrote: So it actually works. Signed-off-by: Lucas Stach l.st...@pengutronix.de --- arch/arm/boot/dts/exynos5440.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

Re: [PATCH v3 2/2] phy: Select PHY_EXYNOS_DP_VIDEO by default for ARCH_EXYNOS

2014-02-23 Thread Jingoo Han
be then disabled or compiled in as module. Cc: Jingoo Han jg1@samsung.com Acked-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Acked-by: Kyungmin Park kyungmin.p...@samsung.com --- Changes since v2: - s/default y/default

Re: [RFC PATCHv1] usb: dwc2: Combine the dwc2 and s3c_hsotg into a single USB DRD driver.

2014-02-11 Thread Jingoo Han
CONFIG_USB_GADGET=n. 's3c-hsotg.c' supports only gadget mode. In the case of USB_DWC2_HOST mode, CONFIG_USB_GADGET is NOT enabled. I don't know how to solve it. Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [RFC PATCHv1] usb: dwc2: Combine the dwc2 and s3c_hsotg into a single USB DRD driver.

2014-02-05 Thread Jingoo Han
will test the patches with Samsung hardware. Thank you. Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH V2 0/3] exynos: arch: add support for exynos5260 SoC

2014-02-04 Thread Jingoo Han
-dt.c mode change 100644 = 100755 arch/arm/plat-samsung/include/plat/cpu.h The mode of these three files should NOT be changed to 100755. Please fix it. Best regards, Jingoo Han -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH] Documentation: devicetree: mct: Fix counter bit of CPU local timers

2014-01-22 Thread Jingoo Han
On Tuesday, January 21, 2014 6:03 PM, Jingoo Han wrote: According to the datasheet of Exynos SoCs, the counter bit of CPU local timers is 31-bit, not 32-bit; thus, it should be fixed. Please, ignore this patch. There is a 31-bit counter in CPU local timers; however, FRC (free running down

[PATCH] Documentation: devicetree: mct: Fix counter bit of CPU local timers

2014-01-21 Thread Jingoo Han
According to the datasheet of Exynos SoCs, the counter bit of CPU local timers is 31-bit, not 32-bit; thus, it should be fixed. Signed-off-by: Jingoo Han jg1@samsung.com --- Documentation/devicetree/bindings/timer/samsung,exynos4210-mct.txt |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] ARM: exynos_defconfig: Update EHCI config entry

2014-01-16 Thread Jingoo Han
Vivek Gautam, Yulgon Kim, Julius Werner) Reviewed-by: Jingoo Han jg1@samsung.com Yes, right. I overlooked 'exynos_defconfig', when I changed the name of Exynos EHCI driver. Thank you for sending the patch. :-) Best regards, Jingoo Han --- arch/arm/configs/exynos_defconfig |2 +- 1

Re: [PATCH -next] clk: exynos-audss: remove redundant dev_err call in exynos_audss_clk_probe()

2014-01-13 Thread Jingoo Han
It looks good. This error message is redundant; thus it should be removed. Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- drivers/clk/samsung/clk-exynos-audss.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/clk/samsung/clk-exynos

Re: [PATCH] exynos4-is: Compile runtime PM callbacks in conditionally

2014-01-07 Thread Jingoo Han
in order to fix the compile warning. Reviewed-by: Jingoo Han jg1@samsung.com Best regards, Jingoo Han --- drivers/media/platform/exynos4-is/fimc-core.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/drivers/media/platform/exynos4-is/fimc-core.c b/drivers

  1   2   3   4   5   6   >