and Sean,
Thanks for the comments!
On Tue, Oct 28, 2014 at 1:28 AM, Sean Paul seanp...@chromium.org wrote:
On Mon, Oct 27, 2014 at 3:01 PM, Daniel Vetter dan...@ffwll.ch wrote:
So don't ask why but I accidentally ended up in a branch looking at this
patch and didn't like it. So very quickgrumpy
the bridge object and pass only the drm-relevant
information to drm_bridge_init.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
This matches how drm_panel works, which it looks like this set is
trying to emulate.
Acked-by: Sean Paul seanp...@chromium.org
---
drivers/gpu/drm/bridge
On Mon, Oct 27, 2014 at 3:01 PM, Daniel Vetter dan...@ffwll.ch wrote:
So don't ask why but I accidentally ended up in a branch looking at this
patch and didn't like it. So very quickgrumpy review.
First, please make the patch subject more descriptive: I'd expect a helper
function scaffolding
On Wed, Aug 27, 2014 at 10:29 AM, Ajay Kumar ajaykumar...@samsung.com wrote:
A set of helper functions are defined in this patch to make
bridge driver probe independent of the drm flow.
The bridge devices register themselves on a lookup table
when they get probed by calling drm_bridge_add.
On Wed, Jul 23, 2014 at 11:18 AM, Ajay kumar ajayn...@gmail.com wrote:
On Wed, Jul 23, 2014 at 8:12 PM, Sean Paul seanp...@google.com wrote:
On Wed, Jul 23, 2014 at 7:22 AM, Ajay kumar ajayn...@gmail.com wrote:
Sean,
On Tue, Jul 22, 2014 at 8:29 PM, Sean Paul seanp...@google.com wrote
On Wed, Jul 23, 2014 at 7:22 AM, Ajay kumar ajayn...@gmail.com wrote:
Sean,
On Tue, Jul 22, 2014 at 8:29 PM, Sean Paul seanp...@google.com wrote:
On Thu, Jul 17, 2014 at 4:43 PM, Ajay Kumar ajaykumar...@samsung.com wrote:
Move the DP training and video enable from the hotplug handler
On Mon, May 5, 2014 at 12:52 PM, Ajay Kumar ajaykumar...@samsung.com wrote:
modify the driver to call the bridge-funcs of the next bridge
in the chain.
We assume that the bridge sitting next to ptn3460 is a bridge-panel.
Signed-off-by: Ajay Kumar ajaykumar...@samsung.com
---
On Mon, May 5, 2014 at 12:52 PM, Ajay Kumar ajaykumar...@samsung.com wrote:
As of now, we can have only one bridge hanging off the encoder.
With this patch, we allow multiple bridges to hang onto the same encoder
with the use of a simple next_bridge ptr.
The drm core calls bridge-funcs for
On Tue, May 6, 2014 at 12:45 PM, Ajay kumar ajayn...@gmail.com wrote:
Sean,
On Tue, May 6, 2014 at 9:25 PM, Sean Paul seanp...@chromium.org wrote:
On Mon, May 5, 2014 at 12:52 PM, Ajay Kumar ajaykumar...@samsung.com wrote:
As of now, we can have only one bridge hanging off the encoder
On Tue, May 6, 2014 at 1:03 PM, Ajay kumar ajayn...@gmail.com wrote:
Sean,
On Tue, May 6, 2014 at 9:24 PM, Sean Paul seanp...@chromium.org wrote:
On Mon, May 5, 2014 at 12:52 PM, Ajay Kumar ajaykumar...@samsung.com wrote:
modify the driver to call the bridge-funcs of the next bridge
On Mon, Apr 21, 2014 at 6:39 PM, Ajay Kumar ajaykumar...@samsung.com wrote:
This patch adds a drm_bridge driver for the PS8622 DisplayPort to LVDS
bridge chip.
Signed-off-by: Andrew Bresticker abres...@chromium.org
Signed-off-by: Sean Paul seanp...@chromium.org
Signed-off-by: Rahul Sharma
On Tue, Mar 25, 2014 at 2:52 PM, Daniel Drake dr...@endlessm.com wrote:
Hi Sean,
In your commit drm/exynos: hdmi: support extra resolutions using
drm_display_mode timings you added several more HDMI PHY configs to
exynos-drm. Thanks for that.
Can you explain where these magic numbers came
that things have changed substantially in the ChromiumOS tree,
for example this patch probably has some effect:
commit 29ae0c6096395a96a597453271946fc7d8442b6e
Author: Sean Paul seanp...@chromium.org
Date: Thu Jun 20 17:24:12 2013 -0400
drm/exynos: Consolidate suspend/resume in drm_drv
On Tue, Dec 3, 2013 at 5:07 PM, Daniel Drake dr...@endlessm.com wrote:
Hi,
Thanks a lot for this exynos-drm commit:
commit 62747fe0ad5169a767987d9009e3398466555cde
Author: Sean Paul seanp...@chromium.org
Date: Tue Jan 15 08:11:08 2013 -0500
drm/exynos: hdmi: support extra
This set adds some missing devicetree nodes to the exynos5250-snow file as well
as adds a drm_bridge driver for the ptn3460 DP-LVDS chip. This chip is used in
the exynos5250-snow board.
Sean
Sean Paul (5):
ARM: dts: Add fimd display-timings for exynos5250-snow
ARM: dts: Add dp-controller node
This patch adds code to look for the ptn3460 in the device tree file on
exynos initialization. If ptn node is found, the driver will initialize
the ptn3460 driver and skip creating a DP connector (since the bridge
driver will register its own connector).
Signed-off-by: Sean Paul seanp
This patch adds a drm_bridge driver for the PTN3460 DisplayPort to LVDS
bridge chip.
Signed-off-by: Sean Paul seanp...@chromium.org
---
v2:
- Changed header definition to static inline
- Changed dt node name to lvds-bridge
v3: No changes
.../devicetree/bindings/drm/bridge
This patch adds the internal panel timings to the exynos5250-snow board
dts file.
Signed-off-by: Sean Paul seanp...@chromium.org
---
v2: No difference
v3: Added status = okay
arch/arm/boot/dts/exynos5250-snow.dts | 18 ++
1 file changed, 18 insertions(+)
diff --git a/arch/arm
This patch adds the dp-controller node to the exynos5250-snow board dts
file.
Signed-off-by: Sean Paul seanp...@chromium.org
---
v2: Added dp-controller address to node (rebased on linux-next)
v3: Added status = okay
arch/arm/boot/dts/exynos5250-snow.dts | 13 +
1 file changed, 13
On Fri, Oct 4, 2013 at 12:18 AM, Inki Dae inki@samsung.com wrote:
2013/10/4 Sean Paul seanp...@chromium.org:
On Thu, Oct 3, 2013 at 10:29 PM, Inki Dae inki@samsung.com wrote:
2013/10/4 Sean Paul seanp...@chromium.org:
This patch adds code to look for the ptn3460 in the device tree file
On Fri, Oct 4, 2013 at 11:01 AM, Inki Dae inki@samsung.com wrote:
-Original Message-
From: Sean Paul [mailto:seanp...@chromium.org]
Sent: Friday, October 04, 2013 11:17 PM
To: Inki Dae
Cc: Kukjin Kim; DRI mailing list; linux-samsung-soc@vger.kernel.org;
linux-arm-ker
On Thu, Oct 3, 2013 at 9:55 AM, Inki Dae inki@samsung.com wrote:
Hi, thank you for your contribution and the below is my short comments,
2013/10/2 Sean Paul seanp...@chromium.org:
This patch adds a drm_bridge driver for the PTN3460 DisplayPort to LVDS
bridge chip.
Signed-off-by: Sean
On Thu, Oct 3, 2013 at 10:43 AM, Inki Dae inki@samsung.com wrote:
2013/10/2 Sean Paul seanp...@chromium.org:
This patch adds code to look for the ptn3460 in the device tree file on
exynos initialization. If ptn node is found, the driver will initialize
the ptn3460 driver and skip creating
On Wed, Oct 2, 2013 at 5:10 PM, Olof Johansson o...@lixom.net wrote:
On Tue, Oct 1, 2013 at 4:40 PM, Sean Paul seanp...@chromium.org wrote:
This patch adds the dp-controller node to the exynos5250-snow board dts
file.
Signed-off-by: Sean Paul seanp...@chromium.org
---
arch/arm/boot/dts
On Thu, Oct 3, 2013 at 1:18 PM, Inki Dae inki@samsung.com wrote:
2013/10/4 Sean Paul seanp...@chromium.org:
On Thu, Oct 3, 2013 at 10:43 AM, Inki Dae inki@samsung.com wrote:
2013/10/2 Sean Paul seanp...@chromium.org:
This patch adds code to look for the ptn3460 in the device tree file
On Thu, Oct 3, 2013 at 1:39 PM, Inki Dae inki@samsung.com wrote:
2013/10/3 Sean Paul seanp...@chromium.org:
On Thu, Oct 3, 2013 at 9:55 AM, Inki Dae inki@samsung.com wrote:
Hi, thank you for your contribution and the below is my short comments,
2013/10/2 Sean Paul seanp
On Thu, Oct 3, 2013 at 2:23 PM, Inki Dae inki@samsung.com wrote:
2013/10/4 Sean Paul seanp...@chromium.org:
On Thu, Oct 3, 2013 at 1:39 PM, Inki Dae inki@samsung.com wrote:
2013/10/3 Sean Paul seanp...@chromium.org:
On Thu, Oct 3, 2013 at 9:55 AM, Inki Dae inki@samsung.com wrote
This patch adds a drm_bridge driver for the PTN3460 DisplayPort to LVDS
bridge chip.
Signed-off-by: Sean Paul seanp...@chromium.org
---
v2:
- Changed header definition to static inline
- Changed dt node name to lvds-bridge
.../devicetree/bindings/drm/bridge/ptn3460.txt
This set adds some missing devicetree nodes to the exynos5250-snow file as well
as adds a drm_bridge driver for the ptn3460 DP-LVDS chip. This chip is used in
the exynos5250-snow board.
Sean
Sean Paul (5):
ARM: dts: Add fimd display-timings for exynos5250-snow
ARM: dts: Add dp-controller node
This patch adds the dp-controller node to the exynos5250-snow board dts
file.
Signed-off-by: Sean Paul seanp...@chromium.org
---
v2: Added dp-controller address to node (rebased on linux-next)
arch/arm/boot/dts/exynos5250-snow.dts | 12
1 file changed, 12 insertions(+)
diff --git
This patch adds a node for the ptn3460 DP-LVDS chip in the
exynos5250-snow board dts file.
Signed-off-by: Sean Paul seanp...@chromium.org
---
v2: Changed node name to lvds-bridge
arch/arm/boot/dts/exynos5250-snow.dts | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch
This patch adds code to look for the ptn3460 in the device tree file on
exynos initialization. If ptn node is found, the driver will initialize
the ptn3460 driver and skip creating a DP connector (since the bridge
driver will register its own connector).
Signed-off-by: Sean Paul seanp
This patch adds the internal panel timings to the exynos5250-snow board
dts file.
Signed-off-by: Sean Paul seanp...@chromium.org
---
v2: No difference
arch/arm/boot/dts/exynos5250-snow.dts | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250
On Thu, Oct 3, 2013 at 10:29 PM, Inki Dae inki@samsung.com wrote:
2013/10/4 Sean Paul seanp...@chromium.org:
This patch adds code to look for the ptn3460 in the device tree file on
exynos initialization. If ptn node is found, the driver will initialize
the ptn3460 driver and skip creating
This patch adds the internal panel timings to the exynos5250-snow board
dts file.
Signed-off-by: Sean Paul seanp...@chromium.org
---
arch/arm/boot/dts/exynos5250-snow.dts | 17 +
1 file changed, 17 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot
This set adds some missing devicetree nodes to the exynos5250-snow file as well
as adds a drm_bridge driver for the ptn3460 DP-LVDS chip. This chip is used in
the exynos5250-snow board.
Sean
Sean Paul (5):
ARM: dts: Add fimd display-timings for exynos5250-snow
ARM: dts: Add dp-controller node
This patch adds a node for the ptn3460 DP-LVDS chip in the
exynos5250-snow board dts file.
Signed-off-by: Sean Paul seanp...@chromium.org
---
arch/arm/boot/dts/exynos5250-snow.dts | 19 +++
1 file changed, 19 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b
This patch adds the dp-controller node to the exynos5250-snow board dts
file.
Signed-off-by: Sean Paul seanp...@chromium.org
---
arch/arm/boot/dts/exynos5250-snow.dts | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/exynos5250-snow.dts
b/arch/arm/boot/dts
This patch adds code to look for the ptn3460 in the device tree file on
exynos initialization. If ptn node is found, the driver will initialize
the ptn3460 driver and skip creating a DP connector (since the bridge
driver will register its own connector).
Signed-off-by: Sean Paul seanp
This patch adds a drm_bridge driver for the PTN3460 DisplayPort to LVDS
bridge chip.
Signed-off-by: Sean Paul seanp...@chromium.org
---
.../devicetree/bindings/drm/bridge/ptn3460.txt | 27 ++
drivers/gpu/drm/Kconfig| 2 +
drivers/gpu/drm/Makefile
On Tue, Dec 25, 2012 at 8:54 PM, Cho KyongHo pullip@samsung.com wrote:
This removes System MMU initialization from arch/arm/mach-exynos/
to move them to DT and the exynos-iommu driver except gating clock
definitions.
exynos with iommu support no longer compiles with this patch:
CC
On Thu, Sep 5, 2013 at 11:37 PM, Rahul Sharma r.sh.o...@gmail.com wrote:
On 5 September 2013 19:20, Inki Dae inki@samsung.com wrote:
-Original Message-
From: Sean Paul [mailto:seanp...@chromium.org]
Sent: Thursday, September 05, 2013 10:20 PM
To: Inki Dae
Cc: Rahul Sharma
On Thu, Sep 5, 2013 at 2:19 AM, Inki Dae inki@samsung.com wrote:
-Original Message-
From: linux-samsung-soc-ow...@vger.kernel.org [mailto:linux-samsung-soc-
ow...@vger.kernel.org] On Behalf Of Rahul Sharma
Sent: Thursday, September 05, 2013 3:04 PM
To: Inki Dae
Cc: Sean Paul
On Wed, Sep 4, 2013 at 3:37 AM, Inki Dae inki@samsung.com wrote:
-Original Message-
From: Rahul Sharma [mailto:r.sh.o...@gmail.com]
Sent: Wednesday, September 04, 2013 2:48 PM
To: Sean Paul
Cc: Rahul Sharma; linux-samsung-soc; dri-devel; kgene.kim; sw0312.kim;
InKi Dae; Lucas
On Wed, Sep 4, 2013 at 1:47 AM, Rahul Sharma r.sh.o...@gmail.com wrote:
Thanks Sean,
On 3 September 2013 20:15, Sean Paul seanp...@chromium.org wrote:
A few comments.
On Fri, Aug 30, 2013 at 2:59 AM, Rahul Sharma rahul.sha...@samsung.com
wrote:
Exynos hdmiphy operations and configs
On Fri, Aug 30, 2013 at 2:59 AM, Rahul Sharma rahul.sha...@samsung.com wrote:
hdmiphy is a dummy clock which actually controls the PMU bit
to enable/disbale hdmiphy (before CCF). This clock is cleaned
s/disbale/disable/
from the hdmi driver.
Signed-off-by: Rahul Sharma
On Fri, Aug 30, 2013 at 2:59 AM, Rahul Sharma rahul.sha...@samsung.com wrote:
Before hdmiphy operation like config, start etc, hdmiphy
bit in PMU block should be enabled. Earlier this happens
in hdmi drvier through a dummy hdmiphy clock.
s/drvier/driver/
Signed-off-by: Rahul Sharma
On Fri, Aug 30, 2013 at 2:59 AM, Rahul Sharma rahul.sha...@samsung.com wrote:
Exynos5420 hdmiphy device is a platform device, unlike
predecessor SoCs where it used to be a I2C device. This
support is added to the hdmiphy driver.
Stuffing a platform driver in the same place as your i2c driver
On Fri, May 3, 2013 at 2:04 AM, Rahul Sharma r.sh.o...@gmail.com wrote:
On Mon, Apr 29, 2013 at 10:06 PM, Sean Paul seanp...@google.com wrote:
On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma rahul.sha...@samsung.com
wrote:
Exynos hdmi sub-system consists of mixer, hdmi ip, hdmi-phy and hdmi
On Fri, May 3, 2013 at 4:25 AM, Rahul Sharma r.sh.o...@gmail.com wrote:
Hi Sean,
On Mon, Apr 29, 2013 at 10:28 PM, Sean Paul seanp...@chromium.org wrote:
On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma rahul.sha...@samsung.com
wrote:
hdmiphy hardware block is a physically separate device
On Mon, Apr 29, 2013 at 7:14 AM, Rahul Sharma rahul.sha...@samsung.com wrote:
Exynos hdmi driver is using drm_display_mode for setting timing values
for a supported resolution. Conversion to fb_videomode and then comparing
with the mixer/hdmi/phy limits is not required. Instead,
On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma rahul.sha...@samsung.com wrote:
Exynos hdmi sub-system consists of mixer, hdmi ip, hdmi-phy and hdmi-ddc
components. Currently, drivers for these components are getting registered
in exynos_drm_drv.c, which is meant for registration of drm
On Mon, Apr 29, 2013 at 10:50 AM, Rahul Sharma rahul.sha...@samsung.com wrote:
Hdmiphy clock flows from hdmiphy hw to hdmi ip and mixer. It is commonly
accessed among hdmi and hdmiphy driver. During power cycle, each of these
driver decrements the ref-count and ensures that last user disables
On Tue, Feb 26, 2013 at 7:16 AM, Rahul Sharma rahul.sha...@samsung.com wrote:
Exynos hdmi driver is using drm_display_mode for setting timing values
for a supported resolution. Conversion to fb_videomode and then comparing
with the mixer/hdmi/phy limits is not required. Instead,
the arch-
specific bits for exynos5.
Changes in v3:
- Use compatible field in device tree instead of hdmi-version field
- Change hdmi driver's naming to use IP version instead of hdmi version
Sean Paul (2):
drm/exynos: Get HDMI version from device tree
ARM: Change exynos5-hdmi references
Use the compatible string in the device tree to determine which
registers/functions to use in the HDMI driver. Also changes the
references from v13 to 4210 and v14 to 4212 to reflect the IP
block version instead of the HDMI version.
Signed-off-by: Sean Paul seanp...@chromium.org
With the change drm/exynos: Get HDMI version from device tree,
exynos5-hdmi is no longer relevant. Update references to exynos4-hdmi
and update the hdmi compatibility string to accurately reflect the hdmi
driver.
Signed-off-by: Sean Paul seanp...@chromium.org
---
arch/arm/boot/dts/exynos5250
On Tue, Feb 5, 2013 at 4:22 PM, Stephen Warren swar...@wwwdotorg.org wrote:
n 02/05/2013 04:42 PM, Sean Paul wrote:
Use the compatible string in the device tree to determine which
registers/functions to use in the HDMI driver. Also changes the
references from v13 to 4210 and v14 to 4212
On Tue, Feb 5, 2013 at 4:42 PM, Stephen Warren swar...@wwwdotorg.org wrote:
On 02/05/2013 05:37 PM, Sean Paul wrote:
On Tue, Feb 5, 2013 at 4:22 PM, Stephen Warren swar...@wwwdotorg.org wrote:
n 02/05/2013 04:42 PM, Sean Paul wrote:
Use the compatible string in the device tree to determine
On Mon, Jan 7, 2013 at 4:00 PM, Sean Paul seanp...@chromium.org wrote:
Set the HDMI version to v1.4 for all exynos5250 targets. This property
was previously being inferred by the existence of the hdmi node.
Signed-off-by: Sean Paul seanp...@chromium.org
---
The patch adding the property has
Set the HDMI version to v1.4 for all exynos5250 targets. This property
was previously being inferred by the existence of the hdmi node.
Signed-off-by: Sean Paul seanp...@chromium.org
---
arch/arm/boot/dts/exynos5250.dtsi |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git
61 matches
Mail list logo
