Re: [PATCH 3/3] [media] s5p-mfc: Use of_match_ptr and CONFIG_OF

2013-01-06 Thread Sylwester Nawrocki
Hi Sachin, On 12/28/2012 11:18 AM, Sachin Kamat wrote: This builds the code only if DT is enabled. Since the driver this patch touches is for platforms that in (not distant) future will be DT only I don't really see an advantage of applying it, only to need to revert it after few kernel

[PATCH] ARM: Samsung: Export MIPI CSIS/DSIM PHY control functions

2013-01-03 Thread Sylwester Nawrocki
The s5p_csis_phy_enable/s5p_dsim_phy_enable functions are now used directly by corresponding drivers and thus need to be exported so the drivers can be built as modules. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm

Re: [PATCH v6 05/12] iommu/exynos: support for device tree

2013-01-03 Thread Sylwester Nawrocki
On 01/02/2013 06:53 AM, KyongHo Cho wrote: +/* + * Descriptions of Device Tree node for System MMU + * + * A System MMU should be described by a single tree node. + * + * A System MMU node should have the following properties: + * - reg: tuples of the base address and the size of the IO

Re: [PATCH v6 00/12] iommu/exynos: Fixes and Enhancements of System MMU driver with DT

2013-01-03 Thread Sylwester Nawrocki
Hi, Cc: devicetree-discuss devicetree-disc...@lists.ozlabs.org On 12/26/2012 02:53 AM, Cho KyongHo wrote: notice: v6 patch-set is rebased on next/iommu-exynos branch of linux-samsung.git. This patch-set does not include 2 patches (05 and 06 patches in v5 patch-se) because they alread exist

Re: [PATCH RFC v2 01/15] [media] Add common video interfaces OF bindings documentation

2013-01-02 Thread Sylwester Nawrocki
Hi Guennadi, On 01/02/2013 12:31 PM, Guennadi Liakhovetski wrote: Hi Sylwester Thanks for picking up these patches! In general both look good to me, just a couple of nit-picks, that I couldn't help remarking:-) Sure, thanks again for the feedback. On Mon, 31 Dec 2012, Sylwester Nawrocki

Re: [PATCH RFC v2 02/15] [media] Add a V4L2 OF parser

2013-01-02 Thread Sylwester Nawrocki
Hi Guennadi, On 01/02/2013 12:58 PM, Guennadi Liakhovetski wrote: --- /dev/null +++ b/drivers/media/v4l2-core/v4l2-of.c @@ -0,0 +1,249 @@ +/* + * V4L2 OF binding parsing library + * + * Copyright (C) 2012 Renesas Electronics Corp. + * Author: Guennadi Liakhovetskig.liakhovet...@gmx.de + * + *

[PATCH RFC v2 00/15] V4L2 device tree bindings and OF helpers

2012-12-31 Thread Sylwester Nawrocki
documentation [media] Add a V4L2 OF parser Sylwester Nawrocki (13): s5p-csis: Add device tree support s5p-fimc: Support for FIMC devices instantiated from the device tree s5p-fimc: Support for FIMC-LITE devices instantiated from the device tree s5p-fimc: Change platform subdevs registration

[PATCH RFC v2 01/15] [media] Add common video interfaces OF bindings documentation

2012-12-31 Thread Sylwester Nawrocki
documents a method of describing data links between devices. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Reviewed-by: Stephen Warren swar...@nvidia.com --- This is basically a resend of my previous version of this patch [1

[PATCH RFC v2 02/15] [media] Add a V4L2 OF parser

2012-12-31 Thread Sylwester Nawrocki
From: Guennadi Liakhovetski g.liakhovet...@gmx.de Add a V4L2 OF parser, implementing bindings, documented in Documentation/devicetree/bindings/media/video-interfaces.txt. Signed-off-by: Guennadi Liakhovetski g.liakhovet...@gmx.de Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com

[PATCH RFC v2 03/15] s5p-csis: Add device tree support

2012-12-31 Thread Sylwester Nawrocki
s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC device. This patch support for binding the driver to the MIPI-CSIS devices instantiated from device tree and for parsing all SoC and board specific properties. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off

[PATCH RFC v2 04/15] s5p-fimc: Support for FIMC devices instantiated from the device tree

2012-12-31 Thread Sylwester Nawrocki
FIMC IP with other ones, like MIPI-CSIS (MIPI CSI2 bus frontend) or FIMC-LITE and FIMC-IS ISP. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/media/soc/samsung-fimc.txt | 92 drivers

[PATCH RFC v2 05/15] s5p-fimc: Support for FIMC-LITE devices instantiated from the device tree

2012-12-31 Thread Sylwester Nawrocki
This patch add support for binding the driver to FIMC-LITE devices instantiated from the device tree. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/media/soc/samsung-fimc.txt | 16 + drivers/media

[PATCH RFC v2 06/15] s5p-fimc: Change platform subdevs registration method

2012-12-31 Thread Sylwester Nawrocki
a device first and then check for its driver while holding device lock. The platform sub-devices are looked up and registered to the top level driver. When any sub-device is not yet initialized and ready the main driver's probe() will be deferred. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com

[PATCH RFC v2 07/15] s5p-fimc: Support camera media device initialization on DT systems

2012-12-31 Thread Sylwester Nawrocki
probing is deferred if any of the sub-device drivers is not yet initialized and ready. An OF matching table is added for the main driver associated with the 'camera' node. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers

[PATCH RFC v2 08/15] s5p-fimc: Add device tree based sensors registration

2012-12-31 Thread Sylwester Nawrocki
for device tree based platforms in the driver, while asynchronous subdev probing and related issues are being discussed on LMML. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/media/soc/samsung-fimc.txt

[PATCH RFC v2 10/15] ARM: EXYNOS4: Add OF_DEV_AUXDATA for FIMC, FIMC-LITE and CSIS

2012-12-31 Thread Sylwester Nawrocki
Add these temporary OF_DEV_AUXDATA entries so we can use clocks before common clock framework support for Exynos4 is available. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/mach-exynos4-dt.c | 16

[PATCH RFC v2 12/15] ARM: dts: Add ISP power domain node for Exynos4x12

2012-12-31 Thread Sylwester Nawrocki
The ISP power domain is a common power domain for fimc-lite and fimc-is (ISP) devices. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4x12.dtsi |5 + 1 file changed, 5 insertions(+) diff --git

[PATCH RFC v2 13/15] ARM: dts: Add FIMC and MIPI CSIS device nodes for Exynos4x12

2012-12-31 Thread Sylwester Nawrocki
Add common camera node and fimc nodes specific to Exynos4212 and Exynos4412 SoCs. fimc-is is a node for the Exynos4x12 FIMC-IS subsystem and fimc-lite nodes are created as its child nodes, among others due to FIMC-LITE device dependencies on FIMC-IS related clocks. Signed-off-by: Sylwester

[PATCH RFC v2 14/15] ARM: dts: Add camera pinctrl nodes for Exynos4x12 SoCs

2012-12-31 Thread Sylwester Nawrocki
Add separate nodes for the CAMCLK pin and turn off pull-up on camera port A. Default driver strength for CAMCLK pin is increased to maximum. The driver strength change can be moved to board specific part if it is considered more appropriate. Signed-off-by: Sylwester Nawrocki s.nawro

[PATCH RFC v2 15/15] ARM: dts: Add camera device nodes nodes for PQ board

2012-12-31 Thread Sylwester Nawrocki
assigned to it. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4412-slp_pq.dts | 133 +++ 1 file changed, 133 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-slp_pq.dts b

Re: [PATCH v6 05/12] iommu/exynos: support for device tree

2012-12-31 Thread Sylwester Nawrocki
On 12/26/2012 02:53 AM, Cho KyongHo wrote: This commit adds device tree support for System MMU. Signed-off-by: KyongHo Chopullip@samsung.com Cc: devicetree-disc...@lists.ozlabs.org Please note any patches adding new device tree bindings should be sent to this mailing list. I have few

Re: [PATCH 0/2] usb: exynos: Fix compatible strings used for device

2012-12-26 Thread Sylwester Nawrocki
On 12/24/2012 09:13 AM, Vivek Gautam wrote: These two changes look good to me. For both of them: Reviewed-by: Doug Andersondiand...@chromium.org Well, I have another idea. Yes, I know, specific chip name should be used. But you know the specific chip name in compatible can cause another

Re: [PATCH v4] usb: phy: samsung: Add support to set pmu isolation

2012-12-26 Thread Sylwester Nawrocki
Hi, On 12/26/2012 02:56 PM, Vivek Gautam wrote: On Wed, Dec 26, 2012 at 5:58 PM, Vivek Gautamgautam.vi...@samsung.com wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautamgautam.vi...@samsung.com ---

Re: [PATCH v2] usb: phy: samsung: Add support to set pmu isolation

2012-12-19 Thread Sylwester Nawrocki
Hi, On 12/19/2012 02:44 PM, Vivek Gautam wrote: --- a/Documentation/devicetree/bindings/usb/samsung-usbphy.txt +++ b/Documentation/devicetree/bindings/usb/samsung-usbphy.txt @@ -9,3 +9,15 @@ Required properties: - compatible : should be samsung,exynos4210-usbphy - reg : base physical

Re: [PATCH v2] usb: phy: samsung: Add support to set pmu isolation

2012-12-18 Thread Sylwester Nawrocki
Hi Vivek, On 12/18/2012 02:56 PM, Vivek Gautam wrote: Adding support to parse device node data in order to get required properties to set pmu isolation for usb-phy. Signed-off-by: Vivek Gautamgautam.vi...@samsung.com --- Changes from v1: - Changed the name of property for phy handler

Re: [PATCH 2/2] ARM: Exynos5250: Enabling USB 3.0 phy for samsung-usbphy driver

2012-12-18 Thread Sylwester Nawrocki
On 12/18/2012 04:39 PM, Vivek Gautam wrote: Adding base address information required for enabling USB 3.0 DRD phy on exynos5250 SOC. Signed-off-by: Vivek Gautamgautam.vi...@samsung.com --- arch/arm/boot/dts/exynos5250.dtsi |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff

Re: [PATCH RFC 01/12] s5p-csis: Add device tree support

2012-12-11 Thread Sylwester Nawrocki
Hello Grant, On 12/11/2012 09:36 AM, Grant Likely wrote: On Mon, 10 Dec 2012 20:45:55 +0100, Sylwester Nawrocki s.nawro...@samsung.com wrote: s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC (camera host interface DMA engine and image processor). This patch adds support

[PATCH RFC 00/12] Device tree support for Exynos4 SoC camera drivers

2012-12-10 Thread Sylwester Nawrocki
-rc8-pq-camera-dt Sylwester Nawrocki (12): s5p-csis: Add device tree support s5p-fimc: Add device tree support for FIMC devices s5p-fimc: Add device tree support for FIMC-LITE s5p-fimc: Instantiate media device from device tree s5p-fimc: Add device tree based sensors registration s5p-fimc

[PATCH RFC 01/12] s5p-csis: Add device tree support

2012-12-10 Thread Sylwester Nawrocki
s5p-csis is platform device driver for MIPI-CSI frontend to the FIMC (camera host interface DMA engine and image processor). This patch adds support for instantiating the MIPI-CSIS devices from DT and parsing all SoC and board specific properties from device tree. Signed-off-by: Sylwester

[PATCH RFC 02/12] s5p-fimc: Add device tree support for FIMC devices

2012-12-10 Thread Sylwester Nawrocki
is essential for linking FIMC IP with other ones, like MIPI-CSIS (MIPI CSI2 bus frontend) or FIMC-LITE and FIMC-IS ISP. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/media/soc/samsung-fimc.txt | 92

[PATCH RFC 04/12] s5p-fimc: Instantiate media device from device tree

2012-12-10 Thread Sylwester Nawrocki
mutex. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 261 +++- drivers/media/platform/s5p-fimc/fimc-mdevice.h |4 + 2 files changed, 167 insertions(+), 98

[PATCH RFC 05/12] s5p-fimc: Add device tree based sensors registration

2012-12-10 Thread Sylwester Nawrocki
for device tree based platforms in the driver, while asynchronous subdev probing and related issues are being discussed on LMML. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings/media/soc/samsung-fimc.txt | 75

[PATCH RFC 08/12] ARM: dts: Add camera node exynos4.dtsi

2012-12-10 Thread Sylwester Nawrocki
This adds common FIMC device nodes for all Exynos4 SoCs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4.dtsi | 64 1 file changed, 64 insertions(+) diff

[PATCH RFC 06/12] s5p-fimc: Use pinctrl API for camera ports configuration

2012-12-10 Thread Sylwester Nawrocki
pinctrl state is intended for setting clock output pin(s) into high impedance state when camera sensors are powered off. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyugmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-fimc/fimc-mdevice.c | 35

[PATCH RFC 10/12] ARM: dts: Add FIMC and MIPI CSIS device nodes for Exynos4x12

2012-12-10 Thread Sylwester Nawrocki
Add common camera node and fimc nodes specific to Exynos4212 and Exynos4412 SoCs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4x12.dtsi | 36 1 file changed, 36

[PATCH RFC 11/12] ARM: dts: Add camera pinctrl nodes for Exynos4x12 SoCs

2012-12-10 Thread Sylwester Nawrocki
Add separate nodes for the CAMCLK pin and turn off pull-up on camera port A. Default driver strength for CAMCLK pin is increased to maximum. The driver strength change can be moved to board specific part if it is considered more appropriate. Signed-off-by: Sylwester Nawrocki s.nawro

[PATCH RFC 12/12] ARM: dts: Add camera device nodes nodes for PQ board

2012-12-10 Thread Sylwester Nawrocki
assigned to it. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/boot/dts/exynos4412-slp_pq.dts | 130 +++ 1 file changed, 130 insertions(+) diff --git a/arch/arm/boot/dts/exynos4412-slp_pq.dts b

[PATCH RFC 07/12] ARM: EXYNOS4: Add OF_DEV_AUXDATA for FIMC, FIMC-LITE and CSIS

2012-12-10 Thread Sylwester Nawrocki
Add these temporary OF_DEV_AUXDATA entries so we can use clocks before common clock framework support for Exynos4 is available. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/mach-exynos4-dt.c | 16

[PATCH RFC 03/12] s5p-fimc: Add device tree support for FIMC-LITE

2012-12-10 Thread Sylwester Nawrocki
This patch add support for instantiation FIMC-LITE platform devices from device tree. Device tree aliases are used to specify the IP hardware instance. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- .../devicetree/bindings

[PATCH] ARM: SAMSUNG: Add s3c24xx/s3c64xx CAMIF GPIO setup helpers

2012-11-19 Thread Sylwester Nawrocki
This patch adds default helper functions for the camera port pin configuration. Whenever pinctrl support for s3c24xx/s3c64xx SoCs is available these code should be removed and proper pinctrl API should be used in the CAMIF driver. Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-17 Thread Sylwester Nawrocki
Hi, On 11/17/2012 01:07 PM, Andrey Gusakov wrote: Hi. Just have time to test. I apologize for delay. No problem, thanks for the feedback. I'd like to squash all the s3c-camif patches before sending upstream, if you don't mind. And to add your Signed-off at the final patch. Ok. Squash. I

Re: [oselas] Mini2440 boot failure on kernel 3.7-rc1

2012-11-13 Thread Sylwester Nawrocki
Hi Brian, On 11/13/2012 08:54 AM, Brian Norris wrote: On Mon, Nov 12, 2012 at 3:18 PM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: On 10/22/2012 09:28 AM, Juergen Beisert wrote: Sylwester Nawrocki wrote: [...] [2.455000] NAND device: Manufacturer ID: 0xec, Chip ID: 0xf1

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-13 Thread Sylwester Nawrocki
Hi Andrey, On 11/11/2012 02:26 PM, Andrey Gusakov wrote: Hi. Patch v2 attached. Comments taken into account. Thanks, I had to rework the S3C-CAMIF subdev controls handling to avoid races when the control's value is modified in the control framwework and accessed from interrupt context in the

Re: [oselas] Mini2440 boot failure on kernel 3.7-rc1

2012-11-12 Thread Sylwester Nawrocki
Hi Juergen, Brian, On 10/22/2012 09:28 AM, Juergen Beisert wrote: Hi Sylwester, Sylwester Nawrocki wrote: [...] [2.455000] NAND device: Manufacturer ID: 0xec, Chip ID: 0xf1 (Samsung NAND 128MiB 3,3V 8-bit), 8 [2.46] 4 cmdlinepart partitions found on MTD device nand [2.465000

Re: [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of camera clock

2012-11-10 Thread Sylwester Nawrocki
On 11/10/2012 03:07 PM, dron0...@gmail.com wrote: From: Andrey Gusakovdron_...@mail.ru The camera clock have only one parent. Define it staticly and remove unused source clock list. Signed-off-by: Andrey Gusakovdron0...@gmail.com Reviewed-by: Sylwester Nawrocki sylvester.nawro...@gmail.com

Re: [PATCH 1/2] ARM: S3C64XX: Remove duplicated camera clock

2012-11-10 Thread Sylwester Nawrocki
...@gmail.com Reviewed-by: Sylwester Nawrocki sylvester.nawro...@gmail.com -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/2] ARM: S3C64XX: Staticly define parent clock of camera clock

2012-11-10 Thread Sylwester Nawrocki
On 11/10/2012 10:13 PM, Sylwester Nawrocki wrote: On 11/10/2012 03:07 PM, dron0...@gmail.com wrote: From: Andrey Gusakovdron_...@mail.ru The camera clock have only one parent. Define it staticly and Forgot to point out a small typo here: staticly - statically. remove unused source clock

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-09 Thread Sylwester Nawrocki
Hi, On 11/08/2012 07:47 PM, Andrey Gusakov wrote: Ok, thanks. I will add the missing CONFIG_PM_RUNTIME dependency in Kconfig. The driver has to have PM_RUNTIME enabled since on s3c64xx SoCs there are power domains and the camera power domain needs to be enabled for the CAMIF operation. The

Re: [PATCH 2/2] ARM: S3C64XX: Statically define parent clock of the camera clock

2012-11-09 Thread Sylwester Nawrocki
On 11/09/2012 08:42 AM, Andrey Gusakov wrote: Hi. I think .reg_src can be removed? This clock have only one source. Yes, good point. I'll repost with reg_src removed. Can you test that patch then ? Thanks, Sylwester On Thu, Nov 8, 2012 at 2:00 AM, Sylwester Nawrocki sylvester.nawro

[PATCH] ARM: S3C64XX: Statically define parent clock of the camera clock

2012-11-09 Thread Sylwester Nawrocki
leaving the parent clock not configured. Define statically the parent clock so it is possible to get or set rate of the camera clock. While at it remove the unneded null reg_src definition. Reported-by: In-Bae Jeong kukya...@gmail.com Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com

Re: [PATCH] ARM: S3C64XX: Statically define parent clock of the camera clock

2012-11-09 Thread Sylwester Nawrocki
Hi, On 11/09/2012 10:31 AM, Andrey Gusakov wrote: On Fri, Nov 9, 2012 at 12:32 PM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: The camera clock defined in arch/arm/mach-s3c64xx/clock.c has null clock source mux control register as it can have only one parent clock. In such cases

Re: [PATCH] ARM: S3C64XX: Statically define parent clock of the camera clock

2012-11-09 Thread Sylwester Nawrocki
On 11/09/2012 11:05 AM, Sylwester Nawrocki wrote: Hi, On 11/09/2012 10:31 AM, Andrey Gusakov wrote: On Fri, Nov 9, 2012 at 12:32 PM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: The camera clock defined in arch/arm/mach-s3c64xx/clock.c has null clock source mux control register

Re: [PATCH] ARM: EXYNOS: Make s3c_device_i2c0 always use id 0

2012-11-07 Thread Sylwester Nawrocki
the only i2c controller used, tested on Origen. Signed-off-by: Tomasz Figat.f...@samsung.com Signed-off-by: Kyungmin Parkkyungmin.p...@samsung.com Reviewed-by: Sylwester Nawrocki s.nawro...@samsung.com -- Thanks, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-07 Thread Sylwester Nawrocki
On 11/07/2012 02:35 PM, Vivek Gautam wrote: @@ -180,10 +273,12 @@ enum samsung_cpu_type { /* * struct samsung_usbphy - transceiver driver state * @phy: transceiver structure + * @phy3: transceiver structure for USB 3.0 * @plat: platform data * @dev: The parent device supplied

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-07 Thread Sylwester Nawrocki
On 11/06/2012 10:34 PM, Andrey Gusakov wrote: Hi. Does the sensor still hang after 0x2f is written to REG_GRCOM instead ? Work! I'm looking at drivers/media/usb/gspca/m5602/m5602_ov9650.h It use significantly different init sequence. Some of settings described in Application note for ov9650,

[PATCH 1/2] ARM: S3C24XX: Add clkdev entry for camif-upll clock

2012-11-07 Thread Sylwester Nawrocki
The s3c-camif driver uses camera clock conn_id for the camif-upll (s3c244x) and camera (s3c64xx) platform clock. By adding this new clkdev entry the platform differences are isolated from the driver. Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com --- arch/arm/mach-s3c24xx/clock

[PATCH 2/2] ARM: S3C64XX: Statically define parent clock of the camera clock

2012-11-07 Thread Sylwester Nawrocki
leaving the parent clock not configured. Define statically the parent clock so it is possible to get or set rate of the camera clock. Reported-by: In-Bae Jeong kukya...@gmail.com Signed-off-by: Sylwester Nawrocki sylvester.nawro...@gmail.com --- arch/arm/mach-s3c64xx/clock.c |1 + 1 files

Re: [PATCH 1/2] USB: PHY: Add support for USB 3.0 phy for exynos5250

2012-11-06 Thread Sylwester Nawrocki
Hi, I have a few comments. Please see below... On 11/06/2012 04:36 PM, Vivek Gautam wrote: Adding support for USB3.0 phy for dwc3 controller on exynso5250 SOC. exynso - exynos Signed-off-by: Vivek Gautamgautam.vi...@samsung.com --- drivers/usb/phy/samsung-usbphy.c| 337

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-05 Thread Sylwester Nawrocki
Hi, On 11/05/2012 10:44 AM, Andrey Gusakov wrote: But documentation on ov9650 is too conflicting and did not cover all registers used in driver. Do you mean the OV9650 datasheet, version 1.3, from September 24, 2004 ? Yes. Also I have datasheet version 1.91 from January 28, 2005 and

Re: S3C244X/S3C64XX SoC camera host interface driver questions

2012-11-05 Thread Sylwester Nawrocki
Hi Andrey, On 11/05/2012 12:11 PM, Andrey Gusakov wrote: Hi. Thanks all! I make it work! Have to comment out write { REG_GRCOM, 0x3f }, /* Great news! Does the sensor still hang after 0x2f is written to REG_GRCOM instead ? Analog BLC regulator */ and have to enable gate clock for fimc

Re: [PATCH 3/5] ARM: Exynos: add device tree support for MCT controller driver

2012-11-03 Thread Sylwester Nawrocki
Hi Thomas, On 11/03/2012 03:45 PM, Thomas Abraham wrote: Allow the MCT controller base address and interrupts to be obtained from device tree and remove unused static definitions of these. The non-dt support for Exynos5250 is removed but retained for Exynos4210 based platforms. Cc: Changhwan

Re: [PATCH v2 1/5] clk: samsung: add common clock framework support for Samsung platforms

2012-10-30 Thread Sylwester Nawrocki
Hi Thomas, On 10/29/2012 11:09 AM, Thomas Abraham wrote: Hi Sylwester, Thanks for your comments. As usual, your comments are very helpful. Thanks. On 22 October 2012 21:25, Sylwester Nawrockis.nawro...@samsung.com wrote: Hi Thomas, On 10/07/2012 07:10 PM, Thomas Abraham wrote: All

Re: [PATCH v2 1/5] clk: samsung: add common clock framework support for Samsung platforms

2012-10-22 Thread Sylwester Nawrocki
Hi Thomas, On 10/07/2012 07:10 PM, Thomas Abraham wrote: All Samsung platforms include several types of clocks including fixed-rate, mux, divider and gate clock types. There are typically hundreds of such clocks on each of the Samsung platforms. To enable Samsung platforms to register these

Re: [PATCH 1/8] [media] s5p-fimc: Use clk_prepare_enable and clk_disable_unprepare

2012-10-17 Thread Sylwester Nawrocki
Hi Sachin, On 10/17/2012 01:11 PM, Sachin Kamat wrote: Replace clk_enable/clk_disable with clk_prepare_enable/clk_disable_unprepare as required by the common clock framework. I think this statement is misleading. In my understanding it is not the common clock framework requirement to use

Re: [PATCH 1/8] [media] s5p-fimc: Use clk_prepare_enable and clk_disable_unprepare

2012-10-17 Thread Sylwester Nawrocki
On 10/17/2012 05:35 PM, Sachin Kamat wrote: Most of the s5p-* drivers have already added support for clk_(un)prepare. Thus most of your changes in this patch are not needed. I seem to have only missed fimc-mdevice.c, other modules are already reworked I did not find these changes in your

Re: [PATCH V5 1/2] video: exynos_dp: Add device tree support to DP driver

2012-10-16 Thread Sylwester Nawrocki
On 10/16/2012 04:02 AM, Jingoo Han wrote: On Tuesday, October 16, 2012 6:14 AM Sylwester Nawrocki wrote On 10/15/2012 10:14 AM, Jingoo Han wrote: On Saturday, October 13, 2012 6:44 AM Sylwester Nawrocki wrote On 10/12/2012 10:47 PM, Ajay Kumar wrote: This patch enables device tree based

Re: [PATCH] [media] s5p-csis: Added RAW data format as the supported format.

2012-10-15 Thread Sylwester Nawrocki
Hi Ritesh, On 10/15/2012 11:48 AM, Ritesh Kumar Solanki wrote: csis can support jpeg, yuv and raw data format. Signed-off-by: Ritesh Kumar Solanki r.sola...@samsung.com Thanks for the patch. I already have a patch adding all three raw Bayer formats (SGRBG8/10/12) at the driver and I plan it

Re: [PATCH] ARM: SAMSUNG: Add naming of s3c64xx-spi devices

2012-10-15 Thread Sylwester Nawrocki
Nawrocki s.nawro...@samsung.com Tested-by: Sylwester Nawrocki s.nawro...@samsung.com (mach-exynos only) José Miguel, can you confirm it solves the problem for you ? -- Regards, Sylwester -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH V5 1/2] video: exynos_dp: Add device tree support to DP driver

2012-10-15 Thread Sylwester Nawrocki
On 10/15/2012 10:14 AM, Jingoo Han wrote: On Saturday, October 13, 2012 6:44 AM Sylwester Nawrocki wrote On 10/12/2012 10:47 PM, Ajay Kumar wrote: This patch enables device tree based discovery support for DP driver. The driver is modified to handle platform data in both the cases: with DT

Re: [PATCH V5 1/2] video: exynos_dp: Add device tree support to DP driver

2012-10-12 Thread Sylwester Nawrocki
On 10/12/2012 10:47 PM, Ajay Kumar wrote: This patch enables device tree based discovery support for DP driver. The driver is modified to handle platform data in both the cases: with DT and non-DT. Signed-off-by: Ajay Kumarajaykumar...@samsung.com Acked-by: Jingoo Hanjg1@samsung.com

Re: [PATCH V5 1/2] video: exynos_dp: Add device tree support to DP driver

2012-10-12 Thread Sylwester Nawrocki
On 10/12/2012 11:54 PM, Tomasz Figa wrote: + if (of_get_property(dp_node, interlaced, NULL)) + dp_video_config-interlaced = 1; of_property_read_bool() could also be used here. Wouldn't it make the property mandatory? No, it wouldn't. of_property_read_bool() uses

Re: [PATCH V4 2/2] video: exynos_dp: device tree documentation

2012-10-11 Thread Sylwester Nawrocki
On 10/11/2012 08:50 AM, Ajay kumar wrote: + -samsung,interlaced: + Interlace scan mode. + Progressive if defined, Interlaced if not defined + -samsung,v_sync_polarity: + VSYNC polarity configuration. + High if defined,

[RFC] Samsung SoC camera DT bindings

2012-10-10 Thread Sylwester Nawrocki
Hi All, The following is a brief description of Samsung SoC architecture from the camera point of view and a corresponding device tree structure. It is based on the media devices DT bindings design from Guennadi [1]. I incorporated some changes proposed during reviews (e.g. s/link/endpoint).

Re: [PATCH V4 2/2] video: exynos_dp: device tree documentation

2012-10-09 Thread Sylwester Nawrocki
Hi Ajay, On 10/10/2012 01:08 AM, Ajay Kumar wrote: Add documentation for the DT bindings in exynos display port driver. Signed-off-by: Ajay Kumarajaykumar...@samsung.com --- .../devicetree/bindings/video/exynos_dp.txt| 83 1 files changed, 83

Re: [PATCH 2/2] ARM: Exynos4: Register clocks via common clock framework

2012-10-05 Thread Sylwester Nawrocki
Hello, On 10/01/2012 02:09 PM, chander.kash...@linaro.org wrote: From: Thomas Abrahamthomas.abra...@linaro.org Register clocks for Exynos4 platfotms using common clock framework. Also included are set of helper functions for clock registration that can be reused on other Samsung platforms

Re: Problem using S3C2416's HSSPI

2012-10-02 Thread Sylwester Nawrocki
. Perhaps these patches should be also sent now to sta...@vger.kernel.org. Regards, Sylwester -- Sylwester Nawrocki Samsung Poland RD Center -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: Problem using S3C2416's HSSPI

2012-10-01 Thread Sylwester Nawrocki
Hi, On 10/01/2012 09:18 PM, Heiko Stübner wrote: Hi José, Am Montag, 1. Oktober 2012, 19:32:15 schrieb José Miguel Gonçalves: I'm trying to use the HSSPI controller on a S3C2416 based board but I'm having some problems. I've added s3c64xx_device_spi0 to my array of platform devices and

Re: [PATCH V3] video: exynos_dp: Add device tree support to DP driver

2012-09-27 Thread Sylwester Nawrocki
Hi, Cc: devicetree-disc...@lists.ozlabs.org On 09/24/2012 09:36 PM, Ajay Kumar wrote: This patch enables device tree based discovery support for DP driver. The driver is modified to handle platform data in both the cases: with DT and non-DT. Documentation is also added for the DT bindings.

[PATCH RFC] s5p-tv: Report only multi-plane capabilities in vidioc_querycap

2012-09-24 Thread Sylwester Nawrocki
V4L2_BUF_TYPE_CAPTURE_MPLANE. Cc: Tomasz Stanislawski t.stanisl...@samsung.com Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/platform/s5p-tv/mixer_video.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH 1/2] m5mols: Remove unneeded control ops assignments

2012-09-21 Thread Sylwester Nawrocki
Since all host drivers using this subdev are already using the control framework these compatibility ops can be removed. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/m5mols/m5mols_core.c | 7 --- 1

[PATCH 2/2] m5mols: Protect driver data with a mutex

2012-09-21 Thread Sylwester Nawrocki
Without the locking the driver's data could get corrupted when the subdev is accessed from user space and from host driver by multiple processes. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/m5mols

[PATCH 0/7] s5p-fimc/mipi-csis drivers cleanup

2012-09-17 Thread Sylwester Nawrocki
Sylwester Nawrocki (7): ARM: samsung: Remove unused fields from FIMC and CSIS platform data ARM: samsung: Change __s5p_mipi_phy_control() function signature ARM: EXYNOS: Change MIPI-CSIS device regulator supply names s5p-csis: Replace phy_enable platform data callback with direct call s5p-fimc

[PATCH 1/7] ARM: samsung: Remove unused fields from FIMC and CSIS platform data

2012-09-17 Thread Sylwester Nawrocki
The MIPI-CSI2 bus data alignment is now being derived from the media bus pixel code, the drivers don't use the corresponding structure fields, so remove them. Also remove the s5p_csis_phy_enable callback which is now used directly by s5p-csis driver. Signed-off-by: Sylwester Nawrocki s.nawro

[PATCH 2/7] ARM: samsung: Change __s5p_mipi_phy_control() function signature

2012-09-17 Thread Sylwester Nawrocki
Replace pdev argument __s5p_mipi_phy_control() helper with plain int so MIPI-CSIS hardware instance index can be passed directly making the function usable on platforms instantiated from device tree. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH 3/7] ARM: EXYNOS: Change MIPI-CSIS device regulator supply names

2012-09-17 Thread Sylwester Nawrocki
Rename MIPI-CSIS regulator supply names to match definitions in the driver after commit s5p-csis: Change regulator supply names. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/mach-exynos/mach-nuri.c | 4

[PATCH 4/7] s5p-csis: Replace phy_enable platform data callback with direct call

2012-09-17 Thread Sylwester Nawrocki
The phy_enable callback is common for all Samsung SoC platforms, replace it with direct function call so the MIPI-CSI2 DPHY control is also possible on device tree instantiated platforms. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p

[PATCH 5/7] s5p-fimc: Remove unused platform data structure fields

2012-09-17 Thread Sylwester Nawrocki
[media] s5p-csis: Handle all available power supplies. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- include/linux/platform_data/mipi-csis.h | 15 --- include/media/s5p_fimc.h| 2 -- 2 files changed, 4

[PATCH 6/7] s5p-csis: Allow to specify pixel clock's source through platform data

2012-09-17 Thread Sylwester Nawrocki
-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/mipi-csis.c | 4 +++- include/linux/platform_data/mipi-csis.h | 4 +++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/s5p-fimc

Re: [PATCH 1/7] ARM: samsung: Remove unused fields from FIMC and CSIS platform data

2012-09-17 Thread Sylwester Nawrocki
On 09/17/2012 01:02 PM, Kukjin Kim wrote: Sylwester Nawrocki wrote: The MIPI-CSI2 bus data alignment is now being derived from the media bus pixel code, the drivers don't use the corresponding structure fields, so remove them. Also remove the s5p_csis_phy_enable callback which is now used

[PATCH] ARM: SAMSUNG: Add missing variable declaration in s3c64xx_spi1_set_platdata()

2012-09-13 Thread Sylwester Nawrocki
Fixes regression introduced in commit 4d0efdd5889b1c81a62aa07a ARM: SAMSUNG: Modify s3c64xx_spi{0|1|2}_set_platdata function Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- arch/arm/plat-samsung/devs.c | 2 ++ 1 file changed, 2

[PATCH] spi: s3c64xx: Don't free controller_data on non-dt platforms

2012-09-13 Thread Sylwester Nawrocki
. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/spi/spi-s3c64xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/spi/spi-s3c64xx.c b/drivers/spi/spi-s3c64xx.c index d1c8441f..7f75d4e 100644

[PATCH] s5p-csis: Add transmission errors logging

2012-09-13 Thread Sylwester Nawrocki
Add hardware event/error counters which can be dumped into the kernel log through VIDIOC_LOG_STATUS ioctl. The counters are reset in each s_stream(1) call. Any errors are logged after streaming is turned off. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park

Re: [PATCH v2] ARM: EXYNOS: Add MFC device tree support

2012-09-12 Thread Sylwester Nawrocki
Just a few small comments... On 09/12/2012 03:34 PM, Arun Kumar K wrote: This patch adds device tree entry for MFC v6 in the Exynos5 SoC. Makes the required changes in the clock files and adds MFC to the DT device list. Signed-off-by: Naveen Krishna Chatradhich.nav...@samsung.com

Re: [PATCH] ARM: EXYNOS5: Add bus clock and set parent clock for FIMD

2012-09-11 Thread Sylwester Nawrocki
with platform clock name. It should be possible to freely define clock connection id and a platform clock association, not at the platform clock definition. I guess we can now clean all this up only during conversion to common clock framework. Regards, -- Sylwester Nawrocki Samsung Poland RD Center

Re: [PATCH 1/2] ARM: samsung: clock: add clock_tree debugfs file

2012-09-07 Thread Sylwester Nawrocki
Hi, On 09/07/2012 09:20 AM, 최종환 wrote: From: Colin Crossccr...@android.com Add a clock/clock_tree debugfs file that shows the entire clock hierarchy including usage counts and rates. Signed-off-by: Colin Crossccr...@android.com Signed-off-by: Jonghwan Choijhbird.c...@samsung.com Due to

Re: [PATCH V4 2/2] video: drm: exynos: Add device tree support

2012-09-06 Thread Sylwester Nawrocki
Hi, On 09/06/2012 09:21 AM, InKi Dae wrote: +Required properties: + - compatible: Should be samsung,exynos5-fimd or samsung,exynos4-fb for Doesn't better to use single word? fimd or fb?. I think 'fb' is used for framebuffer historically. but now it's used both fb and drm, so fimd is neutral

[PATCH 1/2] s5p-fimc: fimc-lite: Correct Bayer pixel format definitions

2012-09-05 Thread Sylwester Nawrocki
Replace erroneous V4L2_PIX_FMT_* entries with their V4L2_MBUS_FMT_* counterparts. This enables use of raw Bayer formats on FIMC-LITE.? subdevs. Signed-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/fimc

[PATCH 2/2] s5p-fimc: fimc-lite: Propagate frame format on the subdev

2012-09-05 Thread Sylwester Nawrocki
-off-by: Sylwester Nawrocki s.nawro...@samsung.com Signed-off-by: Kyungmin Park kyungmin.p...@samsung.com --- drivers/media/video/s5p-fimc/fimc-lite.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/media/video/s5p-fimc/fimc-lite.c b/drivers/media/video/s5p-fimc

Re: [PATCH] ARM: Samsung: Remove unused code for the clocks debug-fs interface

2012-09-05 Thread Sylwester Nawrocki
On 09/05/2012 12:41 AM, Kukjin Kim wrote: Yeah, could be. BTW, following will fix it on Samsung platforms? Yes, that might be better. I tried something similar but thought it might not be worth to invest in a dead horse.. Anyway, since converting all Samsung platforms is expected to take some

Re: [PATCH] gpio: samsung: Update documentation

2012-09-04 Thread Sylwester Nawrocki
On 09/04/2012 09:27 AM, Linus Walleij wrote: On Sun, Sep 2, 2012 at 6:24 PM, Sylwester Nawrocki sylvester.nawro...@gmail.com wrote: Update Samsung GPIO API documentation to reflect removal of the s3c24xx specific gpio API. While at it, fix some typos. The notes on conversion from s3c2410_

<    6   7   8   9   10   11   12   13   14   15   >