Re: [PATCH v2 08/13] exynos: fimg2d: add g2d_set_direction

Hello Emil, my main system which I also used for development was stolen on Tuesday, so I won't be working on this series anytime soon. If anyone wants to pick it up, please go ahead. - Tobias Emil Velikov wrote: > On 22 November 2015 at 18:48, Tobias Jakobi > <tjak...@math.uni-bie

Re: [PATCH v2 4/5] drm/exynos: mixer: do blending setup in mixer_cfg_layer()

Hello Inki, my main system which I also used for development was stolen on Tuesday, so I won't be working on this series anytime soon. If anyone wants to pick it up, please go ahead. - Tobias Inki Dae wrote: > 2015-11-24 2:44 GMT+09:00 Tobias Jakobi <tjak...@math.uni-bielefeld.de>: &g

Re: [PATCH v2 1/5] drm/exynos: mixer: refactor layer setup

Hey Inki, Inki Dae wrote: > Hi Tobias, > > 2015년 11월 23일 01:09에 Tobias Jakobi 이(가) 쓴 글: >> First step in allowing a more generic way to setup complex >> blending for the different layers. >> >> Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.d

Re: [PATCH v2 2/5] drm/exynos: mixer: introduce mixer_layer_blending()

Hey Inki, Inki Dae wrote: > > > 2015년 11월 23일 01:09에 Tobias Jakobi 이(가) 쓴 글: >> This analyses the current layer configuration (which layers >> are enabled, which have alpha-pixelformat, etc.) and setups >> blending accordingly. >> >> We currently disab

Re: [PATCH v2 4/5] drm/exynos: mixer: do blending setup in mixer_cfg_layer()

Hey Inki, Inki Dae wrote: > > > 2015년 11월 23일 01:09에 Tobias Jakobi 이(가) 쓴 글: >> This updates the blending setup when the layer configuration >> changes (triggered by mixer_win_{commit,disable}). >> >> To avoid unnecesary reconfigurations we cache the la

[PATCH v2 5/5] drm/exynos: mixer: also allow ARGB1555 and ARGB4444

Allow the remaining alpha formats now that blending is properly setup. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- drivers/gpu/drm/exynos/exynos_mixer.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/

[PATCH v2 0/5] drm/exynos: rework layer blending setup

: General code clean-up, indentation fixes and other small misc changes. Layer state caching was added, to reduce the amount of register programming. Tobias Jakobi (5): drm/exynos: mixer: refactor layer setup drm/exynos: mixer: introduce mixer_layer_blending() drm/exynos: mixer: remove all

[PATCH v2 1/5] drm/exynos: mixer: refactor layer setup

First step in allowing a more generic way to setup complex blending for the different layers. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- drivers/gpu/drm/exynos/exynos_mixer.c | 84 ++- 1 file changed, 73 insertions(+), 11 deletions(-)

[PATCH v2 3/5] drm/exynos: mixer: remove all static blending setup

Previously blending setup was static and most of it was done in mixer_win_reset(). Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- drivers/gpu/drm/exynos/exynos_mixer.c | 23 --- 1 file changed, 23 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH v2 4/5] drm/exynos: mixer: do blending setup in mixer_cfg_layer()

-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- drivers/gpu/drm/exynos/exynos_mixer.c | 41 +-- 1 file changed, 39 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c index ec9659e..1

[PATCH v2 2/5] drm/exynos: mixer: introduce mixer_layer_blending()

enabled when the layer has a pixelformat with alpha attached. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- drivers/gpu/drm/exynos/exynos_mixer.c | 88 +++ drivers/gpu/drm/exynos/regs-mixer.h | 1 + 2 files changed, 89 insertions(+)

[PATCH v2 03/13] tests/exynos: add fimg2d performance analysis

<human.hw...@samsung.com> Reviewed-by: Hyungwon Hwang <human.hw...@samsung.com> Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- .gitignore| 1 + tests/exynos/Makefile.am | 19 ++- tests/exynos/exynos_f

[PATCH v2 00/13] drm/exynos: async G2D and g2d_move()

, don't worry! ;) Changes since v1: - Added wording changes suggested by Hyungwon Hwang. - Added binaries for new test applications to .gitignore. - Collected r-b and t-b tags. Tobias Jakobi (13): drm: Implement drmHandleEvent2() exynos: Introduce exynos_handle_event() tests/exynos: add fimg2d

[PATCH v2 02/13] exynos: Introduce exynos_handle_event()

Used to handle kernel events specific to the Exynos platform. Currently only G2D events are handled. v2: Adapt to container approach. v3: Add exynos_handle_event() to Exynos symbol test. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos-symbol-check | 1 +

[PATCH v2 01/13] drm: Implement drmHandleEvent2()

event and 'ctx' the event context (casted to void). This way we don't have to maintain a copy of drmHandleEvent() in the vendor code. v2: Remove the opaque pointer, since this can be better handled with a container approach. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld

[PATCH v2 06/13] tests/exynos: add fimg2d event test

'busy' being potentially uninitialized. Also enable timeout for poll() in the monitor thread. This fixes pthread_join() not working because of poll() not returning. v4: Use explicit/fixed values for the DRM event context versions. v5: Add binary to .gitignore. Signed-off-by: Tobias Jakobi

[PATCH v2 04/13] exynos/fimg2d: add g2d_config_event

the current API (e.g. by adding a userdata argument to each public functions). v2: Add g2d_config_event() to Exynos symbol test. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos-symbol-check | 1 + exynos/exynos_fimg2d.c | 28 ++--

[PATCH v2 05/13] exynos: fimg2d: add g2d_exec2

This is a more 'flexible' version of g2d_exec allowing to pass some flags which modify the behaviour of g2d_exec. Currently only the 'async' operation flag is supported. v2: Add g2d_exec2() to Exynos symbol test. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/

[PATCH v2 09/13] exynos/fimg2d: add g2d_move

of g2d_move() as suggested by Hyungwon Hwang. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos_fimg2d.c | 95 ++ exynos/exynos_fimg2d.h | 3 ++ 2 files changed, 98 insertions(+) diff --git a/exynos/exynos_fimg

[PATCH v2 08/13] exynos: fimg2d: add g2d_set_direction

This allows setting the two direction registers, which specify how the engine blits pixels. This can be used for overlapping blits, which happen e.g. when 'moving' a rectangular region inside a fixed buffer. Reviewed-by: Hyungwon Hwang <human.hw...@samsung.com> Signed-off-by: Tobias Jakobi

[PATCH v2 11/13] exynos/fimg2d: add exynos_bo_unmap()

This unmaps a previously mapped (via exynos_bo_map()) buffer object. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos-symbol-check | 1 + exynos/exynos_drm.c| 20 exynos/exynos_drmif.h | 1 + 3 files changed, 22 inse

[PATCH v2 10/13] tests/exynos: add test for g2d_move

com> Reviewed-by: Hyungwon Hwang <human.hw...@samsung.com> Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- tests/exynos/exynos_fimg2d_test.c | 132 ++ 1 file changed, 132 insertions(+) diff --git a/tests/exynos/exynos_fimg2d_test

[PATCH v2 07/13] tests/exynos: use XRGB8888 for framebuffer

This matches the G2D color mode that is used in the entire code. The previous (incorrect) RGBA would only work since the Exynos mixer did its configuration based on the bpp, and not based on the actual pixelformat. Reviewed-by: Hyungwon Hwang <human.hw...@samsung.com> Signed-off-by:

[PATCH v2 12/13] exynos/fimg2d: add g2d_reset() to public API

After the rewrite of the command buffer submission handling g2d_reset() is no longer called internally. Still the user might want to reset the G2D context so expose this call. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos-symbol-check | 1 +

[PATCH v2 13/13] exynos: bump version number

The Exynos API was extended quite a bit, so reflect this in the version number. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/libdrm_exynos.pc.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/libdrm_exynos.pc.in b/exynos/libdrm_exynos

Re: [PATCH 14/25] drm/exynos: introduce exynos_drm_plane_config structure

Hey Marek, Marek Szyprowski wrote: > Hello, > > On 2015-11-17 19:00, Tobias Jakobi wrote: >> Marek Szyprowski wrote: >>> This patch adds common structure for keeping plane configuration and >>> capabilities data. This patch is inspired by similar co

Re: [PATCH 17/25] drm/exynos: fix clipping when scalling is enabled

Small typo: 'scalling' -> 'scaling' With best wishes, Tobias Marek Szyprowski wrote: > This patch fixes calculation of src x/y offset for negative crtc x/y > values when scalling is enabled. This fixes possible IOMMU fault when > scalling is enabled. > > Signed-off-by: Marek Szyprowski

Re: [PATCH 14/25] drm/exynos: introduce exynos_drm_plane_config structure

Hello Marek, Marek Szyprowski wrote: > This patch adds common structure for keeping plane configuration and > capabilities data. This patch is inspired by similar code developed by > Tobias Jakobi. > > Signed-off-by: Marek Szyprowski <m.szyprow...@samsung.com> > --- &

Re: [PATCH 00/25] Exynos DRM: new life of IPP (Image Post Processing) subsystem

Hello guys, Daniel Stone wrote: > Hi Marek, > > On 16 November 2015 at 11:35, Marek Szyprowski <m.szyprow...@samsung.com> > wrote: >> On 2015-11-12 15:46, Daniel Stone wrote: >>> On 12 November 2015 at 12:44, Tobias Jakobi >>> <tjak...@ma

Re: [PATCH 00/25] Exynos DRM: new life of IPP (Image Post Processing) subsystem

Hello, Daniel Stone wrote: > Hi Marek, > > On 10 November 2015 at 13:23, Marek Szyprowski > wrote: >> This patch series introduces a new life into Exynos IPP (Image Post >> Processing) subsystem by integrating it (transparently for userspace >> applications) with

Re: [PATCH 00/25] Exynos DRM: new life of IPP (Image Post Processing) subsystem

Hey Daniel, Daniel Stone wrote: > Hi, > > On 12 November 2015 at 12:44, Tobias Jakobi > <tjak...@math.uni-bielefeld.de> wrote: >> Daniel Stone wrote: >>> On 10 November 2015 at 13:23, Marek Szyprowski <m.szyprow...@samsung.com> >>> wro

Re: [PATCH 18/25] drm/exynos: fimd: fix dma burst size setting for small plane size

This one looks a bit strange. It only changes the argument list of fimd_win_set_pixfmt() but the commit message that it actually fixes something. The corresponding upstream commit: https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=66367461e573321f0fbb0be0391165b5a54d5fe4

Re: [PATCH 06/25] drm/exynos: fix to calculate offset of each plane for ipp fimc

Hello, Marek Szyprowski wrote: > From: Seung-Woo Kim > > NV12 and YUV420 formats are need to calculate offset of each plane > for ipp fimc in a gem buffer. Without proper offset, only Y plane > can be processed, so result shows green frame. > This patch fixes to

Re: [PATCH 00/25] Exynos DRM: new life of IPP (Image Post Processing) subsystem

Hello Marek, this looks very interesting. I'll try to integrate this with my mpv DRM backend once the colorspace conversion bits are implemented. I also wanted to suggest that using the IPP blocks (rotator, FIMC) should be still be possible without any kind of display active. So similar in the

Re: [PATCH 09/13] exynos/fimg2d: add g2d_move

Hello Hyungwon, Hyungwon Hwang wrote: > Hello Tobias, > > On Mon, 09 Nov 2015 10:47:02 +0100 > Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote: > >> Hello Hyungwon, >> >> >> Hyungwon Hwang wrote: >>> Hello Tobias, >>> >>&

Re: [PATCH v4] tests/exynos: add fimg2d performance analysis

Hello Hyungwon, Hyungwon Hwang wrote: > Hello Tobias, > > On Mon, 09 Nov 2015 10:47:13 +0100 > Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote: > >> Hello Hyungwon, >> >> >> Hyungwon Hwang wrote: >>> Hello, >>> >>> I

Re: [PATCH 09/13] exynos/fimg2d: add g2d_move

the naming is fine though, since it mirrors libc's naming. And the user is supposed to read the documentation anyway. With best wishes, Tobias > > Best regards, > Hyungwon Hwang > > On Tue, 22 Sep 2015 17:54:58 +0200 > Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote: &

Re: [PATCH 10/13] tests/exynos: add test for g2d_move

gt; But without it, it looks good to me, and I tested it on my Odroid U3 > board. > > Tested-by: Hyungwon Hwang <human.hw...@samsung.com> > Reviewed-by: Hyungwon Hwang <human.hw...@samsung.com> > > Best regards, > Hyungwon Hwang > > > On Tue, 22 Sep 2015 17:5

[PATCH v3] tests/exynos: add fimg2d performance analysis

this. v2: Add GPLv2 header, argument handling and documentation. Tool is only installed when requested. v3: Free images array in fimg2d_perf_multi() as pointed out by Hyungwon Hwang. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- tests/exynos/Makefile.am

[PATCH v4] tests/exynos: add fimg2d event test

'busy' being potentially uninitialized. Also enable timeout for poll() in the monitor thread. This fixes pthread_join() not working because of poll() not returning. v4: Use explicit/fixed values for the DRM event context versions. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld

[PATCH v4] tests/exynos: add fimg2d performance analysis

this. v2: Add GPLv2 header, argument handling and documentation. Tool is only installed when requested. v3: Free images array in fimg2d_perf_multi() as pointed out by Hyungwon Hwang. v4: Include header for error numbers (fixes build). Signed-off-by: Tobias Jakobi <tjak...@math.

Re: drm/exynos: when to call dma_map_sg() on a GEM object?

Hello Joonyoung, Joonyoung Shim wrote: > On 10/31/2015 05:44 AM, Tobias Jakobi wrote: >> Hey there, >> >> this question arose during some discussion with someone concerning the >> Exynos mixer and G2D. >> >> The question is the following. Consider the E

drm/exynos: when to call dma_map_sg() on a GEM object?

Hey there, this question arose during some discussion with someone concerning the Exynos mixer and G2D. The question is the following. Consider the Exynos mixer when run under the IOMMU (that's sysmmu_tv IIRC). What exactly does setup the IOMMU mapping so that the mixer can scanout the

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

Hello Hyungwon, first of all thanks for reviewing the series! Hyungwon Hwang wrote: > On Tue, 22 Sep 2015 17:54:55 +0200 > Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote: > >> This tests async processing of G2D jobs. A separate thread is spawned >> to mo

Re: [PATCH 07/13] tests/exynos: use XRGB8888 for framebuffer

Hello Hyungwon, Hyungwon Hwang wrote: > On Tue, 22 Sep 2015 17:54:56 +0200 > Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote: > >> This matches the G2D color mode that is used in the entire code. >> The previous (incorrect) RGBA would only work since

Re: [PATCH 08/13] exynos: fimg2d: add g2d_set_direction

Hello Hyungwon, Hyungwon Hwang wrote: > On Tue, 22 Sep 2015 17:54:57 +0200 > Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote: > >> This allows setting the two direction registers, which specify how >> the engine blits pixels. This can be used for overlapping blits

Re: [PATCH 03/13] tests/exynos: add fimg2d performance analysis

Hello Hyungwon, Hyungwon Hwang wrote: > On Tue, 22 Sep 2015 17:54:52 +0200 > Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote: > >> Currently only fast solid color clear performance is measured. >> A large buffer is allocated and solid color clear

Re: [PATCH 09/13] exynos/fimg2d: add g2d_move

Hello Hyungwon, Hyungwon Hwang wrote: > On Tue, 22 Sep 2015 17:54:58 +0200 > Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote: > >> We already have g2d_copy() which implements G2D copy >> operations from one buffer to another. However we can't >> do a overlap

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

Hey Emil, Emil Velikov wrote: > On 30 October 2015 at 11:28, Tobias Jakobi > <tjak...@math.uni-bielefeld.de> wrote: >> Hello Emil, >> >> >> Emil Velikov wrote: >>> On 30 October 2015 at 11:16, Tobias Jakobi >>> <tjak...@math.uni-bielefe

Re: [PATCH 08/13] exynos: fimg2d: add g2d_set_direction

Tobias Jakobi wrote: > Hello Hyungwon, > > > Hyungwon Hwang wrote: >> On Tue, 22 Sep 2015 17:54:57 +0200 >> Tobias Jakobi <tjak...@math.uni-bielefeld.de> wrote: >> >>> This allows setting the two direction registers, which specify how >>> the

Re: [PATCH 06/13] tests/exynos: add fimg2d event test

Hello Emil, Emil Velikov wrote: > On 30 October 2015 at 11:16, Tobias Jakobi > <tjak...@math.uni-bielefeld.de> wrote: >> Hello Hyungwon, >> >> first of all thanks for reviewing the series! >> >> >> >> Hyungwon Hwang wrote: >>

Re: [PATCH 00/13] drm/exynos: async G2D and g2d_move()

Another ping! With best wishes, Tobias Tobias Jakobi wrote: > Hello, > > this series mostly touches G2D code. It introduces the following: > > (1) drmHandleEvent2() is added to enable processing of vendor-specific > events. This will be used to expose asyn

Re: [PATCH 0/3] ARM: dts: Enable Exynos RNG module

Hello Krzysztof, Krzysztof Kozlowski wrote: > On 20.10.2015 01:11, Tobias Jakobi wrote: >> Hello Krzysztof, >> >> I can confirm that this also works on a Odroid-X2, so I guess it's safe >> to enable the PRNG for all Exynos4412-based Odroid devices. > > Sure, I

Re: [PATCH 0/3] ARM: dts: Enable Exynos RNG module

Hello Krzysztof, I can confirm that this also works on a Odroid-X2, so I guess it's safe to enable the PRNG for all Exynos4412-based Odroid devices. Any chance that you might also take a look at the other hwcrypto stuff on the SoC ('samsung,exynos4210-secss' compatible)? With best wishes,

Re: [PATCH 0/7] Switch to generic syscon regmap based drivers

Hello Alim, I tested the Exynos4 bits on a Odroid-X2 and I can confirm that poweroff/reboot (still) work. With best wishes, Tobias Alim Akhtar wrote: > Alim Akhtar (7): > arm: dts: Add syscon-{reboot, poweroff} nodes for exynos3250 SoCs > arm: dts: Add syscon-{reboot, poweroff} nodes for

Re: [PATCH 00/13] drm/exynos: async G2D and g2d_move()

Another ping! I need someone from Samsung to review this, or at least someone familiar with the G2D. With best wishes, Tobias Tobias Jakobi wrote: > Gentle ping! :-) > > - Tobias > > > Tobias Jakobi wrote: >> Hello, >> >> this series mostly touches G

Re: [PATCH] ARM: dts: exynos4412-odroid: unify voltage regulator style

Krzysztof Kozlowski wrote: > On 07.10.2015 08:26, Tobias Jakobi wrote: >> Gentle ping! > > Both patches are now in Kukjin's tree. Thanks Krzysztof for the heads up! With best wishes, Tobias > Best regards, > Krzysztof > >> >> - Tobias >> >> Tobi

Re: [PATCH 00/13] drm/exynos: async G2D and g2d_move()

Gentle ping! :-) - Tobias Tobias Jakobi wrote: > Hello, > > this series mostly touches G2D code. It introduces the following: > > (1) drmHandleEvent2() is added to enable processing of vendor-specific > events. This will be used to expose asynchronous operatio

Re: [PATCH] ARM: dts: exynos4412-odroid: remove redundant pinctrl settings

Gentle ping! - Tobias Tobias Jakobi wrote: > The pinctrl settings in i2c_0 and i2c_1 are already provided > through the exynos4 dtsi. > > Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> > --- > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 6 ---

Re: [PATCH] ARM: dts: exynos4412-odroid: unify voltage regulator style

Gentle ping! - Tobias Tobias Jakobi wrote: > Use 'ldoN_reg: LDON' syntax and drop the deprecated > 'regulator-compatible' property. > > Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> > --- > arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 6 ++-

Re: [PATCH 00/10] drm/exynos: add pm_runtime support

Hello Gustavo, just wanted to ask if the series is still meant to go upstream. I tried applying the series to torvalds/master and I get a conflict because of Inki's commit 148ba09c465cc54d8e68f041bf9a30332b315c39 ('drm/exynos: dp: remove suspend/resume functions'). With best wishes, Tobias

[PATCH 12/13] exynos/fimg2d: add g2d_reset() to public API

After the rewrite of the command buffer submission handling g2d_reset() is no longer called internally. Still the user might want to reset the G2D context so expose this call. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos-symbol-check | 1 +

[PATCH 04/13] exynos/fimg2d: add g2d_config_event

the current API (e.g. by adding a userdata argument to each public functions). v2: Add g2d_config_event() to Exynos symbol test. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos-symbol-check | 1 + exynos/exynos_fimg2d.c | 28 ++--

[PATCH 01/13] drm: Implement drmHandleEvent2()

event and 'ctx' the event context (casted to void). This way we don't have to maintain a copy of drmHandleEvent() in the vendor code. v2: Remove the opaque pointer, since this can be better handled with a container approach. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld

[PATCH 05/13] exynos: fimg2d: add g2d_exec2

This is a more 'flexible' version of g2d_exec allowing to pass some flags which modify the behaviour of g2d_exec. Currently only the 'async' operation flag is supported. v2: Add g2d_exec2() to Exynos symbol test. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/

[PATCH 03/13] tests/exynos: add fimg2d performance analysis

this. v2: Add GPLv2 header, argument handling and documentation. Tool is only installed when requested. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- tests/exynos/Makefile.am | 19 ++- tests/exynos/exynos_fimg2d_perf.c | 320 +++

[PATCH 00/13] drm/exynos: async G2D and g2d_move()

, don't worry! ;) Tobias Jakobi (13): drm: Implement drmHandleEvent2() exynos: Introduce exynos_handle_event() tests/exynos: add fimg2d performance analysis exynos/fimg2d: add g2d_config_event exynos: fimg2d: add g2d_exec2 tests/exynos: add fimg2d event test tests/exynos: use XRGB

[PATCH 02/13] exynos: Introduce exynos_handle_event()

Used to handle kernel events specific to the Exynos platform. Currently only G2D events are handled. v2: Adapt to container approach. v3: Add exynos_handle_event() to Exynos symbol test. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos-symbol-check | 1 +

[PATCH 06/13] tests/exynos: add fimg2d event test

'busy' being potentially uninitialized. Also enable timeout for poll() in the monitor thread. This fixes pthread_join() not working because of poll() not returning. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- tests/exynos/Makefile.am | 11 +- tests/

[PATCH 09/13] exynos/fimg2d: add g2d_move

We already have g2d_copy() which implements G2D copy operations from one buffer to another. However we can't do a overlapping copy operation in one buffer. Add g2d_move() which acts like the standard memmove() and properly handles overlapping copies. Signed-off-by: Tobias Jakobi <t

[PATCH 07/13] tests/exynos: use XRGB8888 for framebuffer

This matches the G2D color mode that is used in the entire code. The previous (incorrect) RGBA would only work since the Exynos mixer did its configuration based on the bpp, and not based on the actual pixelformat. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- tests/

[PATCH 10/13] tests/exynos: add test for g2d_move

To check if g2d_move() works properly we create a small checkerboard pattern in the center of the screen and then shift this pattern around with g2d_move(). The pattern should be properly preserved by the operation. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- tests/

[PATCH 11/13] exynos/fimg2d: add exynos_bo_unmap()

This unmaps a previously mapped (via exynos_bo_map()) buffer object. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos-symbol-check | 1 + exynos/exynos_drm.c| 20 exynos/exynos_drmif.h | 1 + 3 files changed, 22 inse

Re: [PATCH v2 0/9] drm/exynos: rewrite fimg2d error handling

Hey Emil, Emil Velikov wrote: > Hi Tobias, > > On 8 September 2015 at 16:22, Tobias Jakobi > <tjak...@math.uni-bielefeld.de> wrote: >> Hello, >> >> during the discussion about the last patchset touching the >> fimg2d code, it became apparent that the er

[PATCH] ARM: dts: exynos4412-odroid: unify voltage regulator style

Use 'ldoN_reg: LDON' syntax and drop the deprecated 'regulator-compatible' property. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/bo

[PATCH] ARM: dts: exynos4412-odroid: remove redundant pinctrl settings

The pinctrl settings in i2c_0 and i2c_1 are already provided through the exynos4 dtsi. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- arch/arm/boot/dts/exynos4412-odroid-common.dtsi | 6 -- 1 file changed, 6 deletions(-) diff --git a/arch/arm/boot/dts/exynos4412-

[PATCH v2 4/9] exynos/fimg2d: add g2d_validate_xyz() functions

,scale_and_blend}(). For this we move parameter validation to the top and also validate the select mode of the source image and the requested blending operation before starting command submission. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos_fimg2d.c

[PATCH v2 2/9] exynos/fimg2d: simplify base address submission in g2d_scale_and_blend()

Use g2d_add_base_addr() for source and destination base address just like all other calls. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos_fimg2d.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/exynos/exynos_fimg2d.c b/

[PATCH v2 0/9] drm/exynos: rewrite fimg2d error handling

can improve anything! With best wishes, Tobias Changes since v1: - squashed some of the patches together (suggested by Inki) - changed return value of validate functions (suggested by Inki) - added some more explanatory comments (suggested by Emil) Tobias Jakobi (9): exynos/fimg2d: fix empty

[PATCH v2 3/9] exynos/fimg2d: add g2d_check_space()

the G2D context in this situation since the buffers are not partially submitted anymore. The repeat mode in g2d_copy_with_scale() is checked first to make computation of space easier. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos_fimg2d.

[PATCH v2 1/9] exynos/fimg2d: fix empty buffer handling in g2d_flush()

Empty command buffers are no error, we just don't have anything to do for flushing then. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos_fimg2d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fi

[PATCH v2 5/9] exynos/fimg2d: remove default case from g2d_get_blend_op()

We now validate the blending mode via g2d_validate_mode() prior to feeding it to g2d_get_blend_op(). Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos_fimg2d.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/exynos/exynos_fimg

[PATCH v2 6/9] exynos/fimg2d: remove superfluous initialization of g2d_point_val

The g2d_point_val union consists of two coordinates of 16 bits. Whenever this union is used though, both coordinates are explicitly set. Hence prior initialization is unnecessary. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos_fimg2d.c | 19

[PATCH v2 7/9] exynos/fimg2d: make g2d_add_cmd() less heavy

they're only active for debug builds. This is fine since g2d_add_cmd() is not part of the public API. (2) Switch the return value to void. (3) Explicitly state that the caller has to check buffer space before calling g2d_add_cmd(). Signed-off-by: Tobias Jakobi <tjak...@math.

[PATCH v2 9/9] exynos/fimg2d: remove g2d_context from public header

All functions from the public API only operation on struct g2d_context*, so this shouldn't break too much. Make the context private since we don't want the user to modify its content directly. Also remove the defines that were only used for fields of g2d_context. Signed-off-by: Tobias Jakobi

[PATCH v2 8/9] exynos/fimg2d: add message prefix

Add a prefix to the messages printed to the console via printf() and fprintf() so that one can easily see where the message comes from. Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> --- exynos/exynos_fimg2d.c | 30 -- 1 file changed, 16 inse

Re: [PATCH 10/14] exynos/fimg2d: remove default case from g2d_get_blend_op()

Hello Inki, Inki Dae wrote: > On 2015년 09월 01일 03:53, Emil Velikov wrote: >> On 31 August 2015 at 14:25, Inki Dae <inki@samsung.com> wrote: >>> On 2015년 08월 24일 23:14, Tobias Jakobi wrote: >>>> We now validate the blending mode via g2d_v

Re: [PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill()

Hello! Inki Dae wrote: > On 2015년 08월 24일 23:13, Tobias Jakobi wrote: >> The amount of commands (regular and GEM) doesn't depend >> on the input here. >> >> Signed-off-by: Tobias Jakobi <tjak...@math.uni-bielefeld.de> >> --- >> exynos/exynos_fimg

Re: [PATCH 07/14] exynos/fimg2d: add g2d_validate_xyz() functions

Hello, Emil Velikov wrote: > On 31 August 2015 at 14:18, Inki Dae <inki@samsung.com> wrote: >> On 2015년 08월 24일 23:14, Tobias Jakobi wrote: >>> The G2D headers define a number of modes through enums >>> (like e.g. color, select, repeat, etc.). >>> &g

Re: drm/exynos: g2d userptr memory corruption

Tobias Jakobi wrote: Next I looked into Jerome's question about whethere the G2D is cache coherent with the CPU. I looked into old Android code and found FIMG2D_AXI_MODE_REG, a register that currently isn't touched in the DRM code. It seems to manipulate signals to the AXI Master interface

Re: drm/exynos: g2d userptr memory corruption

at 03:53:44PM +0200, Tobias Jakobi wrote: Adding Jérôme to Cc. I think he looked the userptr code before, so maybe he has some idea what is going wrong here. I also had a look at the code, but my knowledge about the DMA API is almost nonexistant. However I can see that before doing any DMA via

Re: [PATCH 00/14] drm/exynos: rewrite fimg2d error handling

Hey Emil, Emil Velikov wrote: Hi Tobias, On 24 August 2015 at 15:13, Tobias Jakobi tjak...@math.uni-bielefeld.de wrote: Hello, during the discussion about the last patchset touching the fimg2d code, it became apparent that the error handling for the command submission is currently

Re: drm/exynos: remove superfluous checks in g2d_check_reg_offset()

Gentle ping! On 2015-08-18 00:51, Tobias Jakobi wrote: The cases of the switch statement ensure that reg_type can never be REG_TYPE_NONE here. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- drivers/gpu/drm/exynos/exynos_drm_g2d.c | 8 1 file changed, 8 deletions

Re: drm/exynos: fix size check in g2d_check_buf_desc_is_valid()

Gentle ping! Also please note that this is a critical fix. With the incomplete check pagefaults can happen when the engine accesses a invalid buffer position. With best wishes, Tobias On 2015-08-18 00:51, Tobias Jakobi wrote: The size check was incomplete. It only computed the size of area

[PATCH 07/14] exynos/fimg2d: add g2d_validate_xyz() functions

The G2D headers define a number of modes through enums (like e.g. color, select, repeat, etc.). This introduces g2d_validate_select_mode() and g2d_validate_blending_op() which validate a select mode or blending operation respectively. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de

[PATCH 08/14] exynos/fimg2d: check buffer space in g2d_blend()

Move parameter validation to the top and also validate the select mode of the source image and the requested blending operation before starting command submission. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 66

[PATCH 05/14] exynos/fimg2d: check buffer space in g2d_copy()

Move the parameter validation before buffer space checking so that we can exit early if it fails. Also don't reset the G2D context anymore in this situation (since the buffers are not partially submitted). Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 26

[PATCH 06/14] exynos/fimg2d: check buffer space in g2d_copy_with_scale()

Parameter validation goes to the top. Repeat mode is checked first to make computation of space easier. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 53 -- 1 file changed, 30 insertions(+), 23 deletions

[PATCH 04/14] exynos/fimg2d: check buffer space in g2d_solid_fill()

The amount of commands (regular and GEM) doesn't depend on the input here. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c index 1ae8adf..9b7bcce 100644

[PATCH 01/14] exynos/fimg2d: fix empty buffer handling in g2d_flush()

Empty command buffers are no error, we just don't have anything to do for flushing then. Signed-off-by: Tobias Jakobi tjak...@math.uni-bielefeld.de --- exynos/exynos_fimg2d.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/exynos/exynos_fimg2d.c b/exynos/exynos_fimg2d.c index

  1   2   3   4   >