Re: [PATCH v3] clk: s3c2410: removed unneeded variable in s3c24xx_clkout_set_parent

2015-11-30 Thread Uwe Kleine-König
Karthik <mkart...@visteon.com> Everything after the first triple-dash doesn't make it into the git history, so you are expected to write the S-o-b line above the list of things changed since a previous submission. Other than that the patch looks fine. Uwe -- Pengutronix e.K.

Re: [PATCH V3] Watchdog: Fix parent of watchdog_devices

2015-08-19 Thread Uwe Kleine-König
see why you don't use the platform device as parent for mpc8xxx. Note however that I did several updates to the mpc8xxx driver which probably conflict with setting the parent. I'll take care of that. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König

[PATCH] clk: make several parent names const

2015-05-28 Thread Uwe Kleine-König
Since commit 2893c379461a (clk: make strings in parent name arrays const) the name of parent clocks can be const. So add more const in several clock drivers. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- Hello, commit 2893c379461a isn't in Linus Torvald's tree yet, so

Re: [PATCH] i2c: exynos5: Move initialization code to subsys_initcall()

2015-01-11 Thread Uwe Kleine-König
to stop the next person converting it to that. (And if not, please fix accordingly to use deferred probing.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from

Re: DT on s3c24xx

2014-12-17 Thread Uwe Kleine-König
you can then use the standard gpiod_{request,direction_{in,out}put} combo. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line

Re: [PATCH] ASoC: rt5631: Fixing compilation warning when DT is disabled

2014-11-17 Thread Uwe Kleine-König
An (IMHO nicer) alternative is: -static struct of_device_id rt5631_i2c_dt_ids[] = { +static struct of_device_id rt5631_i2c_dt_ids[] __maybe_unused = { Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http

Re: Samsung/S3C6410/Mini6410: how to handle NAND's clock off

2014-11-12 Thread Uwe Kleine-König
Hello again, [extending audience a bit] On Tue, Nov 11, 2014 at 07:42:26PM +0100, Uwe Kleine-König wrote: On Tue, Nov 11, 2014 at 07:10:33PM +0100, Juergen Borleis wrote: Hi, the S3C2410 NAND driver [1] can still be used for NANDs attached to an S3C6410 SoC. But this driver has

Re: Samsung/S3C6410/Mini6410: how to handle NAND's clock off

2014-11-11 Thread Uwe Kleine-König
an optional clk entry. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord

Re: [PATCH] clk: don't use __initconst for non-const arrays

2014-09-12 Thread Uwe Kleine-König
Hello Ard, On Fri, Sep 12, 2014 at 09:42:29AM +0200, Ard Biesheuvel wrote: On 12 September 2014 00:04, Uwe Kleine-König u.kleine-koe...@pengutronix.de wrote: Hello, On Thu, Sep 11, 2014 at 11:04:31PM +0200, Uwe Kleine-König wrote: /* Mux parent lists. */ -static const char *fin_pll_p

[PATCH] clk: don't use __initconst for non-const arrays

2014-09-11 Thread Uwe Kleine-König
be added such that the whole definition reads: static const char *const name[] __initconst; or where this is not possible __initdata must be used. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- drivers/clk/hisilicon/clk-hix5hd2.c | 6 ++-- drivers/clk/mxs/clk-imx23.c

Re: [PATCH] clk: don't use __initconst for non-const arrays

2014-09-11 Thread Uwe Kleine-König
Hello, On Thu, Sep 11, 2014 at 11:04:31PM +0200, Uwe Kleine-König wrote: /* Mux parent lists. */ -static const char *fin_pll_p[] __initconst = { +static const char *fin_pll_p[] __initdata = { xxti, xusbxti }; As discussed with Tomasz on irc: The sad thing here

Re: [PATCH 1/3] ARM: exynos: remove unused mach/memory.h

2014-07-23 Thread Uwe Kleine-König
. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo

[PATCH 1/3] ARM: exynos: remove unused mach/memory.h

2014-07-02 Thread Uwe Kleine-König
ARCH_EXYNOS doesn't select NEED_MACH_MEMORY_H, so asm/memory.h doesn't include mach/memory.h and so this file is not used and can go away. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de --- Cc: Kukjin Kim kgene@samsung.com Cc: linux-samsung-soc@vger.kernel.org --- arch/arm

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
it? There are several more that suffer the same problem. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: On Thu, 2013-10-24 at 20:26 +0200, Uwe Kleine-König wrote: Hello Joe, On Wed, Oct 23, 2013 at 12:14:50PM -0700, Joe Perches wrote: Emitting an OOM message isn't necessary after input_allocate_device as there's a generic OOM

Re: [PATCH 4/8] input: Remove OOM message after input_allocate_device

2013-10-24 Thread Uwe Kleine-König
On Thu, Oct 24, 2013 at 11:48:48AM -0700, Joe Perches wrote: On Thu, 2013-10-24 at 20:46 +0200, Uwe Kleine-König wrote: On Thu, Oct 24, 2013 at 11:43:38AM -0700, Joe Perches wrote: [] Any k.alloc without __GFP_NOWARN does a generic OOM message and a dump_stack() so there could already

Re: [PATCH] i2c: s3c2410: Add SMBus emulation for block read

2013-04-09 Thread Uwe Kleine-König
be needed to prevent a buffer overrun? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body

Re: [PATCH] clk: let mxs specific clk-div clock type be a generic clock type

2013-03-18 Thread Uwe Kleine-König
-status.c Thanks Shawn for your comments. I will split this patch as you suggested and post again. I didn't try to look at your patch, but maybe format-patch -M is enough to make the patch easier to parse (for humans). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König

$(make uImage) is stupid [Was: Re: Early kernel hang with big DTB appended]

2013-01-14 Thread Uwe Kleine-König
. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org

Re: [PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata

2012-03-30 Thread Uwe Kleine-König
Hello Shawn, On Fri, Mar 30, 2012 at 02:11:36PM +0800, Shawn Guo wrote: On Thu, Mar 29, 2012 at 11:12:20PM +0200, Uwe Kleine-König wrote: ... diff --git a/arch/arm/mach-imx/imx51-dt.c b/arch/arm/mach-imx/imx51-dt.c index 5cca573..7e00748 100644 --- a/arch/arm/mach-imx/imx51-dt.c +++ b

[PATCH v2 02/15] ARM: mark const init data with __initconst instead of __initdata

2012-03-30 Thread Uwe Kleine-König
and so cannot contain non-const variables. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: Andrew Victor li...@maxim.org.za Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: Jean-Christophe Plagniol-Villard plagn...@jcrosoft.com Cc: Russell King li...@arm.linux.org.uk Cc: Sekhar Nori nsek

[PATCH 03/17] ARM: mark const init data with __initconst instead of __initdata

2012-03-29 Thread Uwe Kleine-König
and so cannot contain non-const variables. Signed-off-by: Uwe Kleine-König u.kleine-koe...@pengutronix.de Cc: Andrew Victor li...@maxim.org.za Cc: Nicolas Ferre nicolas.fe...@atmel.com Cc: Jean-Christophe Plagniol-Villard plagn...@jcrosoft.com Cc: Russell King li...@arm.linux.org.uk Cc: Sekhar Nori nsek

Re: [PATCH] mmc: card: modify mmc_getgeo function

2011-09-26 Thread Uwe Kleine-König
code ... Having said that AFAIK the code used before wasn't ok, too. (I.e. an u64 division that was just noticed to be a shift by luck.) Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http

Re: [PATCH] mmc: card: modify mmc_getgeo function

2011-09-26 Thread Uwe Kleine-König
On Mon, Sep 26, 2011 at 08:41:13AM -0400, Chris Ball wrote: Hi, On Mon, Sep 26 2011, Uwe Kleine-König wrote: Thanks, pushed to mmc-next for 3.2 with a reworded commit message: This (i.e. ee9e0e0 (mmc: card: Remove duplicated constants) in next) makes gcc emit a reference

Re: [PATCH] ARM: S3C64XX: Fix section mismatch from cpufreq init

2011-03-16 Thread Uwe Kleine-König
to cpufreq_register_driver). Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message

Re: [PATCH] ARM: S3C64XX: Fix section mismatch from cpufreq init

2011-03-16 Thread Uwe Kleine-König
On Wed, Mar 16, 2011 at 09:49:59AM +, Mark Brown wrote: On Wed, Mar 16, 2011 at 09:38:11AM +0100, Uwe Kleine-König wrote: On Thu, Mar 10, 2011 at 02:58:13PM +, Mark Brown wrote: we don't appear to have annotations which allow us to mark that it'll never be called after system init

Re: [RFC 2/5] ARM: P2V: avoid initializers and assembly using PHYS_OFFSET

2011-02-07 Thread Uwe Kleine-König
-- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info

Re: [RFC 2/5] ARM: P2V: avoid initializers and assembly using PHYS_OFFSET

2011-02-07 Thread Uwe Kleine-König
Hello again, On Mon, Feb 07, 2011 at 05:51:50PM +0100, Uwe Kleine-König wrote: nack. 7608d7d2b4a146f560436f5b99b1b93d30049e4e has a better fix. urgs, this was already pointed out, sorry. Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux

Re: git pre-commit hook running checkpatch.pl

2010-01-20 Thread Uwe Kleine-König
e.K. | Uwe Kleine-König| Industrial Linux Solutions| http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line unsubscribe linux-samsung-soc in the body of a message to majord...@vger.kernel.org More majordomo info