Re: [PATCH] ASoC: SAMSUNG: Add sound card driver for Snow board

2014-04-22 Thread Mark Brown
On Tue, Apr 22, 2014 at 01:33:54PM +0530, Tushar Behera wrote: Added machine driver to instantiate I2S based sound card on Snow board. It has MAX98095 audio codec on board. In general this isn't up to modern standards, please do try to check that new code is following best practices. Did the

Re: [PATCH] ASoC: SAMSUNG: Add sound card driver for Snow board

2014-04-22 Thread Tushar Behera
On 22 April 2014 16:14, Mark Brown broo...@kernel.org wrote: On Tue, Apr 22, 2014 at 01:33:54PM +0530, Tushar Behera wrote: Added machine driver to instantiate I2S based sound card on Snow board. It has MAX98095 audio codec on board. In general this isn't up to modern standards, please do

Re: [PATCH] ASoC: SAMSUNG: Add sound card driver for Snow board

2014-04-22 Thread Mark Brown
On Tue, Apr 22, 2014 at 07:17:54PM +0530, Tushar Behera wrote: On 22 April 2014 16:14, Mark Brown broo...@kernel.org wrote: In general this isn't up to modern standards, please do try to check that new code is following best practices. Did the support for setting the clocking up in the

Re: [PATCH] ASoC: SAMSUNG: Add sound card driver for Snow board

2014-04-22 Thread Tushar Behera
On 23 April 2014 00:03, Mark Brown broo...@kernel.org wrote: On Tue, Apr 22, 2014 at 07:17:54PM +0530, Tushar Behera wrote: On 22 April 2014 16:14, Mark Brown broo...@kernel.org wrote: In general this isn't up to modern standards, please do try to check that new code is following best